d3ee73e151
capture sort time in hash calculation ( #18118 )
2021-06-22 16:02:21 -05:00
fbc94d84c8
apply 'debug_do_not_add_builtins' to feature activations ( #18110 )
2021-06-22 14:21:49 -05:00
d5f9f3b7ce
correctly calculate hash_total for hash/lamport calculation ( #18144 )
2021-06-22 11:36:43 -05:00
e808f34b0b
Add batch stats ( #18096 )
2021-06-22 15:23:26 +02:00
0ab361b828
Use newly stabilized Duration methods/consts ( #18101 )
2021-06-22 00:11:16 +00:00
19fe1dd463
Move stake_weighted_timestamp module ( #18114 )
...
* Move timestamp module into runtime
* Less public
* Remove unused enum
2021-06-21 16:14:54 -06:00
2087f5da94
refactor generate_index_for_slot ( #17984 )
2021-06-21 15:32:50 -05:00
bf97627021
eliminate flatten and sort in hash calculation ( #17802 )
...
* eliminate flatten and sort in hash calculation
* reduce critical section time
* remove now no-longer necessary test code
* conflict with reset bins to 0 pr
2021-06-21 15:32:03 -05:00
4d46cb686a
Fix build: clippy lint
2021-06-21 10:18:21 -07:00
ae82e4e25b
refactor reconstruct_accountsdb_from_fields ( #17987 )
2021-06-21 10:47:58 -05:00
789f33e8db
chore: cargo fmt
2021-06-18 10:42:46 -07:00
6514096a67
chore: cargo +nightly clippy --fix -Z unstable-options
2021-06-18 10:42:46 -07:00
0a81c37fce
introduce LockMapType for accounts_index ( #18021 )
2021-06-17 14:41:52 -05:00
1feaaf009d
generate_index timings ( #17983 )
2021-06-17 13:35:25 -05:00
20e714b3d0
remove unused code ( #17981 )
2021-06-17 13:30:46 -05:00
71796f4951
break out generate index reporting ( #17980 )
2021-06-16 12:09:17 -05:00
7ca04d6a86
refactor generate_index process_storage_slot ( #17982 )
2021-06-16 11:02:34 -05:00
bb7413c9f9
refactor rebuild_bank_from_snapshots ( #17988 )
2021-06-16 11:01:52 -05:00
eee5414c64
avoid unnecessary empty arrays when binning ( #17944 )
2021-06-16 09:24:59 -05:00
adc683956f
do not use index for verify_bank_hash_and_lamports ( #17812 )
2021-06-16 09:10:38 -05:00
55ee3b5f2f
set hash bins to 65k ( #17912 )
2021-06-16 09:09:55 -05:00
7de79425ce
parallel storage -> accounts folder ( #17955 )
2021-06-16 08:48:24 -05:00
dbd4dc04b0
ledger tool limit_load_slot_count_from_snapshot avoids assert failures ( #17974 )
2021-06-15 15:39:22 -05:00
f558b9b6bf
verify bank hash on startup with ledger tool option ( #17939 )
2021-06-15 11:52:12 -05:00
1b1d34da59
Refactor stake program into solana_program ( #17906 )
...
* Move stake state / instructions into solana_program
* Update account-decoder
* Update cli and runtime
* Update all other parts
* Commit Cargo.lock changes in programs/bpf
* Update cli stake instruction import
* Allow integer arithmetic
* Update ABI digest
* Bump rust mem instruction count
* Remove useless structs
* Move stake::id() -> stake::program::id()
* Re-export from solana_sdk and mark deprecated
* Address feedback
* Run cargo fmt
2021-06-15 18:04:00 +02:00
5ecb30ff58
nit: rename measure ( #17946 )
2021-06-15 09:01:11 -05:00
4d8ffdcc11
remove unused parameters from CalculateHashIntermediate ( #17949 )
2021-06-15 09:00:43 -05:00
ccc013e134
Handle removing slots during account scans ( #17471 )
2021-06-14 21:04:01 -07:00
471b34132e
add metrics for startup ( #17913 )
...
* add metrics for startup
* roll timings up higher
* fix test
* fix duplicate
2021-06-14 17:46:49 -05:00
7fde9b6ff0
name arguments to help with confusion ( #17942 )
2021-06-14 16:21:48 -05:00
62e1b20e56
refactor so hash verify can be done by more callers ( #17941 )
2021-06-14 16:20:03 -05:00
e6bbd4b3f0
add metrics to handle_snapshot_requests ( #17937 )
2021-06-14 15:46:19 -05:00
c2191d885d
Fix accounts index panic in purge_exact ( #17757 )
2021-06-14 16:10:26 +02:00
d4cc975fe9
calculate_capitalization uses hash calculation ( #17443 )
...
* calculate_capitalization uses hash calculation
* feedback
* remove debugging code, clean up slot math
2021-06-14 08:53:07 -05:00
2dc6969858
use trait to simplify and consolidate cumulative code ( #17852 )
2021-06-14 08:43:59 -05:00
269d995832
Make account shrink configurable #17544 ( #17778 )
...
1. Added both options for measuring space usage using total accounts usage and for individual store shrink ratio using an enum. Validator CLI options: --accounts-shrink-optimize-total-space and --accounts-shrink-ratio
2. Added code for selecting candidates based on total usage in a separate function select_candidates_by_total_usage
3. Added unit tests for the new functions added
4. The default implementations is kept at 0.8 shrink ratio with --accounts-shrink-optimize-total-space set to true
Fixes #17544
2021-06-09 21:21:32 -07:00
a1fab0c5ca
Log more info on runtime account verification errors ( #17861 )
2021-06-09 16:27:00 -07:00
050bb5446d
Add local cluster tests that broadcast duplicate slots ( #13995 )
...
* Add duplicate node local cluster test
* fix clippy
* remove dupe test
2021-06-09 15:01:48 -07:00
576e3d95f7
refactor: create type ( #17818 )
2021-06-08 14:49:08 -06:00
2a9b127029
Pass iterator for SortedStorages::new_with_slots ( #17811 )
...
Co-authored-by: Carl Lin <carl@solana.com>
2021-06-08 13:59:50 -06:00
01ef2a5c4a
test: simple CalculateHashIntermediate refactoring ( #17813 )
2021-06-08 13:54:10 -06:00
58fe1d0764
add min to roots_tracker ( #17806 )
2021-06-08 08:32:16 -06:00
817d48be21
binary search in slices for hashing ( #17755 )
2021-06-07 12:09:17 -05:00
b5bb91b50f
rework hash calculation to not keep slot and write version ( #17685 )
...
* rework hash calculation to not keep slot and write version
* refactor functions and add tests
* always use multiple slot code path
2021-06-07 09:01:16 -05:00
8f5e773caf
system-program: Remove zero lamport check on transfers ( #17726 )
...
* system-program: Move lamports == 0 check on transfers
* Address feedback
* Update stake split to explicitly allocate + assign
* Update stake tests referring to split instruction
* Revert whitespace
* Update split instruction index in test
* Remove unnecessary `assign_with_seed` from `split_with_seed`
* Fix stake instruction parser
* Update test to allow splitting into account with lamports
2021-06-06 01:45:45 +02:00
00ee84af37
break out hash time in metric ( #17721 )
2021-06-04 14:54:06 -05:00
f6fb8906c7
add data point for cap mismatch ( #17746 )
2021-06-04 13:54:39 -05:00
5197454fea
increase bin count for hash scan ( #17562 )
2021-06-04 10:53:13 -05:00
f97ce2cd7e
Per-program id timings ( #17554 )
2021-06-04 16:04:31 +02:00
81bafd9daf
add info for vm.max_map_count incorrectly set. ( #17727 )
2021-06-04 03:22:12 +00:00
3dcc8e0046
chore: bump libloading from 0.6.2 to 0.7.0 ( #17704 )
...
* chore: bump libloading from 0.6.2 to 0.7.0
Bumps [libloading](https://github.com/nagisa/rust_libloading ) from 0.6.2 to 0.7.0.
- [Release notes](https://github.com/nagisa/rust_libloading/releases )
- [Commits](https://github.com/nagisa/rust_libloading/compare/0.6.2...0.7.0 )
---
updated-dependencies:
- dependency-name: libloading
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* [auto-commit] Update all Cargo lock files
* New libloading methods are marked unsafe
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
Co-authored-by: Tyera Eulberg <tyera@solana.com>
2021-06-03 18:08:31 -06:00
9388aaca15
use slots returned from get_snapshot_storages to sort ( #17638 )
...
* use slots returned from get_snapshot_storages to sort
* add tests
2021-06-02 18:24:55 -05:00
4bd32d891f
remove slot lookup ( #17691 )
2021-06-02 17:56:19 -05:00
83ceedc091
simplify test construction ( #17686 )
2021-06-02 17:32:31 -05:00
db8811eacd
support bin divisions up to 65536 ( #17563 )
...
* support bin divisions up to 65536
* add tests
2021-06-02 17:31:15 -05:00
d802eb303c
reduce copy ( #17672 )
2021-06-02 14:03:02 -05:00
07bac27ac7
remove antiquated assert ( #17643 )
2021-06-02 09:47:26 -05:00
eec996ba41
implement ancestors as rolling bit field ( #17482 )
2021-06-02 09:32:32 -05:00
107af52deb
minor test code cleanup ( #17645 )
2021-06-02 08:35:10 -05:00
bbcdf073ba
Support out of band dumping of unrooted slots in AccountsDb ( #17269 )
...
* Accounts dumping logic
* Add test for interaction between cache flush and remove_unrooted_slot()
* Update comments
* Rename
* renaming
* Add more comments
* Renaming
* Fixup test and bad check
2021-06-02 09:51:10 +00:00
80e5b24b38
Fix CPI recursion depth ( #17659 )
...
* Fix CPI recursion depth
2021-06-02 11:15:19 +02:00
14c52ab018
Skip shrink when it doesn't save anything ( #17405 )
2021-06-02 09:51:46 +02:00
738cc9549f
parallel get_snapshot_storages ( #17589 )
2021-06-01 19:33:12 -05:00
c8fdf0762c
add Ancestors to get_snapshot_storages to prepare for the future ( #17591 )
2021-06-01 15:14:35 -05:00
ef5169ff24
sort storages by slot before scan ( #17411 )
...
* sort storages by slot before scan
* fix return value
2021-06-01 15:07:46 -05:00
72bb271a94
add metric for collecting storages ( #17527 )
2021-06-01 13:17:49 -05:00
886898eabf
rework test for flexibility ( #17592 )
...
* rework test for flexibility
* respond to pr feedback
2021-05-31 22:49:17 -05:00
654918ab27
refactor SnapshotStorage helpers to prepare for later changes ( #17560 )
2021-05-28 13:54:53 -05:00
a3240aebde
Always bail if program modifies a ro account ( #17569 )
2021-05-28 09:50:25 -07:00
8924fbf6a0
RollingBitField: bug fixes and add tests ( #17525 )
...
* RollingBitField: bug fixes and add tests
* respond to feedback
2021-05-28 16:33:07 +00:00
1d02dba06f
remove unnecessary clone ( #17559 )
2021-05-28 10:30:01 -05:00
55c22d3b76
add check_hash to non-index hash calculation ( #17558 )
2021-05-28 10:24:40 -05:00
1953543274
Refactor bank_forks_utils::load() and some snapshot logic ( #17492 )
...
Refactor a few functions that are on the load-from-snapshot path, to facilitate
adding in incremental snapshots more easily.
Additionally, add some tests and doc comments.
2021-05-27 12:00:27 -05:00
49402b7d82
Only add keys with multiple index entries to the clean set ( #17473 )
2021-05-27 16:31:24 +02:00
3973bf08f1
move local out of call ( #17519 )
2021-05-27 08:53:11 -05:00
9541411c15
Plumb transaction-level rewards (aka "rent debits") into the `getTransaction` RPC method
2021-05-27 03:05:05 +00:00
cbce440af4
simulateTransaction can now return accounts modified by the simulation
2021-05-26 14:20:23 -07:00
3f9e3c7375
Remove copied shrink code ( #17385 )
2021-05-26 19:27:18 +02:00
6b9d8d41a3
add --limit_load_slot_count_from_snapshot to ledger-tool ( #17417 )
2021-05-26 10:36:12 -05:00
2a6c5ed0ac
add tests from `RentDebits`
2021-05-26 08:19:10 +00:00
97eab7edf9
runtime: add rent debit charges to block metadata
2021-05-26 08:19:10 +00:00
e9bc1c6b07
Add last valid block height to rpc Fees ( #17506 )
...
* Add last_valid_block_height to fees rpc
* Add getBlockHeight rpc
* Update docs
2021-05-26 07:26:19 +00:00
a5c2067273
fixup! Ancestors to HashSet: From(Vec) ( #17447 ) ( #17481 )
2021-05-25 12:24:34 -05:00
98f1b11edd
Ancestors to HashSet: From(Vec) ( #17447 )
...
* ancestors.large_range_slots becomes HashSet
* Ancestors to HashSet: From(Vec)
2021-05-25 11:01:11 -05:00
d39a327138
ancestors.large_range_slots becomes HashSet ( #17446 )
2021-05-25 11:00:50 -05:00
40bb6577fc
initialize purge stats ( #17345 )
2021-05-25 09:24:38 -05:00
d4fc9e7ed4
ad metric for collect ( #17418 )
2021-05-24 18:14:52 -05:00
dd22ae047b
ancestors is set instead of map ( #17363 )
2021-05-24 17:01:02 -05:00
d8bc56fa51
Refactor purge_slots_from_cache_and_store() and handle_reclaims() ( #17319 )
2021-05-24 13:51:17 -07:00
ad1f24d487
runtime: Executor usage counts retain only single-epoch memory ( #17162 )
2021-05-24 12:01:56 -07:00
a8dca3976b
Refactor genesis download/load/check functions ( #17276 )
...
* Refactor genesis ingest functions
* Consolidate genesis.bin/genesis.tar.bz2 references
2021-05-24 16:45:36 +02:00
855ae79598
Fix InvokeContext::push() account_deps ( #17350 )
...
* Reverts aliasing of account_deps with the previous invocation stack frame in InvokeContext::push().
* Adds explicit assert of programdata account content in test_program_bpf_upgrade_via_cpi.
2021-05-21 22:34:07 +02:00
3f3324231d
Hold read lock during startup shrink ( #17309 )
...
* hold read lock during account scan of shrink
* rename and improve rusty
2021-05-21 13:59:32 -05:00
44831c18d2
reuse work in is_non_loader_key ( #16521 )
2021-05-21 10:07:04 -05:00
8143ee5502
add AccountsIndex AccountMapsReadLock type ( #17365 )
2021-05-21 10:02:14 -05:00
2f55547d37
remove flatten in storage scan ( #17354 )
...
* remove flatten in storage scan
* fix tests
2021-05-21 09:26:46 -05:00
2c99b23ad7
Add get_sysvar() helper to sdk
2021-05-21 01:30:12 +00:00
45552d271a
take mutex once in process_dead_slots ( #17357 )
2021-05-20 19:50:58 -05:00
0486df02ba
don't limit to thread pool when cleaning on startup ( #17317 )
2021-05-20 14:36:35 -05:00
33ab9c4e8d
batch insert account_index items in generate_index ( #17290 )
2021-05-20 10:29:13 -05:00
9b74988fc6
calculate_accounts_hash does not throttle threads on startup ( #17338 )
2021-05-20 10:25:54 -05:00
a9aa533684
replace Ancestors HashMap for performance ( #16477 )
...
* replace Ancestors HashMap for performance
* add ancestors module
2021-05-20 10:11:56 -05:00
a544010b03
don't log shrink metrics on first call ( #17328 )
...
* don't log shrink metrics on first call
* simplify logic
2021-05-20 00:15:35 +00:00
32ec8341f9
generate_index inserts ideal initial data ( #17247 )
...
* improve insert into map initially
* rework towards single code path
* rename
* update test
2021-05-19 16:21:24 -05:00
b5302e7619
add calc_stored_meta_us metric ( #17318 )
2021-05-19 12:29:41 -05:00
c20b27bc8f
shink all in parallel on startup ( #17308 )
2021-05-19 12:15:24 -05:00
ed9cbd50f0
move Ancestors to its own module ( #17316 )
2021-05-19 11:50:34 -05:00
0781fe1b4f
Upgrade Rust to 1.52.0 ( #17096 )
...
* Upgrade Rust to 1.52.0
update nightly_version to newly pushed docker image
fix clippy lint errors
1.52 comes with grcov 0.8.0, include this version to script
* upgrade to Rust 1.52.1
* disabling Serum from downstream projects until it is upgraded to Rust 1.52.1
2021-05-19 09:31:47 -05:00
4788976517
rework slot list update ( #17232 )
2021-05-19 08:48:46 -05:00
7fe24c455c
simplify generate_index ( #17292 )
2021-05-19 08:11:41 -05:00
827355a6b1
Create solana-rpc crate and move subscriptions ( #17320 )
...
* Move non_circulating_supply to runtime
* Add solana-rpc crate and move max_slots
* Move subscriptions to solana-rpc
* Single use statements
2021-05-19 00:54:28 -06:00
a3c0833a1c
tests: cleanup test ( #17305 )
...
* tests: cleanup test
* 2 more replacements
2021-05-18 18:08:37 -05:00
75335b4f58
datapoint for verify_snapshot_bank ( #17306 )
2021-05-18 12:14:43 -05:00
2175fc0625
calculate account infos before lock ( #17245 )
2021-05-18 08:06:19 -05:00
3a56a56d69
StoredMetaWriteVersion ( #17293 )
2021-05-17 23:58:36 +00:00
bcbe155575
Minor test cleanup and comments ( #17283 )
2021-05-18 07:22:43 +09:00
d461aba6a4
don't try to build secondary indexes if we don't need them ( #17246 )
2021-05-17 17:21:15 -05:00
9d6837c904
fix comment ( #17286 )
2021-05-17 14:06:25 -05:00
d1db5448b9
hold lock to speed up insert ( #17194 )
...
* hold lock to speed up insert
* add tests
2021-05-17 11:58:33 -05:00
3745e0babc
minor refactoring of AccountsIndex in preparation of bigger things ( #17237 )
2021-05-14 15:27:10 -05:00
fd88db7339
ancestors::new -> default ( #17195 )
2021-05-14 15:20:59 -05:00
c6f7867aa1
log mismatch ( #17209 )
2021-05-14 09:50:11 -05:00
76dfacca61
Add documentation for BankForks::prune_non_rooted() ( #17213 )
2021-05-14 07:47:48 -05:00
27004f1b76
Return error for excluded secondary-index keys ( #17193 )
...
* Add runtime helpers to check secondary indexes for key
* Add custom rpc error
* Check secondary-index key inclusion in rpc
* Clone complete AccountSecondaryIndexes into rpc to avoid bank query
2021-05-13 21:04:21 +00:00
3dbc7744ab
metrics for generating index time ( #17192 )
...
* metrics for generating index time
* update metrics to include scan time
2021-05-13 14:32:19 -05:00
239ab8799c
Remove bloat from secondary indexes ( #17048 )
2021-05-12 15:29:30 -07:00
9c42a89a43
Issue #17008 -- make snapshot archives to hold on to configurable. ( #17158 )
...
* purge_old_snapshot_archives is changed to take an extra argument 'maximum_snapshots_to_retain' to control the max number of latest snapshot archives to retain. Note the oldest snapshot is always retained as before and is not subjected to this new options.
* The validator and ledger-tool executables are modified with a CLI argument --maximum-snapshots-to-retain. And the options are propagated down the call chains. Their corresponding shell scripts were changed accordingly.
* SnapshotConfig is modified to have an extra field for the maximum_snapshots_to_retain
* Unit tests are developed to cover purge_old_snapshot_archives
2021-05-12 10:32:27 -07:00
7d96f78821
include/exclude keys on account secondary index ( #17110 )
...
* AccountSecondaryIndexes.include/exclude
* use normal scan if key is not indexed
* add a test to ask for a scan for an excluded secondary index
* fix up cli args
2021-05-11 22:06:22 +00:00
f39dda00e0
type AccountSecondaryIndexes = HashSet ( #17108 )
2021-05-10 14:22:48 +00:00
a6a1355b80
fix secondary index test ( #17111 )
2021-05-10 08:54:30 -05:00
c616c34825
Add comment for another unspoken eager collection subtlety ( #17137 )
2021-05-10 22:44:46 +09:00
225ec00ec4
add comment ( #17059 )
2021-05-06 15:17:41 -05:00
dc0429f5e6
add metric for assumption ( #17061 )
2021-05-06 15:04:13 -05:00
edc2ab3e48
Test account index and store alignment ( #17038 )
...
* Use ReclaimResult::Default() instead of building subtypes
* Add test to ensure account_db store and index are aligned
2021-05-06 14:13:44 -05:00
d19526e6c2
Dump rent_collector/inflation with ledger-tool cap ( #17069 )
2021-05-06 19:29:46 +09:00
ffbe8906ed
get root lock once ( #16829 )
2021-05-05 15:17:45 -05:00
e6f49a3e79
Clean unrooted unfrozen banks ( #16580 ) ( #17003 )
...
Cleanup pubkeys when an unrooted, unfrozen bank is dropped. This is a
continuation of PR #16911 .
2021-05-05 15:02:02 -05:00
ab7c96aa81
insert accounts in parallel when building initial index ( #17040 )
...
* insert accounts in parallel when building initial index
* rename nits from pr review
* rename nits from pr review
* rename nits from pr review
* rename nits from pr review
2021-05-05 17:08:45 +00:00
3e0fed48e7
Don't recognize temp snapshots as possible snapshots to open
2021-05-05 08:45:03 -07:00
5786be13a4
flatten_hash_intermediate sets capacity first ( #17013 )
...
* flatten_hash_intermediate sets capacity first
* use iterator instead of for
2021-05-05 09:07:05 -05:00
d94e4ef7c9
More docs for bank.rs ( #17006 )
2021-05-03 17:37:18 +00:00
541aa5ad85
tests: lamports -> lamports() ( #16982 )
2021-05-03 10:45:54 -05:00
744ac1535f
tests: lamports -> ReadableAccount ( #16983 )
2021-05-03 10:45:15 -05:00
1fe131a5bb
Readable account trait for stored account meta ( #16690 )
...
* ReadableAccount for StoredAccountMeta
* add test
2021-04-30 16:25:02 -05:00
1a9954f85b
bank deposit checked_add error ( #16917 )
...
* bank deposit checked_add error
* add id
* rename variables
* rename error and metric
2021-04-30 16:22:17 -05:00
01308cd890
distribute_rent_to_validators checked_add_lamports unwrap ( #16847 )
...
* distribute_rent_to_validators checked_add_lamports unwrap
* make rent disappear on add failure
* add pubkey to message
* update message text
* don't store account that we failed to transfer to
* format
2021-04-30 16:19:20 -05:00
763c04adf3
lamports = -> .set_lamports() ( #16980 )
2021-04-30 21:17:05 +00:00
17e6bd579f
Clean unrooted dropped banks ( #16580 ) ( #16911 )
...
In a scenario where a bank is unrooted and dropped, any keys that exist
_only_ in that bank are now cleaned up.
This work was originally based on PR #15106 .
2021-04-30 15:34:38 -05:00
6f88aeac56
tests: .lamports= -> .set_lamports() ( #16977 )
...
* .lamports= -> .set_lamports()
* another
* fix
* another
2021-04-30 18:44:15 +00:00
0af84bb91e
lamports= -> .set_lamports() ( #16978 )
2021-04-30 18:20:54 +00:00
Jeff Washington (jwash)
sakridge
Tyera Eulberg
Tyera Eulberg
Alexander Meißner
Jon Cinque
carllin
Lijun Wang
Jack May
Justin Starry
dependabot[bot]
Brooks Prumo
Michael Vines
Trent Nelson
steviez
jon-chuang
Tao Zhu
Ryo Onodera