Commit Graph

11 Commits

Author SHA1 Message Date
Illia Bobyr c449a15c30
metrics: datapoint macro: Allow trailing comma (#30317)
Rust grammar allows trailing commas in most places where a list of
elements are accepted.  It simplifies cases when the list is generated
by a macro, allowing the macro to avoid special cases for a one element
list vs longer lists.

As such, it is a common practice to allow trailing commas in macros as
well.
2023-03-17 12:57:46 -07:00
steviez 136eb43f7d
Allow metric tag values to be runtime configurable (#25615) 2022-06-06 12:14:38 -05:00
Yueh-Hsuan Chiang 6de2884969
Extend the datapoint macro to support group-by operations. (#25385)
#### Problem
Our existing datapoint macro syntax does directly not support group-by tags.
The existing workaround is to embed the group-by tags into the metric name which does not scale well.

#### Summary of Changes
This PR extends the existing syntax to support group-by tags as follows.  The new syntax is also compatible with the existing syntax:
```
datapoint_debug!(
   "metric_name",
   "tag" => "tag-value",
   "tag2" => "tag-value2",
   ....
   ("field1", 100, i64),  // field syntax is the same as the current syntax.
   ("field2", "hello", String),  
   ...
);
```
2022-05-26 17:00:58 -07:00
Yueh-Hsuan Chiang d121a06826
Add comment block and examples for datapoint.rs (#25393)
#### Summary of Changes
Add comment block and examples for datapoint.rs
2022-05-21 16:41:51 -07:00
Michael Vines 6d5bbca630 Pacify clippy 2022-01-21 19:12:57 -08:00
behzad nouri cd87525f54
uses nanos precision for timestamp when submitting metrics to influxdb (#20623)
Current datapoint_info! is apparently overwriting itself when run inside
a loop. For example in
https://github.com/solana-labs/solana/blob/005d6863f/core/src/window_service.rs#L101-L107
only one of the slots will show up in influxdb.

This is apparently because of metrics code using milliseconds as the
timestamp, as mentioned here:
https://github.com/solana-labs/solana/issues/19789#issuecomment-922482013
2021-10-13 13:58:02 +00:00
anatoly yakovenko 17fb8258e5
Datapoints overwhelm the metrics queue and blow up ram usage. (#8272)
automerge
2020-02-14 11:11:55 -08:00
sakridge 5ef012b2c1
Tweak debug to remove unreadable datapoints (#6060) 2019-10-04 16:25:22 -07:00
Michael Vines c1c7e0ff08
Remove reduntant semicolon 2019-10-03 16:25:00 -07:00
Michael Vines 3d44cffcda
Beautify metrics datapoint logging (#5998) 2019-09-20 12:00:43 -07:00
Michael Vines df205f8752
Use ureq instead of influx_db_client (#5839) 2019-09-07 12:48:45 -07:00