Our sanity CI check is unhappy about it.
These were added in
commit 676e80c80a
Author: Nick Frostbutter <75431177+nickfrosty@users.noreply.github.com>
Date: Mon Dec 11 15:17:13 2023 -0500
[docs] docs migration (https://github.com/solana-labs/solana/pull/34096)
Seems like CI marked the original change as having an issue, but it was
still submitted.
* add requested limits to static meta
* rebase to catch up on compue_budget_processor no longer needs feature_set; update requested limits as flat fields of static meta without expiry
* Return early if reference set is empty
* Remove unreachable case
* Update reference_last_block
* Limit reference set by last_block_checked
* Return superflous-block data too
* Sort missing/superfluous blocks
* Fix tests
* Move last_block_checked calculation into missing_blocks()
* Prevent missing_slots panic
* Fix test
* Add script to specify spl-token-cli version
* Add check for spl-token-cli version to CI
* Add minor release branch cleanup instruction to unblock CI on the new stable branch
---------
Co-authored-by: Will Hickey <will.hickey@solana.com>
BankForks has two constructors; one that takes a single Bank (the root)
and one that can take an arbitrary number of Banks plus the root slot.
However, the constructor that accepts multiple banks is unnecessary; it
isn't used in production and is only used in several tests.
So, remove the multi-bank constructor and update unit tests.
* fix typo: Change 'store it the recipient address' to 'store it in the recipient address'
* fix grammar in documentation: Remove 'of' from 'Both of docker images' and add 'is' to 'This image manually maintained'
* fix duplicate word in 'Voting Algorithm' section
* cli: program upgrade with offline signing (--sign-only mode)
* ditch universal NullSigner approach as overly complex
* rearrange some code to make it more coherent, fix typos
* apply clippy suggestions to simplify code
* review pass
* adjust brokens (due to rebase onto refactored structures) doc links
* fix linter complaint in doc formatting
* remove rebase artifacts
---------
Co-authored-by: norwnd <norwnd>
Several commands call load_and_process_ledger() which can fail in a
number of ways. These callers currently all handle the result in the
same way by matching the return Result:
- The Ok(_) case uses the returned types as normal
- The Err(_) case prints an error message and exits
This error handling is redundant, and a helper could remove the
duplicate code. So, this PR adds a wrapper around that checks the
result and unwraps OR prints error messages and exits.
load_and_process_ledger() performs many checks and sub-operations that
can fail. The current error handling prints an error message and exits
immediately. The long error/help messages written inline add clutter
to the functions actual implementation.
This PR creates a new error enum for all of these previous error
conditions, and bubbles up the error to let the caller decide what to
do instead of exiting immediately.
These entries are legacy code at this point; however, older release
branches require these entries to be present. Also, while it would be
nice to clean up these entries immediately, they only occupy a small
amount of space so having them linger a little longer isn't a big deal.
#### Problem
HotAccountOffset::new() might return Err for invalid offset, and this
part needs some test coverage.
#### Summary of Changes
Add unit-tests for checking invalid HotAccountOffset.
* fix grammatical error in Incident Response Process section
* Fix typo in setup instructions
* Fixed grammatical errors in documentation: corrected article usage, pluralization, and singular form in database reference
* Fix typos in documentation: Correct 'In oder' to 'In order', fix 'enviroment' to 'environment', correct 'reults' to 'results' in Ping Results section, and change 'engress' to 'egress' in CUDA section.
* Fix grammatical errors in documentation
* Fix grammatical issues in documentation
Correct subject-verb agreement in transaction balance description and clarify execution of instructions in a transaction.
* Update macro to be a complete sentence
* Update punctuation/spaces to match new macro
* Remove repetitive 'address' usage and correct other verbiage
* Improve a couple withdrawal-recipient messages
* Fix wording
* Review comments