49b8ea771e
simplifies ServeRepair::run_orphan ( #30908 )
2023-03-27 23:19:55 +00:00
04f0311aa1
check data budget before accessing blockstore ( #30809 )
2023-03-22 15:56:06 -07:00
94b27d8f96
add metric for repair request blockstore misses ( #30810 )
2023-03-22 15:47:11 -07:00
4ba80ad785
Inline format args ( #30364 )
...
clippy fixes
2023-02-16 17:00:43 +00:00
febaf36e6d
Apply clippy fixes for future rust upgrade ( #30363 )
2023-02-16 16:12:51 +00:00
ded457cd73
embeds the new gossip ContactInfo in ClusterInfo ( #30022 )
...
Working towards replacing the legacy gossip contact-info with the new
one, the commit updates the respective field in gossip cluster-info.
2023-02-10 20:07:45 +00:00
6163a6c279
restructure repair decode error handling ( #29977 )
2023-01-31 02:44:58 -08:00
7cacbdcca2
track repair handle_requests time ( #29940 )
2023-01-27 15:50:18 -08:00
1c7662a37f
asserts that cluster-info keypair is consistent with contact-info id ( #29818 )
2023-01-24 16:57:55 +00:00
dd92f225bb
Use Ipv4Addr::{LOCALHOST, UNSPECIFIED} constants ( #29813 )
2023-01-23 16:49:51 -06:00
bd9b311c63
adds frozen_abi annotations to repair service enums/structs ( #29820 )
...
... in order to keep types backward compatible.
2023-01-23 16:49:06 +00:00
f9062718c4
prioritize repair requests by stake ( #29730 )
2023-01-17 18:38:10 -08:00
8c212f59ad
renames ContactInfo to LegacyContactInfo ( #29566 )
...
Working towards adding a new ContactInfo where new sockets can be
added in a backward compatible way.
2023-01-08 16:00:55 +00:00
5c9beef498
fixes errors from clippy::useless_conversion ( #29534 )
...
https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
2023-01-05 18:05:32 +00:00
832302485e
require repair request signature, ping/pong for Testnet, Development clusters ( #29351 )
2023-01-04 14:54:19 -08:00
17b64005d3
Add more logging and documentation to flaky optimistic confirmation tests ( #29418 )
...
* Revert "add retry for flakey local cluster test (#29228 )"
This reverts commit 7a97121747
2022-12-27 10:47:45 -07:00
a44ea779bd
add support for a repair protocol whitelist ( #29161 )
2022-12-15 19:24:23 -08:00
88a8f40bd2
apply [limit repairs to top staked... #28673 ] to non-MainnetBeta clusters ( #29163 )
2022-12-11 15:52:41 -08:00
b1340d77a2
sdk: Make Packet::meta private, use accessor functions ( #29092 )
...
sdk: Make packet meta private
2022-12-06 12:54:49 +01:00
0d0a491f27
More documentation + small refactor for RepairService ( #28933 )
2022-11-28 19:46:06 -08:00
17ee3349f8
limit repairs to top staked requests in batch ( #28673 )
2022-11-16 16:30:41 -08:00
e10d958352
signed repair request test fixes/cleanup ( #28691 )
2022-11-15 16:46:17 -08:00
d1ba42180d
clippy for rust 1.65.0 ( #28765 )
2022-11-09 19:39:38 +00:00
0df4be06a0
enable repair ping/pong cache ( #28408 )
2022-10-19 14:55:55 -07:00
e283461d99
enforces hash domain for ping-pong protocol ( #28433 )
...
https://github.com/solana-labs/solana/pull/27193
added hash domain to ping-pong protocol.
For backward compatibility responses both with and without domain were
generated and accepted.
Now that all clusters are upgraded, this commit enforces the hash domain
by removing the response without the domain.
2022-10-18 18:17:12 +00:00
15050b14b9
use signed repair request variants ( #28283 )
2022-10-10 14:09:45 -07:00
e3e888c0e0
stats for staked/unstaked repair requests ( #28215 )
2022-10-04 17:37:24 -07:00
8b0f9b4917
make ping cache rate limit delay configurable ( #27955 )
2022-09-26 14:16:56 -07:00
9816c94d7e
metrics to distinguish why repair packets are dropped ( #27960 )
2022-09-24 23:20:05 -07:00
8b43215ddd
count unsigned repair requests ( #27953 )
2022-09-24 12:56:02 -07:00
206cc9407b
allow unsigned repair requests ( #27910 )
2022-09-23 10:11:08 -07:00
3f4731b37f
Standardize thread names
...
Tenets:
1. Limit thread names to 15 characters
2. Prefix all Solana-controlled threads with "sol"
3. Use Camel case. It's more character dense than Snake or Kebab case
2022-08-20 07:49:39 -07:00
6928b2a5af
adds hash domain to ping-pong protocol ( #27193 )
...
In order to maintain backward compatibility, for now the responding node
will hash the token both with and without domain so that the other node
will accept the response regardless of its upgrade status.
Once the cluster has upgraded to the new code, we will remove the legacy
domain = false case.
2022-08-18 22:39:31 +00:00
370de8129e
ancestor hashes socket ping/pong support ( #26866 )
2022-08-09 21:39:55 -07:00
ec36f0c5df
removes redundant Option<&Arc<...>> wrapper for Blockstore in serve-repair
2022-08-02 15:30:53 +00:00
6423da0218
removes redundant Arc<RwLock<...>> wrapper off ServeRepair
2022-08-02 15:30:53 +00:00
ded9a35cd6
mark repair ping packets for discard only after successful signature verification ( #26878 )
2022-08-01 16:17:19 -07:00
857be1e237
sign repair requests ( #26833 )
2022-07-31 15:48:51 -07:00
f6d5b253fb
Enforce a 12MB limit on outbound repair ( #26493 )
2022-07-24 20:44:22 -05:00
5bffee248c
Cleanup repair logging ( #26461 )
2022-07-07 15:02:43 -05:00
5dbf7d8f91
removes raw indexing into packet data ( #25554 )
...
Packets are at the boundary of the system where, vast majority of the
time, they are received from an untrusted source. Raw indexing into the
data buffer can open attack vectors if the offsets are invalid.
Validating offsets beforehand is verbose and error prone.
The commit updates Packet::data() api to take a SliceIndex and always to
return an Option. The call-sites are so forced to explicitly handle the
case where the offsets are invalid.
2022-06-03 01:05:06 +00:00
880684565c
limits read access into Packet data to Packet.meta.size ( #25484 )
...
Bytes past Packet.meta.size are not valid to read from.
The commit makes the buffer field private and instead provides two
methods:
* Packet::data() which returns an immutable reference to the underlying
buffer up to Packet.meta.size. The rest of the buffer is not valid to
read from.
* Packet::buffer_mut() which returns a mutable reference to the entirety
of the underlying buffer to write into. The caller is responsible to
update Packet.meta.size after writing to the buffer.
2022-05-25 16:52:54 +00:00
cad1c41ce2
Add Packet::deserialize_slice convenience method
2022-05-24 17:31:14 +08:00
ec7ca411dd
Make PacketBatch packets vector non-public ( #25413 )
...
Upcoming changes to PacketBatch to support variable sized packets will
modify the internals of PacketBatch. So, this change removes usage of
the internal packet struct and instead uses accessors (which are
currently just wrappers of Vector functions but will change down the
road).
2022-05-23 15:30:15 -05:00
c248fb3f51
renames Packet Meta::{,set_}addr methods to {,set_}socket_addr ( #25478 )
...
In order to distinguish between Meta.addr field which is an IpAddr and
the methods which refer to a SocketAddr.
2022-05-23 15:48:59 +00:00
b27125815a
Simplify logic around MAX_ORPHAN_REPAIR_RESPONSES constant ( #25032 )
2022-05-17 19:45:45 -06:00
eff59193db
enforces that LAST_SHRED_IN_SLOT is also DATA_COMPLETE_SHRED ( #24892 )
...
A data shred cannot be LAST_SHRED_IN_SLOT if not also DATA_COMPLETE_SHRED.
So LAST_SHRED_IN_SLOT should also imply DATA_COMPLETE_SHRED:
https://github.com/solana-labs/solana/blob/74b586ae7/ledger/src/shredder.rs#L116-L117
https://github.com/solana-labs/solana/blob/74b586ae7/core/src/broadcast_stage/standard_broadcast_run.rs#L80-L81
However current shred constructs allow specifying a shred which is
LAST_SHRED_IN_SLOT but not DATA_COMPLETE_SHRED:
https://github.com/solana-labs/solana/blob/74b586ae7/ledger/src/shred.rs#L117-L118
https://github.com/solana-labs/solana/blob/74b586ae7/ledger/src/shred.rs#L272-L273
The commit updates ShredFlags so that if a shred is not
DATA_COMPLETE_SHRED it cannot be LAST_SHRED_IN_SLOT either.
2022-05-02 23:33:53 +00:00
0f60665100
replaces Shred::new_empty_coding with Shred::new_from_parity_shard ( #24749 )
...
Removing implementation details of shreds and payload offsets from
shredder, so that shredder does not need to mutate payload:
https://github.com/solana-labs/solana/blob/71ad12128/ledger/src/shred.rs#L968-L977
Also, Shred::new_from_data can simply obtain a slice as opposed to
Option<&[u8]>:
https://github.com/solana-labs/solana/blob/71ad12128/ledger/src/shred.rs#L268-L278
2022-04-27 18:04:10 +00:00
081c844d6e
removes Shred::new_empty_data_shred ( #24714 )
...
Shred::new_empty_data_shred returns an invalid shred (i.e.
shred.sanitize() returns error). The method is only used in tests and
can be easily replaced with Shred::new_from_data. To keep the shred api
surface small, this commit removes this method.
2022-04-26 23:13:12 +00:00
895f76a93c
hides implementation details of shred from its public interface ( #24563 )
...
Working towards embedding versioning into shreds binary, so that a new
variant of shred struct can include merkle tree hashes of the erasure
set.
2022-04-25 12:43:22 +00:00
behzad nouri
Jeff Biseda
Brooks
Kevin Ji
Ashwin Sekar
Jon Cinque
Michael Vines
carllin
Justin Starry
steviez