8b90084ebc
fix comment typos ( #22723 )
2022-01-25 11:10:42 -06:00
fc21af4e6e
spl-associated-token-account: Add feature for new program ( #22648 )
...
* spl-associated-token-account: Add feature for new program
* Address feedback
2022-01-24 22:54:41 +01:00
6d5bbca630
Pacify clippy
2022-01-21 19:12:57 -08:00
e3915e4b7a
add comment ( #22636 )
2022-01-21 10:51:58 -06:00
4abf7a7f88
add ActiveStats to track when long running, expensive bg processes are running ( #22608 )
2022-01-21 10:51:23 -06:00
9977396d8f
Remove unused fields from Bank ( #22491 )
2022-01-21 06:03:41 -06:00
7d34a7acac
Perf: Only check executors cache for executable bpf program ids ( #22624 )
...
* Only check executors cache for executable bpf program ids
* switch to native loader check
* clean up tests
* fix tests
* clippy
2022-01-21 18:32:30 +08:00
0eb488580d
minor cleanup ( #22610 )
2022-01-20 18:11:00 -06:00
7ba57e7a7c
Refactor: move instructions sysvar serialization out of Message ( #22544 )
2022-01-20 17:33:49 +08:00
7f20c6149e
Refactor: move simple vote parsing to runtime ( #22537 )
2022-01-20 10:39:21 +08:00
d343713f61
Optimize packet dedup ( #22571 )
...
* Use bloom filter to dedup packets
* dedup first
* Update bloom/src/bloom.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* Update core/src/sigverify_stage.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* Update core/src/sigverify_stage.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* Update core/src/sigverify_stage.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* fixup
* fixup
* fixup
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
2022-01-19 13:58:20 -08:00
b448472037
Refactor: Move `InstructionRecorder` into `TransactionContext` ( #22578 )
...
* Moves InstructionRecorder into TransactionContext.
* Adds assertions for number_of_instructions_at_transaction_level.
2022-01-19 22:40:09 +01:00
cc76a73c49
Refactor: move compute budget runtime logic into solana-program-runtime ( #22543 )
2022-01-17 20:48:00 +08:00
2c38a9213f
Revert "Refactor: move compute budget runtime logic into solana-program-runtime ( #22533 )" ( #22542 )
...
This reverts commit b27976626a
2022-01-17 17:43:17 +08:00
b27976626a
Refactor: move compute budget runtime logic into solana-program-runtime ( #22533 )
2022-01-17 15:52:33 +08:00
6edeed888d
Remove unnecessary & from AsRef params ( #22523 )
2022-01-15 04:51:05 +00:00
70633b5c2f
Add Bank::accounts_data_len to SetRootMetrics ( #22509 )
2022-01-14 20:00:07 -06:00
a724fa2347
Add hidden cli option to allow validator reports replayed transaction cost metrics ( #22369 )
...
* add hidden cli option to allow validator reports replayed transaction cost detail metrics
* Update validator/src/main.rs
Co-authored-by: Michael Vines <mvines@gmail.com>
* - rebase master, using unbounded instead of channel; dowgrade to datapoint_trace
* removed cli arg, prefer log at trace
Co-authored-by: Michael Vines <mvines@gmail.com>
2022-01-15 00:31:21 +00:00
7d7228c356
cleanup assert ( #22495 )
2022-01-14 11:53:24 -06:00
9c9f2dd5bd
port counting vote CUs to block cost ( #22477 )
2022-01-14 10:50:29 -06:00
cddab635ff
Cleanup activated rent_for_sysvars feature ( #22454 )
2022-01-14 20:34:09 +08:00
ae6c511f13
Refactor: Split vote_instruction.rs into multiple files ( #22502 )
2022-01-14 17:25:15 +08:00
4c577d7f8c
`Bank::get_fee_for_message` is now nonce aware
2022-01-13 17:27:38 -08:00
d3b95b9226
Cleanup AccountStorage struct ( #22463 )
...
* Revert "chore: bump dashmap from 4.0.2 to 5.0.0 (#21824 )"
This reverts commit 8aa3d690b5
2022-01-13 17:51:53 -06:00
7711cd74c3
partition_from_pubkey ( #22430 )
...
* Revert "chore: bump dashmap from 4.0.2 to 5.0.0 (#21824 )"
This reverts commit 8aa3d690b5
2022-01-13 17:02:42 -06:00
b82d71d22a
Inline DEFAULT_SNAPSHOT_VERSION constant string ( #22487 )
2022-01-13 18:19:15 +00:00
2756abce39
More serde snapshot cleanup ( #22449 )
2022-01-13 09:20:20 -06:00
9c3144e286
Refactor serde snapshot's "future" to "newer" ( #22431 )
2022-01-13 07:12:09 -06:00
2370e61431
Perf: Store deserialized sysvars in the sysvars cache ( #22455 )
...
* Perf: Store deserialized sysvars in sysvars cache
* add bench
2022-01-13 05:36:21 +00:00
7171c95bdd
Refactor: move sysvar cache to new module
2022-01-12 12:35:28 -07:00
3ca16de851
Only examine explicit tx accounts for rent state ( #22441 )
...
* Add failing test
* Fix: only examine accounts explicitly included in a tx
2022-01-11 20:23:51 -07:00
c45dde6164
Handle accounts data size changes due to rent-collected accounts ( #22412 )
2022-01-11 17:20:28 -06:00
637e366b18
Prevent rent-paying account creation ( #22292 )
...
* Fixup typo
* Add new feature
* Add new TransactionError
* Add framework for checking account state before and after transaction processing
* Fail transactions that leave new rent-paying accounts
* Only check rent-state of writable tx accounts
* Review comments: combine process_result success behavior; log and metrics before feature activation
* Fix tests that assume rent-exempt accounts are okay
* Remove test no longer relevant
* Remove native/sysvar special case
* Move metrics submission to report legacy->legacy rent paying transitions as well
2022-01-11 11:32:25 -07:00
a49ef49f87
optimizes ReadOnlyAccountsCache LRU eviction implementation ( #22403 )
...
ReadOnlyAccountsCache is using a background thread, table scan and sort
to implement LRU eviction policy:
https://github.com/solana-labs/solana/blob/eaa52bc93/runtime/src/read_only_accounts_cache.rs#L66-L73
https://github.com/solana-labs/solana/blob/eaa52bc93/runtime/src/read_only_accounts_cache.rs#L186-L191
https://github.com/solana-labs/solana/blob/eaa52bc93/runtime/src/read_only_accounts_cache.rs#L222
DashMap internally locks each shard when accessed; so a table scan in
the background thread can create a lot of lock contention.
This commit adds an index-list queue containing cached keys in the order
that they are accessed. Each hash-map entry also includes its index into
this queue.
When an item is first entered into the cache, it is added to the end of
the queue. Also each time an entry is looked up from the cache it is
moved to the end of queue. As a result, items in the queue are always
sorted in the order that they have last been accessed. When doing LRU
eviction, cache entries are evicted from the front of the queue.
Using index-list, all queue operations above are O(1) with low overhead
and so above achieves an efficient implementation of LRU cache eviction
policy.
2022-01-11 17:25:28 +00:00
8b66625c95
convert std::sync::mpsc to crossbeam_channel ( #22264 )
2022-01-11 02:44:46 -08:00
9bc2592da1
Use lazy_rent_collection directly ( #22410 )
2022-01-10 10:47:08 -06:00
3b4aad9df1
bank: fix executor cache metrics
2022-01-09 04:22:39 +00:00
d90d5ee9b6
Refactor Rent::due() with RentDue enum ( #22346 )
2022-01-08 09:03:46 -06:00
4a9f4e2505
improve multi executor cache addition
2022-01-08 03:47:23 -07:00
ad3cb0bc93
--amend
2022-01-08 08:19:27 +00:00
4ce48307bb
bank: prime new executor cache entry use-counts
2022-01-08 08:19:27 +00:00
6d76db1de5
bank: Add executors cache metrics
2022-01-07 16:53:27 -07:00
c2389fc209
removes CowCachedExecutors ( #22343 )
...
Copy-on-write semantics for cached executors can be implemented by a
simple Arc<CachedExecutors> as opposed to CowCachedExecutors:
https://github.com/solana-labs/solana/blob/f1e2598ba/runtime/src/bank.rs#L244-L247
This will also avoid the need for double locking as in:
https://github.com/solana-labs/solana/blob/f1e2598ba/runtime/src/bank.rs#L3490-L3491
https://github.com/solana-labs/solana/blob/f1e2598ba/runtime/src/bank.rs#L3525-L3526
2022-01-07 14:06:29 +00:00
52d12cc802
Add runtime support for address table lookups ( #22223 )
...
* Add support for address table lookups in runtime
* feedback
* feedback
2022-01-07 11:59:09 +08:00
f1e2598baa
Retain executor cache counts ( #22322 )
2022-01-06 08:56:00 -08:00
e0c091a9f4
factor out code in do_shrink_slot_stores ( #22306 )
2022-01-06 10:49:24 -06:00
100293c4b5
refactor get_store_for_shrink ( #22307 )
2022-01-06 10:49:01 -06:00
390ef0fbcd
Consolidate process instruction execution timings to own struct
2022-01-06 03:56:46 -07:00
72fc6096a0
Use saturating_add_assign macro
2022-01-06 03:56:46 -07:00
b25e4a200b
Add execute metrics
2022-01-06 03:56:46 -07:00
7d32909e17
move `ExecuteTimings` from `runtime::bank` to `program_runtime::timings`
2022-01-06 03:56:46 -07:00
12e160269e
cache executors on failed transactions ( #22308 )
2022-01-05 22:09:03 -08:00
ab13e39518
Only sum accounts data len from non-zero lamport accounts ( #22309 )
2022-01-05 23:23:37 +00:00
f2ed6f09ee
Skip updating already cached executors if unmodified
2022-01-05 16:08:10 -07:00
bb3a1b6b31
Add zk_token_sdk_enabled feature to gate Zk Token proof program and `sol_zk_token_elgamal_op` syscalls
2022-01-05 11:57:37 -08:00
9f63493789
Refactor: Remove KeyedAccounts (2) ( #22274 )
...
* Adds InstructionContext::get_signers().
Improves error messages when modifying borrowed accounts.
* Removes keyed_accounts from InvokeContext tests.
* Removes keyed_accounts from message_processor.rs
* Removes keyed_accounts from bank.rs
* Removes keyed_accounts from bpf serialization.
2022-01-05 09:39:37 +01:00
45458e7139
Refactor: Improve type safety and readability of transaction execution ( #22215 )
...
* Refactor Bank::load_and_execute_transactions
* Refactor: improve type safety of TransactionExecutionResult
* Add enum for extra type safety in execution results
* feedback
2022-01-05 10:15:15 +08:00
1460f00e0f
Consume from AccountsDataMeter ( #21994 )
2022-01-04 10:00:21 -06:00
2b5e00d36d
Limit number of accounts that a transaction can lock ( #22201 )
2022-01-04 14:25:23 +08:00
73e6038986
Refactor: Remove `KeyedAccount` from program runtime ( #22226 )
...
* Makes error handling in BorrowedAccount optional.
Adds BorrowedAccount ::get_rent_epoch().
Exposes InstructionContext::get_index_in_transaction().
Turns accounts and account_keys into pinned boxed slices.
* Introduces "unsafe" to InvokeContext::push().
* Turns &TransactionContext into &mut TransactionContext in InvokeContext.
* Push and pop InstructionContext in InvokeContext.
Makes test_process_cross_program and test_native_invoke symmetric.
Removes the borrow check from test_invoke_context_verify.
* Removes keyed_accounts from prepare_instruction()
* Removes usage of invoke_stack.
* Removes keyed_accounts from program-test.
* Removes caller_write_privileges.
* Removes keyed_accounts from BPF parameter (de-)serialization.
2022-01-03 23:30:56 +01:00
04b76eb066
Use AtomicUsize for next_bucket_to_flush ( #22095 )
2022-01-03 10:35:35 -06:00
fb62407232
AcctIdx: appendvecid: u32 ( #21842 )
2022-01-03 10:35:17 -06:00
a2a7e91ad6
set secp256k1 cost similar to sigverify
2021-12-31 17:45:50 -06:00
d743c2917c
re-calibrate limit based on mainnet data, see issue #21917
2021-12-31 17:45:50 -06:00
e529d03c11
Cleanup #22182 ( #22205 )
...
* Turns compute_units_consumed of ProcessInstructionResult into a &mut parameter.
* Removes second nesting level from test_process_instruction_compute_budget().
* Makes test_process_cross_program and test_native_invoke symmetric.
* Unifies test_process_cross_program(), test_native_invoke() and test_process_instruction_compute_budget() into test_process_instruction().
2021-12-31 17:55:27 +01:00
d06e6c7425
Count compute units even when transaction errors ( #22182 )
2021-12-30 21:21:42 -05:00
edb20d6909
Splits index of InstructionAccount into index_in_transaction and index_in_caller. ( #22165 )
2021-12-30 15:46:36 +01:00
33d0b5e011
Revert "Count compute units even when transaction errors ( #22059 )" ( #22174 )
...
This reverts commit eaa8c67bde
2021-12-30 02:42:32 -05:00
b1d9a2e60e
Don't forward packets received from TPU forwards port ( #22078 )
...
* Don't forward packets received from TPU forwards port
* Add banking stage test
2021-12-29 19:34:31 +01:00
eaa8c67bde
Count compute units even when transaction errors ( #22059 )
2021-12-28 17:05:11 -05:00
422a095647
Add (preflight) simulation to BanksClient ( #22084 )
...
* Add more-legitimate conversion from legacy Transaction to SanitizedTransaction
* Add Banks method with preflight checks
* Expose BanksClient method with preflight checks
* Unwrap simulation err
* Add Bank simulation method that works on unfrozen Banks
* Add simpler api
* Better name: BanksTransactionResultWithSimulation
2021-12-28 19:25:46 +00:00
e3b20c443a
Use load_accounts_data_len() instead of Atomic .load() ( #22144 )
2021-12-28 13:38:20 +00:00
800472ddf5
Add AccountsDataMeter to InvokeContext ( #21813 )
2021-12-28 05:14:48 -06:00
a06646631c
Feature: TransactionContext, InstructionContext and BorrowedAccount ( #21706 )
...
* Adds TransactionContext, InstructionContext and BorrowedAccount.
* Redirects the usage of accounts in InvokeContext through TransactionContext.
Also use the types declared in transaction_context.rs everywhere.
* Adjusts all affected tests.
2021-12-27 18:49:32 +01:00
cc947cad03
Refactor: CPI Instruction Recording ( #22111 )
...
* Unifies all InstructionRecorders of a transaction into one.
* Stops explicitly compiling CPI instructions for recording,
uses the indices gathered from instruction_accounts instead.
2021-12-25 13:35:43 +01:00
2ab4f34c02
Refactor: Remove `Message` and `CompiledInstruction` from `InvokeContext` interfaces ( #22102 )
...
* Introduces InstructionAccount which is like AccountMeta but uses an index instead of a Pubkey
* Renames InvokeContext::create_message() to InvokeContext::prepare_instruction()
* Removes Message and CompiledInstruction from InvokeContext interfaces.
* Resolves TODOs of sol_invoke_signed() in program-test.
* Moves CompiledInstruction::visit_each_account() into invoke_context.rs
2021-12-24 16:17:55 +01:00
61cc7b10a9
AcctIdx: respect disk idx mem size param ( #22050 )
2021-12-22 09:54:05 -06:00
bdae2993e0
AcctIdx: hold ranges in memory uses multiple threads ( #22031 )
2021-12-21 17:31:48 -06:00
76098dd42a
RPC Block Subscription ( #21787 )
...
* add stuff
* compiling
* add notify block
* wip
* feat: add blockSubscribe pubsub method
* address PR comments
Co-authored-by: Lucas B <buffalu@jito.network>
Co-authored-by: Zano <segfaultdoctor@protonmail.com>
2021-12-17 16:03:09 -07:00
0f6e8d3385
Check file size of `snapshot_version` when unarchiving snapshot ( #21925 )
2021-12-17 12:27:54 -06:00
8ed7ad5fa7
AcctIdx: hold range recognizes already held ranges ( #21937 )
2021-12-17 10:04:41 -06:00
729698e815
AcctIdx: items() uses held ranges ( #21954 )
2021-12-17 09:59:29 -06:00
af53d2f692
simplify api on reconstruct_single_storage ( #21970 )
2021-12-17 09:06:23 -06:00
66fa8f9667
Refactor: Removes `Rc` from `Refcell<AccountSharedData>` in the program-runtime ( #21927 )
...
* Removes Rc from Rc<RefCell<AccountSharedData>> in the program-runtime.
* Adjusts tests in bpf_loader, system_instruction_processor, config_processor, vote_instruction and stake_instruction
2021-12-17 14:01:12 +01:00
c4389a6675
AcctIdx: held ranges search in lifo order ( #21964 )
2021-12-16 23:25:22 -06:00
5d40da5688
log "next_id" to track append vec ids ( #21971 )
2021-12-16 22:41:34 -06:00
6374995522
AcctIdx: share bucket map size for perf ( #21935 )
2021-12-16 21:25:54 -06:00
ba777f4f56
AcctIdx: remove Option from held ranges ( #21958 )
2021-12-16 21:22:04 -06:00
e11a1911ad
load_accounts_index_for_shrink ignores cached entries ( #21951 )
2021-12-16 16:37:08 -06:00
6ff0be6a82
Clean up demote program write lock feature ( #21949 )
...
* Clean up demote program write lock feature
* fix test
2021-12-16 17:27:22 -05:00
347323cbb2
use bg thread pool for shrink ( #21950 )
2021-12-16 15:54:38 -06:00
e97da0ea15
AcctIdx: define type for serialized AppendVecId ( #21938 )
2021-12-16 08:41:01 -06:00
18417e410e
AcctIdx: remove troublesome assert ( #21947 )
2021-12-16 08:37:05 -06:00
49cb161203
Fixes the calculation of the "compute_meter_consumption" across process_instruction() and process_message(). ( #21944 )
2021-12-16 15:15:58 +01:00
82672b40fd
AcctIdx: streamline metric update ( #21936 )
2021-12-15 19:52:23 -06:00
1e0d3f13e6
AcctIdx: fix metrics bug ( #21934 )
2021-12-15 17:05:38 -06:00
635337d2ff
Bank gets accounts data len delta from MessageProcessor::process_message()
2021-12-15 16:41:38 -06:00
46e5350d8c
AcctInfo: store offset in AccountInfo as u32 ( #21895 )
2021-12-15 15:41:11 -06:00
e5be96d8bf
AcctIdx: consolidate next_id calls ( #21929 )
2021-12-15 15:39:54 -06:00
41dd31e5f4
AcctIdx: move cached store id to bit ( #21892 )
...
* AcctIdx: move cached store id to bit
* add comments/rename
2021-12-15 11:49:24 -06:00
Jeff Washington (jwash)
Jon Cinque
Michael Vines
Brooks Prumo
Justin Starry
anatoly yakovenko
Alexander Meißner
Tao Zhu
Tao Zhu
Tyera Eulberg
behzad nouri
Jeff Biseda
Trent Nelson
Jack May
Carl Lin
segfaultdoctor
mooori