16219e300e
generating index sets uncleaned_roots correctly ( #26431 )
...
* generating index sets uncleaned_roots correctly
* fix test failures
* rename
* update comments
2022-07-06 16:12:47 -05:00
d7201a8d1a
names fields in RentResullt::CollectRent enum variant ( #26449 )
...
Avoiding ambiguous raw tuple:
CollectRent((Epoch, u64))
Using named fields instead:
CollectRent {
new_rent_epoch: Epoch,
rent_due: u64,
},
2022-07-06 20:01:16 +00:00
f4718be22f
Clean up `leave_nonce_on_success` feature ( #26447 )
...
Clean up leave_nonce_on_success feature
2022-07-06 17:59:34 +00:00
ff1e6fcbed
Clean up `nonce_must_be_advanceable` feature ( #26446 )
...
Clean up nonce_must_be_advanceable feature
2022-07-06 17:36:33 +00:00
06ebfa1eb2
Replicates `AccountsDataMeter` in `TransactionContext` ( #26438 )
...
Replicates AccountsDataMeter in TransactionContext.
2022-07-06 19:27:42 +02:00
611ac33718
Clean up `nonce_must_be_authorized` feature ( #26445 )
...
Clean up nonce_must_be_authorized feature
2022-07-06 17:17:31 +00:00
44f499cff3
Refactor account index scan function parameters ( #26428 )
...
* Refactor account index scan function parameters
F: FnMut(bool, &SlotList<T>, &'a Pubkey, RefCount) -> AccountsIndexScanResult,
Refactor to take (&'a Pubkey, Option<(&SlotList<T>, RefCount))
* Update comments based on review feedback
* cargo fmt --all fixes
2022-07-06 09:49:11 -07:00
17a99d98dd
Revert "avoid adding to 'uncleaned_roots' when generating index and c… ( #26441 )
...
Revert "avoid adding to 'uncleaned_roots' when generating index and caller passes accounts-db-skip-shrink (#25936 )"
This reverts commit e24cc537a4
2022-07-06 11:32:45 -05:00
ab164fc975
simplify code ( #26443 )
2022-07-06 11:22:26 -05:00
f8dccd4602
Clean up `max_tx_account_locks` feature ( #26440 )
...
Clean up max_tx_account_locks feature
2022-07-06 15:06:03 +00:00
5afe4d938d
combine lookup in calc_delete_dependencies ( #26429 )
2022-07-06 08:50:14 -05:00
71c7b4f9cb
use append vec iter in construct_candidate_clean_keys ( #26426 )
2022-07-06 08:49:35 -05:00
6f5857a5db
removes feature gate code separating durable nonce from blockhash domain ( #26055 )
2022-07-06 12:03:13 +00:00
37f4621c06
chore: bump serde from 1.0.137 to 1.0.138 ( #26421 )
...
* chore: bump serde from 1.0.137 to 1.0.138
Bumps [serde](https://github.com/serde-rs/serde ) from 1.0.137 to 1.0.138.
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.137...v1.0.138 )
---
updated-dependencies:
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* [auto-commit] Update all Cargo lock files
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
2022-07-05 23:18:08 -06:00
c1d89ad749
forward packets by prioritization in desc order ( #25406 )
...
- Forward packets by prioritization in desc order
- Add support of cost-tracking by transaction requested compute units
- Hook up account buckets to forwarder
- Add metrics for forwardable batches count
- Remove redundant invalid packets filtering at end of slot since forwarder will do the same when batch forwardable packets
- Add bench test for forwarding
2022-07-05 23:24:58 -05:00
38216aa781
update comment for the next weary traveller ( #26413 )
2022-07-05 23:12:35 -05:00
75149fd624
move mark_old_slots_as_dirty to be called from ahv ( #26411 )
2022-07-05 23:11:32 -05:00
2aafef38f9
is_shrinking_productive calls avoid arc clone ( #26422 )
2022-07-05 17:53:29 -05:00
b7e34aea15
refactor calculate_rent_result ( #26416 )
...
reactor calculate_rent_result
2022-07-05 16:45:59 -05:00
53b9420562
Remove `INTO!` macros in serde_snapshot ( #26409 )
2022-07-05 16:37:20 -05:00
ce39c14025
Add end-to-end replay slot metrics ( #25752 )
2022-07-05 13:58:51 -05:00
0ab521d5f1
inc counter when append vec drop fails ( #26396 )
2022-07-05 11:27:01 -05:00
5f3b7bdd16
prevent ledger tool from calculating hash on non-rooted slots ( #26355 )
2022-07-02 11:50:01 -05:00
88b5b7e30a
improve log ( #26360 )
2022-07-01 13:12:52 -05:00
728986ddf4
Spell correction and add remove slot in AccountDB purge assert message ( #26358 )
...
nit spell. add remove slots in accoutdb purge assert message
2022-07-01 17:39:35 +00:00
fdb186ba3b
pacify nightly clippy
2022-06-30 21:31:49 -07:00
72a968fbe8
Fix/system instruction processor tests ( #26338 )
...
* Make mock_process_instruction() stricter by invoking the verify() method.
* Fixes broken test cases.
2022-07-01 00:06:24 +02:00
4563bf40f6
cleanup feature: tx-wide-compute-cap ( #26326 )
2022-06-29 23:54:45 -07:00
36d13af015
Add stats for Accounts Background Service ( #26298 )
...
* Add stats for Accounts Background Service
* pr
2022-06-30 02:21:30 +00:00
d053ce79d4
removes RwLock+Once in favor of OnceCell in caching staked-nodes ( #26313 )
...
VoteAccounts uses std::sync::{RwLock, Once} to lazily compute and cache
staked_nodes:
https://github.com/solana-labs/solana/blob/032bee13a/runtime/src/vote_account.rs#L89-L104
This commit instead switches to using once_cell::sync::OnceCell which
provides this exact intended functionality by design.
2022-06-29 22:22:22 +00:00
557bf6e656
allow initial hash calc to occur in bg ( #26271 )
...
* allow initial hash calc to occur in bg
* validator_initialized -> startup_verification_complete
* add infos for leader and vote
* rework snapshot for startup verification
* change to assert
2022-06-29 16:48:33 -05:00
608191352f
track # roots added/removed since last clean ( #26319 )
2022-06-29 16:47:57 -05:00
2deb396490
remove noisy and useless 'error!' and add test ( #26138 )
2022-06-29 16:26:23 -05:00
c01a8f271e
Prepare built-in program tests to deal with stricter account modification checks ( #26314 )
...
* Fixes test_vote_state_withdraw().
* Set is_writable to true where needed.
2022-06-29 19:29:12 +02:00
e241906db2
remove outdated, confusing comment ( #26315 )
2022-06-29 10:42:34 -05:00
ca83f143aa
load_accounts_index_for_shrink uses scan ( #26260 )
2022-06-29 09:02:27 -05:00
af7f08eba4
uses OnceCell instead of RwLock+Once to cache vote-state in vote-account ( #26257 )
...
RwLock seems excessive since only the very 1st call to VoteAccount::vote_state
will write-lock the inner field. Future calls would also incur overhead of an
RwLockReadGuard.
once_cell::sync::OnceCell provides a matching api to the desired functionality.
2022-06-29 11:45:53 +00:00
50631e274d
Ensure that staked nodes is populated before returning length ( #26293 )
2022-06-28 19:15:42 +00:00
89e5640c63
AccountsIndex::Scan takes iter ( #26268 )
2022-06-28 12:47:17 -05:00
d07b079850
make test_age_time less intermittent ( #26280 )
2022-06-28 09:13:01 -05:00
bfc390f9ed
refactor acct idx scan func for reuse ( #26252 )
2022-06-28 09:01:04 -05:00
4b591d7b59
AccountsDb::load_accounts_index_for_shrink takes slice ( #26267 )
2022-06-28 08:59:57 -05:00
e8fed88669
Both kinds of LamportsError are turned into InstructionError::ArithmeticOverflow anyway. ( #26273 )
2022-06-28 10:04:54 +02:00
e164879f20
load_accounts_index_for_shrink uses &item instead of (&item.0, &item.1) ( #26266 )
2022-06-27 22:40:45 -05:00
d6a28cb7a8
load_accounts_index_for_shrink unrefed_pubkeys is optional ( #26265 )
2022-06-27 17:23:46 -05:00
50eb9965ab
fix test_new_from_file_crafted_executable for m1 ( #26009 )
...
* fix test_new_from_file_crafted_executable for m1
* re-add old assert/comment, but disable for aarch64
2022-06-27 12:03:52 -05:00
d8516b5c88
comment and expand on test ( #26231 )
2022-06-27 11:35:46 -05:00
662818ef0d
Use `VoteAccount::node_pubkey()` ( #26207 )
2022-06-27 09:09:06 -05:00
cbefc581c0
test_rent_collect_rent_from_accounts ( #26204 )
2022-06-25 19:04:28 -05:00
0ca963a869
Refactor: Add separate methods for retrieving stake info from VoteAccounts ( #26224 )
2022-06-25 20:03:15 +00:00
7cd7173b71
Refactor: Add get_delegated_stake method to VoteAccounts ( #26221 )
2022-06-25 16:41:35 +00:00
44d1e62007
Refactor: No need to return stake in Bank::get_vote_account ( #26220 )
2022-06-25 16:27:43 +00:00
2efdb965dd
encapsulates AuthorizeNonceAccount implementation in the nonce module ( #26202 )
...
Follow up commit removes feature gate code separating durable nonce from
blockhash domain. This commit allows to encapsulate any logic
distinguishing legacy vs current nonce versions in the nonce module
after removing the feature gate.
2022-06-25 12:17:39 +00:00
a3395a786a
vote_account uses AccountSharedData to avoid copies ( #23687 )
...
* vote_account uses AccountSharedData to avoid copies
* simpler deserialize
2022-06-24 15:08:01 -05:00
2b21c1da29
Sort Cargo.toml files
2022-06-24 12:41:38 -07:00
18397527ad
retain prior metric behavior for invalid_cached_stake_accounts ( #26181 )
2022-06-24 14:12:16 -05:00
054b25729d
eliminate vec creation in stake rewards ( #26191 )
2022-06-24 13:40:53 -05:00
fbcb4d8216
extract get_stake_reward fn from StakeReward ( #26183 )
2022-06-24 08:44:48 -05:00
877fedadac
Remove StatusCacheRc type and use StatusCache directly ( #26184 )
2022-06-24 08:38:56 -05:00
4a729effff
Bugfix/test get rent collection accounts remove random account ( #26178 )
...
* Use default GenisisConfig so we don't have a random account
* Formatting
2022-06-24 09:22:50 -04:00
a36abfda28
don't skip rewrite when account was written IN the current slot already ( #26197 )
2022-06-24 07:28:37 -05:00
5b842669e7
Remove InMemAccountsIndex::map() and use map_internal directly ( #26189 )
2022-06-23 15:55:35 -05:00
23c50a2389
Add StatusCache::root_slot_deltas() and use it ( #26170 )
2022-06-23 15:19:06 -05:00
7efd05f7b3
Change get_pubkeys to match the new enum ( #26177 )
2022-06-23 11:56:09 -05:00
355e09e1fb
runtime: fix possible deadlock in in_mem_accounts_index ( #26046 )
2022-06-23 11:35:47 -05:00
102fb98070
impl StorableAccounts for [StakeReward] ( #26165 )
2022-06-23 08:34:28 -05:00
19b79aa764
add metrics for invalid_cached_stake_accounts_rent_epoch ( #26143 )
2022-06-23 08:33:24 -05:00
9db44ce352
cleanup some AccountSharedData::from(Account ( #26120 )
2022-06-23 08:32:48 -05:00
7d29c26315
Remove auto traits from ICE work-around ( #26098 )
2022-06-23 07:22:30 -05:00
a5cf72e446
StatusCache::roots() returns `Slot`s not `u64`s ( #26164 )
2022-06-23 07:03:09 +00:00
5c2f819f99
Bump Version to 1.11.2 ( #26159 )
2022-06-22 21:16:18 -05:00
aea75e82e3
Bank::store_accounts takes StorableAccounts ( #26113 )
2022-06-22 21:11:01 -05:00
a32523c43b
cleanup some tests ( #26139 )
2022-06-22 21:10:46 -05:00
c4efb9f19e
Stake cache size ( #26071 )
...
* reduce threadpool for stake processing
* wip
* Revert "reduce threadpool for stake processing"
This reverts commit 004a4f872ea7a3ef53e38d145b6350c3f57c680c.
* batch update stake_cache
* fix deadlock
* add test
* code review feedbacks
* more review feedbacks
* fix conflicts
* report stake account len and vote account len at epoch boundary
* report num_staked_nodes
* remove batch store, no atomic for redeem timing
2022-06-22 16:22:22 -05:00
c5c2b44ecc
adjust cached stake account compare for rent_epoch ( #26135 )
2022-06-22 15:11:25 -05:00
1ea6a2cb91
Extended interface for AccountOverrides ( #25964 )
...
* Extended interface for AccountOverrides
* fix checker issue
* make accounts private
Co-authored-by: Ivan Loboda <lobodatell@yandex.ru>
2022-06-22 15:22:31 -04:00
f4189c0305
ledger-tool minimized snapshots ( #25334 )
...
* working on local snapshot
* Parallelization for slot storage minimization
* Additional clean-up and fixes
* make --minimize an option of create-snapshot
* remove now unnecessary function
* Parallelize parts of minimized account set generation
* clippy fixes
* Add rent collection accounts and voting node_pubkeys
* Simplify programdata_accounts generation
* Loop over storages to get slot set
* Parallelize minimized slot set generation
* Parallelize adding owners and programdata_accounts
* Remove some now unncessary checks on the blockstore
* Add a warning for minimized snapshots across epoch boundary
* Simplify ledger-tool minimize
* Clarify names of bank's minimization helper functions
* Remove unnecesary funciton, fix line spacing
* Use DashSets instead of HashSets for minimized account and slot sets
* Filter storages uses all threads instead of thread_pool
* Add some additional comments on functions for minimization
* Moved more into bank and parallelized
* Update programs/bpf/Cargo.lock for dashmap in ledger
* Clippy fix
* ledger-tool: convert minimize_bank_for_snapshot Measure into measure!
* bank.rs: convert minimize_bank_for_snapshot Measure into measure!
* accounts_db.rs: convert minimize_accounts_db Measure into measure!
* accounts_db.rs: add comment about use of minimize_accounts_db
* ledger-tool: CLI argument clarification
* minimization functions: make infos unique
* bank.rs: Add test_get_rent_collection_accounts_between_slots
* bank.rs: Add test_minimization_add_vote_accounts
* bank.rs: Add test_minimization_add_stake_accounts
* bank.rs: Add test_minimization_add_owner_accounts
* bank.rs: Add test_minimization_add_programdata_accounts
* accounts_db.rs: Add test_minimize_accounts_db
* bank.rs: Add negative case and comments in test_get_rent_collection_accounts_between_slots
* bank.rs: Negative test in test_minimization_add_programdata_accounts
* use new static runtime and sdk ids
* bank comments to doc comments
* Only need to insert the maximum slot a key is found in
* rename remove_pubkeys to purge_pubkeys
* add comment on builtins::get_pubkeys
* prevent excessive logging of removed dead slots
* don't need to remove slot from shrink slot candidates
* blockstore.rs: get_accounts_used_in_range shouldn't return Result
* blockstore.rs: get_accounts_used_in_range: parallelize slot loop
* report filtering progress on time instead of count
* parallelize loop over snapshot storages
* WIP: move some bank minimization functionality into a new class
* WIP: move some accounts_db minimization functionality into SnapshotMinimizer
* WIP: Use new SnapshotMinimizer
* SnapshotMinimizer: fix use statements
* remove bank and accounts_db minimization code, where possible
* measure! doesn't take a closure
* fix use statement in blockstore
* log_dead_slots does not need pub(crate)
* get_unique_accounts_from_storages does not need pub(crate)
* different way to get stake accounts/nodes
* fix tests
* move rent collection account functionality to snapshot minimizer
* move accounts_db minimize behavior to snapshot minimizer
* clean up
* Use bank reference instead of Arc. Additional comments
* Add a comment to blockstore function
* Additional clarifying comments
* Moved all non-transaction account accumulation into the SnapshotMinimizer.
* transaction_account_set does not need to be mutable now
* Add comment about load_to_collect_rent_eagerly
* Update log_dead_slots comment
* remove duplicate measure/print of get_minimized_slot_set
2022-06-22 13:17:43 -04:00
cf5ec13f59
Accounts::store_accounts_cached uses StorableAccounts ( #26112 )
2022-06-22 12:13:56 -05:00
f3639b76ce
Remove some clippy lints
2022-06-22 09:23:22 -07:00
5624ab0d4c
Optimize stake accounts store ( #26004 )
...
* reduce threadpool for stake processing
* wip
* Revert "reduce threadpool for stake processing"
This reverts commit 004a4f872ea7a3ef53e38d145b6350c3f57c680c.
* batch update stake_cache
* fix deadlock
* add test
* code review feedbacks
* more review feedbacks
* clippy
* update comments
* fix conflicts
* remove batch store, no atomic for redeem timing
* refactor stake_reward struct
2022-06-22 10:45:58 -05:00
8e2bae7bf9
batch insert updates stat count correctly ( #26107 )
2022-06-22 08:45:42 -05:00
d3829b1a76
store_cached takes StorableAccounts to eliminate collect ( #26109 )
2022-06-22 08:45:03 -05:00
8a18e02f80
Call StatusCache::append() directly ( #26125 )
2022-06-22 07:42:01 -05:00
31c9b03049
Remove unused SignatureConfirmationStatus ( #26124 )
2022-06-22 07:41:22 -05:00
97bd81a32b
Add bench for StatusCache::slot_deltas() ( #26123 )
2022-06-22 07:41:06 -05:00
d35c1a7d04
Use BankStatusCache in bank.rs ( #26114 )
2022-06-21 23:16:16 +00:00
43e0d29b18
Revert "fix double count of account index del stats ( #25797 )" ( #26103 )
...
This reverts commit 05cb25d8da
2022-06-21 14:05:26 -05:00
7a3dc3a57b
remove unused param ( #26096 )
2022-06-21 13:10:41 -05:00
51f26dc96e
Bump version to 1.11.1 ( #26104 )
2022-06-21 12:07:46 -05:00
95ea506d75
runtime: fix double-readlock in in_mem_accounts_index.rs ( #26047 )
2022-06-20 15:44:19 +01:00
752c851070
Clean up feature preventing new rent-paying accounts ( #26000 )
...
* Clean up require_rent_exempt_accounts feature
* Fix tests in bank_client, system_instruction_processor
* Fix tests in snapshot_utils
* Fix bank tests
* Ignore rent tests
* Fix stake-accounts tests
2022-06-16 15:35:25 -06:00
bf9ca9827e
Refactor: instruction account index ( #25825 )
...
* Adds methods based on instruction_account_index to InstructionContext.
Removes methods which are based on index_in_instruction.
* Adjusts program-runtime.
* Adjusts runtime.
* Adjusts bpf loader.
* Adjusts built-in programs.
* Adjusts program-test and bpf tests.
2022-06-16 18:46:17 +02:00
54675b2dd6
Add bank tests for accounts_data_size and resize transactions / rent collection ( #25884 )
2022-06-15 19:40:43 -05:00
b02c412d5b
generate_index straight to disk and batched ( #25947 )
...
* generate_index straight to disk and batched
* renames and comments
* handle in-mem case correctly
* use mutex
2022-06-15 18:14:39 -05:00
631ea93259
parallel rent collection avoids overlapping ranges ( #25991 )
2022-06-15 16:04:38 -05:00
99cf1e280e
Clean up warp-timestamp features ( #25994 )
2022-06-15 14:11:41 -06:00
80f90d6e96
disable logging per thread on rent collection load ( #25982 )
2022-06-15 13:16:00 -05:00
e1efc5bebb
append_vec.rs: remove new_empty_map (unused) ( #25885 )
2022-06-15 08:59:46 -05:00
ae37359b6b
AcctIdx: only advance age on thread 0 ( #25943 )
2022-06-14 21:43:42 -05:00
4652377e5b
Removes the feature gate of reject_empty_instruction_without_program. ( #25870 )
2022-06-14 18:00:12 +02:00
Jeff Washington (jwash)
behzad nouri
Justin Starry
Alexander Meißner
Xiang Zhu
dependabot[bot]
Tao Zhu
Brooks Prumo
carllin
HaoranYi
Michael Vines
Jack May
apfitzge
Nicholas Rempel
Boqin Qin(秦 伯钦)
github-actions[bot]
ivandzen
Will Hickey
Tyera Eulberg