certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
cosmos-sdk/.golangci.yml

75 lines
1.5 KiB
YAML
Raw Normal View History

golangci-lint: exclude _test.go files from analysis (#6090)
2020-04-28 06:50:14 -07:00
run:
tests: false
style: fix lint errors and update lint timeout (#9464) * fix: misc fixes for make to work off freshly cloned repo * gocritic appendAssign fix * markdown trailing space and blank line fixes * change golangci-lint timeout to 5min * update changelog * Update .golangci.yml Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-06-08 09:27:39 -07:00
# timeout for analysis, e.g. 30s, 5m, default is 1m
timeout: 5m
Merge PR #4881: Linting Galore
2019-08-19 09:06:27 -07:00
gometalinter -> golangci-lint migration (#3933) {,scripts/}Makefile: - Remove gometalinter, install golangci-lint. - Remove distinction between tools and devtools. Just tools is enough. - test_lint -> lint Migrating away from underscore separated names. - Remove unnecessary targets. - Drop tendermint/lint. Incompatbile with golangci-lint and no longer necessary anyway. - Fix misleading message in go-mod-cache. - New ci-target to avoid download tools twice. - Run tests with -mod=readonly. Port tools/gometalinter.json to .golangci.yml Update CircleCI config accordingly. Closes: #3896
2019-03-19 09:52:43 -07:00
linters:
linter fixes (#5733) * make .golangcy.yml work with Goland's Golint plugin Explicitly disable all linters. Whitelist of enabled plugins is already provided. This would enable Goland users to user Golint plugin. * fix deadcode warnings * fix gocritic error unslice: could simplify pkBytes[:] to pkBytes
2020-03-01 07:38:57 -08:00
disable-all: true
Merge PR #5192: golangcI-lint updates & set static version to 1.19
2019-10-14 08:43:19 -07:00
enable:
- bodyclose
- deadcode
- depguard
- dogsled
lint: various linting fixs (#5825) * lint: various linting fixs Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * more linting * more linting fixes * more errchecking * comment out errcheck for now * undo error check * address some comments * remore require error * change delete to batch delete Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-03-20 12:24:18 -07:00
# - errcheck
chore: bump TM to v0.35.0 release candidate (#10210) Integrate Tendermint v0.35.0, including changes to build and test plumbing necessary to make everything build. This change does not update any SDK APIs to make use of new features. Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: tycho garen <garen@tychoish.com> Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com>
2021-11-16 11:24:38 -08:00
- exportloopref
Merge PR #5192: golangcI-lint updates & set static version to 1.19
2019-10-14 08:43:19 -07:00
- goconst
- gocritic
- gofmt
- goimports
- gosec
- gosimple
- govet
- ineffassign
- misspell
- nakedret
chore: bump TM to v0.35.0 release candidate (#10210) Integrate Tendermint v0.35.0, including changes to build and test plumbing necessary to make everything build. This change does not update any SDK APIs to make use of new features. Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: tycho garen <garen@tychoish.com> Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com>
2021-11-16 11:24:38 -08:00
- nolintlint
Merge PR #5192: golangcI-lint updates & set static version to 1.19
2019-10-14 08:43:19 -07:00
- prealloc
fix(CI): add golangci-lint to dependencies (#10112) * fix(CI): add golangci-lint to dependencies * update github workflow * tidy go.mod * add missing entries to go.mod * update deps * add missing run command * remove golint and use revive instead * fix workflow setup * lint only changed files * gofmt go tags * update comments * make lint-go Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
2021-09-14 02:05:30 -07:00
- revive
Merge PR #5192: golangcI-lint updates & set static version to 1.19
2019-10-14 08:43:19 -07:00
- staticcheck
- structcheck
Merge PR #5203: Add more linters
2019-10-17 06:47:35 -07:00
- stylecheck
Merge PR #5192: golangcI-lint updates & set static version to 1.19
2019-10-14 08:43:19 -07:00
- typecheck
- unconvert
various linter fixes (#6106) x/staking: Fix all linter warnings. Fixed warnings across base packages. New linters: - unparam - nolintlint Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-05-02 12:26:59 -07:00
- unparam
chore: bump TM to v0.35.0 release candidate (#10210) Integrate Tendermint v0.35.0, including changes to build and test plumbing necessary to make everything build. This change does not update any SDK APIs to make use of new features. Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: tycho garen <garen@tychoish.com> Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com>
2021-11-16 11:24:38 -08:00
- unused
lint: official action (#6156) * switch from review dog to official golangci action * fix release * disable nolintlint and wsl * fix linting issues * have name adhere to required * add timeout Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-05-07 02:40:49 -07:00
# - wsl
Merge PR #5055: Added Prealloc, Gosec, Golint linters
2019-09-17 09:13:26 -07:00
issues:
exclude-rules:
- text: "Use of weak random number generator"
linters:
- gosec
- text: "comment on exported var"
linters:
- golint
- text: "don't use an underscore in package name"
linters:
- golint
Merge PR #5111: Add linters from new golangci version
2019-09-30 16:06:07 -07:00
- text: "ST1003:"
linters:
- stylecheck
Merge PR #5600: Migrate x/staking to Protobuf
2020-02-06 11:21:02 -08:00
# FIXME: Disabled until golangci-lint updates stylecheck with this fix:
Merge PR #5613: update to golangci-lint v1.23.3 Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
2020-02-05 11:32:45 -08:00
# https://github.com/dominikh/go-tools/issues/389
- text: "ST1016:"
linters:
- stylecheck
refactor: Rename x/{mod}/legacy to x/{mod}/migrations (#9628) <!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: #8700 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
2021-07-05 07:55:51 -07:00
- path: "migrations"
Remove bech32 PubKey support (#7477) * Move PubKey bech32 to legacy package and migrate the usage where possible * update /server * wip * move proto json encoding helper functions to internal * update internal/marshal * wip * update sections which needs legacybech32 * update validators output * fix conflicts * slashing update * add more tests and helper function for ANY JSON serialization * update slashing * Update function documentation * Rename code any-marshal helper functions * Update pubkey unpacking test * Update test comments * solve TestDecodeStore * solve legacytx issues * all code compiles * keyring tests * keyring cleanup * remove AssertMsg * fix some tests * fix add_ledger_test.go * update cli tests * debug cli test * rename clashed bech32 names * linter fixes * update tmservice tests * linter: update legacy deprecated checks * fix names * linting * legacybech32 pubkey type rename * fix staking client * fix test compilation * fix TestGetCmdQuerySigningInfo * rename NewIfcJSONAnyMarshaler * keyring: remove duplicated information from multinfo structure * todo cleanups * Update Changelog * remove some legacybech32 from tests * remove todos * remove printlnJSON from /server CLI and amino encoding * remove protocdc.MarshalJSON * client/show remove duplicated function * remove protocdc package * comment update * remove legacybech32.MustMarshalPubKey from a test * add todo * fix TestPublicKeyUnsafe test * review update * fix bech32 UnmarshalPubKey * Use codec.MarshalIfcJSON * fix linter issues * merging conflict: fix codec.Unmarshal calls * cleanups * Update CHANGELOG.md Co-authored-by: Aaron Craelius <aaron@regen.network> * Reword changelog updates * use pubkey.String for comparison in Test_runAddCmdLedgerWithCustomCoinType * Update GetCmdQuerySigningInfo example * cli: update keys add docs * Add errors AsOf and errors.ErrIO type * restore multisigPubKeyInfo structure bring it back to multiInfo struct * Update codec/proto_codec.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Update crypto/keys/ed25519/ed25519_test.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Update codec/proto_codec.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * move pubkey any marshaling tests * Apply suggestions from code review Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * review updates * adding missing return * errors: use IsOf instead of AsOf * keyring: add a correct check for key not found in keyring.Get * add checkKeyNotFound * fix linter issues * fix: keyring key not found check * fix keyring tests * fix linting issues * cli tests * fix: 'simd keys show <key> -p' * fix: TestVerifyMultisignature * rename keyring Bech32... functions to Mk... * fix RunAddCmd * Update pubkey display * wip * add more tests * udate keyring output tests * remove todo from ledger tests * rename MkKeyOutput * Changelog update * solve liner issues * add link to github issue Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2021-03-25 07:53:22 -07:00
text: "SA1019:"
linters:
- staticcheck
various linter fixes (#6106) x/staking: Fix all linter warnings. Fixed warnings across base packages. New linters: - unparam - nolintlint Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-05-02 12:26:59 -07:00
max-issues-per-linter: 10000
max-same-issues: 10000
Merge PR #5111: Add linters from new golangci version
2019-09-30 16:06:07 -07:00
linters-settings:
dogsled:
max-blank-identifiers: 3
Merge PR #5192: golangcI-lint updates & set static version to 1.19
2019-10-14 08:43:19 -07:00
maligned:
# print struct with more effective memory layout or not, false by default
suggest-new: true
various linter fixes (#6106) x/staking: Fix all linter warnings. Fixed warnings across base packages. New linters: - unparam - nolintlint Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-05-02 12:26:59 -07:00
nolintlint:
allow-unused: false
allow-leading-space: true
require-explanation: false
require-specific: false