From 12ff486a5730a41fa2ab8a1d9543766e22561a29 Mon Sep 17 00:00:00 2001
From: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Date: Wed, 4 Dec 2019 18:11:37 +0100
Subject: [PATCH] Updated PR template, stale and codecov settings (#5362)

* updated PR template, stale and codecov settings

* remove extra line

* address @alexanderbez comments

* Update .codecov.yml
---
 .codecov.yml                     | 34 +++++++++++++++++++++++++++-----
 .github/PULL_REQUEST_TEMPLATE.md | 34 ++++++++++++++++++++++----------
 .github/stale.yml                |  4 ++--
 3 files changed, 55 insertions(+), 17 deletions(-)

diff --git a/.codecov.yml b/.codecov.yml
index a751662cd..80b53809f 100644
--- a/.codecov.yml
+++ b/.codecov.yml
@@ -1,4 +1,3 @@
-
 #
 # This codecov.yml is the default configuration for
 # all repositories on Codecov. You may adjust the settings
@@ -10,18 +9,43 @@ coverage:
   range: 70...100
 
   status:
-    # Learn more at https://codecov.io/docs#yaml_default_commit_status
-    project: 
+    # Learn more at https://docs.codecov.io/docs/commit-status
+    project:
       default:
         threshold: 1% # allow this much decrease on project
+      app:
+        target: 70%
+        flags: app
+      modules:
+        target: 70%
+        flags: modules
+      client:
+        flags: client
     changes: false
 
 comment:
-  layout: "header, diff"
-  behavior: default  # update if exists else create new
+  layout: "reach, diff, files"
+  behavior: default # update if exists else create new
+  require_changes: true
+
+flags:
+  app:
+    paths:
+      - "app/"
+      - "baseapp/"
+  modules:
+    paths:
+      - "x/"
+      - "!x/**/client/" # ignore client package
+  client:
+    paths:
+      - "client/"
+      - "x/**/client/"
 
 ignore:
   - "docs"
   - "*.md"
   - "*.rst"
   - "x/**/test_common.go"
+  - "scripts/"
+  - "contrib"
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index b7ffdc2b3..6dd37f7f2 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -4,17 +4,31 @@ v    Before smashing the submit button please review the checkboxes.
 v    If a checkbox is n/a - please still include it but + a little note why
 ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >  -->
 
-- Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/develop/CONTRIBUTING.md#pr-targeting))
+Closes: #XXX
 
-- [ ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
-- [ ] Wrote tests
-- [ ] Updated relevant documentation (`docs/`)
-- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
-- [ ] Re-reviewed `Files changed` in the github PR explorer
+## Description
+
+<!-- Add a description of the changes that this PR introduces and the files that
+are the most critical to review.
+-->
 
 ______
 
-For Admin Use:
-- Added appropriate labels to PR (ex. wip, ready-for-review, docs)
-- Reviewers Assigned
-- Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
+For contributor use:
+
+- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
+- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
+- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
+- [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
+- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
+- [ ] Added  relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
+- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
+- [ ] Re-reviewed `Files changed` in the Github PR explorer
+
+______
+
+For admin use:
+
+- [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc)
+- [ ] Reviewers assigned
+- [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
diff --git a/.github/stale.yml b/.github/stale.yml
index 6b9680042..044feb384 100644
--- a/.github/stale.yml
+++ b/.github/stale.yml
@@ -1,11 +1,11 @@
 # Configuration for probot-stale - https://github.com/probot/stale
 
 # Number of days of inactivity before an Issue or Pull Request becomes stale
-daysUntilStale: 60
+daysUntilStale: 10
 
 # Number of days of inactivity before an Issue or Pull Request with the stale label is closed.
 # Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.
-daysUntilClose: 9
+daysUntilClose: 4
 
 # Only issues or pull requests with all of these labels are check if stale. Defaults to `[]` (disabled)
 onlyLabels: []