From 151c6e85e6e323e54519135a94ca6ab2abce0fa4 Mon Sep 17 00:00:00 2001 From: Devashish Dixit Date: Wed, 9 Feb 2022 15:47:13 +0530 Subject: [PATCH] chore: fix warnings in comments/documentation of nft module (#11150) ## Description Fix warnings in comments/documentation of nft module --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --- x/nft/keys.go | 2 +- x/nft/msgs.go | 2 +- x/nft/simulation/operations.go | 4 ++-- x/nft/validation.go | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/x/nft/keys.go b/x/nft/keys.go index da03362d7..b3c11046e 100644 --- a/x/nft/keys.go +++ b/x/nft/keys.go @@ -1,7 +1,7 @@ package nft const ( - // module name + // ModuleName module name ModuleName = "nft" // StoreKey is the default store key for nft diff --git a/x/nft/msgs.go b/x/nft/msgs.go index 85fbc1ba4..4b85199cd 100644 --- a/x/nft/msgs.go +++ b/x/nft/msgs.go @@ -14,7 +14,7 @@ var ( _ sdk.Msg = &MsgSend{} ) -// GetSigners implements the Msg.ValidateBasic method. +// ValidateBasic implements the Msg.ValidateBasic method. func (m MsgSend) ValidateBasic() error { if err := ValidateClassID(m.ClassId); err != nil { return sdkerrors.Wrapf(ErrInvalidID, "Invalid class id (%s)", m.ClassId) diff --git a/x/nft/simulation/operations.go b/x/nft/simulation/operations.go index e793e86dc..d430c3c12 100644 --- a/x/nft/simulation/operations.go +++ b/x/nft/simulation/operations.go @@ -18,12 +18,12 @@ import ( ) const ( - // Simulation operation weights constants + // OpWeightMsgSend Simulation operation weights constants OpWeightMsgSend = "op_weight_msg_send" ) const ( - // nft operations weights + // WeightSend nft operations weights WeightSend = 100 ) diff --git a/x/nft/validation.go b/x/nft/validation.go index 189b6621e..65d684716 100644 --- a/x/nft/validation.go +++ b/x/nft/validation.go @@ -1,7 +1,7 @@ package nft import ( - fmt "fmt" + "fmt" "regexp" sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"