certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove --select in block command (#2060) 

Closes #1968.
This commit is contained in:
Matthew Slipper 2018-08-21 17:53:16 -07:00 committed by Rigel
parent 204762b2a1
commit 3413a2bff1
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
PENDING.md
View File

@ -41,6 +41,7 @@ IMPROVEMENTS
* [x/stake] \#2000 Added tests for new staking endpoints * [x/stake] \#2000 Added tests for new staking endpoints
* Gaia CLI (`gaiacli`) * Gaia CLI (`gaiacli`)
* [cli] #2060 removed `--select` from `block` command
* Gaia * Gaia
* [x/stake] [#2023](https://github.com/cosmos/cosmos-sdk/pull/2023) Terminate iteration loop in `UpdateBondedValidators` and `UpdateBondedValidatorsFull` when the first revoked validator is encountered and perform a sanity check. * [x/stake] [#2023](https://github.com/cosmos/cosmos-sdk/pull/2023) Terminate iteration loop in `UpdateBondedValidators` and `UpdateBondedValidatorsFull` when the first revoked validator is encountered and perform a sanity check.

6
client/rpc/block.go
View File

@ -12,10 +12,6 @@ import (
"github.com/spf13/cobra" "github.com/spf13/cobra"
) )
const (
flagSelect = "select"
)
//BlockCommand returns the verified block data for a given heights //BlockCommand returns the verified block data for a given heights
func BlockCommand() *cobra.Command { func BlockCommand() *cobra.Command {
cmd := &cobra.Command{ cmd := &cobra.Command{
@ -27,7 +23,6 @@ func BlockCommand() *cobra.Command {
cmd.Flags().StringP(client.FlagNode, "n", "tcp://localhost:26657", "Node to connect to") cmd.Flags().StringP(client.FlagNode, "n", "tcp://localhost:26657", "Node to connect to")
// TODO: change this to false when we can // TODO: change this to false when we can
cmd.Flags().Bool(client.FlagTrustNode, true, "Don't verify proofs for responses") cmd.Flags().Bool(client.FlagTrustNode, true, "Don't verify proofs for responses")
cmd.Flags().StringSlice(flagSelect, []string{"header", "tx"}, "Fields to return (header|txs|results)")
return cmd return cmd
} }
@ -38,7 +33,6 @@ func getBlock(cliCtx context.CLIContext, height *int64) ([]byte, error) {
return nil, err return nil, err
} }
// TODO: actually honor the --select flag!
// header -> BlockchainInfo // header -> BlockchainInfo
// header, tx -> Block // header, tx -> Block
// results -> BlockResults // results -> BlockResults