From 40d22c7ab3a385bde480ce0b10d9920d8646d67e Mon Sep 17 00:00:00 2001
From: Spoorthi <9302666+spoo-bar@users.noreply.github.com>
Date: Tue, 3 Aug 2021 19:43:38 +0200
Subject: [PATCH] refactoring balance.coin validation

---
 x/bank/types/balance.go | 32 +++-----------------------------
 1 file changed, 3 insertions(+), 29 deletions(-)

diff --git a/x/bank/types/balance.go b/x/bank/types/balance.go
index 2aa7967d5..78539ace6 100644
--- a/x/bank/types/balance.go
+++ b/x/bank/types/balance.go
@@ -30,38 +30,12 @@ func (b Balance) GetCoins() sdk.Coins {
 
 // Validate checks for address and coins correctness.
 func (b Balance) Validate() error {
-	_, err := sdk.AccAddressFromBech32(b.Address)
-	if err != nil {
+	if _, err := sdk.AccAddressFromBech32(b.Address); err != nil {
 		return err
 	}
 
-	var prevDenom string
-	if !b.Coins.Empty() {
-		prevDenom = b.Coins[0].Denom
-	}
-	seenDenoms := make(map[string]bool)
-
-	// NOTE: we perform a custom validation since the coins.Validate function
-	// errors on zero balance coins
-	for _, coin := range b.Coins {
-		if seenDenoms[coin.Denom] {
-			return fmt.Errorf("duplicate denomination %s", coin.Denom)
-		}
-
-		if err := sdk.ValidateDenom(coin.Denom); err != nil {
-			return err
-		}
-
-		if coin.Denom < prevDenom {
-			return fmt.Errorf("denomination %s is not sorted", coin.Denom)
-		}
-
-		if coin.IsNegative() {
-			return fmt.Errorf("coin %s amount is cannot be negative", coin.Denom)
-		}
-
-		seenDenoms[coin.Denom] = true
-		prevDenom = coin.Denom
+	if err := b.Coins.Validate(); err != nil {
+		return err
 	}
 
 	return nil