certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

types: fix invalid int->string conversion in benchmarks (#6678) 

Fixes an invalid int->string conversion that will become
a vet error for Go1.15. The correct conversion was to use

    fmt.Sprintf("COINZ_%d", i)

instead of

    "COINZ_" + string(i)

Noticed during a coverage audit.
This commit is contained in:
Emmanuel T Odeke 2020-07-10 03:34:43 -07:00 committed by GitHub
parent d23c779b87
commit 7f69b088d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
types/coin_benchmark_test.go
View File

@ -5,6 +5,10 @@ import (
"testing"
)
func coinName(suffix int) string {
return fmt.Sprintf("COINZ_%d", suffix)
}
func BenchmarkCoinsAdditionIntersect(b *testing.B) {
benchmarkingFunc := func(numCoinsA int, numCoinsB int) func(b *testing.B) {
return func(b *testing.B) {
@ -12,10 +16,10 @@ func BenchmarkCoinsAdditionIntersect(b *testing.B) {
coinsB := Coins(make([]Coin, numCoinsB))
for i := 0; i < numCoinsA; i++ {
coinsA[i] = NewCoin("COINZ_"+string(i), NewInt(int64(i)))
coinsA[i] = NewCoin(coinName(i), NewInt(int64(i)))
}
for i := 0; i < numCoinsB; i++ {
coinsB[i] = NewCoin("COINZ_"+string(i), NewInt(int64(i)))
coinsB[i] = NewCoin(coinName(i), NewInt(int64(i)))
}
b.ResetTimer()
@ -41,10 +45,10 @@ func BenchmarkCoinsAdditionNoIntersect(b *testing.B) {
coinsB := Coins(make([]Coin, numCoinsB))
for i := 0; i < numCoinsA; i++ {
coinsA[i] = NewCoin("COINZ_"+string(numCoinsB+i), NewInt(int64(i)))
coinsA[i] = NewCoin(coinName(numCoinsB+i), NewInt(int64(i)))
}
for i := 0; i < numCoinsB; i++ {
coinsB[i] = NewCoin("COINZ_"+string(i), NewInt(int64(i)))
coinsB[i] = NewCoin(coinName(i), NewInt(int64(i)))
}
b.ResetTimer()