fix: failing tests in x/group (#11184)
* fix: failing tests in `x/group` * add comments * unnecessary line of code
This commit is contained in:
parent
0d4cb92dad
commit
81e9d0bd92
|
@ -1033,6 +1033,7 @@ func (s *TestSuite) TestUpdateGroupPolicyDecisionPolicy() {
|
||||||
groupPolicyAddr, myGroupID, policy := createGroupAndGroupPolicy(admin, s)
|
groupPolicyAddr, myGroupID, policy := createGroupAndGroupPolicy(admin, s)
|
||||||
|
|
||||||
specs := map[string]struct {
|
specs := map[string]struct {
|
||||||
|
preRun func(admin sdk.AccAddress, s *TestSuite) (policyAddr string, groupId uint64, policy group.DecisionPolicy)
|
||||||
req *group.MsgUpdateGroupPolicyDecisionPolicy
|
req *group.MsgUpdateGroupPolicyDecisionPolicy
|
||||||
policy group.DecisionPolicy
|
policy group.DecisionPolicy
|
||||||
expGroupPolicy *group.GroupPolicyInfo
|
expGroupPolicy *group.GroupPolicyInfo
|
||||||
|
@ -1077,6 +1078,9 @@ func (s *TestSuite) TestUpdateGroupPolicyDecisionPolicy() {
|
||||||
expErr: false,
|
expErr: false,
|
||||||
},
|
},
|
||||||
"correct data with percentage decision policy": {
|
"correct data with percentage decision policy": {
|
||||||
|
preRun: func(admin sdk.AccAddress, s *TestSuite) (policyAddr string, groupId uint64, policy group.DecisionPolicy) {
|
||||||
|
return createGroupAndGroupPolicy(admin, s)
|
||||||
|
},
|
||||||
req: &group.MsgUpdateGroupPolicyDecisionPolicy{
|
req: &group.MsgUpdateGroupPolicyDecisionPolicy{
|
||||||
Admin: admin.String(),
|
Admin: admin.String(),
|
||||||
Address: groupPolicyAddr,
|
Address: groupPolicyAddr,
|
||||||
|
@ -1087,11 +1091,9 @@ func (s *TestSuite) TestUpdateGroupPolicyDecisionPolicy() {
|
||||||
),
|
),
|
||||||
expGroupPolicy: &group.GroupPolicyInfo{
|
expGroupPolicy: &group.GroupPolicyInfo{
|
||||||
Admin: admin.String(),
|
Admin: admin.String(),
|
||||||
Address: groupPolicyAddr,
|
|
||||||
GroupId: myGroupID,
|
|
||||||
Metadata: nil,
|
Metadata: nil,
|
||||||
Version: 3,
|
|
||||||
DecisionPolicy: nil,
|
DecisionPolicy: nil,
|
||||||
|
Version: 2,
|
||||||
CreatedAt: s.blockTime,
|
CreatedAt: s.blockTime,
|
||||||
},
|
},
|
||||||
expErr: false,
|
expErr: false,
|
||||||
|
@ -1099,8 +1101,20 @@ func (s *TestSuite) TestUpdateGroupPolicyDecisionPolicy() {
|
||||||
}
|
}
|
||||||
for msg, spec := range specs {
|
for msg, spec := range specs {
|
||||||
spec := spec
|
spec := spec
|
||||||
|
policyAddr := groupPolicyAddr
|
||||||
err := spec.expGroupPolicy.SetDecisionPolicy(spec.policy)
|
err := spec.expGroupPolicy.SetDecisionPolicy(spec.policy)
|
||||||
s.Require().NoError(err)
|
s.Require().NoError(err)
|
||||||
|
if spec.preRun != nil {
|
||||||
|
policyAddr1, groupId, _ := spec.preRun(admin, s)
|
||||||
|
policyAddr = policyAddr1
|
||||||
|
|
||||||
|
// update the expected info with new group policy details
|
||||||
|
spec.expGroupPolicy.Address = policyAddr1
|
||||||
|
spec.expGroupPolicy.GroupId = groupId
|
||||||
|
|
||||||
|
// update req with new group policy addr
|
||||||
|
spec.req.Address = policyAddr1
|
||||||
|
}
|
||||||
|
|
||||||
err = spec.req.SetDecisionPolicy(spec.policy)
|
err = spec.req.SetDecisionPolicy(spec.policy)
|
||||||
s.Require().NoError(err)
|
s.Require().NoError(err)
|
||||||
|
@ -1113,7 +1127,7 @@ func (s *TestSuite) TestUpdateGroupPolicyDecisionPolicy() {
|
||||||
}
|
}
|
||||||
s.Require().NoError(err)
|
s.Require().NoError(err)
|
||||||
res, err := s.keeper.GroupPolicyInfo(s.ctx, &group.QueryGroupPolicyInfoRequest{
|
res, err := s.keeper.GroupPolicyInfo(s.ctx, &group.QueryGroupPolicyInfoRequest{
|
||||||
Address: groupPolicyAddr,
|
Address: policyAddr,
|
||||||
})
|
})
|
||||||
s.Require().NoError(err)
|
s.Require().NoError(err)
|
||||||
s.Assert().Equal(spec.expGroupPolicy, res.Info)
|
s.Assert().Equal(spec.expGroupPolicy, res.Info)
|
||||||
|
|
Loading…
Reference in New Issue