From 89ea3902977836d994b6f20d4d8dcc1dadd2d85e Mon Sep 17 00:00:00 2001 From: Marie Gauthier Date: Fri, 4 Mar 2022 12:10:48 +0100 Subject: [PATCH] fix: Fix group simulations for MsgCreateGroupWithPolicy (#11261) ## Description Closes: https://github.com/cosmos/cosmos-sdk/issues/11230 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --- x/group/simulation/operations.go | 10 +++++----- x/group/simulation/operations_test.go | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/x/group/simulation/operations.go b/x/group/simulation/operations.go index 23a00540a..284956d2f 100644 --- a/x/group/simulation/operations.go +++ b/x/group/simulation/operations.go @@ -72,7 +72,7 @@ const ( WeightMsgUpdateGroupPolicyDecisionPolicy = 5 WeightMsgUpdateGroupPolicyMetadata = 5 WeightMsgWithdrawProposal = 20 - WeightMsgCreateGroupWithPolicy = 100 + WeightMsgCreateGroupWithPolicy = 50 ) // WeightedOperations returns all the operations from the module with their respective weights @@ -179,10 +179,10 @@ func WeightedOperations( weightMsgCreateGroupPolicy, SimulateMsgCreateGroupPolicy(ak, bk, k), ), - // simulation.NewWeightedOperation( - // weightMsgCreateGroupWithPolicy, - // SimulateMsgCreateGroupWithPolicy(ak, bk), - // ), + simulation.NewWeightedOperation( + weightMsgCreateGroupWithPolicy, + SimulateMsgCreateGroupWithPolicy(ak, bk), + ), } wPostCreateProposalOps := simulation.WeightedOperations{ diff --git a/x/group/simulation/operations_test.go b/x/group/simulation/operations_test.go index 38d37ad5d..4fa6385f6 100644 --- a/x/group/simulation/operations_test.go +++ b/x/group/simulation/operations_test.go @@ -53,7 +53,7 @@ func (suite *SimTestSuite) TestWeightedOperations() { }{ {simulation.WeightMsgCreateGroup, group.MsgCreateGroup{}.Route(), simulation.TypeMsgCreateGroup}, {simulation.WeightMsgCreateGroupPolicy, group.MsgCreateGroupPolicy{}.Route(), simulation.TypeMsgCreateGroupPolicy}, - // {simulation.WeightMsgCreateGroupWithPolicy, group.MsgCreateGroupWithPolicy{}.Route(), simulation.TypeMsgCreateGroupWithPolicy}, + {simulation.WeightMsgCreateGroupWithPolicy, group.MsgCreateGroupWithPolicy{}.Route(), simulation.TypeMsgCreateGroupWithPolicy}, {simulation.WeightMsgSubmitProposal, group.MsgSubmitProposal{}.Route(), simulation.TypeMsgSubmitProposal}, {simulation.WeightMsgSubmitProposal, group.MsgSubmitProposal{}.Route(), simulation.TypeMsgSubmitProposal}, {simulation.WeightMsgWithdrawProposal, group.MsgWithdrawProposal{}.Route(), simulation.TypeMsgWithdrawProposal},