certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Check generate_only's output is actually unsigned

This commit is contained in:
Alessio Treglia 2018-09-04 14:57:40 +02:00
parent 86395809cb
commit 8c32a8f229
No known key found for this signature in database
GPG Key ID: E8A48AE5311D765A
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
client/lcd/lcd_test.go
View File

@ -326,6 +326,7 @@ func TestCoinSendGenerateOnly(t *testing.T) {
require.Equal(t, len(msg.Msgs), 1) require.Equal(t, len(msg.Msgs), 1)
require.Equal(t, msg.Msgs[0].Type(), "bank") require.Equal(t, msg.Msgs[0].Type(), "bank")
require.Equal(t, msg.Msgs[0].GetSigners(), []sdk.AccAddress{addr}) require.Equal(t, msg.Msgs[0].GetSigners(), []sdk.AccAddress{addr})
require.Equal(t, 0, len(msg.Signatures))
} }
func TestTxs(t *testing.T) { func TestTxs(t *testing.T) {

6
cmd/gaia/cli_test/cli_test.go
View File

@ -164,6 +164,7 @@ func TestGaiaCLICreateValidator(t *testing.T) {
msg := unmarshalStdTx(t, stdout) msg := unmarshalStdTx(t, stdout)
require.NotZero(t, msg.Fee.Gas) require.NotZero(t, msg.Fee.Gas)
require.Equal(t, len(msg.Msgs), 1) require.Equal(t, len(msg.Msgs), 1)
require.Equal(t, 0, len(msg.GetSignatures()))
// Test --dry-run // Test --dry-run
success = executeWrite(t, cvStr+" --dry-run", app.DefaultKeyPass) success = executeWrite(t, cvStr+" --dry-run", app.DefaultKeyPass)
@ -240,6 +241,7 @@ func TestGaiaCLISubmitProposal(t *testing.T) {
msg := unmarshalStdTx(t, stdout) msg := unmarshalStdTx(t, stdout)
require.NotZero(t, msg.Fee.Gas) require.NotZero(t, msg.Fee.Gas)
require.Equal(t, len(msg.Msgs), 1) require.Equal(t, len(msg.Msgs), 1)
require.Equal(t, 0, len(msg.GetSignatures()))
// Test --dry-run // Test --dry-run
success = executeWrite(t, spStr+" --dry-run", app.DefaultKeyPass) success = executeWrite(t, spStr+" --dry-run", app.DefaultKeyPass)
@ -271,6 +273,7 @@ func TestGaiaCLISubmitProposal(t *testing.T) {
msg = unmarshalStdTx(t, stdout) msg = unmarshalStdTx(t, stdout)
require.NotZero(t, msg.Fee.Gas) require.NotZero(t, msg.Fee.Gas)
require.Equal(t, len(msg.Msgs), 1) require.Equal(t, len(msg.Msgs), 1)
require.Equal(t, 0, len(msg.GetSignatures()))
executeWrite(t, depositStr, app.DefaultKeyPass) executeWrite(t, depositStr, app.DefaultKeyPass)
tests.WaitForNextNBlocksTM(2, port) tests.WaitForNextNBlocksTM(2, port)
@ -294,6 +297,7 @@ func TestGaiaCLISubmitProposal(t *testing.T) {
msg = unmarshalStdTx(t, stdout) msg = unmarshalStdTx(t, stdout)
require.NotZero(t, msg.Fee.Gas) require.NotZero(t, msg.Fee.Gas)
require.Equal(t, len(msg.Msgs), 1) require.Equal(t, len(msg.Msgs), 1)
require.Equal(t, 0, len(msg.GetSignatures()))
executeWrite(t, voteStr, app.DefaultKeyPass) executeWrite(t, voteStr, app.DefaultKeyPass)
tests.WaitForNextNBlocksTM(2, port) tests.WaitForNextNBlocksTM(2, port)
@ -350,6 +354,7 @@ func TestGaiaCLISendGenerateOnly(t *testing.T) {
msg := unmarshalStdTx(t, stdout) msg := unmarshalStdTx(t, stdout)
require.Equal(t, msg.Fee.Gas, int64(client.DefaultGasLimit)) require.Equal(t, msg.Fee.Gas, int64(client.DefaultGasLimit))
require.Equal(t, len(msg.Msgs), 1) require.Equal(t, len(msg.Msgs), 1)
require.Equal(t, 0, len(msg.GetSignatures()))
// Test generate sendTx, estimate gas // Test generate sendTx, estimate gas
success, stdout, stderr = executeWriteRetStdStreams(t, fmt.Sprintf( success, stdout, stderr = executeWriteRetStdStreams(t, fmt.Sprintf(
@ -370,6 +375,7 @@ func TestGaiaCLISendGenerateOnly(t *testing.T) {
msg = unmarshalStdTx(t, stdout) msg = unmarshalStdTx(t, stdout)
require.Equal(t, msg.Fee.Gas, int64(100)) require.Equal(t, msg.Fee.Gas, int64(100))
require.Equal(t, len(msg.Msgs), 1) require.Equal(t, len(msg.Msgs), 1)
require.Equal(t, 0, len(msg.GetSignatures()))
} }
//___________________________________________________________________________________ //___________________________________________________________________________________