certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove CloseDB method from Keybase interface (#5820) 

* remove old method closeDb from Keybase interface

* add changelog

* move to api breaking changes

Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
This commit is contained in:
Jonathan Gimeno 2020-03-18 17:19:22 +01:00 committed by GitHub
parent 3db39cda3c
commit a5899bace0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -69,6 +69,7 @@ and provided directly the IAVL store.
to now accept a `codec.JSONMarshaler` for modular serialization of genesis state. to now accept a `codec.JSONMarshaler` for modular serialization of genesis state.
* (crypto/keys) [\#5735](https://github.com/cosmos/cosmos-sdk/pull/5735) Keyring's Update() function is now no-op. * (crypto/keys) [\#5735](https://github.com/cosmos/cosmos-sdk/pull/5735) Keyring's Update() function is now no-op.
* (types/rest) [\#5779](https://github.com/cosmos/cosmos-sdk/pull/5779) Drop unused Parse{Int64OrReturnBadRequest,QueryParamBool}() functions. * (types/rest) [\#5779](https://github.com/cosmos/cosmos-sdk/pull/5779) Drop unused Parse{Int64OrReturnBadRequest,QueryParamBool}() functions.
* (keys) [\#5820](https://github.com/cosmos/cosmos-sdk/pull/5820/) Removed method CloseDB from Keybase interface.
### Features ### Features

5
crypto/keys/keybase.go
View File

@ -428,11 +428,6 @@ func (kb dbKeybase) Update(name, oldpass string, getNewpass func() (string, erro
} }
} }
// CloseDB releases the lock and closes the storage backend.
func (kb dbKeybase) CloseDB() {
kb.db.Close()
}
// SupportedAlgos returns a list of supported signing algorithms. // SupportedAlgos returns a list of supported signing algorithms.
func (kb dbKeybase) SupportedAlgos() []SigningAlgo { func (kb dbKeybase) SupportedAlgos() []SigningAlgo {
return kb.base.SupportedAlgos() return kb.base.SupportedAlgos()

3
crypto/keys/keyring.go
View File

@ -430,9 +430,6 @@ func (kb keyringKeybase) SupportedAlgosLedger() []SigningAlgo {
return kb.base.SupportedAlgosLedger() return kb.base.SupportedAlgosLedger()
} }
// CloseDB releases the lock and closes the storage backend.
func (kb keyringKeybase) CloseDB() {}
func (kb keyringKeybase) writeLocalKey(name string, priv tmcrypto.PrivKey, _ string, algo SigningAlgo) Info { func (kb keyringKeybase) writeLocalKey(name string, priv tmcrypto.PrivKey, _ string, algo SigningAlgo) Info {
// encrypt private key using keyring // encrypt private key using keyring
pub := priv.PubKey() pub := priv.PubKey()

2
crypto/keys/keyring_test.go
View File

@ -96,8 +96,6 @@ func TestLazyKeyManagementKeyRing(t *testing.T) {
// addr cache gets nuked - and test skip flag // addr cache gets nuked - and test skip flag
require.NoError(t, kb.Delete(n2, "", true)) require.NoError(t, kb.Delete(n2, "", true))
require.NotPanics(t, kb.CloseDB)
} }
// TestSignVerify does some detailed checks on how we sign and validate // TestSignVerify does some detailed checks on how we sign and validate

2
crypto/keys/lazy_keybase.go
View File

@ -219,5 +219,3 @@ func (lkb lazyKeybase) SupportedAlgos() []SigningAlgo {
func (lkb lazyKeybase) SupportedAlgosLedger() []SigningAlgo { func (lkb lazyKeybase) SupportedAlgosLedger() []SigningAlgo {
return newBaseKeybase(lkb.options...).SupportedAlgosLedger() return newBaseKeybase(lkb.options...).SupportedAlgosLedger()
} }
func (lkb lazyKeybase) CloseDB() {}

3
crypto/keys/types.go
View File

@ -80,9 +80,6 @@ type Keybase interface {
// SupportedAlgosLedger returns a list of signing algorithms supported by the keybase's ledger integration // SupportedAlgosLedger returns a list of signing algorithms supported by the keybase's ledger integration
SupportedAlgosLedger() []SigningAlgo SupportedAlgosLedger() []SigningAlgo
// CloseDB closes the database.
CloseDB()
} }
// KeyType reflects a human-readable type for key listing. // KeyType reflects a human-readable type for key listing.