certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

address comments

This commit is contained in:
mossid 2018-09-27 03:30:57 +09:00
parent 67ac8c55b9
commit a766e0f2d9
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
x/params/store/store.go
View File

@ -81,14 +81,19 @@ func (s Store) Modified(ctx sdk.Context, key string) bool {
} }
// Set parameter, return error if stored parameter has different type from input // Set parameter, return error if stored parameter has different type from input
// Also set to the transient store to record change
func (s Store) Set(ctx sdk.Context, key string, param interface{}) { func (s Store) Set(ctx sdk.Context, key string, param interface{}) {
store := s.kvStore(ctx) store := s.kvStore(ctx)
keybz := []byte(key) keybz := []byte(key)
bz := store.Get(keybz) bz := store.Get(keybz)
// To prevent invalid parameter set, we check the type of the stored parameter
// and try to match it with the provided parameter. It continues only if they matches.
// It is possible because parameter set happens rarely.
if bz != nil { if bz != nil {
ptrty := reflect.PtrTo(reflect.TypeOf(param)) ptrType := reflect.PtrTo(reflect.TypeOf(param))
ptr := reflect.New(ptrty).Interface() ptr := reflect.New(ptrType).Interface()
if s.cdc.UnmarshalJSON(bz, ptr) != nil { if s.cdc.UnmarshalJSON(bz, ptr) != nil {
panic(fmt.Errorf("Type mismatch with stored param and provided param")) panic(fmt.Errorf("Type mismatch with stored param and provided param"))
@ -106,6 +111,7 @@ func (s Store) Set(ctx sdk.Context, key string, param interface{}) {
} }
// Set raw bytes of parameter // Set raw bytes of parameter
// Also set to the transient store to record change
func (s Store) SetRaw(ctx sdk.Context, key string, param []byte) { func (s Store) SetRaw(ctx sdk.Context, key string, param []byte) {
keybz := []byte(key) keybz := []byte(key)