add comments to why its nolint (#6366)

* add comments to why its nolint

* fix spelling

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
This commit is contained in:
Marko 2020-06-08 15:47:18 +02:00 committed by GitHub
parent 4e0a475751
commit b618e0a827
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 5 deletions

View File

@ -23,7 +23,7 @@ jobs:
- uses: golangci/golangci-lint-action@master
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.26
version: v1.27
args: --timeout 10m
github-token: ${{ secrets.github_token }}
if: "env.GIT_DIFF != ''"

View File

@ -5,6 +5,7 @@ import (
cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
)
//nolint:stylecheck // ignore linting of comment
// Deprecated: Cdc defines a global generic sealed Amino codec to be used throughout sdk. It
// has all Tendermint crypto and evidence types registered.
//

View File

@ -53,7 +53,7 @@ var (
NewQueryAccountParams = types.NewQueryAccountParams
NewStdTx = types.NewStdTx
CountSubKeys = types.CountSubKeys
NewStdFee = types.NewStdFee //nolint:staticcheck
NewStdFee = types.NewStdFee //nolint:staticcheck // this will be removed when proto is ready
StdSignBytes = types.StdSignBytes
DefaultTxDecoder = types.DefaultTxDecoder
DefaultTxEncoder = types.DefaultTxEncoder
@ -88,9 +88,9 @@ type (
QueryAccountParams = types.QueryAccountParams
StdSignMsg = types.StdSignMsg
StdTx = types.StdTx
StdFee = types.StdFee //nolint:staticcheck
StdFee = types.StdFee //nolint:staticcheck // this will be removed when proto is ready
StdSignDoc = types.StdSignDoc
StdSignature = types.StdSignature //nolint:staticcheck
StdSignature = types.StdSignature //nolint:staticcheck // this will be removed when proto is ready
TxBuilder = types.TxBuilder
GenesisAccountIterator = types.GenesisAccountIterator
ModuleAccount = types.ModuleAccount

View File

@ -125,7 +125,7 @@ func (cgts ConsumeTxSizeGasDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, sim
}
// use stdsignature to mock the size of a full signature
simSig := types.StdSignature{ //nolint:staticcheck
simSig := types.StdSignature{ //nolint:staticheck // this will be removed when proto is ready
Signature: simSecp256k1Sig[:],
PubKey: pubkey.Bytes(),
}