certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #1862 from cosmos/dev/speed_up_handleMsgEditValidator 

x/stake: Speed up handleMsgEditValidator
This commit is contained in:
Rigel 2018-07-29 23:21:10 -04:00 committed by GitHub
parent 89dd333732 0bb3497356
commit c40d5debcc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
PENDING.md
View File

@ -50,6 +50,7 @@ IMPROVEMENTS
* [tests] Fixes ansible scripts to work with AWS too * [tests] Fixes ansible scripts to work with AWS too
* [tests] \#1806 CLI tests are now behind the build flag 'cli_test', so go test works on a new repo * [tests] \#1806 CLI tests are now behind the build flag 'cli_test', so go test works on a new repo
* [x/gov] Initial governance parameters can now be set in the genesis file * [x/gov] Initial governance parameters can now be set in the genesis file
* [x/stake] \#1815 Sped up the processing of `EditValidator` txs.
BUG FIXES BUG FIXES
* \#1666 Add intra-tx counter to the genesis validators * \#1666 Add intra-tx counter to the genesis validators

4
x/stake/handler.go
View File

@ -111,7 +111,9 @@ func handleMsgEditValidator(ctx sdk.Context, msg types.MsgEditValidator, k keepe
} }
validator.Description = description validator.Description = description
k.UpdateValidator(ctx, validator) // We don't need to run through all the power update logic within k.UpdateValidator
// We just need to override the entry in state, since only the description has changed.
k.SetValidator(ctx, validator)
tags := sdk.NewTags( tags := sdk.NewTags(
tags.Action, tags.ActionEditValidator, tags.Action, tags.ActionEditValidator,
tags.DstValidator, []byte(msg.ValidatorAddr.String()), tags.DstValidator, []byte(msg.ValidatorAddr.String()),

4
x/stake/keeper/validator.go
View File

@ -191,9 +191,9 @@ func (k Keeper) ClearTendermintUpdates(ctx sdk.Context) {
//___________________________________________________________________________ //___________________________________________________________________________
// Perfom all the nessisary steps for when a validator changes its power. This // Perfom all the necessary steps for when a validator changes its power. This
// function updates all validator stores as well as tendermint update store. // function updates all validator stores as well as tendermint update store.
// It may kick out validators if new validator is entering the bonded validator // It may kick out validators if a new validator is entering the bonded validator
// group. // group.
// //
// nolint: gocyclo // nolint: gocyclo