certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

modules/coin/rest: incorporated feedback from @ebuchman

This commit is contained in:
Emmanuel Odeke 2017-08-10 17:37:01 -06:00
parent f52d92a40e
commit dfae4ccdbd
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
modules/roles/rest/handlers.go
View File

@ -16,17 +16,25 @@ import (
"github.com/tendermint/tmlibs/common" "github.com/tendermint/tmlibs/common"
) )
// RoleInput encapsulates the fields needed to create a role
type RoleInput struct { type RoleInput struct {
// Role is a hex encoded string of the role name
// for example, instead of "role" as the name, its
// hex encoded version "726f6c65".
Role string `json:"role" validate:"required,min=2"` Role string `json:"role" validate:"required,min=2"`
MinimumSigners uint32 `json:"min_sigs" validate:"required,min=1"` MinimumSigners uint32 `json:"min_sigs" validate:"required,min=1"`
Signers []basecoin.Actor `json:"signers" validate:"required,min=1"` Signers []basecoin.Actor `json:"signers" validate:"required,min=1"`
// Sequence is the user defined field whose purpose is to
// prevent replay attacks when creating a role, since it
// ensures that for a successful role creation, the previous
// sequence number should have been looked up by the caller.
Sequence uint32 `json:"seq" validate:"required,min=1"` Sequence uint32 `json:"seq" validate:"required,min=1"`
} }
func parseRole(roleInHex string) ([]byte, error) { func decodeRoleHex(roleInHex string) ([]byte, error) {
parsedRole, err := hex.DecodeString(common.StripHex(roleInHex)) parsedRole, err := hex.DecodeString(common.StripHex(roleInHex))
if err != nil { if err != nil {
err = errors.WithMessage("invalid hex", err, abci.CodeType_EncodingError) err = errors.WithMessage("invalid hex", err, abci.CodeType_EncodingError)
@ -37,8 +45,8 @@ func parseRole(roleInHex string) ([]byte, error) {
// mux.Router registrars // mux.Router registrars
// RegisterQueryAccount is a mux.Router handler that exposes GET // RegisterCreateRole is a mux.Router handler that exposes POST
// method access on route /query/account/{signature} to query accounts // method access on route /build/create_role to create a role.
func RegisterCreateRole(r *mux.Router) error { func RegisterCreateRole(r *mux.Router) error {
r.HandleFunc("/build/create_role", doCreateRole).Methods("POST") r.HandleFunc("/build/create_role", doCreateRole).Methods("POST")
return nil return nil
@ -51,7 +59,7 @@ func doCreateRole(w http.ResponseWriter, r *http.Request) {
return return
} }
parsedRole, err := parseRole(ri.Role) parsedRole, err := decodeRoleHex(ri.Role)
if err != nil { if err != nil {
common.WriteError(w, err) common.WriteError(w, err)
return return