refactor vote test

This commit is contained in:
Jonathan Gimeno 2020-03-02 19:50:39 +01:00
parent 894b2e5897
commit e266c40ce1
1 changed files with 28 additions and 21 deletions

View File

@ -1,64 +1,71 @@
package keeper package keeper_test
import ( import (
"testing" "testing"
"github.com/stretchr/testify/require" sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/simapp"
abci "github.com/tendermint/tendermint/abci/types"
"github.com/cosmos/cosmos-sdk/x/gov/types" "github.com/cosmos/cosmos-sdk/x/gov/types"
"github.com/stretchr/testify/require"
) )
func TestVotes(t *testing.T) { func TestVotes(t *testing.T) {
ctx, _, _, keeper, _, _ := createTestInput(t, false, 100) // nolint: dogsled app := simapp.Setup(false)
ctx := app.BaseApp.NewContext(false, abci.Header{})
addrs := simapp.AddTestAddrsIncremental(app, ctx, 5, sdk.NewInt(30000000))
tp := TestProposal tp := TestProposal
proposal, err := keeper.SubmitProposal(ctx, tp) proposal, err := app.GovKeeper.SubmitProposal(ctx, tp)
require.NoError(t, err) require.NoError(t, err)
proposalID := proposal.ProposalID proposalID := proposal.ProposalID
var invalidOption types.VoteOption = 0x10 var invalidOption types.VoteOption = 0x10
require.Error(t, keeper.AddVote(ctx, proposalID, TestAddrs[0], types.OptionYes), "proposal not on voting period") require.Error(t, app.GovKeeper.AddVote(ctx, proposalID, addrs[0], types.OptionYes), "proposal not on voting period")
require.Error(t, keeper.AddVote(ctx, 10, TestAddrs[0], types.OptionYes), "invalid proposal ID") require.Error(t, app.GovKeeper.AddVote(ctx, 10, addrs[0], types.OptionYes), "invalid proposal ID")
proposal.Status = types.StatusVotingPeriod proposal.Status = types.StatusVotingPeriod
keeper.SetProposal(ctx, proposal) app.GovKeeper.SetProposal(ctx, proposal)
require.Error(t, keeper.AddVote(ctx, proposalID, TestAddrs[0], invalidOption), "invalid option") require.Error(t, app.GovKeeper.AddVote(ctx, proposalID, addrs[0], invalidOption), "invalid option")
// Test first vote // Test first vote
require.NoError(t, keeper.AddVote(ctx, proposalID, TestAddrs[0], types.OptionAbstain)) require.NoError(t, app.GovKeeper.AddVote(ctx, proposalID, addrs[0], types.OptionAbstain))
vote, found := keeper.GetVote(ctx, proposalID, TestAddrs[0]) vote, found := app.GovKeeper.GetVote(ctx, proposalID, addrs[0])
require.True(t, found) require.True(t, found)
require.Equal(t, TestAddrs[0], vote.Voter) require.Equal(t, addrs[0], vote.Voter)
require.Equal(t, proposalID, vote.ProposalID) require.Equal(t, proposalID, vote.ProposalID)
require.Equal(t, types.OptionAbstain, vote.Option) require.Equal(t, types.OptionAbstain, vote.Option)
// Test change of vote // Test change of vote
require.NoError(t, keeper.AddVote(ctx, proposalID, TestAddrs[0], types.OptionYes)) require.NoError(t, app.GovKeeper.AddVote(ctx, proposalID, addrs[0], types.OptionYes))
vote, found = keeper.GetVote(ctx, proposalID, TestAddrs[0]) vote, found = app.GovKeeper.GetVote(ctx, proposalID, addrs[0])
require.True(t, found) require.True(t, found)
require.Equal(t, TestAddrs[0], vote.Voter) require.Equal(t, addrs[0], vote.Voter)
require.Equal(t, proposalID, vote.ProposalID) require.Equal(t, proposalID, vote.ProposalID)
require.Equal(t, types.OptionYes, vote.Option) require.Equal(t, types.OptionYes, vote.Option)
// Test second vote // Test second vote
require.NoError(t, keeper.AddVote(ctx, proposalID, TestAddrs[1], types.OptionNoWithVeto)) require.NoError(t, app.GovKeeper.AddVote(ctx, proposalID, addrs[1], types.OptionNoWithVeto))
vote, found = keeper.GetVote(ctx, proposalID, TestAddrs[1]) vote, found = app.GovKeeper.GetVote(ctx, proposalID, addrs[1])
require.True(t, found) require.True(t, found)
require.Equal(t, TestAddrs[1], vote.Voter) require.Equal(t, addrs[1], vote.Voter)
require.Equal(t, proposalID, vote.ProposalID) require.Equal(t, proposalID, vote.ProposalID)
require.Equal(t, types.OptionNoWithVeto, vote.Option) require.Equal(t, types.OptionNoWithVeto, vote.Option)
// Test vote iterator // Test vote iterator
// NOTE order of deposits is determined by the addresses // NOTE order of deposits is determined by the addresses
votes := keeper.GetAllVotes(ctx) votes := app.GovKeeper.GetAllVotes(ctx)
require.Len(t, votes, 2) require.Len(t, votes, 2)
require.Equal(t, votes, keeper.GetVotes(ctx, proposalID)) require.Equal(t, votes, app.GovKeeper.GetVotes(ctx, proposalID))
require.Equal(t, TestAddrs[0], votes[0].Voter) require.Equal(t, addrs[0], votes[0].Voter)
require.Equal(t, proposalID, votes[0].ProposalID) require.Equal(t, proposalID, votes[0].ProposalID)
require.Equal(t, types.OptionYes, votes[0].Option) require.Equal(t, types.OptionYes, votes[0].Option)
require.Equal(t, TestAddrs[1], votes[1].Voter) require.Equal(t, addrs[1], votes[1].Voter)
require.Equal(t, proposalID, votes[1].ProposalID) require.Equal(t, proposalID, votes[1].ProposalID)
require.Equal(t, types.OptionNoWithVeto, votes[1].Option) require.Equal(t, types.OptionNoWithVeto, votes[1].Option)
} }