certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

apply comments

This commit is contained in:
chengwenxi 2021-05-31 14:42:56 +08:00
parent 835b58183c
commit e39f05907d
1 changed files with 7 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
docs/architecture/adr-043-nft-module.md
View File

@ -36,15 +36,11 @@ The current design is based on the work done by [IRISnet team](https://github.co
We will create a module `x/nft` which only stores NFTs by id and owner. We will create a module `x/nft` which only stores NFTs by id and owner.
The interface for the `x/nft` module: ```proto
message NFT {
```go string id = 1;
// NFT is an interface used to store NFTs at a given id. string owner = 2;
type NFT interface { google.protobuf.Any data = 3;
GetId() string // define a simple identifier for the NFT
GetOwner() sdk.AccAddress // the current owner's address
GetData() string // specialized metadata to accompany the nft
Validate() error
} }
``` ```
@ -78,17 +74,6 @@ func (k Keeper) TransferOwnership(nftID string, currentOwner, newOwner sdk.AccAd
Other behaviors of NFT, including minting, burning and other business-logic implementation should be defined in other upper-level modules that import this NFT module. Other behaviors of NFT, including minting, burning and other business-logic implementation should be defined in other upper-level modules that import this NFT module.
We will also create `BaseNFT` as the default implementation of the `NFT` interface:
```proto
message BaseNFT {
option (gogoproto.equal) = true;
string id = 1;
string owner = 2;
string data = 3;
}
```
The query service methods for the `x/nft` module are: The query service methods for the `x/nft` module are:
```proto ```proto
service Query { service Query {
@ -111,7 +96,7 @@ message QueryNFTRequest {
// QueryNFTResponse is the response type for the Query/NFT RPC method // QueryNFTResponse is the response type for the Query/NFT RPC method
message QueryNFTResponse { message QueryNFTResponse {
google.protobuf.Any nft = 1 [(cosmos_proto.accepts_interface) = "NFT", (gogoproto.customname) = "NFT"]; NFT nft = 1;
} }
// QueryNFTsRequest is the request type for the Query/NFTs RPC method // QueryNFTsRequest is the request type for the Query/NFTs RPC method
@ -122,13 +107,11 @@ message QueryNFTsRequest {
// QueryNFTsResponse is the response type for the Query/NFTs RPC method // QueryNFTsResponse is the response type for the Query/NFTs RPC method
message QueryNFTsResponse { message QueryNFTsResponse {
repeated google.protobuf.Any nfts = 1 [(cosmos_proto.accepts_interface) = "NFT", (gogoproto.customname) = "NFTs"]; repeated NFT nfts = 1;
cosmos.base.query.v1beta1.PageResponse pagination = 2; cosmos.base.query.v1beta1.PageResponse pagination = 2;
} }
``` ```
## Consequences ## Consequences
### Backward Compatibility ### Backward Compatibility