certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: Change proposer address cast for `sdk_block` conversion (backport #15243) (#15244) 

Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
This commit is contained in:
mergify[bot] 2023-03-02 17:33:53 +00:00 committed by GitHub
parent 6ec0e519e0
commit e966cf9463
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -37,6 +37,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
## [Unreleased] ## [Unreleased]
### Bug Fixes
* [#15243](https://github.com/cosmos/cosmos-sdk/pull/15243) `LatestBlockResponse` & `BlockByHeightResponse` types' field `sdk_block` was incorrectly cast `proposer_address` bytes to validator operator address, now to consensus address
## [v0.47.0-rc3](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.0-rc3) - 2023-03-01 ## [v0.47.0-rc3](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.0-rc3) - 2023-03-01
### Features ### Features

2
client/grpc/tmservice/util.go
View File

@ -21,7 +21,7 @@ func convertHeader(h tmprototypes.Header) Header {
EvidenceHash: h.EvidenceHash, EvidenceHash: h.EvidenceHash,
LastResultsHash: h.LastResultsHash, LastResultsHash: h.LastResultsHash,
LastCommitHash: h.LastCommitHash, LastCommitHash: h.LastCommitHash,
ProposerAddress: sdk.ValAddress(h.ProposerAddress).String(), ProposerAddress: sdk.ConsAddress(h.ProposerAddress).String(),
} }
} }

6
tests/e2e/client/grpc/tmservice/service_test.go
View File

@ -91,8 +91,8 @@ func (s *E2ETestSuite) TestQueryLatestBlock() {
s.Require().NoError(err) s.Require().NoError(err)
var blockInfoRes tmservice.GetLatestBlockResponse var blockInfoRes tmservice.GetLatestBlockResponse
s.Require().NoError(val.ClientCtx.Codec.UnmarshalJSON(restRes, &blockInfoRes)) s.Require().NoError(val.ClientCtx.Codec.UnmarshalJSON(restRes, &blockInfoRes))
s.Require().Equal(types.ValAddress(blockInfoRes.Block.Header.ProposerAddress).String(), blockInfoRes.SdkBlock.Header.ProposerAddress) s.Require().Equal(types.ConsAddress(blockInfoRes.Block.Header.ProposerAddress).String(), blockInfoRes.SdkBlock.Header.ProposerAddress)
s.Require().Contains(blockInfoRes.SdkBlock.Header.ProposerAddress, "cosmosvaloper") s.Require().Contains(blockInfoRes.SdkBlock.Header.ProposerAddress, "cosmosvalcons")
} }
func (s *E2ETestSuite) TestQueryBlockByHeight() { func (s *E2ETestSuite) TestQueryBlockByHeight() {
@ -104,7 +104,7 @@ func (s *E2ETestSuite) TestQueryBlockByHeight() {
s.Require().NoError(err) s.Require().NoError(err)
var blockInfoRes tmservice.GetBlockByHeightResponse var blockInfoRes tmservice.GetBlockByHeightResponse
s.Require().NoError(val.ClientCtx.Codec.UnmarshalJSON(restRes, &blockInfoRes)) s.Require().NoError(val.ClientCtx.Codec.UnmarshalJSON(restRes, &blockInfoRes))
s.Require().Contains(blockInfoRes.SdkBlock.Header.ProposerAddress, "cosmosvaloper") s.Require().Contains(blockInfoRes.SdkBlock.Header.ProposerAddress, "cosmosvalcons")
} }
func (s *E2ETestSuite) TestQueryLatestValidatorSet() { func (s *E2ETestSuite) TestQueryLatestValidatorSet() {