From f470d402a59658cf2f40ea8ef5020994bdfc0ca1 Mon Sep 17 00:00:00 2001 From: atheeshp <59333759+atheeshp@users.noreply.github.com> Date: Thu, 19 May 2022 19:38:30 +0530 Subject: [PATCH] fix: cli `grants-by-grantee`, `grants-by-granter` cmds (#11983) ## Description ref: #11362 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --- CHANGELOG.md | 1 + x/authz/client/cli/query.go | 8 ++++---- x/feegrant/client/cli/query.go | 8 ++++---- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e162a3a1..b9849e0ee 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -277,6 +277,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (x/feegrant) [\#11813](https://github.com/cosmos/cosmos-sdk/pull/11813) Fix pagination total count in `AllowancesByGranter` query. * (simapp) [\#11855](https://github.com/cosmos/cosmos-sdk/pull/11855) Use `sdkmath.Int` instead of `int64` for `SimulationState.InitialStake`. * (x/capability) [\#11737](https://github.com/cosmos/cosmos-sdk/pull/11737) Use a fixed length encoding of `Capability` pointer for `FwdCapabilityKey` +* [\#11983](https://github.com/cosmos/cosmos-sdk/pull/11983) (x/feegrant, x/authz) rename grants query commands to `grants-by-grantee`, `grants-by-granter` cmds. ### State Machine Breaking diff --git a/x/authz/client/cli/query.go b/x/authz/client/cli/query.go index 7cd2ec1ad..62e40b290 100644 --- a/x/authz/client/cli/query.go +++ b/x/authz/client/cli/query.go @@ -98,13 +98,13 @@ $ %s query %s grants cosmos1skjw.. cosmos1skjwj.. %s // GetQueryGranterGrants returns cmd to query for all grants for a granter. func GetQueryGranterGrants() *cobra.Command { cmd := &cobra.Command{ - Use: "granter-grants [granter-addr]", + Use: "grants-by-granter [granter-addr]", Args: cobra.ExactArgs(1), Short: "query authorization grants granted by granter", Long: strings.TrimSpace( fmt.Sprintf(`Query authorization grants granted by granter. Examples: -$ %s q %s granter-grants cosmos1skj.. +$ %s q %s grants-by-granter cosmos1skj.. `, version.AppName, authz.ModuleName), ), @@ -147,13 +147,13 @@ $ %s q %s granter-grants cosmos1skj.. // GetQueryGranteeGrants returns cmd to query for all grants for a grantee. func GetQueryGranteeGrants() *cobra.Command { cmd := &cobra.Command{ - Use: "grantee-grants [grantee-addr]", + Use: "grants-by-grantee [grantee-addr]", Args: cobra.ExactArgs(1), Short: "query authorization grants granted to a grantee", Long: strings.TrimSpace( fmt.Sprintf(`Query authorization grants granted to a grantee. Examples: -$ %s q %s grantee-grants cosmos1skj.. +$ %s q %s grants-by-grantee cosmos1skj.. `, version.AppName, authz.ModuleName), ), diff --git a/x/feegrant/client/cli/query.go b/x/feegrant/client/cli/query.go index cd1727ae8..ba0141716 100644 --- a/x/feegrant/client/cli/query.go +++ b/x/feegrant/client/cli/query.go @@ -83,14 +83,14 @@ $ %s query feegrant grant [granter] [grantee] // GetCmdQueryFeeGrantsByGrantee returns cmd to query for all grants for a grantee. func GetCmdQueryFeeGrantsByGrantee() *cobra.Command { cmd := &cobra.Command{ - Use: "grants [grantee]", + Use: "grants-by-grantee [grantee]", Args: cobra.ExactArgs(1), Short: "Query all grants of a grantee", Long: strings.TrimSpace( fmt.Sprintf(`Queries all the grants for a grantee address. Example: -$ %s query feegrant grants [grantee] +$ %s query feegrant grants-by-grantee [grantee] `, version.AppName), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -131,14 +131,14 @@ $ %s query feegrant grants [grantee] // GetCmdQueryFeeGrantsByGranter returns cmd to query for all grants by a granter. func GetCmdQueryFeeGrantsByGranter() *cobra.Command { cmd := &cobra.Command{ - Use: "grants [granter]", + Use: "grants-by-granter [granter]", Args: cobra.ExactArgs(1), Short: "Query all grants by a granter", Long: strings.TrimSpace( fmt.Sprintf(`Queries all the grants issued for a granter address. Example: -$ %s query feegrant grants [granter] +$ %s query feegrant grants-by-granter [granter] `, version.AppName), ), RunE: func(cmd *cobra.Command, args []string) error {