From f832d785e0f1eeee486d2dc976f6630c1a7621a5 Mon Sep 17 00:00:00 2001 From: Puneet <59960662+puneet2019@users.noreply.github.com> Date: Mon, 13 Dec 2021 16:02:01 +0530 Subject: [PATCH] chore(cli): Update keys add help message (#10730) the command `gaiad keys add myKey --help` is printed as ``` --account uint32 Account number for HD derivation --index uint32 Address index number for HD derivation ``` and it's not obvious that uint32 cannot accept its max value. https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#extended-keys Please close this if it is not required, request changes if there is better way to do this. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --- client/keys/add.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/keys/add.go b/client/keys/add.go index 4480ad699..4591062e5 100644 --- a/client/keys/add.go +++ b/client/keys/add.go @@ -74,8 +74,8 @@ Example: f.Bool(flags.FlagDryRun, false, "Perform action, but don't add key to local keystore") f.String(flagHDPath, "", "Manual HD Path derivation (overrides BIP44 config)") f.Uint32(flagCoinType, sdk.GetConfig().GetCoinType(), "coin type number for HD derivation") - f.Uint32(flagAccount, 0, "Account number for HD derivation") - f.Uint32(flagIndex, 0, "Address index number for HD derivation") + f.Uint32(flagAccount, 0, "Account number for HD derivation (less than equal 2147483647)") + f.Uint32(flagIndex, 0, "Address index number for HD derivation (less than equal 2147483647)") f.String(flags.FlagKeyAlgorithm, string(hd.Secp256k1Type), "Key signing algorithm to generate keys for") return cmd