Robert Zaremba
7bca49e2d2
refactor(client): add client/Context.Codec and deprecate JSONCodec ( #9498 )
...
* chore(types): add sdk.Context.Codec and deprecate JSONCodec
* Use clientContext.Codec rather than JSONCodec everywhere
* update tests to use clientContext.Codec
* added a note that EncodingConfig.Marshaler will be renamed to Codec
* update changelog
* fix tests to use clientCtx.WithCodec instead of WithJSONCodec
* fix genutil build
* Update simapp/params/encoding.go
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-06-11 11:49:39 +00:00
Amaury
d19791be89
Rename clientCtx.JSONMarshaler to JSONCodec ( #9251 )
...
* Rename clientCtx.JSONMarshaler to JSONCodec
* change md files
* Fix lint
2021-05-03 14:45:47 +00:00
Robert Zaremba
cc1db18df5
doc secp256r1 ( #8899 )
...
* Update docs for things related to secp256r1
* docs: update accounts and pubkey documentation
* update table formatting
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Apply suggestions from code review
Awesome grammar fixes and style improvements
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
* Apply suggestions from code review
Awesome grammar and style improvements.
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* hd wallet docs update
* Apply suggestions from code review
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
* Update docs/basics/accounts.md
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* Update docs/architecture/adr-020-protobuf-transaction-encoding.md
I agree, let's use "and"
* update code snippet links
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-03-19 14:22:59 +00:00
Amaury
19e79e00d6
ADR-019/020 cleanups: HybridCodec, Pubkey ( #8683 )
...
* wip adr019
* Remove hybrid codec
* Change date
* Update docs/architecture/adr-019-protobuf-state-encoding.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update pubkey interface
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-25 15:40:04 +00:00
Amaury Martiny
48bfd73aba
Add background for sequence change in ADR-020 ( #7616 )
2020-10-21 14:47:31 +00:00
Federico Kunze
503b518efc
client: add GetAccount and GetAccountWithHeight to AccountRetriever ( #7558 )
...
* client: add GetAccount and GetAccountWithHeight to AccountRetriever
* update ADR
* address comments from review
2020-10-15 14:19:57 +00:00
Marie Gauthier
489599b70f
Remove the old message PublicKey proto oneof ( #7390 )
...
* Remove unused PublicKey type and update docs
* Update wording
* Update proto/cosmos/base/crypto/v1beta1/crypto.proto
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Edit docs
* Move crypto.proto to multisig
* Proto linting
* Update docs/architecture/adr-020-protobuf-transaction-encoding.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update wording for Public Key Encoding
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-09-29 10:01:54 +00:00
Amaury Martiny
7cd25abb87
Proto Tx with Any ( #7276 )
...
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Use anil's suggestion
* Add norace back
* Check nil
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Display StdTx instead of proto Tx
* Remove useless check
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-09-21 16:48:28 +00:00
Amaury Martiny
50bab8f820
Put AccountSequence in SignerInfo ( #6997 )
...
* WIP test the grounds
* Update ADR020
* Fix compile errors
* Fix ADR
* Make ante tests pass
* Fix remaining ante handler tests
* Simplify code
* Fix x/bank app_test
* Fix tests
* Remove useless accSeq from signerdata
* Fix test
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/auth/client/cli/tx_multisign.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Address rewview
* Update x/auth/ante/sigverify.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/ante/sigverify_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/direct_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* AccSeq -> Seq
* Address reviews
* Better variable naming
* Fix variable assign
* Remove old SetSignerInfo
* Fix test
* proto-gen
* Make proto-gen
* Reput gw comment
* Add Changelog
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
2020-08-21 14:20:47 +00:00
Simon Warta
1b9f144b9d
Propose ADR 027: Deterministic Protobuf Serialization ( #6979 )
...
* Add ADR 026: Protocol Buffer Regencode
* Use Regencode in ADR-020
* Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Add reasoning behind omitting empty fields
* Rename to ADR 026: Deterministic Protobuf Serialization
* i++
* explicitely -> explicitly
* Fix description of optional values
* Update reasoning behind omitting default values
* Fix empty -> defaut
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Add rules to avoid duplicate encoding and specify packed fields
* Add rule for variant encoding
* Add surrogate pair to test UTF-8 encoding
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-08-19 17:22:15 +00:00
Alexander Bezobchuk
6a7cf4442e
Merge PR #7006 : auth: Update AccountRetriever
2020-08-13 10:22:16 -04:00
Emmanuel T Odeke
c7c66f8b36
types: remove unused CanonicalSignBytes ( #6912 )
...
Removes all vestiges of CanonicalSignBytes, which is unused
and untested.
Fixes #6679
2020-08-02 15:13:41 +00:00
Simon Warta
b9f39c94f8
Merge PR #6359 : Updates to ADR-020 (protobuf signing)
2020-06-10 10:48:25 -04:00
SaReN
39f53ac22f
client: rename CliContext to Context ( #6290 )
...
* Refactor CliContext as Context
* Fix lint issues
* Fix goimports
* Fix gov tests
* Resolved ci-lint issues
* Add changelog
* Rename cliCtx to clientCtx
* Fix mocks and routes
* Add changelog
* Update changelog
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* merge client/rpc/ro{ot,utes}.go
* Update docs
* client/rpc: remove redundant client/rpc.RegisterRPCRoutes
* regenerate mocks
* Update ADRs
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-01 12:46:03 +00:00
Aaron Craelius
850419fffd
Tx CLI proto module interface ( #5989 )
...
* WIP
* WIP
* WIP on removing x/auth dependency from client/tx
* Revert unneeded changes
* Simplify cli tx UX
* Wire up bank tx REST routes
* Fix assignment issue
* Wire up bank NewSendTxCmd
* fix lint
* revert file
* revert file
* fix simcli
* Refactor AccountRetriever
* Fix build
* Fix build
* Fix build
* Fix integration tests
* Fix tests
* Docs, linting
* Linting
* WIP on all modules
* Implement other module new tx cmd's
* Fix cmd's
* Refactor existing GetTxCmd
* Fix cmd
* Removing deprecated code
* Update ADR 020 & CHANGELOG
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Fix client/tx tests
* Fix mocks
* Fix tests
* Lint fixes
* REST tx migration
* Wire up REST
* Linting
* Update CHANGELOG, docs
* Fix tests
* lint
* Address review feedback
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* group vars
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-21 21:29:34 +00:00
Aaron Craelius
40082b823f
Merge PR #6217 : Add pub key proto definitions
2020-05-14 16:45:19 -04:00
Aaron Craelius
32f82a93b8
Merge PR #6111 : Update ADR 020 to use Any
2020-05-13 15:33:52 -04:00
Aaron Craelius
58a6c4c007
Merge PR #5942 : Tx Client Migration: x/gov
2020-04-14 15:05:14 -04:00
Alexander Bezobchuk
c77b2b90bb
Update docs/architecture/adr-020-protobuf-transaction-encoding.md
...
Co-Authored-By: Aaron Craelius <aaron@regen.network>
2020-03-26 11:11:03 -04:00
Aleksandr Bezobchuk
e77d5cb677
Update ADR + changelog
2020-03-25 11:09:26 -04:00
Aleksandr Bezobchuk
f20db1c835
Update ADR
2020-03-25 11:03:36 -04:00
Aleksandr Bezobchuk
ef29fef514
Fix test and update ADR
2020-03-24 18:00:22 -04:00
Alexander Bezobchuk
e0021ad409
Update docs/architecture/adr-020-protobuf-transaction-encoding.md
...
Co-Authored-By: Marko <marbar3778@yahoo.com>
2020-03-16 10:48:37 -04:00
Aleksandr Bezobchuk
98f62db242
Fix linting
2020-03-15 14:10:15 -04:00
Aleksandr Bezobchuk
c49af0b8dd
Update context
2020-03-13 13:59:14 -04:00
Aleksandr Bezobchuk
690f6290c8
Update ADR
2020-03-13 09:35:14 -04:00
Aleksandr Bezobchuk
b38d3ae69a
Update ADR and types
2020-03-12 15:35:22 -04:00
Aleksandr Bezobchuk
34f9fc439a
Implement canonical signing
2020-03-12 13:32:03 -04:00
Aleksandr Bezobchuk
3a94f42e11
Implement app-level tx
2020-03-12 10:53:27 -04:00
Aleksandr Bezobchuk
9a78fc3b19
Address review
2020-03-09 09:49:30 -04:00