af689350c7
resolve #9284 comments
2021-05-17 18:00:42 +08:00
7b6794a27a
Update Stable Release Managers ( #9335 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-05-16 17:26:53 +00:00
25ecec6c15
rosetta: upgrade to newest version ( #9314 )
...
* feat: update rosetta sdk to v0.6.10
embed from v1.0.0 release branch of the library: https://github.com/tendermint/cosmos-rosetta-gateway/tree/release/v1.0.0
closes:
https://github.com/cosmos/cosmos-sdk/issues/9300
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-05-15 00:18:59 +02:00
925e63cf32
Minor doc fix ( #9328 )
2021-05-14 16:21:34 +00:00
bdb6005015
Merge branch 'shahan/adr-043-nft'
2021-05-14 12:05:39 +08:00
eb7d939f86
add feature CHANGELOG entry for grpc-web ( #9301 )
...
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-05-13 16:29:59 -07:00
8997074028
Use module accounts in MsgSend and MsgMultiSend tests in bank module ( #9075 )
...
* first draft
* unable to cast to simtypes.Account
* fix test
* add for loop in TestSimulateModuleAccountMsgSend
* TestSimulateModuleAccountMsgMultiSend
* refactoring, r4r
* change fromSimAcc, toSimAcc to from,to respectively
* Update x/bank/simulation/operations.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update x/bank/simulation/operations.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* getModuleAccounts
* fix for loop
* applied reviewers suggestions, r4r
* Update x/bank/simulation/operations.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* minor changes
* fix typo
* all simulation package tests pass, r4r
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-13 13:51:21 +00:00
f2cea6a137
doc: Updates related to ServiceMsg, sdk.Msg and Msg service ( #9294 )
...
* doc: Updates related to ServiceMsg, sdk.Msg and Msg service
* Apply suggestions from code review
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
* remove one more ServiceMsg
* Use service method rathr than service RPC
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-12 15:47:54 +00:00
d7dd1d7aff
Fixed parse key issue ( #9299 )
...
* Fixed parse key issue
* Added getconfig in root command
* uncommented changes in parse.go
2021-05-12 15:19:27 +00:00
b4125d1f0c
Update x/auth AnteHandler Spec ( #9298 )
...
* Update auth antehandler spec
* Update x/auth/spec/03_antehandlers.md
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
* Update x/auth/spec/03_antehandlers.md
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
* Update x/auth/spec/03_antehandlers.md
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
* Use 1 line
* Use backticks
* Use consistent tx naming
* Fix grammar
* Update module naming
* Update x/auth/spec/03_antehandlers.md
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-12 09:10:11 +00:00
213c46bb17
build(deps): bump actions/stale from 3 to 3.0.18 ( #9311 )
...
Bumps [actions/stale](https://github.com/actions/stale ) from 3 to 3.0.18.
- [Release notes](https://github.com/actions/stale/releases )
- [Commits](https://github.com/actions/stale/compare/v3...v3.0.18 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-12 04:49:50 -04:00
4631794455
update labeler.yml with shortened labels ( #9303 )
2021-05-11 17:34:20 -04:00
e79157c067
Update doc for IterateAccounts x/auth keeper meethod ( #9285 )
...
Co-authored-by: Lazar Ivanovic <livanovic@happiestbaby.com>
2021-05-11 21:13:31 +00:00
f1de92fef0
ADR-040: Storage and SMT State Commitments ( #8430 )
...
* ADR-040: Storage and SMT State Commitments
* Update docs/architecture/adr-040-storage-and-smt-state-commitments.md
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
* Update docs/architecture/adr-040-storage-and-smt-state-commitments.md
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
* Added more details for snapshotting and pruning.
* updated links and references
* add blockchains which already use SMT
* reorganize versioning and pruning
* Update docs/architecture/adr-040-storage-and-smt-state-commitments.md
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
* Update docs/architecture/adr-040-storage-and-smt-state-commitments.md
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
* adding a paragraph about state management
* adr-40: update 'accessing old state' section
* update based on all recent discussions and validations
* adding more explanation about KV interface
* Apply suggestions from code review
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Marko <marbar3778@yahoo.com>
* Apply suggestions from code review
Co-authored-by: Marko <marbar3778@yahoo.com>
* review comments
* adding paragraph about commiting to an object without storying it
* review updates
* Apply suggestions from code review
Co-authored-by: Roy Crihfield <30845198+roysc@users.noreply.github.com>
* review udpates
* adding clarification
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Roy Crihfield <30845198+roysc@users.noreply.github.com>
2021-05-11 16:45:29 -04:00
8cfa2c2673
x/authz: simulation audit changes ( #9107 )
...
* addressing audit changes
* address simulation genesis changes
* address simulation operations changes
* fix tests
* typo
* add more authorizations to operations
* fix tests
* fix failing simulations
* WIP
* WIP
* testing simulations
* test simulations
* try fixing tests
* WIP
* fix error
* test
* Add exec authorization
* WIP
* WIP
* fix tests
* WIP
* WIP
* WIP
* WIP
* WIP
* fix errors
* fix test
* WIP
* try fix test
* update tests
* fix errors
* add exec authorization
* fix docs
* fix test
* fix error
* try fixing simulation
* fix errors
* fixing simulations
* fix errors
* rename GenTx -> GenerateTx
* Update x/authz/simulation/genesis.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update x/authz/simulation/genesis.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update x/authz/simulation/operations.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* review changes
* fix tests
* rename GenerateTx => GenTx
* remove Authorization suffix
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
2021-05-11 15:33:33 +00:00
56c0595f32
Remove migration scripts <=0.38 ( #9291 )
...
* Remove migration scripts <=0.38
* Add changelog
* remove more
* remove more stuff
* Fix test
* Relase wording
* Add comment
* Include migratio wording
2021-05-11 14:01:13 +00:00
300d2a7fd4
v043 audit changes for version ( #9296 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-11 13:08:23 +00:00
505cb83206
0.43 aidut changes for client module ( #9295 )
...
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-05-11 12:44:10 +00:00
28c2ce0b53
v043 audit changes for telemetry/ ( #9297 )
...
* v043 audit changes for version
* v042 audit changes for telemetry
* remove version changes in telemetry audit
2021-05-11 12:28:47 +00:00
3a774cf0d1
build(deps): bump github.com/armon/go-metrics from 0.3.7 to 0.3.8 ( #9248 )
...
Bumps [github.com/armon/go-metrics](https://github.com/armon/go-metrics ) from 0.3.7 to 0.3.8.
- [Release notes](https://github.com/armon/go-metrics/releases )
- [Commits](https://github.com/armon/go-metrics/compare/v0.3.7...v0.3.8 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-11 09:03:24 +00:00
025d072ff1
Crypto v0.43 Audit updates ( #9292 )
...
* fix tests
* calculate fieldSize for esdca test
* remove require declaration for consistency
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
2021-05-10 19:06:17 -04:00
6c923d39be
Adding specifications to NFT fields and clarity on usage.
2021-05-10 15:35:30 -04:00
38762621a3
Merge branch 'master' into master
2021-05-10 11:50:18 -07:00
709ab089c1
x/bank v0.43 Audit updates ( #9271 )
...
* add godoc to keeper functions
* re-add ValidateBasic to MsgSend CLI tx
* add comment to reflect new return value on method
* remove unecessary variable
* cleanup key comments
* typo
* unused param
* update messages spec
* move event emission to end of method
* update keeper spec
* update proto message to point correct path to interface
* keeper spec typos
* fix test for event emission being moved
* change to blocklist
* rename SendEnabledCoin(s) -> IsSendEnabledCoins
* typo
* remove unecessary check
* move changelog line
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
2021-05-10 12:17:55 -04:00
75d3547e80
build(deps): bump github.com/otiai10/copy from 1.5.1 to 1.6.0 ( #9289 )
...
Bumps [github.com/otiai10/copy](https://github.com/otiai10/copy ) from 1.5.1 to 1.6.0.
- [Release notes](https://github.com/otiai10/copy/releases )
- [Commits](https://github.com/otiai10/copy/compare/v1.5.1...v1.6.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-10 14:03:11 +00:00
6425825cac
ADR-042: Group module ( #9089 )
...
* Add ADR-042
* Fix link
* Small improvements
* Update link
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
* Update docs/architecture/adr-042-group-module.md
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
* Update docs/architecture/adr-042-group-module.md
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-042-group-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Move orm to specific section
* Update docs/architecture/adr-042-group-module.md
* Update naming
* Add concrete use cases
* Rework ### Proposal
* Rework Vote, Exec and implementation sections
* Update to account for removal of ServiceMsg
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-10 12:53:47 +00:00
e96839de2f
x/staking v0.43 Audit updates ( #9267 )
...
* update staking specs
* use gosimple code in x/staking/client/testutil/suite.go
* small fixes
* add godoc to methods in msg_server and grpc_query
* changes to godoc and small fixes
* remove unnecessary lines
* remove mentions of serviceMsg and avoid having slash after Msg
2021-05-10 12:41:24 +00:00
9038dfe3b6
authz: Update MsgGrant proto ( #9280 )
...
* adding GetAuthorization test
* update MsgGrant proto
* update comment
2021-05-10 09:28:08 +00:00
8701e97c65
Add ADR-043 BaseNFT Module
2021-05-08 07:00:58 +00:00
b635ae2090
Update docs for building modules ( #9272 )
...
* update example structure
* update example structure
* update module errors path
* update paths and fix typos
* update paths and fix typos
* update example structure
* address review comments
2021-05-07 18:13:06 -04:00
3e4d81c3d3
Fix proto format ( #9279 )
...
* makefile: fix proto-format
* reformat all proto files
* regenerating proto
* remove dangling semicolon
2021-05-07 21:33:17 +00:00
1986104ef4
ADR-30 (authz) update based on authz audit ( #9270 )
...
* ADR-30 (authz) update based on authz audit
* changelog and comment update
* fix linter issue
* Apply suggestions from code review
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* Update MsgGrant to reuse the Grant type
* Update docs/architecture/adr-030-authz-module.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-05-07 19:38:43 +00:00
5725659684
x/gov v0.43 Audit updates ( #9258 )
...
* Update gov tx usage
* Update proto
* make proto-gen
* Add deposit test
* Rename test function
* More audits
* Update x/gov/keeper/internal_test.go
* Update x/gov/spec/01_concepts.md
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
2021-05-07 12:00:19 +00:00
4af85dc1a3
router: fix handler name ( #9281 )
2021-05-07 12:37:55 +02:00
56ab4e4c93
Cleanup remains of ServiceMsg ( #9236 )
...
* Remove ServiceMsgClientConn from CLI
* Cleanup Operations
* Remove some legacytx.LegacyMsg
* Update CL
* Remove mentions of ServiceMsg
* Simply reflection MsgDescriptor
* Simplify more
* Add code comment
Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>
2021-05-07 09:31:20 +00:00
9899ae056a
build(deps): bump codecov/codecov-action from v1.4.1 to v1.5.0 ( #9256 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from v1.4.1 to v1.5.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v1.4.1...a1ed4b322b4b38cb846afb5a0ebfa17086917d27 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-05-07 11:16:27 +02:00
3582ccef7c
Move x/feegrant/types to x/feegrant ( #9273 )
...
* Move x/feegrant/types to x/feegrant
* Update spec
* Use feegrantmodule
2021-05-07 07:10:47 +00:00
59810f3286
x/authz: audit updates ( #9042 )
...
* x/authz: audit updates
* audit with Aaron
* authz: Update Authorization.Accept method
* authz: add event proto definitions
* update query service
* authz: use typed events
* refactore and rename query authorizations
* remve Authorization infix from proto services
* renames wip
* refactoring
* update tests
* fix compilation
* fixing gRPC query tests
* fix simulation tests
* few renames
* more refactore
* add missing file
* moving export genesis to keeper
* Update docs
* update tests
* rename event Msg attribute to MsgTypeURL
* Upate Authorization interface
* rollback Makefile changes
* fix tests
* Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
* renames
* refactore authz/exported
* lint fix
* authz/types refactore
* comment update
* conflict updates
* Apply suggestions from code review
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* authz: move storage keys to keeper
* review updates
* docs update
* Update x/authz/client/cli/query.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* move codec to the root package
* authz CMD info update
* comment update
* update imports and build flags
* fix functional tests
* update proto comment
* fix tests
* fix test
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-05-06 18:23:48 +00:00
4f306fca4d
store/cachekv: reduce allocation with []byte -> string in map keys ( #9275 )
...
Uses internal/conv throughout store/kv which shows performance gains.
Benchmark for store/cachekv:
name old time/op new time/op delta
CacheKVStoreIterator500-8 23.4µs ± 1% 23.3µs ± 1% ~ (p=0.095 n=5+5)
CacheKVStoreIterator1000-8 46.7µs ± 1% 46.2µs ± 0% -0.96% (p=0.008 n=5+5)
CacheKVStoreIterator10000-8 457µs ± 1% 455µs ± 1% ~ (p=1.000 n=5+5)
CacheKVStoreIterator50000-8 2.59ms ± 2% 2.47ms ± 1% -4.64% (p=0.008 n=5+5)
CacheKVStoreIterator100000-8 7.33ms ± 3% 6.91ms ± 1% -5.75% (p=0.008 n=5+5)
CacheKVStoreGetNoKeyFound-8 423ns ± 1% 391ns ± 2% -7.41% (p=0.008 n=5+5)
CacheKVStoreGetKeyFound-8 267ns ± 3% 264ns ± 2% ~ (p=0.595 n=5+5)
name old alloc/op new alloc/op delta
CacheKVStoreIterator500-8 5.18kB ± 0% 5.18kB ± 0% ~ (all equal)
CacheKVStoreIterator1000-8 9.29kB ± 0% 9.29kB ± 0% ~ (p=0.079 n=4+5)
CacheKVStoreIterator10000-8 85.2kB ± 0% 84.9kB ± 0% -0.30% (p=0.008 n=5+5)
CacheKVStoreIterator50000-8 468kB ± 1% 458kB ± 0% -2.17% (p=0.008 n=5+5)
CacheKVStoreIterator100000-8 1.16MB ± 1% 1.10MB ± 0% -5.34% (p=0.008 n=5+5)
CacheKVStoreGetNoKeyFound-8 222B ± 1% 214B ± 0% -3.78% (p=0.008 n=5+5)
CacheKVStoreGetKeyFound-8 51.0B ± 0% 51.0B ± 0% ~ (all equal)
name old allocs/op new allocs/op delta
CacheKVStoreIterator500-8 13.0 ± 0% 13.0 ± 0% ~ (all equal)
CacheKVStoreIterator1000-8 13.0 ± 0% 13.0 ± 0% ~ (all equal)
CacheKVStoreIterator10000-8 51.0 ± 0% 43.0 ± 0% -15.69% (p=0.008 n=5+5)
CacheKVStoreIterator50000-8 1.22k ± 4% 0.94k ± 1% -23.04% (p=0.008 n=5+5)
CacheKVStoreIterator100000-8 6.48k ± 4% 4.85k ± 1% -25.12% (p=0.008 n=5+5)
CacheKVStoreGetNoKeyFound-8 5.00 ± 0% 4.00 ± 0% -20.00% (p=0.008 n=5+5)
CacheKVStoreGetKeyFound-8 2.00 ± 0% 2.00 ± 0% ~ (all equal)
Benchmark for x/auth/keeper:
name old time/op new time/op delta
AccountMapperGetAccountFound-8 1.27µs ± 3% 1.26µs ± 1% ~ (p=0.270 n=5+5)
AccountMapperSetAccount-8 3.53µs ± 0% 3.44µs ± 1% -2.59% (p=0.008 n=5+5)
name old alloc/op new alloc/op delta
AccountMapperGetAccountFound-8 440B ± 0% 440B ± 0% ~ (all equal)
AccountMapperSetAccount-8 2.13kB ± 0% 2.08kB ± 0% -2.31% (p=0.008 n=5+5)
name old allocs/op new allocs/op delta
AccountMapperGetAccountFound-8 10.0 ± 0% 10.0 ± 0% ~ (all equal)
AccountMapperSetAccount-8 42.0 ± 0% 38.0 ± 0% -9.52% (p=0.008 n=5+5)
Fixes #9274
2021-05-06 06:33:01 -07:00
2eeb464939
Update `memo` usage docs ( #9265 )
...
* Update `memo` usage docs
* update doc
Co-authored-by: Aaron Craelius <aaron@regen.network>
* update doc
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-05-06 08:47:02 +00:00
d9b20122d5
x/staking: lazily get consensus key address ( #9264 )
2021-05-05 11:28:37 -07:00
1e1c812de2
x/feegrant remove height base expiration ( #9206 )
...
* remove height from proto files
* remove PrepareForExport
* fix basic fee
* fix periodic fee
* fix errors
* fix error
* fix errors
* add tests
* review changes
* fix errors
* fix tests
* fix lint error
* Update x/feegrant/types/basic_fee.go
Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>
* fix errors
* fix keeper tests
* Update x/feegrant/keeper/keeper_test.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* review changes
* review changes
* fix tests
* run make proto-gen
* fix errors
* Update x/feegrant/keeper/keeper_test.go
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
* Update x/feegrant/keeper/keeper_test.go
* update ADR
* add test
* review changes
* review changes
Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-05 16:29:22 +00:00
68d461052b
add sorted check for the coins sub/add fun parameter ( #9240 )
...
* add sorted check for the coins sub/add fun parameter
* adding internal tests
* fix tests
* docs update
* add self sorted check
* add unit test for self sorted check
* adding a comment
* review updates
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-05 15:55:28 +00:00
42a4e4b432
x/bank/types: speedy up by singly sort balances without having to re-iterate ( #9260 )
...
The speed is the same as old implementation, but the new one uses slightly
less memory and make the code easier to maintain.
name old time/op new time/op delta
SanitizeBalances500-8 933µs ± 1% 935µs ± 1% ~ (p=0.400 n=9+10)
SanitizeBalances1000-8 1.91ms ± 0% 1.92ms ± 0% +0.58% (p=0.000 n=10+10)
name old alloc/op new alloc/op delta
SanitizeBalances500-8 588kB ± 0% 556kB ± 0% -5.41% (p=0.000 n=9+9)
SanitizeBalances1000-8 1.18MB ± 0% 1.12MB ± 0% -5.37% (p=0.000 n=9+9)
name old allocs/op new allocs/op delta
SanitizeBalances500-8 5.02k ± 0% 4.02k ± 0% -19.94% (p=0.000 n=10+10)
SanitizeBalances1000-8 10.0k ± 0% 8.0k ± 0% -19.93% (p=0.000 n=9+10)
Fixes #9259
2021-05-05 14:36:25 +00:00
bb1b331690
bump iavl to 0.16.0 ( #9261 )
2021-05-05 13:46:51 +00:00
e3e89f5260
Rename memo to note inside CLI ( #9134 )
...
* rename Memo to note
* update change log
* typo
* address review changes
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-05-04 09:00:54 +00:00
3e6c4a6c79
types: make chopPrecisionAndTruncate always non-mutative ( #9250 )
...
Currently, chopPrecisionAndTruncate/chopPrecisionAndTruncateNonMutative
are doing the same thing, except that the former do it mutatively.
Looking at the usages of chopPrecisionAndTruncate, the callers must
alloc a new big.Int before calling it anyway, so any mutation will be
done with this new allocated big.Int, instead of input argument.
So, by making chopPrecisionAndTruncate always non-mutative, we simplify
the code, and make the code faster, less allocation in some benchmarks.
Benchmark for github.com/cosmos/cosmos-sdk/types:
name old time/op new time/op delta
CoinsAdditionIntersect/sizes:_A_1,_B_1-8 35.4ns ± 0% 35.1ns ± 0% -0.92% (p=0.008 n=5+5)
CoinsAdditionIntersect/sizes:_A_5,_B_5-8 366ns ± 1% 363ns ± 1% ~ (p=0.056 n=5+5)
CoinsAdditionIntersect/sizes:_A_5,_B_20-8 557ns ± 0% 553ns ± 0% -0.64% (p=0.008 n=5+5)
CoinsAdditionIntersect/sizes:_A_1,_B_1000-8 6.17µs ± 0% 6.18µs ± 0% ~ (p=0.151 n=5+5)
CoinsAdditionIntersect/sizes:_A_2,_B_1000-8 6.30µs ± 0% 6.32µs ± 0% +0.23% (p=0.008 n=5+5)
CoinsAdditionNoIntersect/sizes:_A_1,_B_1-8 30.2ns ± 0% 29.9ns ± 1% -0.98% (p=0.008 n=5+5)
CoinsAdditionNoIntersect/sizes:_A_5,_B_5-8 226ns ± 0% 224ns ± 0% -0.54% (p=0.008 n=5+5)
CoinsAdditionNoIntersect/sizes:_A_5,_B_20-8 373ns ± 0% 372ns ± 0% -0.26% (p=0.040 n=5+5)
CoinsAdditionNoIntersect/sizes:_A_1,_B_1000-8 6.21µs ± 0% 6.22µs ± 0% ~ (p=0.421 n=5+5)
CoinsAdditionNoIntersect/sizes:_A_2,_B_1000-8 6.22µs ± 0% 6.23µs ± 0% ~ (p=0.286 n=5+5)
CoinsAdditionNoIntersect/sizes:_A_1000,_B_2-8 6.22µs ± 0% 6.23µs ± 0% ~ (p=0.143 n=5+5)
ParseCoin-8 5.46µs ± 0% 5.39µs ± 0% -1.26% (p=0.008 n=5+5)
UintMarshal-8 1.01µs ± 0% 1.00µs ± 0% -1.10% (p=0.008 n=5+5)
IntMarshal-8 764ns ± 0% 758ns ± 1% -0.79% (p=0.024 n=5+5)
MarshalTo-8 192ns ± 0% 190ns ± 0% -1.03% (p=0.008 n=5+5)
name old alloc/op new alloc/op delta
CoinsAdditionIntersect/sizes:_A_1,_B_1-8 32.0B ± 0% 32.0B ± 0% ~ (all equal)
CoinsAdditionIntersect/sizes:_A_5,_B_5-8 520B ± 0% 520B ± 0% ~ (all equal)
CoinsAdditionIntersect/sizes:_A_5,_B_20-8 1.38kB ± 0% 1.38kB ± 0% ~ (all equal)
CoinsAdditionIntersect/sizes:_A_1,_B_1000-8 49.2kB ± 0% 49.2kB ± 0% ~ (all equal)
CoinsAdditionIntersect/sizes:_A_2,_B_1000-8 49.3kB ± 0% 49.3kB ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_1,_B_1-8 24.0B ± 0% 24.0B ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_5,_B_5-8 488B ± 0% 488B ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_5,_B_20-8 1.35kB ± 0% 1.35kB ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_1,_B_1000-8 49.2kB ± 0% 49.2kB ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_2,_B_1000-8 49.2kB ± 0% 49.2kB ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_1000,_B_2-8 49.2kB ± 0% 49.2kB ± 0% ~ (all equal)
ParseCoin-8 2.21kB ± 0% 2.21kB ± 0% ~ (all equal)
UintMarshal-8 392B ± 0% 392B ± 0% ~ (all equal)
IntMarshal-8 168B ± 0% 168B ± 0% ~ (all equal)
MarshalTo-8 80.0B ± 0% 80.0B ± 0% ~ (all equal)
name old allocs/op new allocs/op delta
CoinsAdditionIntersect/sizes:_A_1,_B_1-8 1.00 ± 0% 1.00 ± 0% ~ (all equal)
CoinsAdditionIntersect/sizes:_A_5,_B_5-8 12.0 ± 0% 12.0 ± 0% ~ (all equal)
CoinsAdditionIntersect/sizes:_A_5,_B_20-8 14.0 ± 0% 14.0 ± 0% ~ (all equal)
CoinsAdditionIntersect/sizes:_A_1,_B_1000-8 3.00 ± 0% 3.00 ± 0% ~ (all equal)
CoinsAdditionIntersect/sizes:_A_2,_B_1000-8 6.00 ± 0% 6.00 ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_1,_B_1-8 1.00 ± 0% 1.00 ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_5,_B_5-8 5.00 ± 0% 5.00 ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_5,_B_20-8 6.00 ± 0% 6.00 ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_1,_B_1000-8 3.00 ± 0% 3.00 ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_2,_B_1000-8 4.00 ± 0% 4.00 ± 0% ~ (all equal)
CoinsAdditionNoIntersect/sizes:_A_1000,_B_2-8 3.00 ± 0% 3.00 ± 0% ~ (all equal)
ParseCoin-8 71.0 ± 0% 71.0 ± 0% ~ (all equal)
UintMarshal-8 25.0 ± 0% 25.0 ± 0% ~ (all equal)
IntMarshal-8 18.0 ± 0% 18.0 ± 0% ~ (all equal)
MarshalTo-8 2.00 ± 0% 2.00 ± 0% ~ (all equal)
name old speed new speed delta
UintMarshal-8 6.91MB/s ± 0% 6.99MB/s ± 0% +1.04% (p=0.008 n=5+5)
IntMarshal-8 9.16MB/s ± 0% 9.23MB/s ± 1% +0.83% (p=0.032 n=5+5)
Benchmark for github.com/cosmos/cosmos-sdk/x/mint/types:
name old time/op new time/op delta
BlockProvision-8 263ns ± 0% 257ns ± 0% -2.23% (p=0.008 n=5+5)
name old alloc/op new alloc/op delta
BlockProvision-8 112B ± 0% 104B ± 0% -7.14% (p=0.008 n=5+5)
name old allocs/op new allocs/op delta
BlockProvision-8 6.00 ± 0% 5.00 ± 0% -16.67% (p=0.008 n=5+5)
Fixes #9249
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
2021-05-04 00:32:15 +01:00
a3feeed665
docs: x/distribution spec ( #8928 )
...
* EndBlock => BeginBlock
* Add high-level algorithm
* Update documentation on params invariant
* Comment fix
* Update and extend BeginBlock documentation
* Update hooks documentation
* New intro to the concepts
* Update messages documentation
* Write in full sentences
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* spelling error
* change link
* slashing spec clarification
* Revert "slashing spec clarification"
This reverts commit b08b5a8533ca9d355a0afb0e58254b95487ce880.
* Update x/distribution/spec/04_messages.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update x/distribution/spec/03_begin_block.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update link to latest version
* Update x/distribution/spec/04_messages.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* clarify note on removed validator
* clarify validator removed hook
* clarify validator created hook
* clarify delegation modified/created hook
* clarify slash hook
* clarify possesive singular situation
* clarify hooks.go
* Move comment to clearer position
* Update x/distribution/spec/01_concepts.md
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
* clarifications in concepts file
* Clarify introductory paragraphs
* communitytax => community_tax
* Apply suggestions from code review
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update delegator rewards descirption
* Remove "this"
* Fix error in non-proposer validator rewards spec
* Clarify validator rewards high level description
* Update x/distribution/spec/04_messages.md
* Clarify what fees are
* Misc grammar and style fixes
* Apply suggestions from code review
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
* Apply suggestions from code review
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
2021-05-03 18:40:34 +00:00
d19791be89
Rename clientCtx.JSONMarshaler to JSONCodec ( #9251 )
...
* Rename clientCtx.JSONMarshaler to JSONCodec
* change md files
* Fix lint
2021-05-03 14:45:47 +00:00
d3bcc15b11
x/feegrant API Audit changes ( #9194 )
...
* -add comments to proto fields
-add comments to msg and query server
-remove decorator from docs
-add coments to msgs.go
-remove decorator from godoc
* Update x/feegrant/spec/04_events.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* refactor and add to docs
*refactor proto msg names and functions
*add docs pertaining to auth's ante handler for deducted fees
* lint
* update comment
* gofmt
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-03 12:34:48 +00:00
chengwenxi
Robert Zaremba
Andrea Giacobino
Shahan Khatchadourian
Cory
Andrei Ivasko
Prathyusha Lakkireddy
Marie Gauthier
dependabot[bot]
Aaron Craelius
l-parabellum
MD Aleem
Amaury
likhita-809
technicallyty
HackMD
Ryan Christoffersen
Cuong Manh Le
Anil Kumar Kammari
Rikard Hjort