Commit Graph

5 Commits

Author SHA1 Message Date
Alessio Treglia 1f211aad57
types: keep migrating tests to test suites (#7478)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-08 11:42:32 +00:00
Alessio Treglia 0ba4e3a630
types/errors: make Wrap() work like github.com/pkg/errors.Wrap
Wrap(ErrInsufficientFunds, "40 < 500") returns strings like
"insufficient funds: 40 < 50". Although he function syntax
fits perfectly SDK app developers use case and as such it
should not be changed, the interface is still counter-intuitive
as most Golang developers may reasonably expect a different
result similar to what other popular libraries' (see [1])
would produce (e.g. "40 < 500: insufficient funds").

Follow up PR of #5876.

[1] https://godoc.org/github.com/pkg/errors#Wrapf
2020-03-28 00:19:44 +01:00
Alexander Bezobchuk 9a183ffbcc
Merge PR #5421: Refactor Error Handling 2019-12-27 12:57:54 -05:00
Marko b9490f2d93 Merge PR #5203: Add more linters 2019-10-17 09:47:35 -04:00
Ethan Frey 68dd969b4d Merge PR #4821: Port weave errors package 2019-07-31 12:37:11 -04:00