b34ceecd8a
test: Added tests for DecCoins to increase code coverage ( #9752 )
...
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->
## Description
Ref: #7031
<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->
Note/todo :
1. Not sure if [this](https://github.com/cosmos/cosmos-sdk/blob/spoorthi/7031-deccoins-adding-tests/types/dec_coin.go#L631 ) line is reachable. The condition is already checked in [this ](https://github.com/cosmos/cosmos-sdk/blob/spoorthi/7031-deccoins-adding-tests/types/dec_coin.go#L618 ) line. Therefore, 100% coverage for `ParseDecCoin` function likely not possible
2. Clarification needed [here](https://github.com/cosmos/cosmos-sdk/blob/spoorthi/7031-deccoins-adding-tests/types/dec_coin_test.go#L883-L884 )
3. Clarification needed [here](https://github.com/cosmos/cosmos-sdk/blob/spoorthi/7031-deccoins-adding-tests/types/dec_coin_test.go#L1124-L1125 )
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting ))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules )
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing )
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc )
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2021-07-26 20:51:22 +00:00
54201d11e6
cli: convert coins to smallest unit registered ( #7777 )
...
* cli: convert coins to smallest unit registered
fixes : #7623
- test order of decimal operations
- support both int and decimal coins, truncate when normalizing to
base unit
* Update types/coin_test.go
* Update types/coin_test.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-16 11:34:54 +00:00
1f211aad57
types: keep migrating tests to test suites ( #7478 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-08 11:42:32 +00:00
ddaa3c5176
types: tests -> test suites migration ( #7405 )
2020-09-29 13:29:10 +02:00
04ff40a8df
types: start grouping tests in test suites ( #7395 )
...
Ref #7362
2020-09-27 23:51:14 +02:00
30f9862b4b
Remove zero coins from ParseCoins and ParseDecCoins ( #7348 )
...
* Remove zero coins from ParseCoins and ParseDecCoins
* Implement requested changes
* Update types/coin_test.go
* Revert
* Align the behaviour of NewCoins and ParseCoins (respectively NewDecCoins and ParseDecCoins)
* Amend comments
* Update types/dec_coin.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-09-25 08:31:31 +00:00
1b08e1032c
types: update coin regex ( #7027 )
...
* types: update coin regex
* more tests
* fix test case
* increase coverage
* changelog
* fix tests
* support unicode letters and numbers
* remove ToUpper
* Update types/coin.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Validate function
* fix ICS20 test
* table tests and revert unicodes
* add test case
* add test cases and comment
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-08-14 09:09:53 +00:00
282afcdb12
Fix for 6786 removeZeroCoins mutates original slice ( #6811 )
...
* added test cases to show errors identified in 6786
* mods to fix remove zero coin mutation in slice
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-28 10:17:58 +00:00
066dd1114f
Merge PR #5449 : Add New constructor for the DecCoin
2020-01-03 15:44:53 -05:00
fb0a2c46d3
fix DecCoins constructor ( #5410 )
...
* fix decCoins
* minor changes for standardization
* changelog
* add test cases
2019-12-16 19:10:18 -03:00
b9490f2d93
Merge PR #5203 : Add more linters
2019-10-17 09:47:35 -04:00
576eb51928
Merge PR #4058 : Fix DecCoins Bugs
2019-04-05 14:13:22 -04:00
5f92fef4b0
Fix TruncateDecimal ( #3913 )
2019-03-16 16:14:37 -07:00
4c50380181
Merge PR #3750 : Outstanding per-validator rewards; correctly handle same-BeginBlock redelegation-double-slash
2019-03-06 19:54:12 +01:00
7e08b62f4e
Merge PR #3726 : Cap(clip) reward to remaining coins in AllocateTokens
2019-02-27 21:38:57 +01:00
a814e5ce66
Merge PR #3679 : Consistent Operators
...
* Minus->Sub Plus->Add Div->Quo
* pending
* Update PENDING.md
Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>
* fix
* typo
2019-02-21 12:35:55 -05:00
26c13b28cd
Merge PR #3607 : Reconcile DecCoin/s API with Coin/s API
2019-02-15 16:33:23 +01:00
36d1736a08
Refactor Gas/Fee Model ( #3258 )
2019-01-18 08:45:20 -08:00
2942f83ff5
Merge PR #3099 : F1 fee distribution
2019-01-16 22:38:05 +01:00
Spoorthi Satheesha
yihuang
Alessio Treglia
dauTT
Federico Kunze
Ira Miller
Ferenc Fabian
Marko
Alexander Bezobchuk
Christopher Goes
Jae Kwon
frog power 4000