feed37dc56
ADR-038 Part 1: WriteListener, listen.KVStore, MultiStore and KVStore updates ( #8551 )
...
* StoreKVPair protobuf message definition and generated go types
* store WriteListener
* update MultiStore, CacheWrap, CacheWrapper interfaces
* adjust KVStores to fit new CacheWrapper interface
* new ListenKVStore
* adjust multistores to fit new MultiStore interface and enable wrapping returned KVStores with the new ListenKVStore
* typo fixes in adr
* ListenKV Store test
* update server mock KVStore and MultiStore
* multistore unit test; fix multistore constructor
* update changelog
* fix bug identified in CI
* improve codecov, minor fixes/adjustments
* review fixes
* review updates; flip set to delete in KVStorePair, updated proto-docs from running 'make proto-gen'
2021-03-30 16:13:51 -04:00
823620c231
docs: update bech32 account docs ( #9006 )
...
* docs: update bech32 account docs
* docs: update other places for bech32 and pubkeys
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-03-29 11:22:30 +00:00
5a142db6f0
Fix broken ICS links on ADR001 ( #8971 )
...
Docs have moved to IBC repo
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-03-25 07:20:28 +00:00
5b10af48c6
Fix broken relative link in ADR033 ( #8977 )
...
* Fix broken relative link in ADR033
Replaced with absolute URL
* Update docs/architecture/adr-033-protobuf-inter-module-comm.md
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2021-03-25 07:12:42 +00:00
863d7d033f
Fix broken links to ICS specs ( #8972 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-03-24 10:23:31 +00:00
c0d306ba50
Fix link to ICS007 on ADR026 ( #8976 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-03-24 10:16:10 +00:00
4a93db78dc
Fix broken links to ICS26 in ADR015 ( #8974 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-03-24 09:23:00 +00:00
c45775475a
Fix link to ICS2 on ADR017 ( #8975 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-03-24 08:30:00 +00:00
5bd93bfe7b
x/upgrade: added consensus version tracking (part of ADR-041) ( #8743 )
...
* -added consensus version tracking to x/upgrade
* -added interface to module manager -added e2e test for migrations using consensus version store in x/upgrade -cleaned up x/upgrade Keeper -handler in apply upgrade now handles errors and setting consensus versions -cleaned up migration map keys -removed init chainer method -simapp now implements GetConsensusVersions to assist with testing
* Changed MigrationMap identifier to VersionMap
removed module_test
* updated docs
* forgot this
* added line to changelog for this PR
* Change set consensus version function to match adr 041 spec
* add documentation
* remove newline from changelog
unnecessary newline removed
* updated example in simapp for RunMigrations, SetCurrentConsensusVersions now returns an error
* switch TestMigrations to use Require instead of t.Fatal
* Update CHANGELOG.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* docs for SetVersionManager
* -init genesis method added -removed panics/fails from setting consensus versions
* update identifiers to be more go-like
* update docs and UpgradeHandler fnc sig
* Upgrade Keeper now takes a VersionMap instead of a VersionManager interface
* upgrade keeper transition to Version Map
* cleanup, added versionmap return to RunMigrations
* quick fix
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* remove support for versionmap field on upgrade keeper
* cleanup
* rename get/set version map keeper functions
* update adr doc to match name changes
* remove redudant line
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-03-19 22:01:29 +00:00
cc1db18df5
doc secp256r1 ( #8899 )
...
* Update docs for things related to secp256r1
* docs: update accounts and pubkey documentation
* update table formatting
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Apply suggestions from code review
Awesome grammar fixes and style improvements
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
* Apply suggestions from code review
Awesome grammar and style improvements.
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* hd wallet docs update
* Apply suggestions from code review
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
* Update docs/basics/accounts.md
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* Update docs/architecture/adr-020-protobuf-transaction-encoding.md
I agree, let's use "and"
* update code snippet links
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-03-19 14:22:59 +00:00
1a4418b32b
Docs: Anys Usage, Events & small cleanups ( #8895 )
...
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-03-17 12:15:20 +00:00
6ac8898fec
Move all migration scripts to v043 ( #8814 )
...
* Move all migration scripts to v043
* Fix permaling
* Fix test
* Fix test again
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-03-08 22:36:06 +00:00
95fa768671
ADR 041: In-Place Store Migrations ( #8646 )
...
* Initial draft
* Draft
* Add x/upgrade stuff
* Tweaks
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
* Reviews
* Use migrator
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* More fixes
* Add grpc, use functions
* Add special case with 0 version
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/architecture/adr-041-in-place-store-migrations.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Remove useless err return
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-03-04 17:28:35 +00:00
c0fd863ef1
Merge branch 'master' into adr-epoched-staking
2021-02-25 21:48:57 -06:00
19e79e00d6
ADR-019/020 cleanups: HybridCodec, Pubkey ( #8683 )
...
* wip adr019
* Remove hybrid codec
* Change date
* Update docs/architecture/adr-019-protobuf-state-encoding.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update pubkey interface
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-25 15:40:04 +00:00
06ababdf36
ADR-033 cosmetic updates ( #8676 )
...
* ADR-033 cosmetic updates
* Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
* remove invoker middleware framing
* Update NewFooMsgServer
* Update docs/architecture/adr-033-protobuf-inter-module-comm.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/architecture/adr-033-protobuf-inter-module-comm.md
Co-authored-by: Cory <cjlevinson@gmail.com>
* Update docs/architecture/adr-033-protobuf-inter-module-comm.md
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-24 11:45:21 +00:00
d880d74498
Fix accidentally committed files
2021-02-22 17:39:50 -06:00
649a4e603a
Add section for parameterizing the epoch length
2021-02-22 15:37:53 -06:00
e858c51799
Missed a comment
2021-02-22 14:38:08 -06:00
846cede5bf
Repsond to comments, improve descriptions
2021-02-22 14:33:47 -06:00
7e481cc716
ADR 033: Inter-Module Communication ( #7459 )
...
* Initial WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* Update Invoker
* WIP
* Tidying up
* Update title
* Cleanup diff
* cleanup
* Update context
* Add ClientConn impl
* WIP
* updates
* revert go.mod
* Describe internal methods and authorization
* Add comparison to x/capability
* Cleanup
* Apply suggestions from code review
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-033-protobuf-inter-module-comm.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-033-protobuf-inter-module-comm.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-033-protobuf-inter-module-comm.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-033-protobuf-inter-module-comm.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* ADR-033 Updates / Amendments (#8190 )
* updates to ADR33 based on 12.04.20 architecture call
* add comments about improved devx
* Update docs/architecture/adr-033-protobuf-inter-module-comm.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* update with atomicity note
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-02-19 15:34:54 +00:00
47dd07d4ff
Modify IBC client governance unfreezing to reflect ADR changes ( #8405 )
...
* update proto files
* make proto-gen
* update clienttypes
* update localhost and solo machine
* refactor tm client proposal handling
* copy metadata
* self review fixes
* update 02-client keeper tests
* fix 02-client type tests
* fix localhost and solomachine tests
* begin updating tm tests
* partially fix tm tests
* increase codecov
* add more tests
* add changelog
* update specs
* add docs
* fix test
* modify adr
* allow modified chain-ids
* add CLI command
* fix typos
* fix lint
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update docs, rm example
* Update docs/ibc/proposals.md
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* update height checks to reflect chain-id changes cc @AdityaSripal
* Apply suggestions from code review
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
* address most of @AdityaSripal suggestions
* update docs per review suggestions
* Update x/ibc/core/02-client/types/proposal.go
* add proposal handler
* register proposal type
* register proposal on codec
* fix routing
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: Aditya <adityasripal@gmail.com>
2021-02-16 15:31:40 +00:00
f4d328cc27
Merge branch 'adr-epoched-staking' of github.com:sikkatech/cosmos-sdk into adr-epoched-staking
2021-02-15 13:24:55 -06:00
3a7cc3bd3a
epoched staking
2021-02-11 16:23:53 -05:00
352a19e6eb
Add epoched staking ADR
2021-02-11 11:30:42 -06:00
404dc4f356
Merge branch 'master' of github.com:sikkatech/cosmos-sdk into gov_split_vote_weighted_vote
2021-02-06 01:03:32 +10:00
b55913ddad
fix comments and add CHANGELOG
2021-02-06 00:57:12 +10:00
a3757e14a8
ADR 038: State Listening ( #8012 )
...
* ADR-038 state listening
* updates/fixes
* review fixes/adjustments
* review fixes/adjustments part 2
* review updates part 3: refactor after review to coordinate store changes with block and tx messages and enable file pruning
* review updates part 4: additional details and fixes; addressing recent feedback; use binary protobuf encoding for kv pairs in files
* review updates part 5: formatting fixes; updated StreamingService/Hook interface
* auxiliary streaming/queue service
* review updates part 6: update StoreKVPair to differentiate between Set and Deletes on nil byte values; some minor adjustments
* typo fix
2021-02-04 18:09:28 -08:00
931af4350b
Finalize ADR-028 ( #8398 )
...
Finalize ADR-028
* added note about Named Accounts
* Update docs/architecture/adr-028-public-key-addresses.md
* remove blake2b
* move some paragraphs to 'Further Discussion'
* move composing module accounts to a new subsectoin
* adding appendix from meeting with Alan
* composed addresses: use LengthPrefix before sorting
2021-02-04 04:08:11 +01:00
b125fccfd2
MsgWeightedVote -> MsgVoteWeighted
2021-01-24 20:54:25 -05:00
57f5e96570
Rosetta API implementation ( #7695 )
...
Ref: #7492
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2021-01-21 09:33:02 +00:00
48006b435d
x/bank: client denom metadata gRPC ( #8317 )
...
* deps: bump tendermint to v0.34.2
* x/bank: denom metadata gRPC
* cli: add cmd and tests
* gRPC test'
* changelog
* fix test
* Apply suggestions from code review
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aditya <adityasripal@gmail.com>
* fix panic
* use cmd.Context()
* update tests
* Update x/bank/types/errors.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* test fix
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-19 17:08:09 -05:00
01eec66d28
x/bank: client denom metadata gRPC ( #8317 )
...
* deps: bump tendermint to v0.34.2
* x/bank: denom metadata gRPC
* cli: add cmd and tests
* gRPC test'
* changelog
* fix test
* Apply suggestions from code review
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aditya <adityasripal@gmail.com>
* fix panic
* use cmd.Context()
* update tests
* Update x/bank/types/errors.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* test fix
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-18 18:15:16 +00:00
43840f45dd
Revisions to Unfreezing Clients via Governance ADR ( #8343 )
...
* revisions to adr 26 decision
* Update docs/architecture/adr-026-ibc-client-recovery-mechanisms.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2021-01-16 09:48:48 -03:00
2a2c2ec009
ADR 030: Authorization Module ( #7105 )
...
* Add ADR 030
* Cleanup
* Updates
* Updates based on ADR 031
* Add abstract and context
* Updates
* Update module name as per #7615
* Updates from reviews
* Rename
* CLI update
* Update docs/architecture/adr-030-authz-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-030-authz-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-030-authz-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/architecture/adr-030-authz-module.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Code review updates
* Update docs
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2021-01-13 19:18:19 +00:00
1ec6c640b9
ADR template: add Further Discussions ( #8108 )
...
* ADR template: add Further Discussions
* language update
* Update docs/architecture/adr-template.md
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
2020-12-09 10:36:48 +00:00
b219c54c2d
Move and update codec.MarshalAny functions to codec.Marshaler interface ( #8080 )
...
* Changelog update
* Rename codec.MarshalAny
* move codec.MarshalInterface to codec.Marshaler
* fix tests
* Update amino_codec for compliance with MarshalerInterface
* update tests and comments
* add tests
* change order of args in UnmarshalInterface to a canonical one
* uplift MarshalInterface to take ProtoMessage as an argument
* wip
* add nil check
* make tests working
* tests cleanup
* add support for *JSON methods
* Update changelog
* linter fixes
* fix test types
* update evidence genesis_test
* adding test
* review updates
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-12-08 09:27:08 +00:00
b5442e1d5e
Update adr-034-account-rekeying.md
2020-11-24 13:06:58 -05:00
fd6f07bda2
Merge branch 'master' into sunny/change-pubkey-adr
2020-11-23 16:18:45 -05:00
972095e7fa
pruning info
2020-11-23 15:52:47 -05:00
101d62a69d
Add details about pruning
2020-11-23 15:47:55 -05:00
045e7874b0
Update adr-034-account-rekeying.md
...
Add stack of past keys
2020-11-23 15:33:40 -05:00
20617d0db4
Update docs/architecture/adr-034-account-rekeying.md
...
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-11-23 15:30:25 -05:00
251a27d104
Update ADR status ( #8009 )
2020-11-23 16:31:17 +00:00
fe58ee9951
ADR-031: elaborate consequences and encapsulation of module client-se… ( #7839 )
...
* ADR-031: elaborate consequences and encapsulation of module client-server implementation
* Update docs/architecture/adr-031-msg-service.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-11-18 23:11:04 +00:00
a0c1deb2e2
reassign to adr 037
2020-11-11 13:35:07 -04:00
bf508d9699
Merge branch 'master' into adr_gov_split_vote
2020-11-06 11:43:20 -04:00
53108e7637
Update adr-034-account-rekeying.md
2020-11-06 11:28:18 -04:00
c4e5e29244
Update and rename adr-034-change-pubkey.md to adr-034-account-rekeying.md
2020-11-06 11:21:45 -04:00
4d833f9ef0
ADR 35: Rosetta API Support ( #7492 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: SenorMonito <david@planet-mono.net>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-11-06 10:39:33 +00:00
6274240d7c
Apply suggestions from code review
...
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-11-03 15:55:16 -04:00
e9d6a8a48d
add backwards compatibility section
2020-11-02 12:56:45 -04:00
ebe73fa28b
modify ADR for MsgVote backwards compatibility
2020-11-02 23:10:39 +10:00
71e551bbae
address @alexanderbez review
2020-10-29 16:35:50 -04:00
3a871b86ce
sunny updates
2020-10-29 14:09:05 -04:00
2ace2a738b
Update docs/architecture/adr-034-change-pubkey.md
...
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-10-28 22:20:25 -04:00
ffced9ebef
modify title
2020-10-28 23:31:45 +10:00
5061b8fe19
basic ADR for gov split vote
2020-10-28 23:24:55 +10:00
2c58e1806c
Merge branch 'master' into sunny/change-pubkey-adr
2020-10-27 13:42:15 -04:00
5bebf2bd39
ADR: add a process proposal ( #7621 )
...
* ADR: add a process proposal
* wording update
* Update docs/architecture/PROCESS.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/PROCESS.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/PROCESS.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Add more details to status section and update the template
* Update docs/architecture/PROCESS.md
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* add a note about ADR pruning
* use sequence numbers
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-22 22:40:44 +00:00
c8c73a483a
Apply suggestions from code review
...
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-10-22 12:00:16 -04:00
091c835060
Update adr-034-change-pubkey.md
2020-10-21 21:44:40 -04:00
68ba5647a2
Update adr-034-change-pubkey.md
2020-10-21 21:42:47 -04:00
cb99dbd413
Apply suggestions from code review
...
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-10-21 21:42:06 -04:00
30c13ea554
Apply suggestions from code review
...
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-10-21 15:37:40 -04:00
f24ad5d00a
ADR 028: Public Key Addresses ( #7086 )
...
* ADR 028: Public Key Addresses
* Cleanup
* Address review comments
* wording update.
* Being more precise about nested addresses in multisig
* Apply suggestions from code review
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
* Address review comments
* Address review comments
* Address review comments
* Describe sorting
* Add abstract
* Update status
* Revert to sha256
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-10-21 16:03:18 +00:00
48bfd73aba
Add background for sequence change in ADR-020 ( #7616 )
2020-10-21 14:47:31 +00:00
503b518efc
client: add GetAccount and GetAccountWithHeight to AccountRetriever ( #7558 )
...
* client: add GetAccount and GetAccountWithHeight to AccountRetriever
* update ADR
* address comments from review
2020-10-15 14:19:57 +00:00
24714f80cb
fix typo ( #7536 )
...
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-10-14 20:17:53 +00:00
36c1b24a06
ADR 32: Typed Events ( #7474 )
2020-10-13 19:51:47 +01:00
2affa79c0a
adr 32 -> 34
2020-10-13 10:13:30 -04:00
c7d926da2d
ADR 031: Protobuf Msg Services ( #7458 )
...
* Ideas
* WIP
* Add ADR 031
* WIP
* WIP
* Revert changes
* Revert changes
* Revert changes
* Updates
* Updates
* Apply suggestions from code review
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
* Add package names
* Adding clarifications
+ Adding an abstract
+ Updating the first paragraph of decision
* Update Context and wording
* Update wording
* Address proto naming
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Cory <cjlevinson@gmail.com>
2020-10-09 19:13:30 +00:00
90579c0a99
ADR 029: Fee Grant Module ( #7106 )
...
* Add ADR 029 stub
* ADR 029 first draft
* Cleanup
* Updates from code review
* Updates from review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-10-09 15:09:17 +00:00
df6414d040
adr
2020-10-08 20:47:05 -04:00
435fc83ba7
Updating the ADR template ( #7449 )
...
* Updating the ADR template
Introducing few small sections to the template:
* Summary: IMHO it's very valuable for every reader to quickly see what this ADR is about. Must be short.
* Backwards Compatibility -- each ADR MUST analyze backward compatibility issue. Let's make it clear and put as the ADR subsection.
* Test Cases -- often, when analyzing a problem and implementing a solution, it's very useful to define test-cases. Hence it SHOULD be a part of the template.
Inspiration: Enterprise Ethreum Alliance Proposal [template](https://github.com/EntEthAlliance/EEPs/blob/master/draft/templates/EEP0002-Standards_Proposal_Template.md )
* change Summary -> Abstract
2020-10-05 21:34:41 +00:00
852e7693a7
Update ADR 023 package versioning guidelines ( #6954 )
...
* ADR 023 updates
* ADR 023 updates
* ADR 023 updates
* Update docs/architecture/adr-023-protobuf-naming.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update ADR 023
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-10-05 11:49:13 +00:00
cdf9bd2a4f
Proportional slashing ADR Update ( #6368 )
...
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
2020-10-05 09:30:50 +02:00
2c93ec7a0c
ibc: core restructure ( #7434 )
...
* ibc: protobuf v1
* update codec
* core client
* core connection
* core host
* core commitment
* core port
* core channel
* core ibc module files
* core exported
* core types & simulation
* core spec
* make proto-all
* ibc alias
2020-10-02 06:03:02 -03:00
72353902e2
ibc: rename epoch -> version ( #7429 )
...
* ibc: rename epoch -> version
* more renaming
* update spec
2020-10-01 15:08:26 +00:00
489599b70f
Remove the old message PublicKey proto oneof ( #7390 )
...
* Remove unused PublicKey type and update docs
* Update wording
* Update proto/cosmos/base/crypto/v1beta1/crypto.proto
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Edit docs
* Move crypto.proto to multisig
* Proto linting
* Update docs/architecture/adr-020-protobuf-transaction-encoding.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update wording for Public Key Encoding
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-09-29 10:01:54 +00:00
308ee267a8
Followup suggestions from ADR-027 updates ( #7232 ) ( #7379 )
...
* add grammar suggestions to adr-027
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-28 09:42:57 +00:00
09998ef86e
adr-27: adding ( #7232 )
...
* adr-27: adding
Each ADR should have an abstract and an example use case to quickly present the goal.
Here, adding this to DR 027: Deterministic Protobuf Serialization
* review update
* added link to TxRaw
* added list of major use-cases
* updated wording in context and abstract
* updated the adr-020 part
* add consequences and motivation for TxRaw
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* rewording
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-23 23:06:55 +00:00
7cd25abb87
Proto Tx with Any ( #7276 )
...
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Use anil's suggestion
* Add norace back
* Check nil
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Display StdTx instead of proto Tx
* Remove useless check
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-09-21 16:48:28 +00:00
e4c67eddc7
Added glossary explaning Denomination Key ( #7330 )
...
When reading this ADR, I was confused about _denomination_. When reading this in context of tokens I always think about a unit / measure. Examples: bills denominated in $20 and $50. Or as 100 cents makes 1 dollar.
The Merriam-Webster dictionary defines [denomination](https://www.merriam-webster.com/dictionary/denomination ) as:
1. an act of denominating. Eg: the denomination of prices in U.S. dollars
2. a value or size of a series of values or sizes. Eg: metric denominations
3. name, designation especially : a general name for a category
It seams that we are using the last definition (3rd).
2020-09-16 10:27:01 -07:00
2bb9a241bb
ADR-027: Make rules more precise ( #7220 )
...
* Update changelog.
* Fix typos.
* Remove 'by default' from packed encoding rule.
* Further specify longer requirement.
* Clarify that bool must have value of 1 if included.
* Fix typo variant -> varint.
* Disambiguate rule 3.
* Add more reasoning for requirements on zeroes.
* Reword rules to make bit restrictions clearer. Add exception for negative int32.
* Add reference for signed integer encoding.
* Clarify rule for signed int requirement.
* Deterministic -> bijective.
* Normalize spacing in 'protobuf 3'.
* Add background to clarify 70 bits.
* Fix nit: all -> most.
* Clarify is -> must.
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-09-11 14:46:37 +00:00
64b6bb5270
rename RegisterCodec to RegisterLegacyAminoCodec ( #7243 )
...
* rename RegisterCodec to RegisterLegacyAminoCodec
* Add changelog
* gofmt
* rename codec.New() to codec.NewLegacyAmino()
* Add change log
* Update CHANGELOG.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Fix
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-09-07 14:47:12 +00:00
50bab8f820
Put AccountSequence in SignerInfo ( #6997 )
...
* WIP test the grounds
* Update ADR020
* Fix compile errors
* Fix ADR
* Make ante tests pass
* Fix remaining ante handler tests
* Simplify code
* Fix x/bank app_test
* Fix tests
* Remove useless accSeq from signerdata
* Fix test
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/auth/client/cli/tx_multisign.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Address rewview
* Update x/auth/ante/sigverify.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/ante/sigverify_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/direct_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* AccSeq -> Seq
* Address reviews
* Better variable naming
* Fix variable assign
* Remove old SetSignerInfo
* Fix test
* proto-gen
* Make proto-gen
* Reput gw comment
* Add Changelog
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
2020-08-21 14:20:47 +00:00
1b9f144b9d
Propose ADR 027: Deterministic Protobuf Serialization ( #6979 )
...
* Add ADR 026: Protocol Buffer Regencode
* Use Regencode in ADR-020
* Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Add reasoning behind omitting empty fields
* Rename to ADR 026: Deterministic Protobuf Serialization
* i++
* explicitely -> explicitly
* Fix description of optional values
* Update reasoning behind omitting default values
* Fix empty -> defaut
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Add rules to avoid duplicate encoding and specify packed fields
* Add rule for variant encoding
* Add surrogate pair to test UTF-8 encoding
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-08-19 17:22:15 +00:00
3022fe9044
x/ibc-transfer: ADR001 source tracing implementation ( #6871 )
...
* x/ibc-transfer: ADR001 source tracing implementation
* gRPC proto file
* validation
* fix validation
* import export genesis
* relay.go updates
* gRPC service methods
* client CLI
* update implementation
* build
* trace test
* fix CLI tx args
* genesis import/export tests
* update comments
* update proto files
* GRPC tests
* remove field from packet
* fix coin validation bug
* more validations
* update comments
* minor refactor
* update relay.go
* try fix test
* minor updates
* fix tests
* fix test
* ADR updates and comments
* build
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address a few comments from review
* gRPC annotations
* update proto files
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address comments
* docs and changelog
* sort traces
* final changes to ADR
* client support for full path denom prefixes
* address @AdityaSripal comments
* address TODO
* increase test timeouts
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-14 17:46:26 -04:00
6a7cf4442e
Merge PR #7006 : auth: Update AccountRetriever
2020-08-13 10:22:16 -04:00
20c80cfd44
Rename *codec.Codec to *codec.LegacyAmino ( #6991 )
...
* Rename *codec.Codec to *codec.LegacyAmino
* Implement requested changes
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-08-10 19:41:21 +00:00
769387b754
Merge PR #6488 : Initial ADR for IBC client recovery mechanisms
2020-08-10 18:19:08 +02:00
6f3ca5c140
ADR 001: coin cross-chain transfer source tracing ( #6662 )
...
* adr: coin cross-chain transfer source tracing
* update pros and cons
* update spec README
* Update docs/architecture/adr-001-coin-source-tracing.md
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
* Apply suggestions from code review
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
* Update docs/architecture/adr-001-coin-source-tracing.md
* address comments from review
* update ADR with Send/Recv logic
* final touches
* Apply suggestions from code review
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* address comments from review
* address @aaronc review comments
* Apply suggestions from code review
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* use SplitN
* custom denom validation reference
* address some comments from review
* more updates based on Colin's review
* final draft with changes to relay.go
* undo proto changes
* address @aaronc review comments
* why do I keep updating the proto files?
* address @AdityaSripal comments
* address more comments
* typos
* final ammendments
* minor fix
* address more comments
* update example
* Update docs/architecture/adr-001-coin-source-tracing.md
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
* address more comments
* update prefix example
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2020-08-03 11:39:26 +00:00
c7c66f8b36
types: remove unused CanonicalSignBytes ( #6912 )
...
Removes all vestiges of CanonicalSignBytes, which is unused
and untested.
Fixes #6679
2020-08-02 15:13:41 +00:00
f33749263f
Merge PR #6761 : telemetry: use UTC() in wrappers
2020-07-17 15:33:50 -04:00
eb3f7e6473
rename blacklist to blocked ( #6455 )
...
* rename blacklisted to cannotSendTo
* add changelog
* rename to blockedAddrs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-17 13:32:49 +00:00
8ee7d1f403
Merge PR #6399 : SDK Telemetry
2020-06-16 11:11:02 -04:00
b9f39c94f8
Merge PR #6359 : Updates to ADR-020 (protobuf signing)
2020-06-10 10:48:25 -04:00
cd94032c0e
docs: ADR 025 for passive channels ( #6250 )
...
* docs: new ADR 023 for passive channels
* docs: simplify application handshake just to OnChanOpenAccept
* chore: rename IBC Passive Channels to ADR 025
* docs: more details for passive channels
* docs: rework the callback for attempted ChanOpenTry
* docs: Attempted -> attempt
* docs: add code reference
* docs: replace OnChanOpenTry with OnAttemptChanOpenTry in ADR 025
2020-06-08 01:07:00 -04:00
8bc645a418
ADR 024 - Coin Metadata ( #6253 )
...
* Start draft
* Add context
* Updates
* Fix tabbing
* Fix title
* Update docs/architecture/adr-024-coin-metadata.md
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
* revise aliases
* Add section on total supply and gen state
* Add section on aliases
* Add section on gov
* Update docs/architecture/adr-024-coin-metadata.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Add ext
* Remove extensions
* Add special treatment for base and display denomination (#6351 )
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
2020-06-07 01:05:22 +00:00
Ian Norden
Robert Zaremba
Tim Lind
technicallyty
Amaury
Dev Ojha
ValarDragon
Aaron Craelius
colin axnér
Sunny Aggarwal
antstalepresh
SaReN
Federico Kunze
Sunny Aggarwal
Jonathan Gimeno
antstalepresh
Amaury Martiny
Jack Zampolin
Marie Gauthier
Cory
John Adler
Anil Kumar Kammari
Simon Warta
Alexander Bezobchuk
dauTT
Christopher Goes
Emmanuel T Odeke
Adam Bozanich
Michael FIG