* Switch keys commands to keyring
* Replace NewKeybase with NewKeyring
* Fix delete test
* Purge dead code
* Override COSMOS_SDK_TEST_KEYRING envvar to switch to a test keyring
* s/unningOnServer/unningUnattended/
C'ing @tnachen
* Add deprecated warning, output looks like the following:
```
$ gaiacli keys update --help
Command "update" is deprecated, it takes no effect with the new keyring
based backend and is provided only for backward compatibility with the
legacy LevelDB based backend.
Refer to your operating system's manual to learn how to change your
keyring's password.
Change the password used to protect private key
Usage:
gaiacli keys update <name> [flags]
Flags:
-h, --help help for update
Global Flags:
--chain-id string Chain ID of tendermint node
-e, --encoding string Binary encoding (hex|b64|btc) (default "hex")
--home string directory for config and data (default "/home/alessio/.gaiacli")
-o, --output string Output format (text|json) (default "text")
--trace print out full stack trace on errors
```
* Update multisign command
* Modify server.GenerateSaveCoinKey()
* GenerateSaveCoinKey more modifications
* Update docs
* Update upgrade module
Introduce new Keybase implementation that can leverage
operating systems' built-in functionalities to securely store
secrets.
This chunk is extracted from @poldsam's original PR:
- #4754
Thanks: @alexanderbez
* in sync with @okwme/cosmos-nft
* remove tmp tx
* structuring and minor changes
* supply and client files
* adding cli client
* complete cli/tx and rest.go
* cleanup and restructuring
* restructure rest folder
* minor updates on clients
* update querier
* encoding for clients and other changes
* genesis, invariants, and keeper updates
* update types
* make golangcibot happy
* renamed and removed bank keeper
* remove handlers for editmetadata, mint, burn, buy
* nft interface
* minor cleanup
* sort collections and nfts
* balance and find
* nft query and tx
* touch ups
* uint in place of int
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* little fixes:
- fix error to err to avoid collision
- error handling
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* module generalization changes
* fixes
* query with data
* minor updates and TODOs
* fix CLI tx
* golang bot fixes
* handlers and txs done
* update module generalization
* Added very basic tests which for some reason do not work
* fix test
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* fixed test, now we should fix implementation, seems to fail
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* fix test, create new struct instead of changing the old one
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* fix handler with new logic
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* let's make it compile
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* single failing test example, need to be fixed and extended
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* single failing test example, need to be fixed and extended
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* reverting work, still problems unmarshalling inside iterator from test
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* Setter in nft.go should return NFT instead of BaseNFT
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* remove TODOS
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* comment out broken tests, we want at least a green mark here
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* little fixes
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* hopefully no conflict
* minor changes for tests
* change nft id to string, refactors
* messy pause
* Changes Balances to OWners add all necessary functions, updated Keeper with UpdateNFT as as well as MintNFT and made sure they all update Owners
* pause dev to merge sdk master
* go.mod changes
* getting closer still need module.go
* builds!!!
* fix lint begin handler tests
* stableish
* re-order nft attributes, add back mint and burn msgs and handlers
* add errors to minting the same NFT and burning an NFT that doesnt exist
* first querier test
* add simulations for nft msgs
* handler tests check tags now (fixed a bug!)
* update simulation
* generic handler
* need to check if it compiles on another machine
* fix weird interface error
* add back cli
* wtfff
* codec error fixed, logs removed. still returning empty arrays of IDs
* Take empty input as yes answer
Closes: #4564
* Add pending log entry
* merged in master
* marshall errors
* build commands
* working!!!
* linting errors
* remove unused func
* pause
* fix burn error
* fix burn error
* tests for querier
* typo
* tests for NFT types
* module spec standard
* tests for Collection and Collections types
* merge w Fede
* tests for Owner Type
* added genesis tests and beefed up keeper, querier, handler & types tests
* linting errors deadcode
* DONT COVER test_common.go
* add msg type tests
* Update x/nft/internal/keeper/key.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/nft/genesis.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/nft/client/cli/query.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Apply suggestions from code review
* typo
* cleanup events
* split events
* more cleanup
* remove restrictions from default handlers
* not sure where these go mod changes came from
* sim generated changes
* make format
* add mint and burn sims
* move NFT interface to nft/exported
* make format
* NFT spec
* Updates
* more updates
* update specs readme
* fix sims
* rest additions
* rest additions
* fix invariant
* minimal nft without name, description or image
* sim
* fix sim
* fix sim
* fix Update methods
* nothing
* simplify update and remove
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* remove test on memory location
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* TEST to get logs, need to be removed
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* fix simulator editMetadata Msg type
* owner not found start with empty collection
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* artifacts on errors in case of failure, else, no artifacts
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* add more invariant checks to handler_tests
* never forget to overwrite
* merge and update spec
* colins feedback
* code coverage test
* code coverage test
* code coverage test
* spelling
* clean up client
* testing code coverage
* testing code coverage
* testing code coverage
* testing code coverage
* testing code coverage
* Update docs/spec/nft/README.md
Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>
* Apply suggestions from code review
Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>
* minor changes
* integration tests and fixes
* minor golangCI fixes
* Update simapp/app.go
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Add Keybase's ExportPrivKey()/ImportPrivKey() API calls to export/import
ASCII-armored private keys. Relevant keys subcommands are provided as well.
Closes: #2020
Gaia is removed from cosmos-sdk repository.
Few changes were required to make sure no packages depend on gaia subpackages.
CI config is amended accordingly.
Unnecessary targets are removed from Makefile.
Simulations run through a lightweight version of gaia renamed to simapp.
Closes: #4104
* add a bunch of tests, add DONTCOVER text tag
- Also fix flaky test (closes: #3559). Don't test values
returned by queries since there's no way to query a
specific height via REST.
* GetTempDir -> NewTestCaseDir
* add --force to keys delete for unattended execution
Skip password check when --force is on and delete
keys unconditionally.
Closes: #2961
* Forcibly cleanup keys on fixtures initialization
* Force password to 'yes' when deleting ledger-offline keys
* Improve UX, better docs on removing offline/ledger keys
* Ask for confirmation on offline/ledger keys deletion
* crypto/keys/hd: use btcec to remove dep on tendermint
* crypto/keys/bcrypt: improve comment about fork
* crypto/keys/bip39 -> crypto/keys/bip39/fundraiser
* crypto/keys/bip39: bring in fork of tyler-smith
* crypto/keys/hd: update dep
* crypto/keys: update deps
* crypto/keys: move mintkey.go into new crypto/keys/mintkey
* crypto/keys/hd: NewParamsFromPath
* crypto/keys: keybase.Derive takes a bip39 passphrase too
* crypto/keys/hd: BIP44Params.DerivationPath
* gaiacli keys: add commands new and mnemonic
* fix lints
* minor fixes from review
* update Gopkg.toml
* add tendermint fork of golang.org/x/crypto
* pin some transitive deps
* crypto/keys/bcrypt: remove
* remove in favour of fork of golang.org/x/crypto/bcrypt at github.com/tendermint/crypto/bcrypt
* crypto/keys/bip39: remove completely
* use fork cosmos/go-bip39 instead
* Gopkg.toml: dont use master
* Pull in changes from my PR
* fixes from review
* enforce min len for --unsafe-entropy
* lint fix
* feedback from review
* fix dep
* Allow --from to be a name or an address
Closes#1735.
* Post-rebase fixes
* Updates from code review
* Updates from code review
* Updates from code review
* Fix merge artifacts
* Fix merge conflicts
* Fix integration tests
* Add back GetFromName() check broken during merge
* Code review updates
* Fix failing test
* Updates from code review
The new CLI flag builds an unsigned transaction and writes it to STDOUT.
Likewise, REST clients can now append generate_only=true to a request's
query arguments list and expect a JSON response carrying the unsigned
transaction.
Closes: #966
* Start upgrade. Currently go test ./... hangs.
* (squash this) Fix staking tests
* wip
* note what changes need to be made to make this work on tm v0.23.0
* Fix addr -> pubkey map
* cleanup code
* Fix slashing test failures except for begin blocker
* fix all slashing tests
* fix lcd tests
* Address PR comments
* add link to changelog.
* (wip) start making addrToPubkey map persisted. Since amino can't handle maps,
we have to change from what this commit is doing.
* Use the correct method of storing a map
* (squash this) address PR comments
* Did you run 'make'?
* remove gaiadebug binary
Currently the crypto/keys tests take 2 minutes in circle CI.
A significant portion of this time is due to the bcrypt security
parameter. Changing it for these tests should reduce the time significantly.
* Update to tendermint v0.22.6-rc0
This is comprised of updating the crypto imports / API
* (squash this) switch to v0.22.6
If this passes tests, I'll squash this commit and update the PR.
* tools: Ensure Gopkg.lock is correct in linting
This adds dep status to the lint process. Also fixes linting errors
that existed earlier. (not sure why they didn't show up on CI)
Closes#1574
* Update dep, use the lock file new dep version creates
This is done so that the time spent on bcrypt during test cases
can be reduced. This change reduces the amount of time lcd tests
spend on bcrypt from 76% to 40%. (We need to reduce the number of
calls to bcrypt in a seperate PR, along with fixing other sources
of slowness)
Making the bcrypt security parameter a var shouldn't be a security issue:
One can't verify an invalid key by maliciously changing the bcrypt
parameter during a runtime vulnerability. The main security
threat this then exposes would be something that changes this during
runtime before the user creates their key. This vulnerability must
succeed to update this to that same value before every subsequent call
to gaiacli keys in future startups / or the attacker must get access
to the filesystem. However, with this same threat model (changing
variables in runtime), one can cause the user to sign a different tx
than what they see, which is a significantly cheaper attack then breaking
a bcrypt hash. (Recall that the nonce still exists to break rainbow
tables)
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK
Adds support for Ledger into gaiacli
Cherry-picks updated error handling from #1158
Alessio Treglia
Marko
Federico Kunze
Alexander Bezobchuk
yys
Austin Abell
frog power 4000
Frank Yang
Juan Leni
Alessio Treglia
Juan Leni
Christopher Goes
Juan Leni
HaoyangLiu
Ethan Buchman
Matthew Slipper
Dev Ojha
Sunny Aggarwal
Aleksandr Bezobchuk
ValarDragon