--validate-signatures should not be a flag of the sign command
as the operation performed (transaction signatures verification)
is logically distinct.
cli_test is and has always been an horrible name for package
directory as it's very much Go anti-idiomatic - _test is the
suffix used by test packages, not directories. Plus, CLI test
cases can and should live alongside other testcases that don't
require binaries to be built beforehand. Thus:
x/module/client/cli_test/*.go -> x/module/client/cli/
Test files that require sim{cli,d} shall be tagged with // +build cli_test
With regard to cli test auxiliary functions, they should live in:
x/module/client/testutil/
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
x/staking: Fix all linter warnings.
Fixed warnings across base packages.
New linters:
- unparam
- nolintlint
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Added cli integration base setup
* Added cmd to simapp
* Fixed ci-lint issues
* Fixed ci-lint issues
* Addressed changes in Makefile
* Updated simd to latest
* Removed testnet and replay commands
* Modified tx command for simcli
* Did code cleanup
* Removed duplication in Makefile
* Refactored cli_test
* Added build-sim to Makefile
* Added test-cli to circleci
* Added tests for staking txns
* Addressed format issues
* refctored tests code
* Added tests for send, staking
* Removed test_hepers file
* Moved test_cover to contrib
* Added codec in fixtures
* Migrated tests to respective modules
* Exported helper methods
* Moved helpers to bank
* Added codec to fixtures
* Migrated tests to modules
* Removed auth helpers from staking
* Did minor code cleanup
* Added test-cli to Makefile
* Updated github actions
* Did code refactor
* Fixed github actions for cli-test
* Added tests for recover keys and fee deduction
* Did minor code cleanup
* Added build flag to cli_tests
* Moved cli_test to tests
* Modified path in Makefile
* Updated codec std in fixtures
* Added doc for cli tests
* Remove ibc genesis validation
* Fix issue number
* Added missing imports
* Add tests for distribution and simd
* Modified naming for test functions
* Added test for withdraw rewards
* Modified test function names
* Fixed import format
* Migrated helpers to package cli
* Fixed github test actions
* Fixed test coverage in actions
* Added build sim to actions
* Apply Alessio patch for tests
* Removed unused imports
* Added init for go tests
* try fix tests
* goimports what wasn't goimports'd
* try fix ci
* add relevant tags to integration tests
* run integration tests separately
* use go build -o flag and let compiler gemerate the binary with the
right extension for the HOST platform
rename cli-test to test-integration
* update ci
* rename
Co-authored-by: atheesh <atheesh1>
Co-authored-by: kaustubhkapatral <54210167+kaustubhkapatral@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* enable the wsl linter
Fix various wsl-related warnings.
x/ibc/04-channel/keeper/handshake.go: fix missing return statement in ChanOpenTry().
* goimports -w files
* remove unknown linter references
* run make format
* Revert "run make format"
This reverts commit f810b62b9e4993f08506663d4e5f2ec2228a9863.
* run make format
github.com/spf13/viper's recent releases introduced a semantic
change in some public API such as viper.IsSet(), which have
broken some of our flags checks. Instead of checking whether
users have changed a flag's default value we should rely on such
defaults and adjust runtime behaviour accordingly. In order to do
so, it's important that we pick sane defaults for all our flags.
The --pruning flag and configuration option now allow for a
fake custom strategy. When users elect custom, then the
pruning-{keep,snapshot}-every options are interpreted and
parsed; else they're ignored.
Zero is pruning-{keep,snapshot}-every default value. When
users choose to set a custom pruning strategy they are
signalling that they want more fine-grainted control, therefore
it's legitimate to expect them to know what they are doing and
enter valid values for both options.
Ref #5964
* lint: various linting fixs
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* more linting
* more linting fixes
* more errchecking
* comment out errcheck for now
* undo error check
* address some comments
* remore require error
* change delete to batch delete
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* change abci file to use BinaryBare
* change all calls to EncodeLengthPrefixed to BinaryBare in distribution keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in mint keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in auth keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in distribution keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in staking keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in staking keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in gov keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in slashing keeper store.
* update decoder test
* migrate decoder
* migrate gov simulation decoder
* migrate baseapp_test
* refactor QuerySubspace
* refactor coedc std codec
* migrate keybase
* migrate iavl store
* migrate root multi
* migrate ante basic
* migrate tx type to bare
* migrate auth client
* update auth types
* update decoder
* migrate supply decoder
* migrate stake encoding
* migrate staking simulation
* migrate genutil
* migrate simapp test helpers
* migrate docs
* upgrade changelog
* Update CHANGELOG.md
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* migrate first distribution test to use simapp
* refactor test TestAllocateTokensTruncation
* migrate allocation test for distribution
* migrate TestCalculateRewardsBasic to simapp in distribution
* migrate TestCalculateRewardsAfterSlash to simapp in distribution
* migrate TestCalculateRewardsAfterManySlashes to use simapp
* migrate TestCalculateRewardsMultiDelegator to use ssimapp
* migrate TestWithdrawDelegationRewardsBasic to simapp
* migrate TestCalculateRewardsAfterManySlashesInSameBlock to simapp
* migrate TestCalculateRewardsMultiDelegatorMultiSlash
* migrate old delegation test
* migrate keeper test to simapp
* refactor all distribution to use simapp
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Packages named utils, common, or misc provide clients with no
sense of what the package contains. This makes it harder for
clients to use the package and makes it harder for maintainers
to keep the package focused. Over time, they accumulate dependencies
that can make compilation significantly and unnecessarily slower,
especially in large programs. And since such package names are
generic, they are more likely to collide with other packages
imported by client code, forcing clients to invent names to
distinguish them.
cit. https://blog.golang.org/package-names
* Bump Tendermint version to v0.33.0
* Deprecate old cmn package with new packages
* Update update DB APIs
* More DB updates
* Bump IAVL to v0.13.0
* Handle error returned by iavl.NewMutableTree
* Fix some IAVL stuffs
* Update IAVL
* More updates
* Passing tests
* Fix unit tests
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
* encoding
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* module doc start
* finish intro
* working
* workinnn
* add transactions into core
* hans comments
* add transactions into core
* working
* gautier comments
* clean
* working
* consolidate intro
* querier
* workiiiing
* refactor for new module interface
* karoly review
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* finish intro
* workinnn
* initial commit after rebase
* query-lifecycle and started modules-interfaces
* query-lifecycle first draft done
* module interfaces first draft
* rest and intro skeletons
* rest and intro done
* small edits and links
* comments
* revisions
* cli.md comments
* comments
* minor edits
* better flow for query lifecycle
* add transactions into core
* hans comments
* add transactions into core
* checkout master-docs files
* deleted some
* remove modules readme
* cli.md comments
* comments
* module-interfaces comments
* Merge PR #4857: Add Context concept doc
* working
* working
* finish messages and queries
* handler
* querier
* last comments!
* punctuation
* querier2
* consolidate intro
* querier
* workiiiing
* refactor for new module interface
* karoly review
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* finish intro
* workinnn
* initial commit after rebase
* query-lifecycle and started modules-interfaces
* query-lifecycle first draft done
* module interfaces first draft
* rest and intro skeletons
* rest and intro done
* small edits and links
* comments
* revisions
* cli.md comments
* comments
* minor edits
* better flow for query lifecycle
* checkout master-docs files
* deleted some
* remove modules readme
* cli.md comments
* comments
* module-interfaces comments
* keeper
* genesis
* finish
* Apply suggestions from code review
Co-Authored-By: Hans Schoenburg <hschoenburg@users.noreply.github.com>
* hans review
* Update docs/core/baseapp.md
Co-Authored-By: Hans Schoenburg <hschoenburg@users.noreply.github.com>
* working
* last comment
* workin
* Apply suggestions from code review
* encoding and node
* almost finish store
* finish docs
* fixes
* fede comments + permalinks
* hans review
* add more permalinks
* update docs theme version (#5239)
* R4R: Docs Cleanup (#5246)
* start
* work
* work
* work
* remove table of content
* links intro
* fix links
* remove junk
* cleanup
* cleanup
* work
* finish cleanup
* addback readmes
* remove nft
* fix links
* remove dup
* remove dup
* remove dup
* remove dup
* remove dup
* fix links
* add subscribe events
* refine rest
* index page
* sidebar
* theme version
* theme version
* testing netlify
* theme version
* tooltip example
* version
* testing code embedding
* reverting back
* theme version
* version
* version
* version
* readme and version
* cleanup
* redo app anatomy
* modules readme, theme version
* theme version
* fix modules list
* theme version
* new snippets
* modules readme
* update docs readme
* modify synopsis
* version
* fix yaml
* version
* version
* version
* version
* version
* version
* version
* version
* version
* version
* add hide banner
* version
* version
* version
* small fixes
* modules readme, version
* remove hotkeys dep, version
* version
* version
* version
* version
* version
* version
* version
* slight notice
* fix links and hide
* permalinks
* small clean
* version
* resolve conflicts, add google analytics
* fix merge remants
* version
* changelog 1/2
* Changelog: docs UI
* version
* remove merge conflicts
* Code: Update link for Contributing to the docs to docs_readme
* HTML/CSS: Update layout of homepage footer to match new layout in Figma
* version
* final modifs
* modules, version
* modules readme
* link to module list from homepage
* version
* building modules link
* version
* version
* fonts
* version
* version
* fix link
* fix package.json
* links in explore sdk section
* core concepts
* version
* change delimeters for frontmatter
* frontmatter in comments
* version
* temp add tiny-cookie
* fixed link issues
* fixed styling issues, copy
* hide frontmatter
* hide frontmatter
* layout fixes, padded ascii diagram
* fira sans font for code
* consolidate intro
* start anatomy of sdk app
* wokring
* working
* querier
* working
* workiiiing
* finish
* add dep and makefile
* Apply suggestions from code review
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
* typo
* typo
* Apply suggestions from code review
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>
* refactor for new module interface
* karoly review
* Apply suggestions from code review
Co-Authored-By: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* encoding
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* module doc start
* finish intro
* working
* workinnn
* add transactions into core
* hans comments
* add transactions into core
* working
* gautier comments
* clean
* working
* consolidate intro
* querier
* workiiiing
* refactor for new module interface
* karoly review
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* finish intro
* workinnn
* initial commit after rebase
* query-lifecycle and started modules-interfaces
* query-lifecycle first draft done
* module interfaces first draft
* rest and intro skeletons
* rest and intro done
* small edits and links
* comments
* revisions
* cli.md comments
* comments
* minor edits
* better flow for query lifecycle
* add transactions into core
* hans comments
* add transactions into core
* checkout master-docs files
* deleted some
* remove modules readme
* cli.md comments
* comments
* module-interfaces comments
* Merge PR #4857: Add Context concept doc
* working
* working
* finish messages and queries
* handler
* querier
* last comments!
* punctuation
* querier2
* consolidate intro
* querier
* workiiiing
* refactor for new module interface
* karoly review
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* finish intro
* workinnn
* initial commit after rebase
* query-lifecycle and started modules-interfaces
* query-lifecycle first draft done
* module interfaces first draft
* rest and intro skeletons
* rest and intro done
* small edits and links
* comments
* revisions
* cli.md comments
* comments
* minor edits
* better flow for query lifecycle
* checkout master-docs files
* deleted some
* remove modules readme
* cli.md comments
* comments
* module-interfaces comments
* keeper
* genesis
* finish
* Apply suggestions from code review
Co-Authored-By: Hans Schoenburg <hschoenburg@users.noreply.github.com>
* hans review
* Update docs/core/baseapp.md
Co-Authored-By: Hans Schoenburg <hschoenburg@users.noreply.github.com>
* working
* last comment
* workin
* Apply suggestions from code review
* encoding and node
* almost finish store
* finish docs
* fixes
* fede comments + permalinks
* hans review
* add more permalinks
* update docs theme version (#5239)
* R4R: Docs Cleanup (#5246)
* start
* work
* work
* work
* remove table of content
* links intro
* fix links
* remove junk
* cleanup
* cleanup
* work
* finish cleanup
* addback readmes
* remove nft
* fix links
* remove dup
* remove dup
* remove dup
* remove dup
* remove dup
* fix links
* add subscribe events
* refine rest
* index page
* sidebar
* theme version
* theme version
* testing netlify
* theme version
* tooltip example
* version
* testing code embedding
* reverting back
* theme version
* version
* version
* version
* readme and version
* cleanup
* redo app anatomy
* modules readme, theme version
* theme version
* fix modules list
* theme version
* new snippets
* modules readme
* update docs readme
* modify synopsis
* version
* fix yaml
* version
* version
* version
* version
* version
* version
* version
* version
* version
* version
* add hide banner
* version
* version
* version
* small fixes
* modules readme, version
* remove hotkeys dep, version
* version
* version
* version
* version
* version
* version
* version
* slight notice
* fix links and hide
* permalinks
* small clean
* version
* resolve conflicts, add google analytics
* fix merge remants
* version
* changelog 1/2
* Changelog: docs UI
* version
* remove merge conflicts
* Code: Update link for Contributing to the docs to docs_readme
* HTML/CSS: Update layout of homepage footer to match new layout in Figma
* version
* final modifs
* modules, version
* modules readme
* link to module list from homepage
* version
* building modules link
* version
* version
* fonts
* version
* Update post.sh
* Switch keys commands to keyring
* Replace NewKeybase with NewKeyring
* Fix delete test
* Purge dead code
* Override COSMOS_SDK_TEST_KEYRING envvar to switch to a test keyring
* s/unningOnServer/unningUnattended/
C'ing @tnachen
* Add deprecated warning, output looks like the following:
```
$ gaiacli keys update --help
Command "update" is deprecated, it takes no effect with the new keyring
based backend and is provided only for backward compatibility with the
legacy LevelDB based backend.
Refer to your operating system's manual to learn how to change your
keyring's password.
Change the password used to protect private key
Usage:
gaiacli keys update <name> [flags]
Flags:
-h, --help help for update
Global Flags:
--chain-id string Chain ID of tendermint node
-e, --encoding string Binary encoding (hex|b64|btc) (default "hex")
--home string directory for config and data (default "/home/alessio/.gaiacli")
-o, --output string Output format (text|json) (default "text")
--trace print out full stack trace on errors
```
* Update multisign command
* Modify server.GenerateSaveCoinKey()
* GenerateSaveCoinKey more modifications
* Update docs
* Update upgrade module
New Signature interface available in the top level types package.
auth.StdSignature implements such interface. User defined auth
module can now define their own custom signature types.
Work carried out in the context of the following issues:
- #4488
- #4487
* cleanup staking references from types pkg
* check interface on runtime
* fixes
* rename validator set from slashing keeper
* final cleanup
* fix test
* fix querier
* fix tests
* rename interfaces
* update bond status
* fixes
* expected pkg
* ensure expected keepers match used funcs
* cha cha cha
Fixes#4284
Now prints:
gaiacli query distr comission --trust-node cosmos1234
ERROR: unknown command "comission" for "distr"
Did you mean this?
commission
Adds custom argument validation for subcommands with subcommands. Doesn't affect "query" or "tx" subcommands since they reside in gaia repo. All flags except help are disabled for these commands.
Implement the "CommunityPoolSpendProposal" as described in Cosmos Hub proposal 7.
Also a useful test of Git flow for merging features passed in governance proposals.
Gaia is removed from cosmos-sdk repository.
Few changes were required to make sure no packages depend on gaia subpackages.
CI config is amended accordingly.
Unnecessary targets are removed from Makefile.
Simulations run through a lightweight version of gaia renamed to simapp.
Closes: #4104
* first commit
* gaia cleanup
* ...
* staking multihooks
* missing module function return args
* bank module name constant
* working, module interface for x/
* got this thing compiling
* make test compiles and passes
* remove expanded simulation invariants
* genesis issue
* continued
* continued
* register crisis routes thought mm
* begin blocker to mm
* end blocker to mm
* empty routes not initialized
* move gaia initChainer sanity check to baseapp
* remove codecs from module manager
* reorging genesis stuff
* module manager passed by reference/bugfixes from working last commit
int
int
* move invariant checks from gaia to crisis
* typo
* basic refactors cmd/gaia/init
* working
* MultiStakingHooks from types to x/staking/types
int
* default module manager order of operations from input modules
* working
* typo
* add AppModuleBasic
* moduleBasicManager / non-test code compiles
* working attempting to get tests passing
* make test passes
* sim random genesis fix
* export bug
* ...
* genutil module
* genutil working
* refactored - happy with non-testing code in cmd/
* ...
* lint fixes
* comment improvement
* cli test fix
* compile housing
* working through compile errors
* working gettin' compilin'
* non-test code compiles
* move testnet to its own module
* reworking tests
int
* bez staging PR 1 comments
* concise module function-of names
* moved all tests from genesis_test.go to other genutil tests
* genaccounts package, add genutil and genaccounts to app.go
* docs for genutil genaccounts
* genaccounts iterate fn
* non-test code with genaccounts/ now compiles
* working test compiling
* debugging tests
* resolved all make test compile errors
* test debuggin
* resolved all unit tests, introduced param module
* cli-test compile fixes
* staking initialization bug
* code comment improvements, changelog entries
* BasicGaiaApp -> ModuleBasics
* highlevel explanation in types/module.go
* @alexanderbez comment revisions
* @fedekunze PR comments
* @alexanderbez PR comments (x2)
* @cwgoes comments (minor updates)
* @fedekunze suggestions
* panic on init with multiple validator updates from different modules
* initchain panic makes validate genesis fail
int
* AppModuleGenesis seperation
int
* test
* remove init panic logic in validate genesis replaced with TODO
* set maxprocs to match system's GOMAXPROCS
* Update circleci
* Cap maxprocs in CI to 4
* @alexanderbez recent comments addressed
* less blocks in twouble sims
int
* runsim error output flag
* -e on import_export as well
* error out
int
* Try to fix failures
* runsim
Aaron Craelius
SaReN
dauTT
Federico Kunze
Marko
Alessio Treglia
Alexander Bezobchuk
Aleksandr Bezobchuk
Jonathan Gimeno
Gavin
mergify[bot]
Erik Grinaker
Ferenc Fabian
kaustubhkapatral
Denis Fadeev
gamarin2
Riccardo Montagnin
Santatic
Xuefeng Zhu
Hans Schoenburg
colin axner
frog power 4000
Aayushi Jain
Alessio Treglia
Juan Leni
Christopher Goes