## Description
We start to adopt acceptance tests when designing new module. We had few internal sessions on how to do and started to practice it.
We should better document the process and start requiring it with new documents.
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
## Description
Ref: #9707
<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->
- Add `client.md` to module specification.
- Add `client.md` page to `authz` module spec.
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [x] included the correct `docs:` prefix in the PR title
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the [documentation writing guidelines](https://github.com/cosmos/cosmos-sdk/blob/master/docs/DOC_WRITING_GUIDELINES.md)
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct `docs:` prefix in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] confirmed that this PR only changes documentation
- [ ] reviewed content for consistency
- [ ] reviewed content for thoroughness
- [ ] reviewed content for spelling and grammar
- [ ] tested instructions (if applicable)
* in sync with @okwme/cosmos-nft
* remove tmp tx
* structuring and minor changes
* supply and client files
* adding cli client
* complete cli/tx and rest.go
* cleanup and restructuring
* restructure rest folder
* minor updates on clients
* update querier
* encoding for clients and other changes
* genesis, invariants, and keeper updates
* update types
* make golangcibot happy
* renamed and removed bank keeper
* remove handlers for editmetadata, mint, burn, buy
* nft interface
* minor cleanup
* sort collections and nfts
* balance and find
* nft query and tx
* touch ups
* uint in place of int
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* little fixes:
- fix error to err to avoid collision
- error handling
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* module generalization changes
* fixes
* query with data
* minor updates and TODOs
* fix CLI tx
* golang bot fixes
* handlers and txs done
* update module generalization
* Added very basic tests which for some reason do not work
* fix test
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* fixed test, now we should fix implementation, seems to fail
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* fix test, create new struct instead of changing the old one
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* fix handler with new logic
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* let's make it compile
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* single failing test example, need to be fixed and extended
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* single failing test example, need to be fixed and extended
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* reverting work, still problems unmarshalling inside iterator from test
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* Setter in nft.go should return NFT instead of BaseNFT
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* remove TODOS
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* comment out broken tests, we want at least a green mark here
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* little fixes
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* hopefully no conflict
* minor changes for tests
* change nft id to string, refactors
* messy pause
* Changes Balances to OWners add all necessary functions, updated Keeper with UpdateNFT as as well as MintNFT and made sure they all update Owners
* pause dev to merge sdk master
* go.mod changes
* getting closer still need module.go
* builds!!!
* fix lint begin handler tests
* stableish
* re-order nft attributes, add back mint and burn msgs and handlers
* add errors to minting the same NFT and burning an NFT that doesnt exist
* first querier test
* add simulations for nft msgs
* handler tests check tags now (fixed a bug!)
* update simulation
* generic handler
* need to check if it compiles on another machine
* fix weird interface error
* add back cli
* wtfff
* codec error fixed, logs removed. still returning empty arrays of IDs
* Take empty input as yes answer
Closes: #4564
* Add pending log entry
* merged in master
* marshall errors
* build commands
* working!!!
* linting errors
* remove unused func
* pause
* fix burn error
* fix burn error
* tests for querier
* typo
* tests for NFT types
* module spec standard
* tests for Collection and Collections types
* merge w Fede
* tests for Owner Type
* added genesis tests and beefed up keeper, querier, handler & types tests
* linting errors deadcode
* DONT COVER test_common.go
* add msg type tests
* Update x/nft/internal/keeper/key.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/nft/genesis.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/nft/client/cli/query.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Apply suggestions from code review
* typo
* cleanup events
* split events
* more cleanup
* remove restrictions from default handlers
* not sure where these go mod changes came from
* sim generated changes
* make format
* add mint and burn sims
* move NFT interface to nft/exported
* make format
* NFT spec
* Updates
* more updates
* update specs readme
* fix sims
* rest additions
* rest additions
* fix invariant
* minimal nft without name, description or image
* sim
* fix sim
* fix sim
* fix Update methods
* nothing
* simplify update and remove
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* remove test on memory location
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* TEST to get logs, need to be removed
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* fix simulator editMetadata Msg type
* owner not found start with empty collection
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* artifacts on errors in case of failure, else, no artifacts
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
* add more invariant checks to handler_tests
* never forget to overwrite
* merge and update spec
* colins feedback
* code coverage test
* code coverage test
* code coverage test
* spelling
* clean up client
* testing code coverage
* testing code coverage
* testing code coverage
* testing code coverage
* testing code coverage
* Update docs/spec/nft/README.md
Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>
* Apply suggestions from code review
Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>
* minor changes
* integration tests and fixes
* minor golangCI fixes
* Update simapp/app.go
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Robert Zaremba
Ryan Christoffersen
Amaury Martiny
Federico Kunze
Alexander Bezobchuk
frog power 4000