* adr-27: adding
Each ADR should have an abstract and an example use case to quickly present the goal.
Here, adding this to DR 027: Deterministic Protobuf Serialization
* review update
* added link to TxRaw
* added list of major use-cases
* updated wording in context and abstract
* updated the adr-020 part
* add consequences and motivation for TxRaw
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* rewording
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
When reading this ADR, I was confused about _denomination_. When reading this in context of tokens I always think about a unit / measure. Examples: bills denominated in $20 and $50. Or as 100 cents makes 1 dollar.
The Merriam-Webster dictionary defines [denomination](https://www.merriam-webster.com/dictionary/denomination) as:
1. an act of denominating. Eg: the denomination of prices in U.S. dollars
2. a value or size of a series of values or sizes. Eg: metric denominations
3. name, designation especially : a general name for a category
It seams that we are using the last definition (3rd).
I think the train of thoughts were interrupted here, removing it for completeness.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
* Update changelog.
* Fix typos.
* Remove 'by default' from packed encoding rule.
* Further specify longer requirement.
* Clarify that bool must have value of 1 if included.
* Fix typo variant -> varint.
* Disambiguate rule 3.
* Add more reasoning for requirements on zeroes.
* Reword rules to make bit restrictions clearer. Add exception for negative int32.
* Add reference for signed integer encoding.
* Clarify rule for signed int requirement.
* Deterministic -> bijective.
* Normalize spacing in 'protobuf 3'.
* Add background to clarify 70 bits.
* Fix nit: all -> most.
* Clarify is -> must.
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* gen ack proto type
* remove transfer ack
* change ics20 ack to use standard type
* update commented tests
* small typo fix
* revert back to module cdc
* update docs
* fix lint
* nit
* update ack event emission
* Update x/ibc-transfer/spec/01_concepts.md
* add comment for onacknowledgement
* Update proto/ibc/channel/channel.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* adr: coin cross-chain transfer source tracing
* update pros and cons
* update spec README
* Update docs/architecture/adr-001-coin-source-tracing.md
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
* Apply suggestions from code review
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
* Update docs/architecture/adr-001-coin-source-tracing.md
* address comments from review
* update ADR with Send/Recv logic
* final touches
* Apply suggestions from code review
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* address comments from review
* address @aaronc review comments
* Apply suggestions from code review
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* use SplitN
* custom denom validation reference
* address some comments from review
* more updates based on Colin's review
* final draft with changes to relay.go
* undo proto changes
* address @aaronc review comments
* why do I keep updating the proto files?
* address @AdityaSripal comments
* address more comments
* typos
* final ammendments
* minor fix
* address more comments
* update example
* Update docs/architecture/adr-001-coin-source-tracing.md
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
* address more comments
* update prefix example
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
* remove verifier
* more removal of trustnode flag
* add todo
* fix lint
* remove file
* remove viper and add link to issue
* remve mention of trustnode
* Formatting documents
* Fixing typos
* Update the intro document to the latest version
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update connection versions with feature set flag
* make connection version modular to support channel versioning and registering
* revert IBCVersion renaming, add channel versioning logic
* fix channel version flag
* remove unnecessary godoc
* remove unused func
* fix lint and version test
* add test and fix error
* revert changes
* update docs
* remove unnecessary godoc
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update doc
* add test cases for unchecked lines
* go fmt
* begin migration to standardized version
* revert proto changes
* restructure versioning to go from string to proto
* update versionStr to encodedVersion naming
* fix version test build
* fix keeper tests
* fix various tests
* fixes from self review
* update docs
* fix lint
* add more code cov
* rename ToString funcs to Encode/DecodeVersion + GetCompatibleEncodedVersions renaming
* update spec docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Aaron Craelius
Sunny Aggarwal
Federico Kunze
Cory
Marie Gauthier
Amaury Martiny
Robert Zaremba
dependabot[bot]
Helder Moreira
puneet2019
John Adler
colin axnér
Anil Kumar Kammari
Cyrus Goh
Simon Warta
Marko
Alexander Bezobchuk
dauTT
Christopher Goes
dependabot-preview[bot]
Emmanuel T Odeke
Adam Bozanich
daoleno
billy rennekamp
Aditya