f04b5dcb96
fix zero coins ( #9229 )
...
* fix zero coins issue
* fix tests
* udpate tests
* Review change
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add change log
* review changes
* review changes
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2021-04-30 16:54:08 +00:00
dfe3e7a8d7
Remove ServiceMsgs from ADR-031 ( #9139 )
...
* wip
* wip
* wip
* wip on refactoring adr 031 type URLs
* Fix msg_service_router
* Fix gov client queries
* Fix some modules tests
* Remove all instances of "*.Msg/*"
* Uncomment code
* Remove commented code
* // simulation.NewWeightedOperation(
* Fix CopyTx
* Fix more tests
* Fix x/gov test
* proto.MessageName->sdk.MsgName
* Fix authz tests
* Use MsgRoute in feegrant and staking/authz
* Fix more tests
* Fix sims?
* Add norace tag
* Add CL
* rebuild rosetta api test data
* Update ADR
* Rename MsgRoute -> MsgTypeURL
* Fix codec registration
* Remove sdk.GetLegacySignBytes
* Update types/tx_msg.go
* Update x/authz/simulation/operations.go
* Move LegacyMsg to legacytx
* Update CHANGELOG.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Remove NewAnyWithCustomTypeURL
* Keep support for ServiceMsgs
* Fix TxBody UnpackInterfaces
* Fix test
* Address review
* Remove support for ServiceMsg typeURLs
* Fix lint
* Update changelog
* Fix tests
* Use sdk.MsgTypeURL everywhere
* Fix tests
* Fix rosetta, run make rosetta-data
* Fix rosetta thanks to froydi
* Address reviews
* Fix test
* Remove stray log
* Update CL
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-04-30 11:00:47 +00:00
e25f80d34c
gov, params: refactor tests ( #9137 )
...
* gov, params: refactor tests
* wrap up params tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-04-30 08:41:25 +00:00
be4a965599
codec: Rename codec and marshaler interfaces ( #9226 )
...
* codec: Rename codec and marshaler interfaces, ref: 8413
* codec: remove BinaryBare
* changelog update
* Update comments and documentation
* adding doc string comments
* Update CHANGELOG.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update codec/codec.go
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-04-29 10:46:22 +00:00
c94e9eb1bb
fix validator address prefix ( #9212 )
...
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-04-29 07:11:32 +00:00
afa818a58f
Added a "new_shares" attribute inside the delegate event type ( #9214 )
...
* Added a "new_shares" attribute inside the delegate event type
* ADded CHANGELOG entry
2021-04-29 06:57:46 +00:00
6ad84c5065
x/gov/keeper: fix flaky TestPaginatedVotesQuery ( #9223 )
...
When testing with -race, sometimes the random source generate the same
string for consecutive calls, causing duplicated voter address. So the
number of votes in DB is not 20.
To fix this, we ensure unique addresses are generated, by using a map
for tracking which one was produced, and skip the duplicated address and
generated new one. Testing with:
go test -race -v -count=1000 -run=TestPaginatedVotesQuery
now passes.
Updates #9010
2021-04-28 17:08:42 +00:00
a2911d0dc6
x/feegrant state machine audit updates ( #9176 )
...
* replace panic with error
* improve test coverage
* add time based tests to basic-fee
* add periodic fee tests
* wip
* add msg_server tests
* improve getFeeGrant
* fix failing test
* fix test
* fix comments
* refactor
* review changes
* review changes
* fix errors
* Update x/feegrant/types/basic_fee_test.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* review changes
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2021-04-28 15:39:58 +00:00
0cbed20db8
x/feegrant audit: clean up / add test coverage to types package ( #9193 )
...
* Squashed commit of the following:
commit 58dc50051226a9eeb8d0ebea5bb0908fe5b9637f
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Fri Apr 23 15:09:27 2021 -0700
remove comments
commit a84107e1b3eaa31324cb0f4f097b49f02af79c69
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Fri Apr 23 15:02:41 2021 -0700
add tests for msgs.go
commit 2ad16869237e9631b402c93cde650c3fc554daf2
Author: technicallyty <48813565+tytech3@users.noreply.github.com>
Date: Fri Apr 23 13:20:21 2021 -0700
specify test name
commit b7121277c9be586a7c80d010ec401e50b510e02a
Merge: c0c134d971 3c65c3dacde28271b8e6bffcae54a1
2021-04-28 14:18:38 +00:00
f32597e510
remove unused list ( #9219 )
2021-04-28 12:46:22 +00:00
15edf3c38f
Add more details in error message for invalid vote option ( #9185 )
...
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-04-28 10:19:08 +00:00
3ab1bc2346
x/feegrant completeness audit updates ( #9177 )
...
* Updates to Genesis
* Move grpc_query tests to keeper pkg
* Unify CLI command usage message
* Use timestamp for time based expiration in cli
* Update FlagExpiration
* Update wording
* Add test case for invalid expiration
* Update cli Long description
* Update exp date examples
* Use constants
2021-04-27 13:37:26 +00:00
fc256a3683
x/feegrant simulation audit changes ( #9145 )
...
* simulation genesis changes
* update msg types
* refactor
* update operations test
* fix sims
* fix tests
* fix tests
* address review changes
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2021-04-27 07:42:48 +00:00
fdbc32e50c
Fixed the --recover flag not working properly inside the init command ( #9201 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-04-26 18:33:30 +00:00
3c65c3dacd
Make integration test suites reusable by apps ( #6711 )
...
* WIP on refactoring new integration tests.
* godocs
* godocs
* Fix ineff assign
* Updates
* Updates
* fix test
* refactor crisis, distr testsuites
* fix import issue
* refactor x/auth
* refactor x/authz
* refactor x/evidence
* refactor x/feegrant
* refactor x/genutil
* refactor x/gov
* refactor x/mint
* refactor x/params
* refactor x/{auth_vesting, slashing, staking}
* fix lint
* fix tests & lint
* fix lint
* fix tests
* lint
* lint
* fix lint memory
* add missing `norace` build flag
* update feegrant cfg
* fix lint
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
2021-04-23 14:49:49 -04:00
bffcae54a1
Add hooks to governance actions ( #9133 )
...
* add governance hooks
* fix lint
* fix lint
* CHANGELOG
* sh -> gh
* improve comments
* add test
* add more tests
* rename two of the hooks
Co-authored-by: ahmedaly113 <ahmedaly113@outlook.com>
2021-04-21 12:59:30 -04:00
603e89541f
Add support for permanent locked vesting accounts ( #8520 )
...
* add basics for permanent locked vesting account support
* remove sdk.Msg support for PermanentLockedVestingAccount
* add tests for PermanentLockedVestingAccount
* remove unecessary tests
* drop unecessary create vesting acct msgs
* Update x/auth/vesting/types/vesting_account.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update x/auth/vesting/types/vesting_account.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update x/auth/vesting/types/vesting_account.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update x/auth/vesting/types/vesting_account_test.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Review changes
* Factorize init function
* Factorize more
* Comments
* Fix build after rename
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-04-21 16:18:28 +00:00
b1cf4793d0
consistency in antehandler ( #9144 )
2021-04-20 09:21:37 +00:00
96fe999343
Set proper default command output ( #8628 )
...
* Set proper default command output
* Removed duplicated cmd.SetErr(cmd.ErrOrStderr()) and cmd.SetOut(cmd.OutOrStdout())
* Moved command initialization and added CHANGELOG
* fix: groom all uses of cmd.Print*
* Ran make format
Co-authored-by: Michael FIG <mfig@agoric.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-04-17 00:21:32 +00:00
b4fc48ca71
Add comment on x/auth hacky migration script ( #9132 )
...
* Add comment on x/auth hacky migration script
* QueryServer -> QueryRouter
2021-04-16 18:00:08 -04:00
89cb9b0f8c
docs: uml hotfix ( #9124 )
...
* comment out ungenerated uml .svg in the md files
* generate svgs to docs/uml
* create docs/uml/svg
* move .punl to docs/uml/puml
* update uml path in md files
* docs: update relative path of uml svg in `x` md files
* docs: remove plantuml script from pre.sh
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-04-16 07:59:21 +00:00
bc4c3be15c
add docs for gas consumption ( #9118 )
...
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-04-15 09:09:01 +00:00
ef69863f46
x/bank/types: fix AddressFromBalancesStore address length overflow ( #9112 )
...
addrLen is encoded in a byte, so it's an uint8. The code in
AddressFromBalancesStore cast it to int for bound checking, but wrongly uses "addrLen+1", which can be overflow.
To fix this, just cast addrLen once and use it in all places.
Found by fuzzing added in #9060 .
Fixes #9111
2021-04-15 00:13:55 -07:00
8ac983fb28
remove unneeded exported files ( #9097 )
...
Co-authored-by: Marko Baricevic <markobaricevic@Fergalicious.fritz.box>
2021-04-12 08:17:02 +00:00
4b778abf91
merged master
2021-04-10 19:23:58 -04:00
10b2b08ece
Merge branch 'master' into powerreduction_param
2021-04-10 16:26:50 -04:00
7a3a156b4f
feegrant filtered msgs ( #8604 )
...
* WIP: add filtered message
* updated `Accept` interface method
* fix tests
* add cli tests for filtered fee allowance
* fix tests
* review changes
* rename `filteredFeeAllowance` message
* review changes
* review changes
* review changes
* review changes
* review changes
* update errors
* remove validation
* fix conflicts
* add `ctx` to `Accept` method
* fix test
* add gas consumption
* review changes
* review changes
* revert
* review changes
* improve error handling
* fix test
* Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/feegrant-filtered-msgs
* review changes
* update gas
* update type
* review changes
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-04-09 16:49:24 +00:00
bb7b2a62cf
build(deps): bump github.com/otiai10/copy from 1.5.0 to 1.5.1 ( #9077 )
...
* build(deps): bump github.com/otiai10/copy from 1.5.0 to 1.5.1
Bumps [github.com/otiai10/copy](https://github.com/otiai10/copy ) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/otiai10/copy/releases )
- [Commits](https://github.com/otiai10/copy/compare/v1.5.0...v1.5.1 )
Signed-off-by: dependabot[bot] <support@github.com>
* fix lint
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
2021-04-09 14:09:25 +00:00
8a376a41c9
x/authz charge gas for expensive authorizations ( #8995 )
...
* WIP
* Add consume gas
* update authz.go
* add build flag
* Update x/staking/types/authz.go
* Update x/staking/types/authz.go
* add tests docs
* review changes
* fix operations
* Update x/authz/types/msgs.go
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* review changes
* update gas cost
* review changes
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-04-09 12:33:27 +00:00
6e26ee9805
bump tendermint core ( #9081 )
2021-04-08 20:22:00 +01:00
93965e0bcc
Write back account changes after tracking delegation/undelegation for vesting accounts ( #8865 )
...
Delegations and undelegations calculations performed during
accounting operations for vesting accounts were correct but
were not written back to the account store.
closes : #8601
closes : #8812
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Frojdi Dymylja <frojdi.dymylja@gmail.com>
Co-authored-by: Adam Bozanich <adam.boz@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2021-04-08 16:20:29 +01:00
8cf5fe0b9b
add nolint to pb.go files
2021-04-07 20:07:52 -04:00
04e483dd69
fixed migrations
2021-04-07 19:56:39 -04:00
61b608f4bc
Merge branch 'master' into powerreduction_param
2021-04-07 13:59:49 -04:00
3a5550a938
x/bank/types: fix AddressFromBalancesStore panics with invalid keys ( #9061 )
...
Currently, AddressFromBalancesStore uses the input key without any
validation, so an empty key or an invalid key length cause it panics.
This commit fixes the problem, by returning an error in case of invalid
key was passed.
Found by fuzzing added in #9060 .
Fixed #9062
2021-04-07 16:20:38 +00:00
a3b3a670aa
Refactor auth cli tests ( #9018 )
...
* refactor cli tests
* add norace
* fix typos
* update docs
* go imports
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-04-07 10:50:16 +00:00
ca34808fdc
merged master
2021-04-06 20:18:20 -04:00
29ff333007
cosmos-reflection: extend to support writing by reflection clients ( #8965 )
...
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-04-07 00:33:54 +01:00
05e2e45010
merged in master
2021-04-06 19:19:59 -04:00
0effd3a9d3
Paginate supply queries ( #8798 )
...
* paginate grpc query
* fix lint
* update tests
* remove GetTotalSupply
* fix test
* remove GetTotalSupply
* add changelog
* update changelog
* update rosetta data
* update limit
* update genesis
* add max limit to query
* fix lint
* go imports
* Update types/query/pagination.go
* update supply
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-04-06 14:43:08 +00:00
4b2fc3bd43
Store supply as Int bytes rather than string bytes ( #9051 )
...
* store supply as int bytes
* update migrate
* update migrate tests
* add error context
* fix lint
* update spec
* add changelog
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
2021-04-06 14:01:57 +00:00
5247a557d5
revert 8909 ( #8960 )
...
* revert 8909
* remove entry from CHANGELOG
* fix test
2021-04-06 11:40:17 +00:00
c41baa9bc8
PlantUML diagrams ( #8712 )
...
* Overview of keepers in object capability model (OCM)
* Updates to the spec, making clarifications
* Create a sequence diagram of a (fresh) delegation
* Misc notes, not yet decided where to put them
* Description of the shares abstraction in validators
* Model all keeper dependencies and move the UML file to docs
* Move and rename delegation sequence diagram
* Move shares description
* Remove TODO
* Diagram touch-ups
* Add how consensus power is calculated
* remove temp file
* Diagram improvements
* Describe slashing in more detail
* Describe redelegation
* Describe unbonding
* Delegation updates
* Delegation updates
* Make a diagram describing overall transaction flow
* Add delegation flows for the events of tokens being bonded/unbonding/etc.
* Grammar fix
* Diagram updates: distinguish alts, remove numbering.
* Use groups instead of "func:" participants
* Remove unused keepers from dependency diagram
* Add title to unbonding diagram
* Move keeper dependencies
* small doc updates
* remove numbers on sequence diagram
* !!!WIP EndBlock
* Explain "Last"-prefix in storage
* Remove `panic` step (they are supposed to never happen)
* EndBlock sequence diagram (with TODOs)
* Add TODO
* More visible TODOs
* Remove numbering
* Complete EndBlock
* Remove numbering
* Remove TODOs and update title
* add title back
* remove endblock seq-diagram
* Make power index update conditional on not being jailed
* update title
* Move files to /docs
* Install PlantUML and compile images to png and txt
* Use transaction flow in documentation
* Use staking UML in staking docs
* Clarify uml with inline doc
* Add keeper deps diagram to docs
* Only produce SVG images
Co-authored-by: hjort <>
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-04-06 09:50:56 +00:00
ccdf896ed7
x/auth new test - multisig tx on simulate endpoint ( #9038 )
...
* merge master
* daily
* test fix / comments
* cleanup
* cleanup
* -remove unecessary balance check
-cleanup imports
* fixed issue
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
2021-04-05 17:04:22 +00:00
5d13b1fc63
InitGenesis in migrations when fromVersion==0 ( #9007 )
...
* InitGenesis in migrations when fromVersion==0
* Add test
* Fix test
* Fix comment
* cdc=>codec
* Don't break Configurator
* Remove method
* Add comments
* Add more comments
* Update types/module/module.go
Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>
* Update types/module/module.go
Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>
* Update types/module/module.go
Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>
2021-04-02 15:41:35 +00:00
e3a0148bf6
x/upgrade: protocol version tracking ( #8897 )
...
* -added consensus version tracking to x/upgrade
* -added interface to module manager -added e2e test for migrations using consensus version store in x/upgrade -cleaned up x/upgrade Keeper -handler in apply upgrade now handles errors and setting consensus versions -cleaned up migration map keys -removed init chainer method -simapp now implements GetConsensusVersions to assist with testing
* protocol version p1
* add protocol version to baseapp
* rebase against master
* add test
* added test case
* cleanup
* docs and change to bigendian
* changelog
* cleanup keeper
* swap appVersion and version
* cleanup
* change interface id
* update keeper field name to versionSetter
* reorder keys and docs
* -move interface into exported folder
* typo
* typo2
* docs on keeper fields
* docs for upgrade NewKeeper
* cleanup
* NewKeeper docs
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-04-02 07:11:58 -07:00
413938c5ed
Add ledger/multisig detection in SignTx functions ( #9026 )
...
* Add ledger/multisig detection in SignTx functions
* Fix tests
* Update CHANGELOG.md
* update cl
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-03-31 09:25:23 +00:00
f8f52c6df6
x/auth: update NewAccountKeeper docs ( #9020 )
...
* x/auth: update NewAccountKeeper docs
* Update x/auth/keeper/keeper.go
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
* Update x/auth/keeper/keeper.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-03-30 13:24:20 +00:00
7fc7b3f6ff
Make clearer that the distribution iterates over all active validators ( #8866 )
...
* Make clearer that the distribution iterates over all active validators, not just ones that voted
* Update x/distribution/keeper/allocation.go
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
* Move comment to docstring
* Change variable name
* Fix: remove git conflict markers
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2021-03-29 16:57:50 +00:00
636e6598b9
fix: grpc-gateway error codes ( #9015 )
...
* update grpc query handler
* try fix http response error codes
* add test
* add changelog
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-03-29 13:42:43 +00:00
atheeshp
Amaury
Federico Kunze
Robert Zaremba
yihuang
Riccardo Montagnin
Cuong Manh Le
MD Aleem
technicallyty
Marko
Devashish Dixit
Marie Gauthier
Aaron Craelius
Sunny Aggarwal
Cory
Cyrus Goh
Sunny Aggarwal
dependabot[bot]
Alessio Treglia
Gianguido Sora
SaReN
Frojdi Dymylja
colin axnér
Rikard Hjort