cb66c99eab
chore: add markdownlint to lint commands ( #9353 )
...
* add markdownlint config
* update make lint commands
* update markdownlint config
* run make lint-fix
* fix empty link
* resuse docker container
* run lint-fix
* do not echo commands
Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com>
2021-05-27 15:31:04 +00:00
9d0504808a
SDK Core Audit - simapp updates ( #9315 )
...
* Make package imports consistent
* Update comment
* Update FundAccount/FundModuleAccount
* Fix bench test
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
2021-05-17 15:42:44 +00:00
b4125d1f0c
Update x/auth AnteHandler Spec ( #9298 )
...
* Update auth antehandler spec
* Update x/auth/spec/03_antehandlers.md
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
* Update x/auth/spec/03_antehandlers.md
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
* Update x/auth/spec/03_antehandlers.md
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
* Use 1 line
* Use backticks
* Use consistent tx naming
* Fix grammar
* Update module naming
* Update x/auth/spec/03_antehandlers.md
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-12 09:10:11 +00:00
e79157c067
Update doc for IterateAccounts x/auth keeper meethod ( #9285 )
...
Co-authored-by: Lazar Ivanovic <livanovic@happiestbaby.com>
2021-05-11 21:13:31 +00:00
56c0595f32
Remove migration scripts <=0.38 ( #9291 )
...
* Remove migration scripts <=0.38
* Add changelog
* remove more
* remove more stuff
* Fix test
* Relase wording
* Add comment
* Include migratio wording
2021-05-11 14:01:13 +00:00
709ab089c1
x/bank v0.43 Audit updates ( #9271 )
...
* add godoc to keeper functions
* re-add ValidateBasic to MsgSend CLI tx
* add comment to reflect new return value on method
* remove unecessary variable
* cleanup key comments
* typo
* unused param
* update messages spec
* move event emission to end of method
* update keeper spec
* update proto message to point correct path to interface
* keeper spec typos
* fix test for event emission being moved
* change to blocklist
* rename SendEnabledCoin(s) -> IsSendEnabledCoins
* typo
* remove unecessary check
* move changelog line
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
2021-05-10 12:17:55 -04:00
56ab4e4c93
Cleanup remains of ServiceMsg ( #9236 )
...
* Remove ServiceMsgClientConn from CLI
* Cleanup Operations
* Remove some legacytx.LegacyMsg
* Update CL
* Remove mentions of ServiceMsg
* Simply reflection MsgDescriptor
* Simplify more
* Add code comment
Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>
2021-05-07 09:31:20 +00:00
3582ccef7c
Move x/feegrant/types to x/feegrant ( #9273 )
...
* Move x/feegrant/types to x/feegrant
* Update spec
* Use feegrantmodule
2021-05-07 07:10:47 +00:00
e3e89f5260
Rename memo to note inside CLI ( #9134 )
...
* rename Memo to note
* update change log
* typo
* address review changes
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-05-04 09:00:54 +00:00
d19791be89
Rename clientCtx.JSONMarshaler to JSONCodec ( #9251 )
...
* Rename clientCtx.JSONMarshaler to JSONCodec
* change md files
* Fix lint
2021-05-03 14:45:47 +00:00
d3bcc15b11
x/feegrant API Audit changes ( #9194 )
...
* -add comments to proto fields
-add comments to msg and query server
-remove decorator from docs
-add coments to msgs.go
-remove decorator from godoc
* Update x/feegrant/spec/04_events.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* refactor and add to docs
*refactor proto msg names and functions
*add docs pertaining to auth's ante handler for deducted fees
* lint
* update comment
* gofmt
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-03 12:34:48 +00:00
dfe3e7a8d7
Remove ServiceMsgs from ADR-031 ( #9139 )
...
* wip
* wip
* wip
* wip on refactoring adr 031 type URLs
* Fix msg_service_router
* Fix gov client queries
* Fix some modules tests
* Remove all instances of "*.Msg/*"
* Uncomment code
* Remove commented code
* // simulation.NewWeightedOperation(
* Fix CopyTx
* Fix more tests
* Fix x/gov test
* proto.MessageName->sdk.MsgName
* Fix authz tests
* Use MsgRoute in feegrant and staking/authz
* Fix more tests
* Fix sims?
* Add norace tag
* Add CL
* rebuild rosetta api test data
* Update ADR
* Rename MsgRoute -> MsgTypeURL
* Fix codec registration
* Remove sdk.GetLegacySignBytes
* Update types/tx_msg.go
* Update x/authz/simulation/operations.go
* Move LegacyMsg to legacytx
* Update CHANGELOG.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Remove NewAnyWithCustomTypeURL
* Keep support for ServiceMsgs
* Fix TxBody UnpackInterfaces
* Fix test
* Address review
* Remove support for ServiceMsg typeURLs
* Fix lint
* Update changelog
* Fix tests
* Use sdk.MsgTypeURL everywhere
* Fix tests
* Fix rosetta, run make rosetta-data
* Fix rosetta thanks to froydi
* Address reviews
* Fix test
* Remove stray log
* Update CL
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-04-30 11:00:47 +00:00
be4a965599
codec: Rename codec and marshaler interfaces ( #9226 )
...
* codec: Rename codec and marshaler interfaces, ref: 8413
* codec: remove BinaryBare
* changelog update
* Update comments and documentation
* adding doc string comments
* Update CHANGELOG.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update codec/codec.go
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-04-29 10:46:22 +00:00
3c65c3dacd
Make integration test suites reusable by apps ( #6711 )
...
* WIP on refactoring new integration tests.
* godocs
* godocs
* Fix ineff assign
* Updates
* Updates
* fix test
* refactor crisis, distr testsuites
* fix import issue
* refactor x/auth
* refactor x/authz
* refactor x/evidence
* refactor x/feegrant
* refactor x/genutil
* refactor x/gov
* refactor x/mint
* refactor x/params
* refactor x/{auth_vesting, slashing, staking}
* fix lint
* fix tests & lint
* fix lint
* fix tests
* lint
* lint
* fix lint memory
* add missing `norace` build flag
* update feegrant cfg
* fix lint
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
2021-04-23 14:49:49 -04:00
603e89541f
Add support for permanent locked vesting accounts ( #8520 )
...
* add basics for permanent locked vesting account support
* remove sdk.Msg support for PermanentLockedVestingAccount
* add tests for PermanentLockedVestingAccount
* remove unecessary tests
* drop unecessary create vesting acct msgs
* Update x/auth/vesting/types/vesting_account.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update x/auth/vesting/types/vesting_account.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update x/auth/vesting/types/vesting_account.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update x/auth/vesting/types/vesting_account_test.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Review changes
* Factorize init function
* Factorize more
* Comments
* Fix build after rename
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-04-21 16:18:28 +00:00
b1cf4793d0
consistency in antehandler ( #9144 )
2021-04-20 09:21:37 +00:00
96fe999343
Set proper default command output ( #8628 )
...
* Set proper default command output
* Removed duplicated cmd.SetErr(cmd.ErrOrStderr()) and cmd.SetOut(cmd.OutOrStdout())
* Moved command initialization and added CHANGELOG
* fix: groom all uses of cmd.Print*
* Ran make format
Co-authored-by: Michael FIG <mfig@agoric.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-04-17 00:21:32 +00:00
b4fc48ca71
Add comment on x/auth hacky migration script ( #9132 )
...
* Add comment on x/auth hacky migration script
* QueryServer -> QueryRouter
2021-04-16 18:00:08 -04:00
4b778abf91
merged master
2021-04-10 19:23:58 -04:00
10b2b08ece
Merge branch 'master' into powerreduction_param
2021-04-10 16:26:50 -04:00
7a3a156b4f
feegrant filtered msgs ( #8604 )
...
* WIP: add filtered message
* updated `Accept` interface method
* fix tests
* add cli tests for filtered fee allowance
* fix tests
* review changes
* rename `filteredFeeAllowance` message
* review changes
* review changes
* review changes
* review changes
* review changes
* update errors
* remove validation
* fix conflicts
* add `ctx` to `Accept` method
* fix test
* add gas consumption
* review changes
* review changes
* revert
* review changes
* improve error handling
* fix test
* Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/feegrant-filtered-msgs
* review changes
* update gas
* update type
* review changes
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-04-09 16:49:24 +00:00
6e26ee9805
bump tendermint core ( #9081 )
2021-04-08 20:22:00 +01:00
93965e0bcc
Write back account changes after tracking delegation/undelegation for vesting accounts ( #8865 )
...
Delegations and undelegations calculations performed during
accounting operations for vesting accounts were correct but
were not written back to the account store.
closes : #8601
closes : #8812
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Frojdi Dymylja <frojdi.dymylja@gmail.com>
Co-authored-by: Adam Bozanich <adam.boz@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2021-04-08 16:20:29 +01:00
61b608f4bc
Merge branch 'master' into powerreduction_param
2021-04-07 13:59:49 -04:00
a3b3a670aa
Refactor auth cli tests ( #9018 )
...
* refactor cli tests
* add norace
* fix typos
* update docs
* go imports
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-04-07 10:50:16 +00:00
ca34808fdc
merged master
2021-04-06 20:18:20 -04:00
29ff333007
cosmos-reflection: extend to support writing by reflection clients ( #8965 )
...
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-04-07 00:33:54 +01:00
05e2e45010
merged in master
2021-04-06 19:19:59 -04:00
ccdf896ed7
x/auth new test - multisig tx on simulate endpoint ( #9038 )
...
* merge master
* daily
* test fix / comments
* cleanup
* cleanup
* -remove unecessary balance check
-cleanup imports
* fixed issue
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
2021-04-05 17:04:22 +00:00
413938c5ed
Add ledger/multisig detection in SignTx functions ( #9026 )
...
* Add ledger/multisig detection in SignTx functions
* Fix tests
* Update CHANGELOG.md
* update cl
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-03-31 09:25:23 +00:00
f8f52c6df6
x/auth: update NewAccountKeeper docs ( #9020 )
...
* x/auth: update NewAccountKeeper docs
* Update x/auth/keeper/keeper.go
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
* Update x/auth/keeper/keeper.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-03-30 13:24:20 +00:00
7568b6680a
Remove bech32 PubKey support ( #7477 )
...
* Move PubKey bech32 to legacy package and migrate the usage where possible
* update /server
* wip
* move proto json encoding helper functions to internal
* update internal/marshal
* wip
* update sections which needs legacybech32
* update validators output
* fix conflicts
* slashing update
* add more tests and helper function for ANY JSON serialization
* update slashing
* Update function documentation
* Rename code any-marshal helper functions
* Update pubkey unpacking test
* Update test comments
* solve TestDecodeStore
* solve legacytx issues
* all code compiles
* keyring tests
* keyring cleanup
* remove AssertMsg
* fix some tests
* fix add_ledger_test.go
* update cli tests
* debug cli test
* rename clashed bech32 names
* linter fixes
* update tmservice tests
* linter: update legacy deprecated checks
* fix names
* linting
* legacybech32 pubkey type rename
* fix staking client
* fix test compilation
* fix TestGetCmdQuerySigningInfo
* rename NewIfcJSONAnyMarshaler
* keyring: remove duplicated information from multinfo structure
* todo cleanups
* Update Changelog
* remove some legacybech32 from tests
* remove todos
* remove printlnJSON from /server CLI and amino encoding
* remove protocdc.MarshalJSON
* client/show remove duplicated function
* remove protocdc package
* comment update
* remove legacybech32.MustMarshalPubKey from a test
* add todo
* fix TestPublicKeyUnsafe test
* review update
* fix bech32 UnmarshalPubKey
* Use codec.MarshalIfcJSON
* fix linter issues
* merging conflict: fix codec.Unmarshal calls
* cleanups
* Update CHANGELOG.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Reword changelog updates
* use pubkey.String for comparison in Test_runAddCmdLedgerWithCustomCoinType
* Update GetCmdQuerySigningInfo example
* cli: update keys add docs
* Add errors AsOf and errors.ErrIO type
* restore multisigPubKeyInfo structure bring it back to multiInfo struct
* Update codec/proto_codec.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update crypto/keys/ed25519/ed25519_test.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update codec/proto_codec.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* move pubkey any marshaling tests
* Apply suggestions from code review
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* review updates
* adding missing return
* errors: use IsOf instead of AsOf
* keyring: add a correct check for key not found in keyring.Get
* add checkKeyNotFound
* fix linter issues
* fix: keyring key not found check
* fix keyring tests
* fix linting issues
* cli tests
* fix: 'simd keys show <key> -p'
* fix: TestVerifyMultisignature
* rename keyring Bech32... functions to Mk...
* fix RunAddCmd
* Update pubkey display
* wip
* add more tests
* udate keyring output tests
* remove todo from ledger tests
* rename MkKeyOutput
* Changelog update
* solve liner issues
* add link to github issue
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2021-03-25 14:53:22 +00:00
1fa2c22d8a
Prefer sending tx_bytes to Simulate gRPC endpoint ( #8926 )
...
* First run
* Remove dead code
* Make test pass
* Proto gen
* Fix lint
* Add changelog
* Fix tests
* Fix test
* Update x/auth/tx/service.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Remove protoTxProvider
* Add grpc-gateway test
* Add comment
* move to api breaking
* lesser diff
* remove conflict
* empty commit to rerun CI
* empty commit to rerun CI
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-03-25 10:52:54 +00:00
025d226099
move feegrant ante to auth ante ( #8682 )
...
* move feegrant ante to auth ante
* update ante builder
* remove commented code
* review changes
* fix lint
* review changes
* review changes
* review changes
* review changes
* fix ante builder
* review changes
* update ante builder with options struct
* review changes
* review changes
* add changelog
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-03-23 07:31:09 +00:00
3361ea989c
exclude test from race detection ( #8949 )
2021-03-22 16:18:06 +00:00
7b1d80e6e4
chore: refactor code quality issues ( #8932 )
...
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2021-03-22 09:30:27 +00:00
1f99aa3fb2
merged in master
2021-03-21 16:37:06 -04:00
7b09f95ab5
add +nobuild flags to all relevant test cases ( #8934 )
...
Closes : #8923
2021-03-19 11:24:29 +00:00
553aac5030
add orderBy parameter to TxsByEvents ( #8815 )
...
* add orderBy parameter to grpc query
* add orderby parameter
* change orderBy param to enum
* lint
* proto lint
* add changelog
* Update x/auth/tx/service.go
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-03-15 17:56:33 +00:00
d4d27e1c0c
Fix multisig LegacyAminoPubKey Amino marshaling ( #8841 )
...
* Use v034auth RegisterCrypto
* Add custom amino for LegacyAminoPubKey
* Fix registercrypto
* Revert old PR
* revert some genutil stuff
* Add comment
* Add changelog
* Remove binary marshalling
* Fix lint
* Fix lint again
* Fix lint, 3rd time's a charm
* ignore wrong linter warning
* Fix UnmarshalAmioJSON
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2021-03-15 12:42:10 +00:00
5f71e93b1e
add --output-document to multisign-batch ( #8873 )
...
Closes : #8870
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2021-03-15 12:18:46 +00:00
adf5f625c1
add orderBy parameter to TxsByEvents ( #8815 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
2021-03-12 18:47:10 +00:00
b9f3db1be8
all: skip noisy/faulty benchmarks + add b.ReportAllocs for every benchmark ( #8856 )
...
* Skips very noisy benchmarks that end up running only for b.N=1 because
their entire time is spent in setup, and varying parameters doesn't change
much given that the number of stores is what dominates the expense. To
ensure we can provide reliable benchmarks, progressively for the project,
skip these until there is a proper re-work of what the benchmarks need to do
* Previously sub-benchmarks: b.Run(...) did not b.ReportAllocs() due to a faulty
assumption that invoking b.ReportAllocs() at the top would be inherited by
all sub-benchmarks. This change fixes that
Fixes #8779
Fixes #8855
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-03-11 15:59:13 +00:00
0e3ff45380
Fix typo ( #8848 )
2021-03-10 21:50:30 +00:00
8f7cdafc32
update SigVerifiableTx.GetPubKeys to return an error ( #8828 )
...
closes : #8129
2021-03-10 07:16:04 +00:00
67964b1df4
fix multisig account pubkeys migration ( #8794 )
...
closes : #8776
2021-03-05 12:33:41 +00:00
a18f0b111a
Enable secp256r1 ( #8786 )
...
* enable secp256r1 in antehandlers
* Add sig verification benchamrk to find a sigverify fee
* adjust the gas fee
* enable secp256r1 in antehandlers
* Add sig verification benchamrk to find a sigverify fee
* adjust the gas fee
* Update the secp256r1 fee factor
* Update changelog
* regenerate docs
2021-03-04 21:31:42 +00:00
da064e13d5
Remove IBC from the SDK ( #8735 )
2021-03-04 13:11:34 +00:00
a93edeef4c
Move QueryTx functions to x/auth/tx ( #8734 )
...
* Use x/auth/client for querying Txs
* Fix lint
* Fix small test
* Update todos
* Move QueryTx functions to x/auth/tx
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-03-01 15:57:28 +00:00
3832860263
Allow REST endpoint to query txs with multisig ( #8730 )
...
* Fix unpack stdtx
* Add test for multisig
* remove println
* Add changelog
* Better UnpackInterfaces
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2021-03-01 13:01:05 +00:00
Ryan Christoffersen
Marie Gauthier
l-parabellum
Amaury
technicallyty
Anil Kumar Kammari
Robert Zaremba
Aaron Craelius
Cory
Marko
Riccardo Montagnin
Sunny Aggarwal
atheeshp
Alessio Treglia
Gianguido Sora
SaReN
Frojdi Dymylja
Aksh Gupta
MD Aleem
Emmanuel T Odeke
Dev Ojha
Akhil Kumar P
colin axnér