Commit Graph

147 Commits

Author SHA1 Message Date
Sunny Aggarwal 81bc4479c0 Merge branch 'master' into gov_split_vote_weighted_vote 2021-01-10 00:27:20 -05:00
Sunny Aggarwal 9635a99e2f
Merge branch 'master' into gov_split_vote_weighted_vote 2020-11-26 13:54:24 -05:00
Sunny Aggarwal b5442e1d5e
Update adr-034-account-rekeying.md 2020-11-24 13:06:58 -05:00
Sunny Aggarwal fd6f07bda2
Merge branch 'master' into sunny/change-pubkey-adr 2020-11-23 16:18:45 -05:00
Sunny Aggarwal 972095e7fa
pruning info 2020-11-23 15:52:47 -05:00
Sunny Aggarwal 101d62a69d
Add details about pruning 2020-11-23 15:47:55 -05:00
Sunny Aggarwal 045e7874b0
Update adr-034-account-rekeying.md
Add stack of past keys
2020-11-23 15:33:40 -05:00
Sunny Aggarwal 20617d0db4
Update docs/architecture/adr-034-account-rekeying.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-11-23 15:30:25 -05:00
Aaron Craelius 251a27d104
Update ADR status (#8009) 2020-11-23 16:31:17 +00:00
Robert Zaremba fe58ee9951
ADR-031: elaborate consequences and encapsulation of module client-se… (#7839)
* ADR-031: elaborate consequences and encapsulation of module client-server implementation

* Update docs/architecture/adr-031-msg-service.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-11-18 23:11:04 +00:00
Sunny Aggarwal e239504bc0
Merge branch 'master' into gov_split_vote_weighted_vote 2020-11-16 01:53:13 -04:00
Sunny Aggarwal a0c1deb2e2 reassign to adr 037 2020-11-11 13:35:07 -04:00
Sunny Aggarwal 138ae178ff
Merge branch 'master' into gov_split_vote_weighted_vote 2020-11-06 12:33:13 -04:00
Sunny Aggarwal bf508d9699
Merge branch 'master' into adr_gov_split_vote 2020-11-06 11:43:20 -04:00
Sunny Aggarwal 53108e7637
Update adr-034-account-rekeying.md 2020-11-06 11:28:18 -04:00
Sunny Aggarwal c4e5e29244
Update and rename adr-034-change-pubkey.md to adr-034-account-rekeying.md 2020-11-06 11:21:45 -04:00
Jonathan Gimeno 4d833f9ef0
ADR 35: Rosetta API Support (#7492)
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: SenorMonito <david@planet-mono.net>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-11-06 10:39:33 +00:00
Sunny Aggarwal 6274240d7c
Apply suggestions from code review
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-11-03 15:55:16 -04:00
Sunny Aggarwal e9d6a8a48d add backwards compatibility section 2020-11-02 12:56:45 -04:00
antstalepresh ebe73fa28b
modify ADR for MsgVote backwards compatibility 2020-11-02 23:10:39 +10:00
Sunny Aggarwal 71e551bbae address @alexanderbez review 2020-10-29 16:35:50 -04:00
Sunny Aggarwal 3a871b86ce sunny updates 2020-10-29 14:09:05 -04:00
Sunny Aggarwal 2ace2a738b
Update docs/architecture/adr-034-change-pubkey.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-10-28 22:20:25 -04:00
antstalepresh ffced9ebef modify title 2020-10-28 23:31:45 +10:00
antstalepresh 5061b8fe19 basic ADR for gov split vote 2020-10-28 23:24:55 +10:00
Sunny Aggarwal 2c58e1806c
Merge branch 'master' into sunny/change-pubkey-adr 2020-10-27 13:42:15 -04:00
Robert Zaremba 5bebf2bd39
ADR: add a process proposal (#7621)
* ADR: add a process proposal

* wording update

* Update docs/architecture/PROCESS.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/PROCESS.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/PROCESS.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Add more details to status section and update the template

* Update docs/architecture/PROCESS.md

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* add a note about ADR pruning

* use sequence numbers

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-22 22:40:44 +00:00
Sunny Aggarwal c8c73a483a
Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-10-22 12:00:16 -04:00
Sunny Aggarwal 091c835060
Update adr-034-change-pubkey.md 2020-10-21 21:44:40 -04:00
Sunny Aggarwal 68ba5647a2
Update adr-034-change-pubkey.md 2020-10-21 21:42:47 -04:00
Sunny Aggarwal cb99dbd413
Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-10-21 21:42:06 -04:00
Sunny Aggarwal 30c13ea554
Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-10-21 15:37:40 -04:00
Aaron Craelius f24ad5d00a
ADR 028: Public Key Addresses (#7086)
* ADR 028: Public Key Addresses

* Cleanup

* Address review comments

* wording update.

* Being more precise about nested addresses in multisig

* Apply suggestions from code review

Co-authored-by: Ethan Buchman <ethan@coinculture.info>

* Address review comments

* Address review comments

* Address review comments

* Describe sorting

* Add abstract

* Update status

* Revert to sha256

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-10-21 16:03:18 +00:00
Amaury Martiny 48bfd73aba
Add background for sequence change in ADR-020 (#7616) 2020-10-21 14:47:31 +00:00
Federico Kunze 503b518efc
client: add GetAccount and GetAccountWithHeight to AccountRetriever (#7558)
* client: add GetAccount and GetAccountWithHeight to AccountRetriever

* update ADR

* address comments from review
2020-10-15 14:19:57 +00:00
colin axnér 24714f80cb
fix typo (#7536)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-10-14 20:17:53 +00:00
Jack Zampolin 36c1b24a06
ADR 32: Typed Events (#7474) 2020-10-13 19:51:47 +01:00
Sunny Aggarwal 2affa79c0a adr 32 -> 34 2020-10-13 10:13:30 -04:00
Aaron Craelius c7d926da2d
ADR 031: Protobuf Msg Services (#7458)
* Ideas

* WIP

* Add ADR 031

* WIP

* WIP

* Revert changes

* Revert changes

* Revert changes

* Updates

* Updates

* Apply suggestions from code review

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>

* Add package names

* Adding clarifications

+ Adding an abstract
+ Updating the first paragraph of decision

* Update Context and wording

* Update wording

* Address proto naming

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Cory <cjlevinson@gmail.com>
2020-10-09 19:13:30 +00:00
Aaron Craelius 90579c0a99
ADR 029: Fee Grant Module (#7106)
* Add ADR 029 stub

* ADR 029 first draft

* Cleanup

* Updates from code review

* Updates from review

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-10-09 15:09:17 +00:00
Sunny Aggarwal df6414d040 adr 2020-10-08 20:47:05 -04:00
Robert Zaremba 435fc83ba7
Updating the ADR template (#7449)
* Updating the ADR template

Introducing few small sections to the template:

* Summary: IMHO it's very valuable for every reader to quickly see what this ADR is about. Must be short.
* Backwards Compatibility -- each ADR MUST analyze backward compatibility issue. Let's make it clear and put as the ADR subsection.
* Test Cases -- often, when analyzing a problem and implementing a solution, it's very useful to define test-cases. Hence it SHOULD be a part of the template.

Inspiration: Enterprise Ethreum Alliance Proposal [template](https://github.com/EntEthAlliance/EEPs/blob/master/draft/templates/EEP0002-Standards_Proposal_Template.md)

* change Summary -> Abstract
2020-10-05 21:34:41 +00:00
Aaron Craelius 852e7693a7
Update ADR 023 package versioning guidelines (#6954)
* ADR 023 updates

* ADR 023 updates

* ADR 023 updates

* Update docs/architecture/adr-023-protobuf-naming.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update ADR 023

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-10-05 11:49:13 +00:00
Sunny Aggarwal cdf9bd2a4f
Proportional slashing ADR Update (#6368)
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
2020-10-05 09:30:50 +02:00
Federico Kunze 2c93ec7a0c
ibc: core restructure (#7434)
* ibc: protobuf v1

* update codec

* core client

* core connection

* core host

* core commitment

* core port

* core channel

* core ibc module files

* core exported

* core types & simulation

* core spec

* make proto-all

* ibc alias
2020-10-02 06:03:02 -03:00
Federico Kunze 72353902e2
ibc: rename epoch -> version (#7429)
* ibc: rename epoch -> version

* more renaming

* update spec
2020-10-01 15:08:26 +00:00
Marie Gauthier 489599b70f
Remove the old message PublicKey proto oneof (#7390)
* Remove unused PublicKey type and update docs

* Update wording

* Update proto/cosmos/base/crypto/v1beta1/crypto.proto

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Edit docs

* Move crypto.proto to multisig

* Proto linting

* Update docs/architecture/adr-020-protobuf-transaction-encoding.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update wording for Public Key Encoding

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-09-29 10:01:54 +00:00
Cory 308ee267a8
Followup suggestions from ADR-027 updates (#7232) (#7379)
* add grammar suggestions to adr-027

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-28 09:42:57 +00:00
Robert Zaremba 09998ef86e
adr-27: adding (#7232)
* adr-27: adding 

Each ADR should have an abstract and an example use case to quickly present the goal.
Here, adding this to DR 027: Deterministic Protobuf Serialization

* review update

* added link to TxRaw

* added list of major use-cases

* updated wording in context and abstract

* updated the adr-020 part

* add consequences and motivation for TxRaw

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* rewording

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-23 23:06:55 +00:00
Amaury Martiny 7cd25abb87
Proto Tx with Any (#7276)
* WIP on protobuf keys

* Use Type() and Bytes() in sr25519 pub key Equals

* Add tests

* Add few more tests

* Update other pub/priv key types Equals

* Fix PrivKey's Sign method

* Rename variables in tests

* Fix infinite recursive calls

* Use tm ed25519 keys

* Add Sign and VerifySignature tests

* Remove ed25519 and sr25519 references

* proto linting

* Add proto crypto file

* Implement some of the new multisig proto type methods

* Add tests for MultisigThresholdPubKey

* Add tests for pubkey pb/amino conversion functions

* Move crypto types.go and register new proto pubkeys

* Add missing pointer ref

* Address review comments

* panic in MultisigThresholdPubKey VerifySignature

* Use internal crypto.PubKey in multisig

* Add tests for MultisigThresholdPubKey VerifyMultisignature

* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1

* Remove conversion functions and introduce internal PubKey type

* Override Amino marshaling for proto pubkeys

* Merge master

* Make proto-gen

* Start removal of old PubKeyMultisigThreshold references

* Fix tests

* Fix solomachine

* Fix ante handler tests

* Pull latest go-amino

* Remove ed25519

* Remove old secp256k1 PubKey and PrivKey

* Uncomment test case

* Fix linting issues

* More linting

* Revert tests keys values

* Add Amino overrides to proto keys

* Add pubkey test

* Fix tests

* Use threshold isntead of K

* Standardize Type

* Revert standardize types commit

* Fix build

* Fix lint

* Fix lint

* Add comment

* Register crypto.PubKey

* Add empty key in BuildSimTx

* Simplify proto names

* Unpack interfaces for signing desc

* Fix IBC tests?

* Format proto

* Use secp256k1 in ibc

* Fixed merge issues

* Uncomment tests

* Update x/ibc/testing/solomachine.go

* UnpackInterfaces for solomachine types

* Remove old multisig

* Add amino marshal for multisig

* Fix lint

* Correctly register amino

* One test left!

* Remove old struct

* Fix test

* Fix test

* Unpack into tmcrypto

* Remove old threshold pubkey tests

* Fix register amino

* Fix lint

* Use sdk crypto PubKey in multisig UnpackInterfaces

* Potential fix?

* Register LegacyAminoPubKey

* Register our own PubKey

* Register tmcrypto PubKey

* Register both PubKeys

* Register interfaces in test

* Refactor fiels

* Add comments

* Use anil's suggestion

* Add norace back

* Check nil

* Address comments

* FIx lint

* Add tests for solomachine unpack interfaces

* Fix query tx by hash

* Better name in amino register

* Display StdTx instead of proto Tx

* Remove useless check

Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-09-21 16:48:28 +00:00