## Description
now that Vega upgrade has passed and IBC is a standalone module, a clear definition of the IBC project is needed more than ever. This helpful plain language description helps visitors understand IBC.
It's funny that I haven't submitted this fix before since I get frustrated every time I visit the [IBC Overview](https://docs.cosmos.network/master/ibc/overview.html) doc and don't find the answer to the heading question `What is the Inter-Blockchain Communication Protocol (IBC)?`
Let's add a description of IBC following that question
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
* went to fix a broken link and then got caught up in an editorial quick sweep to address style, typos, and clarity issues
* typo
* removed the commented out link to use cases, can replace with link to website when the site has the use cases.
* get corrected links from #9005
* Update docs/ibc/overview.md
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Apply Colin's suggestions from code review
thank you for your careful review, I appreciate you
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* resolve merge conflict with link fixes, I hope these are correct
* is like (was analogous)
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* add zeroed custom fields check to tm client
* remove custom fields function from x/upgrade and fix tests
* use []byte in x/upgrade, move abci to 02-client
* remove x/ibc from types
* whoops, delete testing files
* fix upgrade tests
* fix tm tests
* fix tests
* update CHANGELOG
* revert proto breakage, use reserved field cc @amaurym
* add IBC Upgrade Proposal type
* remove IBC from upgrade types
* add IBC upgrade logic to 02-client
* fix all tests for x/upgrade
* Add CLI for IBC Upgrade Proposal
* Update x/ibc/core/02-client/types/proposal_test.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add gRPC for upgraded client state
* test fixes
* add HandleUpgradeProposal tests
* update docs and remove unnecessary code
* self review bug and test fixes
* neatness
* construct empty rest handler
* fix tests
* fix stringer tests
* Update docs/core/proto-docs.md
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* add key in ibc store tracking ibc upgrade heights
Add a new Key to the IBC client store to track the IBC Upgrade Height. This allows IBC upgrades to correctly remove old IBC upgrade states
* update abci and tests
* revert key storage after discussion with @AdityaSripal
Revert using a key to track IBC upgrades. By clearing any IBC state using an old plan in ScheduleUpgrade, IBC upgrades do not need to be tracked by IBC. This reduces code complexity and reduces potential for bugs.
* clear IBC states on cancelled upgrades
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* Add function to query ack proofs
* fix bugs
* fix swagger
* fix final queries
* docs and add test case
* Rename QueryUnrelayedAcks to more accurate QueryUnreceivedAcks
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address rest of reviews
* consistent spelling
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* gen ack proto type
* remove transfer ack
* change ics20 ack to use standard type
* update commented tests
* small typo fix
* revert back to module cdc
* update docs
* fix lint
* nit
* update ack event emission
* Update x/ibc-transfer/spec/01_concepts.md
* add comment for onacknowledgement
* Update proto/ibc/channel/channel.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* update connection versions with feature set flag
* make connection version modular to support channel versioning and registering
* revert IBCVersion renaming, add channel versioning logic
* fix channel version flag
* remove unnecessary godoc
* remove unused func
* fix lint and version test
* add test and fix error
* revert changes
* update docs
* remove unnecessary godoc
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update doc
* add test cases for unchecked lines
* go fmt
* begin migration to standardized version
* revert proto changes
* restructure versioning to go from string to proto
* update versionStr to encodedVersion naming
* fix version test build
* fix keeper tests
* fix various tests
* fixes from self review
* update docs
* fix lint
* add more code cov
* rename ToString funcs to Encode/DecodeVersion + GetCompatibleEncodedVersions renaming
* update spec docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>