Luke Rhoads
bf11b1bf1f
refactor: Implementing sigs.k8s.io YAML to remove .proto yaml annotations ( #9780 )
...
## Description
Draft of: #9705
Started off with changing codec `MarshalYaml` function to directly go from JSON to yaml using the new library. Replaced the only usage of UnmarshalYaml per request.
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting ))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules )
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing )
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc )
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [x] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [x] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [x] reviewed state machine logic
- [x] reviewed API design and naming
- [x] reviewed documentation is accurate
- [x] reviewed tests and test coverage
- [x] manually tested (if applicable)
2021-09-24 14:37:34 +00:00
Anil Kumar Kammari
d55c1a2665
Change `address` from bytes to bech32 strings ( #7242 )
...
* init
* Fix bank proto messages
* missing conversions
* remove casttype for addresses
* Fix tests
* Fix consaddress
* more test fixes
* Fix tests
* fixed tests
* migrate missing proto declarations
* format
* Fix format
* Fix alignment
* Fix more tests
* Fix ibc merge issue
* Fix fmt
* Fix more tests
* Fix missing address declarations
* Fix staking tests
* Fix more tests
* Fix config
* fixed tests
* Fix more tests
* Update staking grpc tests
* Fix merge issue
* fixed failing tests in x/distr
* fixed sim tests
* fixed failing tests
* Fix bugs
* Add logs
* fixed slashing issue
* Fix staking grpc tests
* Fix all bank tests :)
* Fix tests in distribution
* Fix more tests in distr
* Fix slashing tests
* Fix statking tests
* Fix evidence tests
* Fix gov tests
* Fix bug in create vesting account
* Fix test
* remove fmt
* fixed gov tests
* fixed x/ibc tests
* fixed x/ibc-transfer tests
* fixed staking tests
* fixed staking tests
* fixed test
* fixed distribution issue
* fix pagination test
* fmt
* lint
* fix build
* fix format
* revert tally tests
* revert tally tests
* lint
* Fix sim test
* revert
* revert
* fixed tally issue
* fix tests
* revert
* fmt
* refactor
* remove `GetAddress()`
* remove fmt
* revert fmt.Striger usage
* Fix tests
* Fix rest test
* disable interfacer lint check
* make proto-format
* add nolint rule
* remove stray println
Co-authored-by: aleem1314 <aleem.md789@gmail.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
2020-09-25 10:25:37 +00:00
Amaury Martiny
5559af8b97
Proto Auditing: Replace ID with Id ( #7032 )
...
* Proto Auditing: Replace ID with Id
* make proto-gen
* Update docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-14 08:55:54 +00:00
SaReN
919e906866
Minor Code Cleanup - gRPC queries ( #6862 )
...
* add missing RegisterQueryService
* Update generated proto files
* Update grpc tests for auth,bank
* Make format
* fix godoc
* Address suggestions
* Update godoc
2020-07-28 12:53:35 +00:00
Aleksandr Bezobchuk
fb42f8b2a0
types updates
2020-03-02 15:50:20 -05:00
Aleksandr Bezobchuk
7562c2765a
Update gov types
2020-03-02 14:13:42 -05:00
Aaron Craelius
e8155d67d0
Simple refactoring of gov to use protobuf for store encoding (for everything besides proposal)
2020-02-26 20:15:00 -05:00
Federico Kunze
e4c8bd72b7
Merge PR #4665 : Refactor x/gov Module Structure (prep for module spec)
2019-08-08 15:51:18 -04:00
Aayushi Jain
1a7f31f7c8
Merge PR #4678 : Clean YAML output
2019-07-05 19:25:56 -04:00
Federico Kunze
fe695b8f7b
Merge PR #4460 : Gov Keys and Iterators
...
* refactor gov keys
* iterators and renamings
* invert queue key order
* changelog
* fix tests
* update alias.go
* Apply suggestions from code review
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* rename keys
* rename functions
* Apply suggestions from code review
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* address Aleks' comments
* fix test
* address Karoly's comments
2019-06-04 11:38:11 -07:00
Alexander Bezobchuk
5ca93ac574
Merge PR #4206 : Param Change Proposal
...
* Add params error types
* Update param module keeper to take a codespace
* Update imports
* Implement SetRaw and SetRawWithSubkey
* Implement ParamChange and update aliases
* Add types codec
* Implement ParameterChangeProposal
* Implement TestParameterChangeProposal
* Fix linting errors
* Update tags
* Implement content
* Updata params aliases
* Finish params handler and proposal types
* Move deposit and vote logic to types package
* Move proposal type to types package
* Move errors to types package
* Update proposal
* Move gov messages to types package
* Minor updates to naming
* Move keys to types package
* Move codec to types package
* Move proposal types to types package
* Update aliases
* Add governance alias types
* Implement governance router
* Update gov aliases
* Update gov keeper
* Update private functions needed for the keeper
* Update godocs
* Update the gov message handler
* Update Gaia app
* Make updates to auth
* Update the message codec in the keeper
* Update gov end blocker
* Update types tests
* Minor tweaks
* Add legacy genesis logic
* Update gov aliases
* Move gov keys to types package
* Revertt to using gov/types in params
* Implement params handler test
* Update governance tests
* Fix endblocker tests
* Fix governance querier tests
* Add seal support to gov router
* Update simulationCreateMsgSubmitProposal
* Disable software upgrade proposals
* Move params keys to types package
* Implement param module proposal client logic
* Update gov client logic
* Update gaia app client hooks
* Fix linting errors
* Fix ValidateBasic
* Remove legacy files
* Update paramchange to use strings
* Update paramchange cli cmd
* Update ValidateBasic and errors
* Use PostCommands when adding child cmds
* Fix codec logic
* Update params client and handler
* Update IsValidProposalType
* Update SubmitProposal to test exec
* Implement TestGaiaCLISubmitParamChangeProposal
* Implement TestSubmitParamChangeProposal
* Update swagger.yaml
* Update gaiacli.md
* Update gov spec docs
* Fix linting errors
* Fix unit tests
* Add pending log entries
* Update docs
* Update docs
* Update client/lcd/swagger-ui/swagger.yaml
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update docs/cosmos-hub/gaiacli.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update cmd/gaia/cli_test/test_helpers.go
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update client/lcd/test_helpers.go
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update docs/cosmos-hub/gaiacli.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update docs/cosmos-hub/gaiacli.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update docs/cosmos-hub/gaiacli.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update x/gov/types/proposal.go
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update docs/cosmos-hub/gaiacli.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update docs/cosmos-hub/gaiacli.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Address PR comments
* Update docs/cosmos-hub/gaiacli.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update gov docs to include quorum notes
* Add logs to handleParameterChangeProposal
* Update docs/spec/governance/02_state.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Support and use new StatusFailed when proposal passes but fails exec
* Add docs/notes warning on param validity
* Update docs
* Update docs/spec/governance/02_state.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Update docs/spec/governance/02_state.md
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Minor doc update
* Update x/gov/client/cli/tx.go
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Fix usage of fromAddr
* Rige code style suggestion
* Update x/params/types/proposal.go
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
* Fix CI lint errors
* Update NewModuleClient godoc
* Add godoc to rtr.Seal() call
* Rename files
* Rename NewProposalHandler
2019-04-30 12:31:38 -04:00