certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
8,941 Commits 36 Branches 291 Tags 166 MiB
Commit Graph

246 Commits

Author SHA1 Message Date
chengwenxi af689350c7 resolve #9284 comments 2021-05-17 18:00:42 +08:00
Andrea Giacobino 25ecec6c15
rosetta: upgrade to newest version (#9314) 
* feat:  update rosetta sdk to v0.6.10 

embed from v1.0.0 release branch of the library: https://github.com/tendermint/cosmos-rosetta-gateway/tree/release/v1.0.0

closes:
https://github.com/cosmos/cosmos-sdk/issues/9300

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
 2021-05-15 00:18:59 +02:00
chengwenxi bdb6005015 Merge branch 'shahan/adr-043-nft' 2021-05-14 12:05:39 +08:00
Robert Zaremba f1de92fef0
ADR-040: Storage and SMT State Commitments (#8430) 
* ADR-040: Storage and SMT State Commitments

* Update docs/architecture/adr-040-storage-and-smt-state-commitments.md

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>

* Update docs/architecture/adr-040-storage-and-smt-state-commitments.md

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>

* Added more details for snapshotting and pruning.

* updated links and references

* add blockchains which already use SMT

* reorganize versioning and pruning

* Update docs/architecture/adr-040-storage-and-smt-state-commitments.md

Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>

* Update docs/architecture/adr-040-storage-and-smt-state-commitments.md

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>

* adding a paragraph about state management

* adr-40: update 'accessing old state' section

* update based on all recent discussions and validations

* adding more explanation about KV interface

* Apply suggestions from code review

Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Marko <marbar3778@yahoo.com>

* Apply suggestions from code review

Co-authored-by: Marko <marbar3778@yahoo.com>

* review comments

* adding paragraph about commiting to an object without storying it

* review updates

* Apply suggestions from code review

Co-authored-by: Roy Crihfield <30845198+roysc@users.noreply.github.com>

* review udpates

* adding clarification

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Roy Crihfield <30845198+roysc@users.noreply.github.com>
 2021-05-11 16:45:29 -04:00
Shahan Khatchadourian 6c923d39be Adding specifications to NFT fields and clarity on usage. 2021-05-10 15:35:30 -04:00
Shahan Khatchadourian 38762621a3
Merge branch 'master' into master 2021-05-10 11:50:18 -07:00
Marie Gauthier 6425825cac
ADR-042: Group module (#9089) 
* Add ADR-042

* Fix link

* Small improvements

* Update link

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

* Update docs/architecture/adr-042-group-module.md

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

* Update docs/architecture/adr-042-group-module.md

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-042-group-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Move orm to specific section

* Update docs/architecture/adr-042-group-module.md

* Update naming

* Add concrete use cases

* Rework ### Proposal

* Rework Vote, Exec and implementation sections

* Update to account for removal of ServiceMsg

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-05-10 12:53:47 +00:00
HackMD 8701e97c65 Add ADR-043 BaseNFT Module 2021-05-08 07:00:58 +00:00
Robert Zaremba 1986104ef4
ADR-30 (authz) update based on authz audit (#9270) 
* ADR-30 (authz) update based on authz audit

* changelog and comment update

* fix linter issue

* Apply suggestions from code review

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* Update MsgGrant to reuse the Grant type

* Update docs/architecture/adr-030-authz-module.md

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
 2021-05-07 19:38:43 +00:00
MD Aleem 1e1c812de2
x/feegrant remove height base expiration (#9206) 
* remove height from proto files

* remove PrepareForExport

* fix basic fee

* fix periodic fee

* fix errors

* fix error

* fix errors

* add tests

* review changes

* fix errors

* fix tests

* fix lint error

* Update x/feegrant/types/basic_fee.go

Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>

* fix errors

* fix keeper tests

* Update x/feegrant/keeper/keeper_test.go

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

* review changes

* review changes

* fix tests

* run make proto-gen

* fix errors

* Update x/feegrant/keeper/keeper_test.go

Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>

* Update x/feegrant/keeper/keeper_test.go

* update ADR

* add test

* review changes

* review changes

Co-authored-by: technicallyty <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-05-05 16:29:22 +00:00
Amaury d19791be89
Rename clientCtx.JSONMarshaler to JSONCodec (#9251) 
* Rename clientCtx.JSONMarshaler to JSONCodec

* change md files

* Fix lint
 2021-05-03 14:45:47 +00:00
Amaury dfe3e7a8d7
Remove ServiceMsgs from ADR-031 (#9139) 
* wip

* wip

* wip

* wip on refactoring adr 031 type URLs

* Fix msg_service_router

* Fix gov client queries

* Fix some modules tests

* Remove all instances of "*.Msg/*"

* Uncomment code

* Remove commented code

* // simulation.NewWeightedOperation(

* Fix CopyTx

* Fix more tests

* Fix x/gov test

* proto.MessageName->sdk.MsgName

* Fix authz tests

* Use MsgRoute in feegrant and staking/authz

* Fix more tests

* Fix sims?

* Add norace tag

* Add CL

* rebuild rosetta api test data

* Update ADR

* Rename MsgRoute -> MsgTypeURL

* Fix codec registration

* Remove sdk.GetLegacySignBytes

* Update types/tx_msg.go

* Update x/authz/simulation/operations.go

* Move LegacyMsg to legacytx

* Update CHANGELOG.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Remove NewAnyWithCustomTypeURL

* Keep support for ServiceMsgs

* Fix TxBody UnpackInterfaces

* Fix test

* Address review

* Remove support for ServiceMsg typeURLs

* Fix lint

* Update changelog

* Fix tests

* Use sdk.MsgTypeURL everywhere

* Fix tests

* Fix rosetta, run make rosetta-data

* Fix rosetta thanks to froydi

* Address reviews

* Fix test

* Remove stray log

* Update CL

Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
 2021-04-30 11:00:47 +00:00
Robert Zaremba be4a965599
codec: Rename codec and marshaler interfaces (#9226) 
* codec: Rename codec and marshaler interfaces, ref: 8413

* codec: remove BinaryBare

* changelog update

* Update comments and documentation

* adding doc string comments

* Update CHANGELOG.md

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* Update codec/codec.go

Co-authored-by: Marko <marbar3778@yahoo.com>

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
 2021-04-29 10:46:22 +00:00
colin axnér 556134c89b
remove IBC ADRs (#9191) 
* remove IBC ADRs

* remove ADR references from README

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-04-26 11:05:24 +00:00
Frojdi Dymylja 83645e0360
ADR036: Arbitrary signature (#7727) 
* add: arbitrary signature adr draft

* fix: adr number

* change: adjust scope, address feedback

* fix: missing sentence

* change: address wording

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* change: address wording and formatting

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* change: address formatting

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* change: message name, address modal verbs changes

* change: document how MsgSignData should be used

* change: address wording

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* add: how verification works

* Update docs/architecture/adr-036-arbitrary-signature.md

* Update docs/architecture/adr-036-arbitrary-signature.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Apply suggestions from code review

* Update docs/architecture/adr-036-arbitrary-signature.md

* add: expand further discussion items

* fix: wording

* add: context references

* change: split offchain tx specific from MsgSignData

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marko <marbar3778@yahoo.com>
 2021-04-19 16:18:48 +00:00
Robert Zaremba e43edc4749
ADR-28 derive address functions (#9088) 
* update Derive functions

* update adr-028

* changelog update

* Apply suggestions from code review

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

* review updates

* remove DeriveMulti and rollback some changes in CHANGELOG

* add noop error check

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
 2021-04-15 21:32:45 +00:00
Ian Norden feed37dc56
ADR-038 Part 1: WriteListener, listen.KVStore, MultiStore and KVStore updates (#8551) 
* StoreKVPair protobuf message definition and generated go types

* store WriteListener

* update MultiStore, CacheWrap, CacheWrapper interfaces

* adjust KVStores to fit new CacheWrapper interface

* new ListenKVStore

* adjust multistores to fit new MultiStore interface and enable wrapping returned KVStores with the new ListenKVStore

* typo fixes in adr

* ListenKV Store test

* update server mock KVStore and MultiStore

* multistore unit test; fix multistore constructor

* update changelog

* fix bug identified in CI

* improve codecov, minor fixes/adjustments

* review fixes

* review updates; flip set to delete in KVStorePair, updated proto-docs from running 'make proto-gen'
 2021-03-30 16:13:51 -04:00
Robert Zaremba 823620c231
docs: update bech32 account docs (#9006) 
* docs: update bech32 account docs

* docs: update other places for bech32 and pubkeys

Co-authored-by: Marko <marbar3778@yahoo.com>
 2021-03-29 11:22:30 +00:00
Tim Lind 5a142db6f0
Fix broken ICS links on ADR001 (#8971) 
Docs have moved to IBC repo

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-03-25 07:20:28 +00:00
Tim Lind 5b10af48c6
Fix broken relative link in ADR033 (#8977) 
* Fix broken relative link in ADR033

Replaced with absolute URL

* Update docs/architecture/adr-033-protobuf-inter-module-comm.md

Co-authored-by: Marko <marko@baricevic.me>

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
 2021-03-25 07:12:42 +00:00
Tim Lind 863d7d033f
Fix broken links to ICS specs (#8972) 
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
 2021-03-24 10:23:31 +00:00
Tim Lind c0d306ba50
Fix link to ICS007 on ADR026 (#8976) 
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
 2021-03-24 10:16:10 +00:00
Tim Lind 4a93db78dc
Fix broken links to ICS26 in ADR015 (#8974) 
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
 2021-03-24 09:23:00 +00:00
Tim Lind c45775475a
Fix link to ICS2 on ADR017 (#8975) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-03-24 08:30:00 +00:00
technicallyty 5bd93bfe7b
x/upgrade: added consensus version tracking (part of ADR-041) (#8743) 
* -added consensus version tracking to x/upgrade

* -added interface to module manager -added e2e test for migrations using consensus version store in x/upgrade -cleaned up x/upgrade Keeper -handler in apply upgrade now handles errors and setting consensus versions -cleaned up migration map keys -removed init chainer method -simapp now implements GetConsensusVersions to assist with testing

* Changed MigrationMap identifier to VersionMap
removed module_test

* updated docs

* forgot this

* added line to changelog for this PR

* Change set consensus version function to match adr 041 spec

* add documentation

* remove newline from changelog

unnecessary newline removed

* updated example in simapp for RunMigrations, SetCurrentConsensusVersions now returns an error

* switch TestMigrations to use Require instead of t.Fatal

* Update CHANGELOG.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* docs for SetVersionManager

* -init genesis method added -removed panics/fails from setting consensus versions

* update identifiers to be more go-like

* update docs and UpgradeHandler fnc sig

* Upgrade Keeper now takes a VersionMap instead of a VersionManager interface

* upgrade keeper transition to Version Map

* cleanup, added versionmap return to RunMigrations

* quick fix

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* remove support for versionmap field on upgrade keeper

* cleanup

* rename get/set version map keeper functions

* update adr doc to match name changes

* remove redudant line

Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-03-19 22:01:29 +00:00
Robert Zaremba cc1db18df5
doc secp256r1 (#8899) 
* Update docs for things related to secp256r1

* docs: update accounts and pubkey documentation

* update table formatting

* Apply suggestions from code review

Co-authored-by: Alessio Treglia <alessio@tendermint.com>

* Apply suggestions from code review

Awesome grammar fixes and style improvements

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Apply suggestions from code review

Awesome grammar and style improvements.

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>

* hd wallet docs update

* Apply suggestions from code review

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Update docs/basics/accounts.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* Update docs/architecture/adr-020-protobuf-transaction-encoding.md

I agree, let's use "and"

* update code snippet links

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
 2021-03-19 14:22:59 +00:00
Amaury 1a4418b32b
Docs: Anys Usage, Events & small cleanups (#8895) 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
 2021-03-17 12:15:20 +00:00
Amaury 6ac8898fec
Move all migration scripts to v043 (#8814) 
* Move all migration scripts to v043

* Fix permaling

* Fix test

* Fix test again

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-03-08 22:36:06 +00:00
Amaury 95fa768671
ADR 041: In-Place Store Migrations (#8646) 
* Initial draft

* Draft

* Add x/upgrade stuff

* Tweaks

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>

* Reviews

* Use migrator

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* More fixes

* Add grpc, use functions

* Add special case with 0 version

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Update docs/architecture/adr-041-in-place-store-migrations.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Remove useless err return

Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-03-04 17:28:35 +00:00
Dev Ojha c0fd863ef1
Merge branch 'master' into adr-epoched-staking 2021-02-25 21:48:57 -06:00
Amaury 19e79e00d6
ADR-019/020 cleanups: HybridCodec, Pubkey (#8683) 
* wip adr019

* Remove hybrid codec

* Change date

* Update docs/architecture/adr-019-protobuf-state-encoding.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update pubkey interface

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-02-25 15:40:04 +00:00
Robert Zaremba 06ababdf36
ADR-033 cosmetic updates (#8676) 
* ADR-033 cosmetic updates

* Apply suggestions from code review

Co-authored-by: Aaron Craelius <aaron@regen.network>

* remove invoker middleware framing

* Update NewFooMsgServer

* Update docs/architecture/adr-033-protobuf-inter-module-comm.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Update docs/architecture/adr-033-protobuf-inter-module-comm.md

Co-authored-by: Cory <cjlevinson@gmail.com>

* Update docs/architecture/adr-033-protobuf-inter-module-comm.md

Co-authored-by: Cory <cjlevinson@gmail.com>

Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-02-24 11:45:21 +00:00
ValarDragon d880d74498 Fix accidentally committed files 2021-02-22 17:39:50 -06:00
ValarDragon 649a4e603a Add section for parameterizing the epoch length 2021-02-22 15:37:53 -06:00
ValarDragon e858c51799 Missed a comment 2021-02-22 14:38:08 -06:00
ValarDragon 846cede5bf Repsond to comments, improve descriptions 2021-02-22 14:33:47 -06:00
Aaron Craelius 7e481cc716
ADR 033: Inter-Module Communication (#7459) 
* Initial WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* Update Invoker

* WIP

* Tidying up

* Update title

* Cleanup diff

* cleanup

* Update context

* Add ClientConn impl

* WIP

* updates

* revert go.mod

* Describe internal methods and authorization

* Add comparison to x/capability

* Cleanup

* Apply suggestions from code review

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-033-protobuf-inter-module-comm.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-033-protobuf-inter-module-comm.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-033-protobuf-inter-module-comm.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-033-protobuf-inter-module-comm.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* ADR-033 Updates / Amendments (#8190)

* updates to ADR33 based on 12.04.20 architecture call

* add comments about improved devx

* Update docs/architecture/adr-033-protobuf-inter-module-comm.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* update with atomicity note

Co-authored-by: Aaron Craelius <aaron@regen.network>

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
 2021-02-19 15:34:54 +00:00
colin axnér 47dd07d4ff
Modify IBC client governance unfreezing to reflect ADR changes (#8405) 
* update proto files

* make proto-gen

* update clienttypes

* update localhost and solo machine

* refactor tm client proposal handling

* copy metadata

* self review fixes

* update 02-client keeper tests

* fix 02-client type tests

* fix localhost and solomachine tests

* begin updating tm tests

* partially fix tm tests

* increase codecov

* add more tests

* add changelog

* update specs

* add docs

* fix test

* modify adr

* allow modified chain-ids

* add CLI command

* fix typos

* fix lint

* Apply suggestions from code review

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* update docs, rm example

* Update docs/ibc/proposals.md

Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>

* update height checks to reflect chain-id changes cc @AdityaSripal

* Apply suggestions from code review

Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>

* Apply suggestions from code review

Co-authored-by: Aditya <adityasripal@gmail.com>

* address most of @AdityaSripal suggestions

* update docs per review suggestions

* Update x/ibc/core/02-client/types/proposal.go

* add proposal handler

* register proposal type

* register proposal on codec

* fix routing

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: Aditya <adityasripal@gmail.com>
 2021-02-16 15:31:40 +00:00
ValarDragon f4d328cc27 Merge branch 'adr-epoched-staking' of github.com:sikkatech/cosmos-sdk into adr-epoched-staking 2021-02-15 13:24:55 -06:00
Sunny Aggarwal 3a7cc3bd3a epoched staking 2021-02-11 16:23:53 -05:00
ValarDragon 352a19e6eb Add epoched staking ADR 2021-02-11 11:30:42 -06:00
antstalepresh 404dc4f356 Merge branch 'master' of github.com:sikkatech/cosmos-sdk into gov_split_vote_weighted_vote 2021-02-06 01:03:32 +10:00
antstalepresh b55913ddad fix comments and add CHANGELOG 2021-02-06 00:57:12 +10:00
Ian Norden a3757e14a8
ADR 038: State Listening (#8012) 
* ADR-038 state listening

* updates/fixes

* review fixes/adjustments

* review fixes/adjustments part 2

* review updates part 3: refactor after review to coordinate store changes with block and tx messages and enable file pruning

* review updates part 4: additional details and fixes; addressing recent feedback; use binary protobuf encoding for kv pairs in files

* review updates part 5: formatting fixes; updated StreamingService/Hook interface

* auxiliary streaming/queue service

* review updates part 6: update StoreKVPair to differentiate between Set and Deletes on nil byte values; some minor adjustments

* typo fix
 2021-02-04 18:09:28 -08:00
Robert Zaremba 931af4350b
Finalize ADR-028 (#8398) 
Finalize ADR-028

* added note about Named Accounts
* Update docs/architecture/adr-028-public-key-addresses.md
* remove blake2b
* move some paragraphs to 'Further Discussion'
* move composing module accounts to a new subsectoin
* adding appendix from meeting with Alan
* composed addresses: use LengthPrefix before sorting
 2021-02-04 04:08:11 +01:00
Sunny Aggarwal b125fccfd2 MsgWeightedVote -> MsgVoteWeighted 2021-01-24 20:54:25 -05:00
SaReN 57f5e96570
Rosetta API implementation (#7695) 
Ref: #7492

Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
 2021-01-21 09:33:02 +00:00
Federico Kunze 48006b435d x/bank: client denom metadata gRPC (#8317) 
* deps: bump tendermint to v0.34.2

* x/bank: denom metadata gRPC

* cli: add cmd and tests

* gRPC test'

* changelog

* fix test

* Apply suggestions from code review

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aditya <adityasripal@gmail.com>

* fix panic

* use cmd.Context()

* update tests

* Update x/bank/types/errors.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* test fix

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-01-19 17:08:09 -05:00
Federico Kunze 01eec66d28
x/bank: client denom metadata gRPC (#8317) 
* deps: bump tendermint to v0.34.2

* x/bank: denom metadata gRPC

* cli: add cmd and tests

* gRPC test'

* changelog

* fix test

* Apply suggestions from code review

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aditya <adityasripal@gmail.com>

* fix panic

* use cmd.Context()

* update tests

* Update x/bank/types/errors.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* test fix

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-01-18 18:15:16 +00:00
colin axnér 43840f45dd
Revisions to Unfreezing Clients via Governance ADR (#8343) 
* revisions to adr 26 decision

* Update docs/architecture/adr-026-ibc-client-recovery-mechanisms.md

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
 2021-01-16 09:48:48 -03:00
Aaron Craelius 2a2c2ec009
ADR 030: Authorization Module (#7105) 
* Add ADR 030

* Cleanup

* Updates

* Updates based on ADR 031

* Add abstract and context

* Updates

* Update module name as per #7615

* Updates from reviews

* Rename

* CLI update

* Update docs/architecture/adr-030-authz-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-030-authz-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-030-authz-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs/architecture/adr-030-authz-module.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Code review updates

* Update docs

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
 2021-01-13 19:18:19 +00:00
Robert Zaremba 1ec6c640b9
ADR template: add Further Discussions (#8108) 
* ADR template: add Further Discussions

* language update

* Update docs/architecture/adr-template.md

Co-authored-by: Amaury <amaury.martiny@protonmail.com>

Co-authored-by: Amaury <amaury.martiny@protonmail.com>
 2020-12-09 10:36:48 +00:00
Robert Zaremba b219c54c2d
Move and update codec.MarshalAny functions to codec.Marshaler interface (#8080) 
* Changelog update

* Rename codec.MarshalAny

* move codec.MarshalInterface to codec.Marshaler

* fix tests

* Update amino_codec for compliance with MarshalerInterface

* update tests and comments

* add tests

* change order of args in UnmarshalInterface to a canonical one

* uplift MarshalInterface to take ProtoMessage as an argument

* wip

* add nil check

* make tests working

* tests cleanup

* add support for *JSON methods

* Update changelog

* linter fixes

* fix test types

* update evidence genesis_test

* adding test

* review updates

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-12-08 09:27:08 +00:00
Sunny Aggarwal b5442e1d5e
Update adr-034-account-rekeying.md 2020-11-24 13:06:58 -05:00
Sunny Aggarwal fd6f07bda2
Merge branch 'master' into sunny/change-pubkey-adr 2020-11-23 16:18:45 -05:00
Sunny Aggarwal 972095e7fa
pruning info 2020-11-23 15:52:47 -05:00
Sunny Aggarwal 101d62a69d
Add details about pruning 2020-11-23 15:47:55 -05:00
Sunny Aggarwal 045e7874b0
Update adr-034-account-rekeying.md 
Add stack of past keys
 2020-11-23 15:33:40 -05:00
Sunny Aggarwal 20617d0db4
Update docs/architecture/adr-034-account-rekeying.md 
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
 2020-11-23 15:30:25 -05:00
Aaron Craelius 251a27d104
Update ADR status (#8009) 2020-11-23 16:31:17 +00:00
Robert Zaremba fe58ee9951
ADR-031: elaborate consequences and encapsulation of module client-se… (#7839) 
* ADR-031: elaborate consequences and encapsulation of module client-server implementation

* Update docs/architecture/adr-031-msg-service.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

Co-authored-by: Aaron Craelius <aaron@regen.network>
 2020-11-18 23:11:04 +00:00
Sunny Aggarwal a0c1deb2e2 reassign to adr 037 2020-11-11 13:35:07 -04:00
Sunny Aggarwal bf508d9699
Merge branch 'master' into adr_gov_split_vote 2020-11-06 11:43:20 -04:00
Sunny Aggarwal 53108e7637
Update adr-034-account-rekeying.md 2020-11-06 11:28:18 -04:00
Sunny Aggarwal c4e5e29244
Update and rename adr-034-change-pubkey.md to adr-034-account-rekeying.md 2020-11-06 11:21:45 -04:00
Jonathan Gimeno 4d833f9ef0
ADR 35: Rosetta API Support (#7492) 
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: SenorMonito <david@planet-mono.net>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
 2020-11-06 10:39:33 +00:00
Sunny Aggarwal 6274240d7c
Apply suggestions from code review 
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
 2020-11-03 15:55:16 -04:00
Sunny Aggarwal e9d6a8a48d add backwards compatibility section 2020-11-02 12:56:45 -04:00
antstalepresh ebe73fa28b
modify ADR for MsgVote backwards compatibility 2020-11-02 23:10:39 +10:00
Sunny Aggarwal 71e551bbae address @alexanderbez review 2020-10-29 16:35:50 -04:00
Sunny Aggarwal 3a871b86ce sunny updates 2020-10-29 14:09:05 -04:00
Sunny Aggarwal 2ace2a738b
Update docs/architecture/adr-034-change-pubkey.md 
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
 2020-10-28 22:20:25 -04:00
antstalepresh ffced9ebef modify title 2020-10-28 23:31:45 +10:00
antstalepresh 5061b8fe19 basic ADR for gov split vote 2020-10-28 23:24:55 +10:00
Sunny Aggarwal 2c58e1806c
Merge branch 'master' into sunny/change-pubkey-adr 2020-10-27 13:42:15 -04:00
Robert Zaremba 5bebf2bd39
ADR: add a process proposal (#7621) 
* ADR: add a process proposal

* wording update

* Update docs/architecture/PROCESS.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/PROCESS.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/PROCESS.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Add more details to status section and update the template

* Update docs/architecture/PROCESS.md

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* add a note about ADR pruning

* use sequence numbers

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-10-22 22:40:44 +00:00
Sunny Aggarwal c8c73a483a
Apply suggestions from code review 
Co-authored-by: Aaron Craelius <aaron@regen.network>
 2020-10-22 12:00:16 -04:00
Sunny Aggarwal 091c835060
Update adr-034-change-pubkey.md 2020-10-21 21:44:40 -04:00
Sunny Aggarwal 68ba5647a2
Update adr-034-change-pubkey.md 2020-10-21 21:42:47 -04:00
Sunny Aggarwal cb99dbd413
Apply suggestions from code review 
Co-authored-by: Aaron Craelius <aaron@regen.network>
 2020-10-21 21:42:06 -04:00
Sunny Aggarwal 30c13ea554
Apply suggestions from code review 
Co-authored-by: Aaron Craelius <aaron@regen.network>
 2020-10-21 15:37:40 -04:00
Aaron Craelius f24ad5d00a
ADR 028: Public Key Addresses (#7086) 
* ADR 028: Public Key Addresses

* Cleanup

* Address review comments

* wording update.

* Being more precise about nested addresses in multisig

* Apply suggestions from code review

Co-authored-by: Ethan Buchman <ethan@coinculture.info>

* Address review comments

* Address review comments

* Address review comments

* Describe sorting

* Add abstract

* Update status

* Revert to sha256

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
 2020-10-21 16:03:18 +00:00
Amaury Martiny 48bfd73aba
Add background for sequence change in ADR-020 (#7616) 2020-10-21 14:47:31 +00:00
Federico Kunze 503b518efc
client: add GetAccount and GetAccountWithHeight to AccountRetriever (#7558) 
* client: add GetAccount and GetAccountWithHeight to AccountRetriever

* update ADR

* address comments from review
 2020-10-15 14:19:57 +00:00
colin axnér 24714f80cb
fix typo (#7536) 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
 2020-10-14 20:17:53 +00:00
Jack Zampolin 36c1b24a06
ADR 32: Typed Events (#7474) 2020-10-13 19:51:47 +01:00
Sunny Aggarwal 2affa79c0a adr 32 -> 34 2020-10-13 10:13:30 -04:00
Aaron Craelius c7d926da2d
ADR 031: Protobuf Msg Services (#7458) 
* Ideas

* WIP

* Add ADR 031

* WIP

* WIP

* Revert changes

* Revert changes

* Revert changes

* Updates

* Updates

* Apply suggestions from code review

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>

* Add package names

* Adding clarifications

+ Adding an abstract
+ Updating the first paragraph of decision

* Update Context and wording

* Update wording

* Address proto naming

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Cory <cjlevinson@gmail.com>
 2020-10-09 19:13:30 +00:00
Aaron Craelius 90579c0a99
ADR 029: Fee Grant Module (#7106) 
* Add ADR 029 stub

* ADR 029 first draft

* Cleanup

* Updates from code review

* Updates from review

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
 2020-10-09 15:09:17 +00:00
Sunny Aggarwal df6414d040 adr 2020-10-08 20:47:05 -04:00
Robert Zaremba 435fc83ba7
Updating the ADR template (#7449) 
* Updating the ADR template

Introducing few small sections to the template:

* Summary: IMHO it's very valuable for every reader to quickly see what this ADR is about. Must be short.
* Backwards Compatibility -- each ADR MUST analyze backward compatibility issue. Let's make it clear and put as the ADR subsection.
* Test Cases -- often, when analyzing a problem and implementing a solution, it's very useful to define test-cases. Hence it SHOULD be a part of the template.

Inspiration: Enterprise Ethreum Alliance Proposal [template](https://github.com/EntEthAlliance/EEPs/blob/master/draft/templates/EEP0002-Standards_Proposal_Template.md)

* change Summary -> Abstract
 2020-10-05 21:34:41 +00:00
Aaron Craelius 852e7693a7
Update ADR 023 package versioning guidelines (#6954) 
* ADR 023 updates

* ADR 023 updates

* ADR 023 updates

* Update docs/architecture/adr-023-protobuf-naming.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update ADR 023

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
 2020-10-05 11:49:13 +00:00
Sunny Aggarwal cdf9bd2a4f
Proportional slashing ADR Update (#6368) 
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
 2020-10-05 09:30:50 +02:00
Federico Kunze 2c93ec7a0c
ibc: core restructure (#7434) 
* ibc: protobuf v1

* update codec

* core client

* core connection

* core host

* core commitment

* core port

* core channel

* core ibc module files

* core exported

* core types & simulation

* core spec

* make proto-all

* ibc alias
 2020-10-02 06:03:02 -03:00
Federico Kunze 72353902e2
ibc: rename epoch -> version (#7429) 
* ibc: rename epoch -> version

* more renaming

* update spec
 2020-10-01 15:08:26 +00:00
Marie Gauthier 489599b70f
Remove the old message PublicKey proto oneof (#7390) 
* Remove unused PublicKey type and update docs

* Update wording

* Update proto/cosmos/base/crypto/v1beta1/crypto.proto

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Edit docs

* Move crypto.proto to multisig

* Proto linting

* Update docs/architecture/adr-020-protobuf-transaction-encoding.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update wording for Public Key Encoding

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
 2020-09-29 10:01:54 +00:00
Cory 308ee267a8
Followup suggestions from ADR-027 updates (#7232) (#7379) 
* add grammar suggestions to adr-027

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-09-28 09:42:57 +00:00
Robert Zaremba 09998ef86e
adr-27: adding (#7232) 
* adr-27: adding 

Each ADR should have an abstract and an example use case to quickly present the goal.
Here, adding this to DR 027: Deterministic Protobuf Serialization

* review update

* added link to TxRaw

* added list of major use-cases

* updated wording in context and abstract

* updated the adr-020 part

* add consequences and motivation for TxRaw

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

* rewording

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

* Update docs/architecture/adr-027-deterministic-protobuf-serialization.md

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-09-23 23:06:55 +00:00
Amaury Martiny 7cd25abb87
Proto Tx with Any (#7276) 
* WIP on protobuf keys

* Use Type() and Bytes() in sr25519 pub key Equals

* Add tests

* Add few more tests

* Update other pub/priv key types Equals

* Fix PrivKey's Sign method

* Rename variables in tests

* Fix infinite recursive calls

* Use tm ed25519 keys

* Add Sign and VerifySignature tests

* Remove ed25519 and sr25519 references

* proto linting

* Add proto crypto file

* Implement some of the new multisig proto type methods

* Add tests for MultisigThresholdPubKey

* Add tests for pubkey pb/amino conversion functions

* Move crypto types.go and register new proto pubkeys

* Add missing pointer ref

* Address review comments

* panic in MultisigThresholdPubKey VerifySignature

* Use internal crypto.PubKey in multisig

* Add tests for MultisigThresholdPubKey VerifyMultisignature

* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1

* Remove conversion functions and introduce internal PubKey type

* Override Amino marshaling for proto pubkeys

* Merge master

* Make proto-gen

* Start removal of old PubKeyMultisigThreshold references

* Fix tests

* Fix solomachine

* Fix ante handler tests

* Pull latest go-amino

* Remove ed25519

* Remove old secp256k1 PubKey and PrivKey

* Uncomment test case

* Fix linting issues

* More linting

* Revert tests keys values

* Add Amino overrides to proto keys

* Add pubkey test

* Fix tests

* Use threshold isntead of K

* Standardize Type

* Revert standardize types commit

* Fix build

* Fix lint

* Fix lint

* Add comment

* Register crypto.PubKey

* Add empty key in BuildSimTx

* Simplify proto names

* Unpack interfaces for signing desc

* Fix IBC tests?

* Format proto

* Use secp256k1 in ibc

* Fixed merge issues

* Uncomment tests

* Update x/ibc/testing/solomachine.go

* UnpackInterfaces for solomachine types

* Remove old multisig

* Add amino marshal for multisig

* Fix lint

* Correctly register amino

* One test left!

* Remove old struct

* Fix test

* Fix test

* Unpack into tmcrypto

* Remove old threshold pubkey tests

* Fix register amino

* Fix lint

* Use sdk crypto PubKey in multisig UnpackInterfaces

* Potential fix?

* Register LegacyAminoPubKey

* Register our own PubKey

* Register tmcrypto PubKey

* Register both PubKeys

* Register interfaces in test

* Refactor fiels

* Add comments

* Use anil's suggestion

* Add norace back

* Check nil

* Address comments

* FIx lint

* Add tests for solomachine unpack interfaces

* Fix query tx by hash

* Better name in amino register

* Display StdTx instead of proto Tx

* Remove useless check

Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
 2020-09-21 16:48:28 +00:00
Robert Zaremba e4c67eddc7
Added glossary explaning Denomination Key (#7330) 
When reading this ADR, I was confused about _denomination_. When reading this in context of tokens I always think about a unit / measure. Examples: bills denominated in $20 and $50. Or as 100 cents makes 1 dollar.

The Merriam-Webster dictionary defines [denomination](https://www.merriam-webster.com/dictionary/denomination) as:

1. an act of denominating. Eg: the denomination of prices in U.S. dollars
2. a value or size of a series of values or sizes. Eg: metric denominations
3. name, designation especially : a general name for a category

It seams that we are using the last definition (3rd).
 2020-09-16 10:27:01 -07:00