Commit Graph

8 Commits

Author SHA1 Message Date
Jae Kwon bc51fa93b6
Fix updateValidatorDistInfoFromPool (#3046)
Fixes regression introduced by #2984.
Continuiation of #3033 , which didn't fix the simulation issues.
(candidate) Complete solution for #3019, 9002 halt bug.

From #2984, it isn't sufficient to take the fee pool rewards of a validator. Since we don't track delegator accums (as we do with validator accums), and because onValidatorModified >updateValidatorDistInfoFromPool is also being called upon delegation updates (or at least I believe this is the reason), it is necessary to also withdraw self delegation.

TODO: I don't think self-delegation should be required to be modified here... consider using a delegation hook to do the self-delegation withdraw part instead, e.g. splitting the updateValidatorDistInfoFromPool function into two. It might not result in cleaner code, however. Think hard.
2018-12-08 07:18:04 -08:00
Rigel b48d0d5623 Merge PR #2527: Minting 2018-10-19 20:36:00 +02:00
rigelrozanski 32e0f14de2 rework to correctly use previous vote info 2018-10-15 22:09:13 -04:00
rigelrozanski 2ece2ff37c address @cwgoes comments 2018-10-15 02:34:01 -04:00
rigelrozanski 06fa518e30 address @cwgoes comments, add in precommit calculation 2018-10-12 07:15:13 -04:00
rigelrozanski 7b1f4a87ea finished off validator tests 2018-10-12 06:06:01 -04:00
rigelrozanski 94731a502a some validator dist tests 2018-10-12 05:51:00 -04:00
rigelrozanski 81d0f5f4a7 add wanted final test case functions 2018-10-04 21:37:40 -04:00