bf11b1bf1f
refactor: Implementing sigs.k8s.io YAML to remove .proto yaml annotations ( #9780 )
...
## Description
Draft of: #9705
Started off with changing codec `MarshalYaml` function to directly go from JSON to yaml using the new library. Replaced the only usage of UnmarshalYaml per request.
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting ))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules )
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing )
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc )
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [x] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [x] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [x] reviewed state machine logic
- [x] reviewed API design and naming
- [x] reviewed documentation is accurate
- [x] reviewed tests and test coverage
- [x] manually tested (if applicable)
2021-09-24 14:37:34 +00:00
603e89541f
Add support for permanent locked vesting accounts ( #8520 )
...
* add basics for permanent locked vesting account support
* remove sdk.Msg support for PermanentLockedVestingAccount
* add tests for PermanentLockedVestingAccount
* remove unecessary tests
* drop unecessary create vesting acct msgs
* Update x/auth/vesting/types/vesting_account.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update x/auth/vesting/types/vesting_account.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update x/auth/vesting/types/vesting_account.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update x/auth/vesting/types/vesting_account_test.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Review changes
* Factorize init function
* Factorize more
* Comments
* Fix build after rename
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-04-21 16:18:28 +00:00
7568b6680a
Remove bech32 PubKey support ( #7477 )
...
* Move PubKey bech32 to legacy package and migrate the usage where possible
* update /server
* wip
* move proto json encoding helper functions to internal
* update internal/marshal
* wip
* update sections which needs legacybech32
* update validators output
* fix conflicts
* slashing update
* add more tests and helper function for ANY JSON serialization
* update slashing
* Update function documentation
* Rename code any-marshal helper functions
* Update pubkey unpacking test
* Update test comments
* solve TestDecodeStore
* solve legacytx issues
* all code compiles
* keyring tests
* keyring cleanup
* remove AssertMsg
* fix some tests
* fix add_ledger_test.go
* update cli tests
* debug cli test
* rename clashed bech32 names
* linter fixes
* update tmservice tests
* linter: update legacy deprecated checks
* fix names
* linting
* legacybech32 pubkey type rename
* fix staking client
* fix test compilation
* fix TestGetCmdQuerySigningInfo
* rename NewIfcJSONAnyMarshaler
* keyring: remove duplicated information from multinfo structure
* todo cleanups
* Update Changelog
* remove some legacybech32 from tests
* remove todos
* remove printlnJSON from /server CLI and amino encoding
* remove protocdc.MarshalJSON
* client/show remove duplicated function
* remove protocdc package
* comment update
* remove legacybech32.MustMarshalPubKey from a test
* add todo
* fix TestPublicKeyUnsafe test
* review update
* fix bech32 UnmarshalPubKey
* Use codec.MarshalIfcJSON
* fix linter issues
* merging conflict: fix codec.Unmarshal calls
* cleanups
* Update CHANGELOG.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Reword changelog updates
* use pubkey.String for comparison in Test_runAddCmdLedgerWithCustomCoinType
* Update GetCmdQuerySigningInfo example
* cli: update keys add docs
* Add errors AsOf and errors.ErrIO type
* restore multisigPubKeyInfo structure bring it back to multiInfo struct
* Update codec/proto_codec.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update crypto/keys/ed25519/ed25519_test.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update codec/proto_codec.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* move pubkey any marshaling tests
* Apply suggestions from code review
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* review updates
* adding missing return
* errors: use IsOf instead of AsOf
* keyring: add a correct check for key not found in keyring.Get
* add checkKeyNotFound
* fix linter issues
* fix: keyring key not found check
* fix keyring tests
* fix linting issues
* cli tests
* fix: 'simd keys show <key> -p'
* fix: TestVerifyMultisignature
* rename keyring Bech32... functions to Mk...
* fix RunAddCmd
* Update pubkey display
* wip
* add more tests
* udate keyring output tests
* remove todo from ledger tests
* rename MkKeyOutput
* Changelog update
* solve liner issues
* add link to github issue
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2021-03-25 14:53:22 +00:00
f2ee972e31
various linter fixes ( #8666 )
2021-02-23 08:46:01 +00:00
d55c1a2665
Change `address` from bytes to bech32 strings ( #7242 )
...
* init
* Fix bank proto messages
* missing conversions
* remove casttype for addresses
* Fix tests
* Fix consaddress
* more test fixes
* Fix tests
* fixed tests
* migrate missing proto declarations
* format
* Fix format
* Fix alignment
* Fix more tests
* Fix ibc merge issue
* Fix fmt
* Fix more tests
* Fix missing address declarations
* Fix staking tests
* Fix more tests
* Fix config
* fixed tests
* Fix more tests
* Update staking grpc tests
* Fix merge issue
* fixed failing tests in x/distr
* fixed sim tests
* fixed failing tests
* Fix bugs
* Add logs
* fixed slashing issue
* Fix staking grpc tests
* Fix all bank tests :)
* Fix tests in distribution
* Fix more tests in distr
* Fix slashing tests
* Fix statking tests
* Fix evidence tests
* Fix gov tests
* Fix bug in create vesting account
* Fix test
* remove fmt
* fixed gov tests
* fixed x/ibc tests
* fixed x/ibc-transfer tests
* fixed staking tests
* fixed staking tests
* fixed test
* fixed distribution issue
* fix pagination test
* fmt
* lint
* fix build
* fix format
* revert tally tests
* revert tally tests
* lint
* Fix sim test
* revert
* revert
* fixed tally issue
* fix tests
* revert
* fmt
* refactor
* remove `GetAddress()`
* remove fmt
* revert fmt.Striger usage
* Fix tests
* Fix rest test
* disable interfacer lint check
* make proto-format
* add nolint rule
* remove stray println
Co-authored-by: aleem1314 <aleem.md789@gmail.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
2020-09-25 10:25:37 +00:00
816c5a37bd
Enable proto JSON generally and remove HybridCodec ( #6859 )
...
* Remove HybridCodec
* WIP on fixing proto JSON issues
* WIP on fixing proto JSON issues
* WIP on fixing proto JSON issues
* WIP on fixing proto JSON issues
* WIP on fixing proto JSON issues
* Test fixes
* Delete hybrid_codec.go
* Fixes
* Fixes
* Fixes
* Test fixes
* Test fixes
* Test fixes
* Lint
* Sim fixes
* Sim fixes
* Revert
* Remove vesting account JSON tests
* Update CHANGELOG.md
* Lint
* Sim fixes
* Sim fixes
* Docs
* Migrate more amino usages
* Remove custom VoteOption String() and json marshaling
* Fix tests
* Add comments, update CHANGELOG.md
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-08-13 13:20:02 +00:00
919e906866
Minor Code Cleanup - gRPC queries ( #6862 )
...
* add missing RegisterQueryService
* Update generated proto files
* Update grpc tests for auth,bank
* Make format
* fix godoc
* Address suggestions
* Update godoc
2020-07-28 12:53:35 +00:00
81d647e505
Move codec.RegisterCrypto and codec.Cdc to new packages ( #6330 )
...
* Move codec.Cdc to legacy_global.Cdc
* Update CHANGELOG.md
* Updates
* nit
* Fix imports
* Updates
* Use cosmos multisig instead of tendermint multisig everywhere
* Fix tests
* Rename legacy_global -> legacy
* Add doc.go
* Linting, move all RegisterCrypto calls to crypto/codec
* Update crypto/codec/amino.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 10:38:24 +00:00
bf8809ef98
Update x/auth to use Any ( #6165 )
...
* Migrate keeper codec to use marshaler
* Migrate AccountI to types
* Did go imports
* Fix tests for x/auth
* Cleanup std/codec
* Sort imports
* Fix legacy codec
* Add godoc for RegisterInterfaces
* Add RegisterInterfaces to std
* Fix typo
* Fixed merge changes
* Eliminate vesting import in auth
* Fix lint issues
* Fix tests
* Addressed comments
* Rename interfaces in RegisterInterfaces
* Removed codec.proto from std
* Minor code cleanup
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-05-20 19:21:00 +00:00
9b47079171
Merge PR #5682 : Change pubkey to bytes
2020-02-20 17:15:22 +01:00
794a496892
Merge PR #5533 : Protobuf: x/auth & x/supply
2020-02-18 13:50:13 +01:00
6890feb3d2
Merge PR #5572 : ADR 004 Implementation
2020-01-30 16:31:16 -05:00
869531ca92
Merge PR #5495 : Replace Redundant Bech32 PubKey Functions
2020-01-09 09:04:28 -05:00
066dd1114f
Merge PR #5449 : Add New constructor for the DecCoin
2020-01-03 15:44:53 -05:00
82a2c5d6d8
Merge PR #5280 : Custom JSON Marshal/Unmarshal for Account Types
2019-11-06 13:06:26 -07:00
64a2741250
Merge PR #5040 : Separate vesting from auth, add custom vesting schedules
2019-10-10 11:53:30 -04:00
Luke Rhoads
Cory
Robert Zaremba
Alessio Treglia
Anil Kumar Kammari
Aaron Craelius
SaReN
Alexander Bezobchuk
Ferenc Fabian
Kevin Davis