Jonathan Gimeno
0daf3c3271
Fix problem with Gen TX ( #6924 )
...
Closes : #6908
2020-08-04 08:41:58 +02:00
Aaron Craelius
6d937443b2
Reject unknown fields in TxDecoder and sign mode handlers ( #6883 )
...
* WIP on unknown field rejection in TxDecoder
* WIP on unknown field rejection in TxDecoder
* WIP
* WIP
* WIP
* WIP
* Fix bugs with RejectUnknownFields
* Fix tests
* Fix bug and update docs
* Lint
* Add tests
* Add unknown field tests
* Lint
* Address review comments
2020-08-03 19:47:25 +00:00
Aaron Craelius
7e2eea84c6
Fix the one remaining proto tx bug and flip the switch ( #6902 )
...
* Fix the one remaining proto tx bug and flip the switch
* Update github CI
* Wrap TxDecoder errors
* Add test
* Cleanup
2020-07-30 18:58:26 +00:00
Alexander Bezobchuk
9ccec075e2
cli: refactor flag reading ( #6884 )
...
* cli: refactor ReadPersistentCommandFlags
* updates
* fix tetts
* cover all cases
* fix tests
* fix tests
* fix tests
* fix tests
* godoc++
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-07-30 16:44:22 +00:00
SaReN
e15d0322dc
Migrate remaining x/auth tx tests to proto ( #6898 )
...
* Fix ReadTx
* Migrate batch scanner tests
* add TODO
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-30 15:36:36 +00:00
Marko
617b822efa
types: add kv type ( #6897 )
...
* add kv type
* add changelog entry
* fix build
* replace sdkkv with kv
* revert change
* fix some tests
* proto-gen
* fix tests
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-30 14:53:02 +00:00
SaReN
c7ad21d162
REST tx endpoint backwards compatibility ( #6801 )
...
* update rest endpoints
* Add conversion logic for auth encode/decode/broadcast
* Cleanup
* Add tx conversion to legacy REST tx endpoints.
* Cleanup
* Add tests
* Add tests for ConvertAndEncodeStdTx
* Fix for StdSignature
* Test coverage improvements
* Add integration test for REST broadcast
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-07-30 10:45:18 -04:00
Amaury Martiny
8283165600
Revert `SetSignerInfo` ( #6894 )
...
* Fix TestCLIMultisign tests
* Fix lint
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2020-07-30 13:22:31 +00:00
Aaron Craelius
ef6dc2f180
Revert change of StdSignature PubKey to []byte ( #6885 )
...
* Revert change of StdSignature.PubKey to []byte
* Fixes
2020-07-30 09:29:43 +00:00
SaReN
72ebafeeca
Update auth cli commands ( #6717 )
...
* add utils
* update sign cmd
* update multisign cmd
* update sign batch cmd
* update genutil cmd
* add wrap tx builder
* update gentx cli
* update validate sigs cmd
* fix lint
* add flag reader to cli
* update marshaler for batchscan
* add register query server
* update to master
* remove depricated methods
* fix keyring issue
* update wraptx
* Fix batch scan
* fix register interfaces issue
* update printOutput
* Update Validate Sigs test
* WIP on signature JSON
* Cleanup
* Cleanup
* Test fixes
* Test fixes
* Fixes
* WIP on tests
* Fix gov tests
* fix lint
* fix MultiSign tests
* fix tests
* refactor tests
* Cleanup
* Address review comments
* Update encode
* Test fix
* Rename SignData func
* Fix lint
* Fix lint
* Revert ReadTxCommandFlags
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
2020-07-29 22:33:42 +00:00
Marie
bc7e943158
x/auth genesis protobuf migration ( #6880 )
...
* Add auth genesis.proto and related changes
* Add UnpackInterfaces method to auth GenesisState
* Remove unrelevant test case
* Update proto/cosmos/auth/genesis.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Add test for auth types ConvertAccountsAny
* Apply naming suggestions
* Update x/auth/types/genesis_test.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-29 16:00:15 +00:00
Aaron Craelius
9592f34cde
Fully remove StdTx usage in ante handler tests ( #6845 )
...
* WIP on removing StdTx from ante handler tests
* Fix recheck
* Fix basic_test
* Don't use StdTx in ante_test
* Use TxConfig sign mode handler in anteHandler
* Fix TestAnteHandlerAccountNumbers
* Amino don't panic
* Fix more tests
* All proto ante tests pass
* Fix last tests
* Amino register concrete
* Add tests
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-29 15:52:22 +00:00
Alexander Bezobchuk
72f6bf0893
Fix 0.39 x/auth Migration Types ( #6870 )
...
* types: add coins to JSON
* add migrate test
* finish test
* Add panic
* fix test
2020-07-28 19:18:07 +00:00
Alexander Bezobchuk
3ff3e58240
Launchpad Migration ( #6829 )
...
* fix migration
* add 039 pkg
* lint
* Fix pkg name
* add v0.39 auth types
* remove file
* updates
* updates
* update godoc
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-28 15:28:23 +00:00
SaReN
919e906866
Minor Code Cleanup - gRPC queries ( #6862 )
...
* add missing RegisterQueryService
* Update generated proto files
* Update grpc tests for auth,bank
* Make format
* fix godoc
* Address suggestions
* Update godoc
2020-07-28 12:53:35 +00:00
Aaron Craelius
bb8aabd4e1
Migrate pieces of x/genutil missed in #6734 ( #6860 )
...
* Migrate pieces of x/genutil missed in 6734
* Fix tests
* Fix lint
* Add test
2020-07-27 15:41:20 +00:00
Marie
f59df68a97
Migrate x/genutil to use TxConfig ( #6734 )
...
* Update genutil collect and gentx to use TxGenerator
* Remove print statement
* Use Tx in genutil DeliverGenTxs
* Use Tx in genutil genesis_state
* Use Tx in ValidateGenesis
* Use amino txJSONDecoder and txBinaryEncoder in genutil InitGenesis
* Use TxConfig in place of TxGenerator
* Add gentx tests
* Remove commented line
* Test fixes
* Apply suggestions from code review
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Fixes
* Fixes
* Fixes
* Fixes
* Remove unneeded test case (doesn't apply to proto marshaling)
* linting
* Refactor to use new TxEncodingConfig interface in genutil module
* Replace golang/protobuf with gogo/protobuf package
* Use TxEncodingConfig in InitTestnet
* Remove old amino.go file
* Use TxJSONDecoder in genutil ValidateGenesis
* Add parameter to ValidateGenesis to resolve the tx JSON decoder issue
* Address review feedback
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-25 08:10:04 +00:00
Anil Kumar Kammari
3bafd8255a
Remove hybrid codec usage ( #6843 )
...
* remove hybrid codec for slashing, staking and upgrade
* Remove hybridcodec from params and mint
* revert staking
* Fix gov
* Fix ibc and evidence
* Fix ibc-transfer
* Fix staking
* remove evidence json marshaling
* Fix tests
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-25 08:03:58 +00:00
SaReN
928f7fccff
Add wrap tx builder to TxConfig ( #6836 )
...
* Add wrap tx builder
* Add tests
* update for StdTx
* fix StdTxConfig
* Update generator
* Add godoc
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-24 22:24:57 +00:00
Aaron Craelius
80f7ff62f7
Start removing HybridCodec (init + auth, bank, distribution) ( #6838 )
...
* Start to remove HybridCodec
* Rename
* Fixes
* Test fixes
* Cleanup
2020-07-24 19:04:29 +00:00
Aaron Craelius
1538e65478
Fix module interface registration ( #6834 )
2020-07-23 22:45:34 -04:00
Marko
e6a56226a8
context: remove verifier & trust node ( #6805 )
...
* remove verifier
* more removal of trustnode flag
* add todo
* fix lint
* remove file
* remove viper and add link to issue
* remve mention of trustnode
2020-07-23 06:44:18 +00:00
Alexander Bezobchuk
ab664e9a43
Merge PR #6815 : Code & Doc Cleanup
2020-07-22 11:02:36 -04:00
atheeshp
470465d792
x/auth: cli gRPC migration ( #6809 )
...
* migrated auth cli to use grpc query client
* unpacker added for account command
* fxed tests
2020-07-21 17:48:37 +00:00
Alexander Bezobchuk
61d69a978f
Merge PR #6806 : Docs & Cleanup
2020-07-21 11:28:43 -04:00
Amaury Martiny
61d0c4adcd
proto: Consistent naming for Params ( #6803 )
...
* Use consistent "Params" in proto
* Update comments
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-21 14:04:51 +00:00
Alexander Bezobchuk
0ccc48d2a3
CLI/Tests: Remove Fixtures ( #6799 )
...
* remove fixtures
* setup tests
* update x/mint
* cli: update x/staking commands
* tests: convert x/staking CLI tests
* tests: fix x/auth CLI tests
* cli updates
* fix buiild
* fix build
* Update x/gov/client/cli/cli_test.go
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* remove GenerateOrBroadcastTx
* move TestCLIQueryConn
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-21 13:54:07 +00:00
billy rennekamp
cde3f46d52
Add validation to prevent empty store keys ( #6754 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 18:05:01 +02:00
colin axner
79fa06b26c
remove IBC ante handler in favor of using handler ( #6793 )
...
* remove IBC ante handler, add calls to handler
* move some events upstream to handler
* remove change log entry
* move ante handler tests to handler
* fix build
* update docs
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 15:25:57 +00:00
Amaury Martiny
8e61ef86c3
x/{gov,params,upgrade,distribution} CLI: In-Process test & use grpc query service ( #6664 )
...
* refactor CLI to use grpc query service
* In process CLI for gov
* ReadQueryCommandFlags
* gov tx
* Fix compiler errors
* Formatting
* x/distribution: use gRPC query
* Consistent
* Fix x/distrib test
* Update x/gov
* Add ReadQueryCommandFlags
* Fix lint
* Revert x/params
* x/params use grpc query
* Fix tests
* Use page request
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 13:09:57 +00:00
Amaury Martiny
5c0e3b4de5
x/auth/ante: Migrate tests to use the new client.TxConfig ( #6661 )
...
* WIP: using encoding config
* Make it compile, test fails
* test should be okay
* Make tests pass
* Add comments
* Convert more tests
* Make TestAnteHandlerSigErrors work
* Make first 2 tests pass
* TestAnteHandlerAccountNumbers
* Use table tests
* Remove print
* Use test table
* TestAnteHandlerSigErrors
* TestAnteHandlerAccountNumbers
* TestAnteHandlerAccountNumbers
* Refactor TestAccount
* Refactor getSignBytes
* TestAnteHandlerAccountNumbersAtBlockHeightZero
* TestAnteHandlerSequences
* TestAnteHandlerFees
* TestAnteHandlerMultiSigner
* TestAnteHandlerBadSignBytes
* TestAnteHandlerSetPubKey
* TestAnteHandlerSigLimitExceeded
* TestCustomSignatureVerificationGasConsumer
* TestAnteHandlerReCheck
* Make all tests pass
* Refactor a little bit more
* Fee test
* SetupTest
* All tests pass
* Refactor to RunTestCase
* Don't use StdFee
* Revert some little stuff
* Finish up last couple of test cases
* Less verbose
* s/TxGenerator/TxConfig
* Add comments
* Indent
* Move KeyTestPubAddr to testdata
* Move testdata to /testutil
* Revert to use signature: nil step in signing
* Add comments
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 08:30:12 -04:00
dauTT
5a5a402518
Merge PR #6775 : x/auth/simulation/genesis.go: add unit tests
2020-07-18 13:46:56 -04:00
dauTT
f59ea26941
Merge PR #6774 : x/auth/simulation/params.go: add unit tests
2020-07-18 13:23:37 -04:00
Alexander Bezobchuk
e59781eca7
Merge PR #6765 : x/auth: Finish CLI Refactor
2020-07-17 16:20:45 -04:00
Cory
32de79d0aa
refactor auths broadcast cmd in alignment with #6216 ( #6713 )
...
* refactor auths broadcast cmd in alignment with #6216
* add TxResponse proto definition, and related refactoring
* re-run make proto-gen, updating staking.pb.go
* cleanup TxResponse tests to handle nil return values
* properly handle nil Tx value in TxResponse's implementation of UnpackInterfaces
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-17 17:17:21 +00:00
Emmanuel T Odeke
1d711f537c
x/auth/signing/direct: increase test coverage to 100% from 83.3% ( #6731 )
...
Ensure that all known routes for GetSignBytes are explored for
DirectHandler.
2020-07-16 03:48:36 -04:00
Jonathan Gimeno
351192aa0b
x/auth: in-process test refactor ( #6573 )
...
* remove unused functions
* create helper func to send tx
* refactor to use test help to send tx by client
* Commit before getting backend.
* Temporal commit
* temp commit
* remove the creation of txbuilder from cli
* fix imports
* update changelog
* Remove unused function.
* Add flag home into tx sign command.
* migrade TestCLIValidateSignatures to use new test suite
* migrate test one
* Add changes to make sign batch.
* make test pass
* refactor common logic
* First part of cli sign.
* Add test for sign batch.
* refactor a little and improve the test
* migrate broadcast command
* fix linter
* Remove printf for debug in bank module.
* Fix unused err var.
* fix linter
* fix test
* fix tests client
* Fix linter.
* Temp commit signature.
* encode tx
* migrate tests
* Fix imports.
* Remove changelog
* fix tests
* Fix tests.
* Update x/bank/client/testutil/cli_helpers.go
* Remove alias.
* Remove wait for N block func.
* export callCmd function into its own file.
* fix imports
* bring back to inner functions
* apply mock io
* the helpers use mockio
* fix bug
* Add Helpers.
* return to put the function in testutil package
* return BufferWriter in ExecTestCLICmd
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-14 18:37:14 +00:00
Alexander Bezobchuk
e7554bb3b0
Fix Gas Flag Usage + CLI Flag APIs ( #6685 )
...
* Use new APIs
* fix usage
* fix usage of gas flag
* tests: TestParseGasSetting
2020-07-11 08:13:46 +00:00
Amaury Martiny
d23c779b87
Fix godocs for NewTxBuilderFromFlags ( #6676 )
2020-07-10 11:55:17 +02:00
Jonathan Gimeno
6ceedc9e4f
Remove TxBuilder references to viper. ( #6653 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-07-10 11:05:35 +02:00
Alessio Treglia
255ed06eb4
testutil: add ApplyMockIODiscardOutErr, simplify existing functions ( #6665 )
2020-07-10 08:55:48 +02:00
Alessio Treglia
a940214a49
testutil cleanup and reorg ( #6658 )
...
Prepare migrating testing auxiliary functions from tests
to testutil.
Remove local duplicates on testutil.WriteToNewTempFile().
Always favor testutil.NewTestCaseDir() over ioutil.TempDir().
Add test cases for the testing auxiliary functions.
2020-07-09 14:21:20 +02:00
Akhil Kumar P
4536ca22bb
x/auth: gRPC query service ( #6565 )
...
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2020-07-08 13:12:38 +02:00
Alessio Treglia
57ffe14631
Makefile: build simd with ledger support ( #6629 )
...
Makefile: parse COSMOS_BUILD_OPTIONS
Look for build options in the make's COSMOS_BUILD_OPTIONS
variable. This allows one to build simd with ledger support.
References:
* https://github.com/cosmos/gaia/pull/363
* https://github.com/tendermint/tendermint/pull/4738
fix tiny typo in nolint: statement that causes golangci-lint to
misbehave.
2020-07-07 19:10:11 +02:00
Alexander Bezobchuk
8670a10564
Merge PR #6595 : Single Binary & Command Refactor
2020-07-07 11:40:46 -04:00
Jonathan Gimeno
3c76084bf5
Merge PR #6596 : Genutil remove global viper
2020-07-06 17:48:54 -04:00
Aaron Craelius
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-06 17:03:45 +00:00
Alexander Bezobchuk
feb69770ef
Merge PR #6609 : x/auth: CLI Remove Viper
2020-07-06 10:23:32 -04:00
Alexander Bezobchuk
dacbcef54d
cl & deps++ ( #6582 )
...
* cl & deps++
* Use PersistentPreRunE
* revert x/bank/client/cli/tx.go
* move to root level
* Use block mode by default
* Skip x/auth CLI tests
2020-07-02 19:35:42 +00:00
Marko
a0f9cc7627
vesting: remove alias.go ( #6579 )
2020-07-02 15:08:44 +02:00