Commit Graph

614 Commits

Author SHA1 Message Date
frog power 4000 cec3065a36
Revert "Return errors instead of panic (#3782)" (#4054)
This reverts commit 985aae5575.
2019-04-05 16:20:58 -04:00
Alexander Bezobchuk 576eb51928
Merge PR #4058: Fix DecCoins Bugs 2019-04-05 14:13:22 -04:00
Alessio Treglia 85021d4ca9
No packages must depend on cmd/gaia/ (#4048)
Preparation work for moving gaia out of the SDK.
2019-04-04 15:36:39 +01:00
Marin Basic 985aae5575 Return errors instead of panic (#3782)
This is related to issue #3741 where fetching data from
invalid store, package panic.

Modify subspace.go to return errors instead of panic.

Also update other packages that import subspace and
handle errors.
2019-04-04 08:10:56 +01:00
Alexander Bezobchuk 0e55b6eada Merge PR #4028: Hex Encode Data in Tx Responses 2019-04-03 07:49:34 -07:00
Alexander Bezobchuk e2928d5b70
Merge PR ##4007: Add Block Time in Txs Responses 2019-04-02 21:09:37 -04:00
Frank Yang bc8d2d4414 R4R: Rename validator.GetJailed() to validator.IsJailed() #3245 (#4017)
Closes: #3245
2019-04-02 15:43:22 +02:00
Karoly Albert Szabo 5bb6090e38 Add route for querying signing_info for all validators (#3952)
Also remove duplicate pagination:
- move function to extract query params into types/rest
- adjust pagination values locally until available in tendermint for validators

Code cleanup:
- helper function in test
- fix pagination description in swagger.yaml
- uint instead of int when possible

Closes: #3226
Closes: #3991
2019-03-28 18:43:33 +00:00
Alexander Bezobchuk 2b43e25d55
Merge PR #3954: Tx Broadcasting Sync by Default 2019-03-25 20:54:23 -04:00
Alexander Bezobchuk 59765cecb1 Merge PR #3857: Remove Shares Concept from Unbond/Redelegate UX
* Remove shares concept from unbonding and redelegation

* Remove redundant staking REST type declerations

* Rename staking REST request types

* Fix slashing tests

* Fix staking tests

* Fix integration tests

* Add safety checks for when validator tokens are zero

* Attempt to fix simulation

* Add pending log entry

* Update docs

* Implement and use SharesFromTokens

* Rename ShareTokens and ShareTokensTruncated

* Rename Delegation to Amount in DelegateRequest

* Implement and use SharesFromTokensTruncated

* Update MsgDelegate to use Amount instead of Value

* Use constructors in staking sim messages

* Implement and use ValidateUnbondAmount
2019-03-25 17:13:02 -04:00
Alexander Bezobchuk dd7de2acaf
Merge PR #3951: Remove ';' delimiting support from ParseDecCoins 2019-03-25 10:38:15 -04:00
Alexander Bezobchuk 5f92fef4b0
Fix TruncateDecimal (#3913) 2019-03-16 16:14:37 -07:00
Alexander Bezobchuk 25408e7856 Merge PR #3747: Implement initial simple denom convert utils 2019-03-16 14:18:27 +01:00
Frank Yang 7e53da86ee Merge PR #3884: steak to stake 2019-03-14 10:32:46 -04:00
Alessio Treglia 7af11ece92 Merge PR #3864: Make IsAllGTE() more consistent
* Make IsAllGTE() more consistent

Co-Authored-By: alessio <quadrispro@ubuntu.com>
2019-03-12 19:13:36 +01:00
Alessio Treglia 997aa6106c
Merge branch 'develop' into sunny/coins-AllGT-test 2019-03-12 16:33:01 +01:00
Alexander Bezobchuk b316c477c1 Merge PR #3836: Fix WithdrawValidatorCommission 2019-03-12 16:10:20 +01:00
Alessio Treglia e200a2bf35 Fix comments 2019-03-12 16:02:18 +01:00
Alessio Treglia 3049862325 ContainsDenomsOf -> DenomsSubsetOf 2019-03-11 15:26:46 +01:00
Alessio Treglia 862cc436f3 Fix tests 2019-03-08 01:09:26 +00:00
Alessio Treglia 71ca0e5535 Port IsAllGT from safe-coins PR 2019-03-08 01:09:26 +00:00
Alessio Treglia 714168f473
Merge branch 'develop' into sunny/coins-AllGT-test 2019-03-08 01:58:24 +01:00
Alessio Treglia fbd79d0cad Merge PR #3818: Introduce sdk.NewCoins 2019-03-07 16:55:08 -08:00
Sunny Aggarwal 9ffe64dc1e failing test 2019-03-07 09:02:40 +01:00
Christopher Goes 4c50380181
Merge PR #3750: Outstanding per-validator rewards; correctly handle same-BeginBlock redelegation-double-slash 2019-03-06 19:54:12 +01:00
Jack Zampolin 805e7fbfc2 Merge PR #3806: Fix nil returned in Unmarshal functions
* Fix nils returned in unmarshal functions
* Address comments
2019-03-06 12:38:18 +01:00
Alessio Treglia 3e82a8bbb8 Merge PR #3792: Use DBBackend set at compile time
* use DBBackend set at compile time

Closes: #3719

* Refresh changelog

* Tweak Makefile
2019-03-04 21:31:55 +01:00
Alessio Treglia b47032d280 Merge PR #3666: improve denom validation 2019-03-01 12:10:22 -08:00
Jae Kwon 10bd98e58e Merge PR #3717: Allow the undelegation of more coins than were delegated; More validity checks. 2019-02-27 22:09:26 +01:00
Jae Kwon 7e08b62f4e Merge PR #3726: Cap(clip) reward to remaining coins in AllocateTokens 2019-02-27 21:38:57 +01:00
Alexander Bezobchuk 0611d2eda2 Merge PR #3688: JSON Decode Log in REST Client 2019-02-22 12:54:31 +01:00
frog power 4000 a814e5ce66
Merge PR #3679: Consistent Operators
* Minus->Sub Plus->Add Div->Quo

* pending

* Update PENDING.md

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* fix

* typo
2019-02-21 12:35:55 -05:00
Alexander Bezobchuk 992dc8b2dc Merge PR #3691: Minor Error Message Cleanup
* cleanup error messages

* Add pending log entry

* Rename Message to Error in ErrorResponse
2019-02-21 03:49:57 -05:00
frog power 4000 ab9de3a7f1
Merge PR #3680: Convenience ToDec()
* NewDecFromInt -> ToDec

* pending

* Update PENDING.md

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* test typo

* typo
2019-02-21 03:05:31 -05:00
Alessio Treglia b67d024fe3 Merge PR #3665: Uint overhaul 2019-02-19 14:59:03 -08:00
Alexander Bezobchuk e39debd359 Merge PR #3674: Remove password/keybase from REST Client 2019-02-19 10:15:39 -08:00
Juan Leni 6967de1073 Merge PR #3676: Refactored prefixes as constants
* Refactored prefixes as constants
* Fixing test
2019-02-18 22:35:08 +01:00
Jack Zampolin 5ccad4723f Merge PR #3642: Tx Query return values 2019-02-15 17:00:40 +01:00
frog power 4000 c0eec30840 Merge PR #3654: x/mint now uses total supply instead of bonded supply 2019-02-15 16:55:21 +01:00
Alexander Bezobchuk 26c13b28cd Merge PR #3607: Reconcile DecCoin/s API with Coin/s API 2019-02-15 16:33:23 +01:00
Alessio Treglia 1aa6c197ff Merge PR #3580: Code cleanup of client types 2019-02-14 08:53:36 -08:00
frog power 4000 d66db6a772 Merge PR #3621: module inter-dependency cleanup 2019-02-13 15:01:50 -08:00
Alexander Bezobchuk 22bdc1778b Merge PR #3264: Return an empty TxResponse when nil 2019-02-12 17:23:03 +01:00
Alexander Bezobchuk 2216f4716e Merge PR #3625: Fix Fee Comparison 2019-02-12 16:22:04 +01:00
Alexander Bezobchuk 9c23fe68ee Merge PR #3604: Improve REST Error Messages & Allow Unicode 2019-02-11 15:12:43 -08:00
Alexander Bezobchuk 1d4bb1a863 Merge PR #3591: Fix setting tx hash when nil
* fix setting the tx hash when nil
* add a pending log entry
2019-02-11 11:28:23 +01:00
Sunny Aggarwal da0426a2dd Merge PR #2601: Bech32 Empty Addresses 2019-02-09 00:54:40 +01:00
Alexander Bezobchuk fd5e7b9b80 Merge PR #3552: General Sanitization & Gas Cost Review 2019-02-08 23:33:29 +01:00
Juan Leni b5fdb83830 Merge PR #3517: Increasing test coverage in keys/client package 2019-02-08 12:45:23 -08:00
Sunny Aggarwal cff985ffc5 Merge PR #3546: Min Self Delegation 2019-02-08 12:44:19 -08:00
Alexander Bezobchuk 7bc837aa06 Merge PR #3555: Reintroduce Fees OR Semantics 2019-02-07 18:14:54 -08:00
Joon 685bfca1d4 Merge PR #3526: BaseApp Peer Review 2019-02-07 17:52:24 -08:00
Christopher Goes 38068a59ea Merge PR #3507: Results from x/staking & x/slashing peer review 2019-02-07 17:41:23 -08:00
Alessio Treglia b63b6254c8 Merge PR #3522: get rid of double negatives: IsNotNegative -> IsAnyNegative 2019-02-06 14:45:15 -08:00
Alexander Bezobchuk c5ab5699e3 Merge PR #3520: Minor CLI Output Updates
* minor cli output fixes

* Update client/utils/utils.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
2019-02-06 11:48:06 -08:00
frog power 4000 52f2ec71a9
Merge PR #3400: power reduction for Tendermint
* add uncompiled power functionality

* fix some compile errors

* Power -> TendermintPower

* tests rename GetTendermintPower

* test fix

* working

* fix delegation tests

* fix slash tests

* staking/keeper tests passing

* docs reversion

* debuggin workin

* x/staking test pass

* fix gov tests

* fix x/slashing tests

* working distribution test fixes

* fix distribution tests

* lint

* fix lcd tests

* fix gov test

* lint

* CLI fixes, rm stakingTypes

* typos

* working cli fixes

* cli test fix

* cli tests fixed

* testnet creation modification

* typo

* pending

* Sanitize Dec.Roundint64 (#3475)

* merge fixes

* @cwgoes comments

* fix tests

* change power reduction to 10^-6

* option to turn off minting for LCD tests
2019-02-05 21:30:48 -08:00
Jack Zampolin 5e35354269
Merge PR #3451: Make tags and responses legible 2019-02-04 18:20:56 -08:00
Joon 08e62fb157 Store Refactor 1 (#2985) 2019-02-01 17:03:09 -08:00
Jack Zampolin af60c75dd3 Merge PR #3352: Reenable simulation tests 2019-01-24 22:01:32 +01:00
Alexander Bezobchuk 36d1736a08 Refactor Gas/Fee Model (#3258) 2019-01-18 08:45:20 -08:00
frog power 4000 d9e32e93d5 Merge PR #3315: Increase decimal precision to 18
* Decimal precision increase WIP
* fix String()
* resolve many errors
* changelog
2019-01-17 18:15:10 +01:00
Christopher Goes 2942f83ff5
Merge PR #3099: F1 fee distribution 2019-01-16 22:38:05 +01:00
cong 916ea85630 Merge PR #2730: add tx search pagination related CLI/REST API parameter 2019-01-15 16:34:48 +01:00
Alexander Bezobchuk a984a22373 Merge PR #2694: Vesting Account(s) Implementation 2019-01-14 17:11:24 +01:00
Alexander Bezobchuk 03bdd3f870 Fix IsAnyGTE (#3265) 2019-01-09 12:31:03 -08:00
Hleb Albau 867f8a7467 Merge PR #3195: Configurable pruning. Fix docs and create strategies const. 2019-01-09 16:06:22 +01:00
Jack Zampolin b16af44271 Merge PR #3076: Rename hooks from Before -> Pre and On -> Post
* Rename hooks from Before -> Pre and On -> Post

* Fix lint error

* Update x/slashing/hooks.go

Co-Authored-By: jackzampolin <jack.zampolin@gmail.com>

* Ignore linter warnings on hooks file

* swap 171, 172 for clarity (my own comment)
2019-01-09 00:28:46 -05:00
Alessio Treglia 1040e3a8f5 Increase CLI test coverage (#3254) 2019-01-08 08:43:36 -08:00
Zaki Manian ed2b6bd9a7 Multiple fees in min fees to OR instead of AND (#3239) 2019-01-08 08:21:54 -08:00
Jack Zampolin 23819b1ce5 Merge PR #3159: Add address interface
* Add address interface
* Add test for addresses
* Address comments
2019-01-04 23:09:39 +01:00
Jack Zampolin d1824ad704
R4R: validate sign tx request's body (#3179)
* validate sign tx request's body

Closes: #3176

* Introduce CodeNoSignatures

* Update swagger.yaml

* Fix tests

* Update x/auth/client/rest/sign.go

Co-Authored-By: alessio <quadrispro@ubuntu.com>
2019-01-03 08:30:04 -08:00
Alexander Bezobchuk 990f3ab4c1 Add IsValid check on sendCoins (#3212) 2019-01-02 13:19:48 -08:00
frog power 4000 a98a5a056a
Merge PR #2958: Validator Power Dec-> Int
* Validator Power Dec-> Int, working

* non-test code compiles

* working, many test compile fixes

* all test compile errors resolved

* ...

* slashing test fixes minor

* test cover passes

* invariant rounding issue

* comment update

* PENDING and doc updates

* @cwgoes comments

* RemoveDelShares trimmings to the final delegation share

* fixes

* ...

* fix the oopsie

* @alexanderbez comments

* merge fixes

* address @cwgoes comments
2019-01-02 15:29:47 -05:00
Dev Ojha 67a1e47c6e Fix is_valid bug (#3211) 2019-01-02 11:14:12 -08:00
Christopher Goes 5ca8c5bb83
Merge PR #3207: Fix token printing bug
* Add IsPositive, case check on coins[0]
* Link to correct PR
* Add testcase
2019-01-02 19:17:27 +01:00
Alessio Treglia 11585a4abd Introduce CodeNoSignatures 2019-01-02 10:05:56 +00:00
Alessio Treglia 500fa2b694 Make coins denoms case insensitive (#3092) 2018-12-18 11:14:11 -08:00
Alessio Treglia eac7d6939d Merge PR #3127: Don't fallback to any default values for chain id
- Remove DefaultChainID(). User needs to suplly chain ID
  via either config or flag.
- Mark --chain-id as required by all tx commands.
- Fix gaiacli config values containing underscores.
  Underscore '_' character is not automagically translated
  into hyphen '-'. Viper values wouldn't be affected.
- Refresh gaiacli config tests

Closes: #810
2018-12-18 19:40:01 +01:00
Artur Albov 0c6d53dc07 Merge PR #2959: Add TxEncoder to client TxBuilder 2018-12-12 22:29:42 +01:00
Jack Zampolin e1f0767ba8
R4R: Move generate_only and simulate to POST body in REST txs (#3060)
* Move generate_only and simulate to POST body in REST txs

Closes: #3056

* Run make format

* drop extra else block, outdent its block, and make linter happy

* Update PENDING.md

* Update LCD swagger docs
2018-12-10 14:51:53 -08:00
Christopher Goes 243576143e
Merge PR #3072: Catch overflows in gas wanted
* Check for overflow

* Only expect block gas meter on DeliverTx

* ErrGasOverflow in tx.ValidateBasic()

* Update unit test
2018-12-10 21:39:29 +01:00
Alessio Treglia 24a1670cf0 Run make format 2018-12-10 14:27:25 +00:00
Jae Kwon 40a30b738f
Update gas costs to more reasonable numbers for GoS (#3052) 2018-12-10 02:48:19 -08:00
Jae Kwon bc51fa93b6
Fix updateValidatorDistInfoFromPool (#3046)
Fixes regression introduced by #2984.
Continuiation of #3033 , which didn't fix the simulation issues.
(candidate) Complete solution for #3019, 9002 halt bug.

From #2984, it isn't sufficient to take the fee pool rewards of a validator. Since we don't track delegator accums (as we do with validator accums), and because onValidatorModified >updateValidatorDistInfoFromPool is also being called upon delegation updates (or at least I believe this is the reason), it is necessary to also withdraw self delegation.

TODO: I don't think self-delegation should be required to be modified here... consider using a delegation hook to do the self-delegation withdraw part instead, e.g. splitting the updateValidatorDistInfoFromPool function into two. It might not result in cleaner code, however. Think hard.
2018-12-08 07:18:04 -08:00
Jae Kwon 1ba93ea1c1 Merge PR #3033: Fix negative stake & invariance bug
* Fix negative stake & invariance bug

* Merge PR #3037: Updates to negative stake fix

* Update invariant; fix lint

* Fix linter

* Add comment & TODO
2018-12-08 01:04:52 +01:00
Hendrik Hofstadt db77117a5b Only allow supported pubKey types (#2949)
* Only allow supported pubKey types
* Add type and supported types to error message
* Add default value for ConsensusParams
2018-11-29 09:21:45 -08:00
Jae Kwon d1e76221d8
Jae/simulator improvements (#2900)
* Make simulator operations predetermined
* Use new dbm.ReverseIterator API
* Simulation speed improvements
* Pin exact revisions, not branches
* Rename 'MountStoresIAVL' to 'MountStores'
* Zero Power Block fees to community pool
2018-11-27 00:14:22 -08:00
frog power 4000 7cb1ba625e blockly minting (#2825)
* update mechanism to use average block time
* correctly sets accum height for zero-delegations
* update Decimal Format()
* clip withdrawal tokens
* PositiveDelegationInvariant
* DelegatorSharesInvariant
* DelAccumInvariants
2018-11-26 04:13:47 -08:00
Jae Kwon 819af35962 Final fixes from review 2018-11-24 18:15:02 -08:00
rigelrozanski 0861112b70 Merge remote-tracking branch 'origin/develop' into rigel/deliver-max-gas 2018-11-22 12:34:41 -05:00
rigelrozanski b4b61b890c address some comments while reviewing Jaes work 2018-11-22 00:30:04 -05:00
Alexander Bezobchuk 1ea0e4c457 Merge PR #2863: Transaction ValidateBasic
* Add ValidateBasic to Tx interface
* Update BaseApp unit tests
* Add missing return in ValidateBasic
* Update ValidateBasic to use IsNotNegative
* Add pending log entry
* Add unit test TestTxValidateBasic
* Fix broken lint regression
* Add sig count check to validation
* Add test case to TestTxValidateBasic
2018-11-21 11:16:56 +01:00
rigelrozanski 6fd3132e71 lint fix, merge fix 2018-11-21 02:02:15 -05:00
rigelrozanski 70e60c2f30 Merge remote-tracking branch 'origin/develop' into rigel/deliver-max-gas 2018-11-21 01:51:56 -05:00
Jae Kwon 4afd53d81b Consume block gas to tx gas limit even upon overconsumption 2018-11-20 20:07:30 -08:00
Jae Kwon 10bdf8fa03 Store ConsensusParams to main store 2018-11-20 16:44:49 -08:00
Alexander Bezobchuk 41fc538ac7 Add Safety Measures to Coin/Coins (#2797) 2018-11-20 01:22:35 -08:00
Jae Kwon 47eed3958b
Clean up Context/MultiStore usage in BaseApp (#2847) 2018-11-20 01:06:14 -08:00
rigelrozanski 56dc2363fa Merge remote-tracking branch 'origin/develop' into rigel/deliver-max-gas 2018-11-20 02:58:33 -05:00
Alexander Bezobchuk 6e813ab3a8 Change gas & related fields to unsigned integer type (#2839)
* Change gas & related fields to unsigned integer type
* Implement AddUint64Overflow
2018-11-19 09:13:45 -08:00