d82c2e6a94
Enforce ProofSpecs in 23-Commitment ( #6374 )
...
* enforce spec ordering
* modify clients to pass in specs to verify functions
* start fixing tests
* Apply suggestions from code review
* enforce spec length and proof length match
* fix all tests
* add argument to constructor:
* fixed msg client and tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* finish fixes from review
* add back proof-specific checks
* Apply suggestions from code review
* more robust proof spec checks
* add CHANGELOG entries
* do not hardcode proofspecs in 23-commitment
* fix client modules
* fix tests
* appease linter
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-12 10:45:40 +00:00
9048ffa8d3
Update ibc proof to be bytes ( #6393 )
...
* update interfaces to use []byte instead of commitment proof
* update 03/04 msgs with bytes
* fix compile errors
* fix channel tests
* fix connection tests
* fix testing, tm, and localhost tests
* fix ante tests
* update 03-connection spec
* update channel msgs spec
* small fixes after self review
* rm unused import
* Update x/ibc/03-connection/client/utils/utils.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* add empty proof test and rm ics 20 from ibc spec
* fix merge issues
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 00:19:25 +02:00
b09d6728ec
Rename all methods IsEmpty to Empty to be consistent with all codebase ( #6409 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 23:32:24 +02:00
49597b19ec
module: pass route by value ( #6404 )
...
* use instance
* add some comments
* Update types/router.go
* rename Nil to Empty
* run make mocks
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 15:37:23 +00:00
affe7265cb
Update connection and channel to use types_test package name ( #6395 )
...
* convert connection types test pacakge name
* convert channel types test package name
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-11 00:31:54 +00:00
79c308ae4a
Concept PR simplify Module ( #6231 )
...
* add test of alternative impl
* simplify query route too
* change name querier
* simplify register routes
* revert change
* add route
* add router
* first step refactor
* refactor
* update documentation
* update
* add format
* simplify appmodule
* update changelog
* rename vars
* remove interface
* Update CHANGELOG.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-10 18:48:16 +00:00
0d9faec1f3
07-tendermint: cherry-picks from #6272 ( #6387 )
2020-06-10 08:36:18 -04:00
55796fb3e7
x/ibc: client consensus_height event ( #6381 )
2020-06-10 05:34:18 -04:00
6851c844b3
x/ibc: testing pkg ( #6356 )
...
* add ibc testing pkg with testchain
* add ibctestsuite
* add create connection and channel support
* lint fixes
* lint
* revert
* simplify code via lint
* change suite to coordinator
* Update x/ibc/testing/chain.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* make trust level var and remove get from channel test struct
* apply most suggestions from pr review
* split conn handshake into single step funcs
* split channel handshake into separate funcs
* apply @fedekunze suggestions
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-10 09:00:13 +00:00
a8298976ac
update 07-tm err msg to utc time ( #6383 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-10 08:54:23 +00:00
744c1ce250
x/ibc: simulation store decoders ( #6247 )
...
* x/ibc: simulation store decoders
* x/ibc: missing decoders
* fixes
* 02-client: decoder test
* 03-connection: decoder test
* x/ibc: decoder test
* address comments from review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-10 08:09:51 +00:00
c44813bcdf
x/ibc: commit timeout timestamp ( #6363 )
...
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-06-08 08:03:18 -04:00
52d11acb45
R4R: Fix bug of unordered channel ( #6337 )
...
* fix unordered
* resolve conflicts
2020-06-08 06:19:59 +00:00
b9b578d6de
x/ibc: querying support for unordered channels ( #6294 )
...
* pause
* add querying for packet commitments and unrelayed acks
* add get all packet commitments test
* add query channels test
* add query connection channels test
* add test for query packet commitments
* fix key path and add unrelayed acks test
* fix part of lint
* add unrelayed packetsends func
* fix godoc
* add nolint directive
* fix lint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-06 19:25:45 -04:00
43947ca2ef
Add RegisterQueryService to AppModule ( #6336 )
...
* Add RegisterQueryService to AppModule
* Update CHANGELOG.md
* Update CHANGELOG.md
* Wire up BaseApp, fix tests
* Add mock test
* add missing file
* Update types/module/module.go
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-06 07:59:57 +00:00
1a5f2b7859
x/ibc-transfer: custom absolute packet timeout ( #6248 )
...
* x/ibc-transfer: custom timeout
* remove destHeight field
* cleanup
* fix test
* replace CLI arg for flag
* update CLI
* viper get flag
* address comments from review
* update cmd example:
* update spec
* address comments from review
2020-06-04 19:30:56 +00:00
b1f483fe24
move packet executed call to ibc handler ( #6312 )
...
* move packet executed to within ibc handler
* add spec updates
* godoc and nil check to lenght
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 11:24:21 +00:00
50d748bffb
remove duplicate event emission ( #6328 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 10:59:13 +00:00
81d647e505
Move codec.RegisterCrypto and codec.Cdc to new packages ( #6330 )
...
* Move codec.Cdc to legacy_global.Cdc
* Update CHANGELOG.md
* Updates
* nit
* Fix imports
* Updates
* Use cosmos multisig instead of tendermint multisig everywhere
* Fix tests
* Rename legacy_global -> legacy
* Add doc.go
* Linting, move all RegisterCrypto calls to crypto/codec
* Update crypto/codec/amino.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 10:38:24 +00:00
fed0c2317d
Change GetQueryCmd to take client.Context ( #6326 )
...
* Change GetQueryCmd to take a client.Context
* Update CHANGELOG
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-03 20:15:11 +00:00
2e11c81668
Make sdk.Msg implement proto.Message ( #6327 )
...
* Make sdk.Msg implement proto.Message
* Cleaning up
* Cleaning up
* Update CHANGELOG.md
* Lint fixes
* Lint fixes
* fix tests
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-03 19:52:05 +00:00
1f5626b800
baseapp: fix sender events accumulation ( #6307 )
...
* add default case on ibc AnteHandler
* reset ante handler EventManager
* use event manager from runTx instead the one set by the ante handler
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-02 04:26:13 +00:00
39f53ac22f
client: rename CliContext to Context ( #6290 )
...
* Refactor CliContext as Context
* Fix lint issues
* Fix goimports
* Fix gov tests
* Resolved ci-lint issues
* Add changelog
* Rename cliCtx to clientCtx
* Fix mocks and routes
* Add changelog
* Update changelog
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* merge client/rpc/ro{ot,utes}.go
* Update docs
* client/rpc: remove redundant client/rpc.RegisterRPCRoutes
* regenerate mocks
* Update ADRs
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-01 12:46:03 +00:00
654b2fdd10
x/ibc: packet commitment deletion after ack verification ( #6292 )
...
* add deletion of packet commitments to AcknowledgePacket and remove CleanupPacket
* update tests
* add replay test for unordered channels
* add cleanup back, update tests
* remove nolint
* add timeoutonclose handling and fix
* add check for deleted packets
* Update x/ibc/04-channel/keeper/keeper.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add ackexecuted and update tests
* add timeoutexecuted back and update test
* move events to executed funcs
* update handler
* update godoc
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-05-30 21:18:43 -04:00
6973c56457
x/ibc: fix internal errors messages ( #6268 )
...
* update errors in ibc client and localhost
* update code 1 errors
* fix misisng import
* add import
* fix compile and lint issues
* fix lint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-05-22 17:17:52 -04:00
bf3fa30671
ibc/07-tendermint: fix CLI ( #6271 )
2020-05-22 14:48:44 -04:00
850419fffd
Tx CLI proto module interface ( #5989 )
...
* WIP
* WIP
* WIP on removing x/auth dependency from client/tx
* Revert unneeded changes
* Simplify cli tx UX
* Wire up bank tx REST routes
* Fix assignment issue
* Wire up bank NewSendTxCmd
* fix lint
* revert file
* revert file
* fix simcli
* Refactor AccountRetriever
* Fix build
* Fix build
* Fix build
* Fix integration tests
* Fix tests
* Docs, linting
* Linting
* WIP on all modules
* Implement other module new tx cmd's
* Fix cmd's
* Refactor existing GetTxCmd
* Fix cmd
* Removing deprecated code
* Update ADR 020 & CHANGELOG
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Fix client/tx tests
* Fix mocks
* Fix tests
* Lint fixes
* REST tx migration
* Wire up REST
* Linting
* Update CHANGELOG, docs
* Fix tests
* lint
* Address review feedback
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* group vars
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-21 21:29:34 +00:00
ca20a39962
x/ibc: constrain acks processing order ( #6244 )
...
* x/ibc: constrain acks processing order
* test
* address @AdityaSripal comments
* address @colin-axner comments
* address @alexanderbez comments
2020-05-18 16:50:07 +00:00
3dcdc582af
x/ibc-transfer: move ICS20 out from x/ibc ( #6222 )
...
* x/transfer: move ICS20 out from x/ibc
* rename to ibc-transfer
2020-05-15 20:36:47 +00:00
86a9750508
x/ibc: update path validator to enforce no beginning or ending of the separator ( #6233 )
...
* update path validator to enforce no beginning or ending of the separator
* modify test slightly
2020-05-15 14:58:43 -04:00
b2ad4d2a23
x/ibc: alter id requirements ( #6227 )
...
* x/ibc: alter id requirements
* add regex to validations
* comment
* update error
* test all validators:
* fix tests
* check for only separators
2020-05-15 17:24:31 +00:00
c9ec0ff087
x/ibc: default genesis state for sims ( #6158 )
...
* x/ibc: default genesis state for sims
* add ibc and transfer module to simulations
* minor update
* remove TODO
* add validation to transfer genesis
* fix transfer init genesis
* address @alexanderbez comments
2020-05-14 22:47:11 +00:00
48aebed2ea
x/ibc: /types cleanup ( #6169 )
...
* x/ibc: move /types to /common
* x/ibc/types: remove errors
* remove mocked proofs
* remove invalidProof{}
* create new ibc/types dir
* format
* move keys to host
* move order to channel
* move channel state
* move connection state
* lint
2020-05-13 19:23:33 -04:00
513c5f30c2
Alter connection handshake ( #6209 )
...
* Alter connection handshake
* Add test-case
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-05-13 13:26:19 -04:00
a08aa41213
ibc/07-tendermint: variable trust-level ( #6206 )
...
* ibc/07-tendermint: variable trust-level
* update client state and tests
* fix tests
* address comments from review
* cli: define trust-level as flag
2020-05-13 01:10:25 +00:00
b93300288e
x/ibc: stateful clients ( #6202 )
...
Closes : #6198
2020-05-12 21:13:41 +02:00
138e0b074f
x/ibc: log fixes ( #6184 )
...
* x/ibc: log fixes
* fix test
2020-05-11 17:17:05 +00:00
f88d9ab586
x/ibc: create localhost client on InitGenesis ( #6170 )
...
closes : #6159
2020-05-11 17:46:00 +02:00
bef3689245
linter: enable nolintlint ( #6162 )
...
* nolintlint enable
* remove space
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-05-08 08:46:12 +00:00
c8c47786da
x/ibc: fix int overflow ( #6171 )
...
x/ibc/07-tendermint/types/test_utils.go: Calculate and use
machine-dependent maxInt instead of causing int overflow by
passing math.MaxInt64.
Closes : #6130
2020-05-07 22:11:29 -04:00
b3cada1001
x/ibc: fix event emission on msgs ( #6161 )
...
* add sender events into signer, and update events into keeper
* move all handler functionality to keeper for update
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-05-07 09:55:26 -04:00
f3e3a30e5e
x/ibc: add missing query height ( #6157 )
2020-05-06 13:06:35 -04:00
ff24a24ae6
x/ibc: query all client connection paths ( #6155 )
...
* x/ibc: query all client connections
* add queries to CLI and REST
* add missing height
* update swagger
2020-05-06 15:56:49 +00:00
d7ebee74e7
x/ibc: proto migration pt 1 ( #6097 )
...
* x/ibc: proto migration pt 1
* fix tests
* fixes and godoc
* yaml tags
* rm changelog
* address comments from review
* fix some tests
* fix tests
* add _UNSPECIFIED suffix for default enums
* Update app
* protobuf Any fixes
* use gogoproto
* fix tests
* wrap all messages
* address @alexanderbez comments
* update proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-05-06 11:17:50 -04:00
b09eef7298
run make format ( #6153 )
2020-05-06 13:47:53 +02:00
f2a331fddb
Fix Timeout Handling ( #6118 )
...
* fix timeout
* remove print statement
* fix tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-05 14:46:13 +00:00
4a28dd1645
Args: cobra.ExactArgs(1) required but never used ( #6140 )
2020-05-05 08:43:20 +00:00
106bcd5e13
default gen state ( #6139 )
2020-05-04 18:00:17 -04:00
110942add6
add anotation for json/yaml marshal ibc/tendermint/header type ( #6138 )
2020-05-04 20:34:08 +00:00
54ecf7d629
bump ibc sub module error codes ( #6117 )
...
* bump ibc sub module error codes
* add godoc
* update error numbers
2020-05-04 09:02:23 -04:00
Aditya
colin axner
Jonathan Gimeno
Federico Kunze
Segue
Aaron Craelius
SaReN
colin axner
Christopher Goes
Marko
Alessio Treglia
Pavel