<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->
## Description
Closes: #9447
This PR partially reverts #8505. Namely:
- it removes PowerReduction as a staking on-chain param
- however, it keeps #8505's API changes regarding adding a `powerReduction` function argument to staking functions. This allows us to rely less on global variables in said functions.
<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
* fix: misc fixes for make to work off freshly cloned repo
* gocritic appendAssign fix
* markdown trailing space and blank line fixes
* change golangci-lint timeout to 5min
* update changelog
* Update .golangci.yml
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
* Update CHANGELOG.md
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* test unpack on validator
* *add line to docs about validator being encoded in any
* add test to show how to unpack interfaces with validator object
* Update docs/core/encoding.md
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* sort imports
* Update docs/core/encoding.md
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
* setup version map query
* query methods
* grpc methods
* cleanup
* grpc for VersionMap
* swagger update
* swagger sync
* cleanup
* reset docs
* clean
* grpc with field
* daily
* -add grpc methods
-add optional field to get specific module from version map
-added cli test for version map query from cli
* -consolidate grpc test to one test function
-return better errors in grpc methods
* consolidate tests
* swagger update
* this breaks
* Try stringer on individual msgs
* change map to slice in proto
* cleanup
* add comments to proto fields
* cleanup
* regen proto files
* jsoncodec
* rename gRPC methods
* * add fetch method for module version slice
* add method to return version given a module name
* remove sorting functions
* lint
* Update proto/cosmos/upgrade/v1beta1/query.proto
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update proto/cosmos/upgrade/v1beta1/upgrade.proto
Co-authored-by: Aaron Craelius <aaron@regen.network>
* fix up comments and regen proto/swagger
* Update x/upgrade/client/cli/query.go
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* conform to pr 6711
* lint
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
* doc: Updates related to ServiceMsg, sdk.Msg and Msg service
* Apply suggestions from code review
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
* remove one more ServiceMsg
* Use service method rathr than service RPC
Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* update staking specs
* use gosimple code in x/staking/client/testutil/suite.go
* small fixes
* add godoc to methods in msg_server and grpc_query
* changes to godoc and small fixes
* remove unnecessary lines
* remove mentions of serviceMsg and avoid having slash after Msg
* -add comments to proto fields
-add comments to msg and query server
-remove decorator from docs
-add coments to msgs.go
-remove decorator from godoc
* Update x/feegrant/spec/04_events.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* refactor and add to docs
*refactor proto msg names and functions
*add docs pertaining to auth's ante handler for deducted fees
* lint
* update comment
* gofmt
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* use docker for proto-swagger-gen
fixes#7933
* fix deprecated commands and flags
see https://docs.buf.build/faq/ for detail
* run proto-gen and proto-swagger-gen
* add changelog entry
* Overview of keepers in object capability model (OCM)
* Updates to the spec, making clarifications
* Create a sequence diagram of a (fresh) delegation
* Misc notes, not yet decided where to put them
* Description of the shares abstraction in validators
* Model all keeper dependencies and move the UML file to docs
* Move and rename delegation sequence diagram
* Move shares description
* Remove TODO
* Diagram touch-ups
* Add how consensus power is calculated
* remove temp file
* Diagram improvements
* Describe slashing in more detail
* Describe redelegation
* Describe unbonding
* Delegation updates
* Delegation updates
* Make a diagram describing overall transaction flow
* Add delegation flows for the events of tokens being bonded/unbonding/etc.
* Grammar fix
* Diagram updates: distinguish alts, remove numbering.
* Use groups instead of "func:" participants
* Remove unused keepers from dependency diagram
* Add title to unbonding diagram
* Move keeper dependencies
* small doc updates
* remove numbers on sequence diagram
* !!!WIP EndBlock
* Explain "Last"-prefix in storage
* Remove `panic` step (they are supposed to never happen)
* EndBlock sequence diagram (with TODOs)
* Add TODO
* More visible TODOs
* Remove numbering
* Complete EndBlock
* Remove numbering
* Remove TODOs and update title
* add title back
* remove endblock seq-diagram
* Make power index update conditional on not being jailed
* update title
* Move files to /docs
* Install PlantUML and compile images to png and txt
* Use transaction flow in documentation
* Use staking UML in staking docs
* Clarify uml with inline doc
* Add keeper deps diagram to docs
* Only produce SVG images
Co-authored-by: hjort <>
Co-authored-by: Marko <marbar3778@yahoo.com>
* StoreKVPair protobuf message definition and generated go types
* store WriteListener
* update MultiStore, CacheWrap, CacheWrapper interfaces
* adjust KVStores to fit new CacheWrapper interface
* new ListenKVStore
* adjust multistores to fit new MultiStore interface and enable wrapping returned KVStores with the new ListenKVStore
* typo fixes in adr
* ListenKV Store test
* update server mock KVStore and MultiStore
* multistore unit test; fix multistore constructor
* update changelog
* fix bug identified in CI
* improve codecov, minor fixes/adjustments
* review fixes
* review updates; flip set to delete in KVStorePair, updated proto-docs from running 'make proto-gen'
* First run
* Remove dead code
* Make test pass
* Proto gen
* Fix lint
* Add changelog
* Fix tests
* Fix test
* Update x/auth/tx/service.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Remove protoTxProvider
* Add grpc-gateway test
* Add comment
* move to api breaking
* lesser diff
* remove conflict
* empty commit to rerun CI
* empty commit to rerun CI
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* remove time based upgrades
* cleanup
* cleanup evidence of time based upgrades
* cleanup docs referring to time based upgrades
* forgot one
* added line to changelog deprecated section
* Update proto/cosmos/upgrade/v1beta1/upgrade.proto
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* update changelog line to correct section
* update buf config to allow reserved fields
Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Add back supply proto
* Add migration for supply
* Fix lint
* Update x/bank/spec/01_state.md
* Fix test
* Proto gen
* Update x/bank/spec/01_state.md
* Make proto gen
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
* enable secp256r1 in antehandlers
* Add sig verification benchamrk to find a sigverify fee
* adjust the gas fee
* enable secp256r1 in antehandlers
* Add sig verification benchamrk to find a sigverify fee
* adjust the gas fee
* Update the secp256r1 fee factor
* Update changelog
* regenerate docs
* add zeroed custom fields check to tm client
* remove custom fields function from x/upgrade and fix tests
* use []byte in x/upgrade, move abci to 02-client
* remove x/ibc from types
* whoops, delete testing files
* fix upgrade tests
* fix tm tests
* fix tests
* update CHANGELOG
* revert proto breakage, use reserved field cc @amaurym
* add IBC Upgrade Proposal type
* remove IBC from upgrade types
* add IBC upgrade logic to 02-client
* fix all tests for x/upgrade
* Add CLI for IBC Upgrade Proposal
* Update x/ibc/core/02-client/types/proposal_test.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add gRPC for upgraded client state
* test fixes
* add HandleUpgradeProposal tests
* update docs and remove unnecessary code
* self review bug and test fixes
* neatness
* construct empty rest handler
* fix tests
* fix stringer tests
* Update docs/core/proto-docs.md
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* add key in ibc store tracking ibc upgrade heights
Add a new Key to the IBC client store to track the IBC Upgrade Height. This allows IBC upgrades to correctly remove old IBC upgrade states
* update abci and tests
* revert key storage after discussion with @AdityaSripal
Revert using a key to track IBC upgrades. By clearing any IBC state using an old plan in ScheduleUpgrade, IBC upgrades do not need to be tracked by IBC. This reduces code complexity and reduces potential for bugs.
* clear IBC states on cancelled upgrades
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* Changelog update
* Rename codec.MarshalAny
* move codec.MarshalInterface to codec.Marshaler
* fix tests
* Update amino_codec for compliance with MarshalerInterface
* update tests and comments
* add tests
* change order of args in UnmarshalInterface to a canonical one
* uplift MarshalInterface to take ProtoMessage as an argument
* wip
* add nil check
* make tests working
* tests cleanup
* add support for *JSON methods
* Update changelog
* linter fixes
* fix test types
* update evidence genesis_test
* adding test
* review updates
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Remove deprecated docs and add first guidelines to protobuf migration
* Add conventions
* Reorder and add more FAQ doc
* Update guidelines for pb msg definitions
* Use commit hash in github links
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* query-lifecycle and started modules-interfaces
* query-lifecycle first draft done
* module interfaces first draft
* rest and intro skeletons
* rest and intro done
* small edits and links
* comments
* revisions
* cli.md comments
* comments
* minor edits
* better flow for query lifecycle
* add transactions into core
* hans comments
* add transactions into core
* checkout master-docs files
* deleted some
* remove modules readme
* cli.md comments
* comments
* module-interfaces comments
* Merge PR #4857: Add Context concept doc
* working
* working
* finish messages and queries
* handler
* querier
* last comments!
* punctuation
* querier2
* consolidate intro
* querier
* workiiiing
* refactor for new module interface
* karoly review
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* finish intro
* workinnn
* initial commit after rebase
* query-lifecycle and started modules-interfaces
* query-lifecycle first draft done
* module interfaces first draft
* rest and intro skeletons
* rest and intro done
* small edits and links
* comments
* revisions
* cli.md comments
* comments
* minor edits
* better flow for query lifecycle
* checkout master-docs files
* deleted some
* remove modules readme
* cli.md comments
* comments
* module-interfaces comments
* keeper
* genesis
* finish
* Apply suggestions from code review
Co-Authored-By: Hans Schoenburg <hschoenburg@users.noreply.github.com>
* hans review
* Update docs/core/baseapp.md
Co-Authored-By: Hans Schoenburg <hschoenburg@users.noreply.github.com>
* working
* last comment
* workin
* Apply suggestions from code review
* encoding and node
* almost finish store
* finish docs
* fixes
* fede comments + permalinks
* hans review
* add more permalinks
* update docs theme version (#5239)
* R4R: Docs Cleanup (#5246)
* start
* work
* work
* work
* remove table of content
* links intro
* fix links
* remove junk
* cleanup
* cleanup
* work
* finish cleanup
* addback readmes
* remove nft
* fix links
* remove dup
* remove dup
* remove dup
* remove dup
* remove dup
* fix links
* add subscribe events
* refine rest
* index page
* sidebar
* theme version
* theme version
* testing netlify
* theme version
* tooltip example
* version
* testing code embedding
* reverting back
* theme version
* version
* version
* version
* readme and version
* cleanup
* redo app anatomy
* modules readme, theme version
* theme version
* fix modules list
* theme version
* new snippets
* modules readme
* update docs readme
* modify synopsis
* version
* fix yaml
* version
* version
* version
* version
* version
* version
* version
* version
* version
* version
* add hide banner
* version
* version
* version
* small fixes
* modules readme, version
* remove hotkeys dep, version
* version
* version
* version
* version
* version
* version
* version
* slight notice
* fix links and hide
* permalinks
* small clean
* version
* resolve conflicts, add google analytics
* fix merge remants
* version
* changelog 1/2
* Changelog: docs UI
* version
* remove merge conflicts
* Code: Update link for Contributing to the docs to docs_readme
* HTML/CSS: Update layout of homepage footer to match new layout in Figma
* version
* final modifs
* modules, version
* modules readme
* link to module list from homepage
* version
* building modules link
* version
* version
* fonts
* version
* version
* fix link
* fix package.json
* links in explore sdk section
* core concepts
* version
* change delimeters for frontmatter
* frontmatter in comments
* version
* temp add tiny-cookie
* fixed link issues
* fixed styling issues, copy
* hide frontmatter
* hide frontmatter
* layout fixes, padded ascii diagram
* fira sans font for code
* scrollbar color
* move synopsis from frontmatter
* move synopsis from frontmatter
* code styling in synopsis fix
* tutorial link
* active headers
* 404 fix
* homepage links fix
* fix link in footer
* misc fixes
* version
* prerequisite links on mobile
* version
* version
* Fix footer links
* version
* Fix permalink popup
* Update version
* package-lock.json
* Update Questions section in the footer
* Config for Algolia Docsearch
* Update version
* Update to the latest version of the theme
* Use docs-staging as a branch for staging website
* Update version
* Add google analytics
* Remove {hide} from Pre-Requisite Readings
* Replace Riot with Discord
Co-Authored-By: billy rennekamp <billy.rennekamp@gmail.com>
* Fix yaml syntax error in docs
* Fix formatting in keyring.md
Co-authored-by: Gloria Zhao <gzhao408@berkeley.edu>
Co-authored-by: gamarin <gautier@tendermint.com>
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Hans Schoenburg <hschoenburg@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
* change abci file to use BinaryBare
* change all calls to EncodeLengthPrefixed to BinaryBare in distribution keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in mint keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in auth keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in distribution keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in staking keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in staking keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in gov keeper store.
* change all calls to EncodeLengthPrefixed to BinaryBare in slashing keeper store.
* update decoder test
* migrate decoder
* migrate gov simulation decoder
* migrate baseapp_test
* refactor QuerySubspace
* refactor coedc std codec
* migrate keybase
* migrate iavl store
* migrate root multi
* migrate ante basic
* migrate tx type to bare
* migrate auth client
* update auth types
* update decoder
* migrate supply decoder
* migrate stake encoding
* migrate staking simulation
* migrate genutil
* migrate simapp test helpers
* migrate docs
* upgrade changelog
* Update CHANGELOG.md
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* encoding
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* module doc start
* finish intro
* working
* workinnn
* add transactions into core
* hans comments
* add transactions into core
* working
* gautier comments
* clean
* working
* consolidate intro
* querier
* workiiiing
* refactor for new module interface
* karoly review
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* finish intro
* workinnn
* initial commit after rebase
* query-lifecycle and started modules-interfaces
* query-lifecycle first draft done
* module interfaces first draft
* rest and intro skeletons
* rest and intro done
* small edits and links
* comments
* revisions
* cli.md comments
* comments
* minor edits
* better flow for query lifecycle
* add transactions into core
* hans comments
* add transactions into core
* checkout master-docs files
* deleted some
* remove modules readme
* cli.md comments
* comments
* module-interfaces comments
* Merge PR #4857: Add Context concept doc
* working
* working
* finish messages and queries
* handler
* querier
* last comments!
* punctuation
* querier2
* consolidate intro
* querier
* workiiiing
* refactor for new module interface
* karoly review
* working on baseapp doc
* baseapp work
* reorg
* almost there
* finish first draft
* remove old files
* finish intro
* workinnn
* initial commit after rebase
* query-lifecycle and started modules-interfaces
* query-lifecycle first draft done
* module interfaces first draft
* rest and intro skeletons
* rest and intro done
* small edits and links
* comments
* revisions
* cli.md comments
* comments
* minor edits
* better flow for query lifecycle
* checkout master-docs files
* deleted some
* remove modules readme
* cli.md comments
* comments
* module-interfaces comments
* keeper
* genesis
* finish
* Apply suggestions from code review
Co-Authored-By: Hans Schoenburg <hschoenburg@users.noreply.github.com>
* hans review
* Update docs/core/baseapp.md
Co-Authored-By: Hans Schoenburg <hschoenburg@users.noreply.github.com>
* working
* last comment
* workin
* Apply suggestions from code review
* encoding and node
* almost finish store
* finish docs
* fixes
* fede comments + permalinks
* hans review
* add more permalinks
* update docs theme version (#5239)
* R4R: Docs Cleanup (#5246)
* start
* work
* work
* work
* remove table of content
* links intro
* fix links
* remove junk
* cleanup
* cleanup
* work
* finish cleanup
* addback readmes
* remove nft
* fix links
* remove dup
* remove dup
* remove dup
* remove dup
* remove dup
* fix links
* add subscribe events
* refine rest
* index page
* sidebar
* theme version
* theme version
* testing netlify
* theme version
* tooltip example
* version
* testing code embedding
* reverting back
* theme version
* version
* version
* version
* readme and version
* cleanup
* redo app anatomy
* modules readme, theme version
* theme version
* fix modules list
* theme version
* new snippets
* modules readme
* update docs readme
* modify synopsis
* version
* fix yaml
* version
* version
* version
* version
* version
* version
* version
* version
* version
* version
* add hide banner
* version
* version
* version
* small fixes
* modules readme, version
* remove hotkeys dep, version
* version
* version
* version
* version
* version
* version
* version
* slight notice
* fix links and hide
* permalinks
* small clean
* version
* resolve conflicts, add google analytics
* fix merge remants
* version
* changelog 1/2
* Changelog: docs UI
* version
* remove merge conflicts
* Code: Update link for Contributing to the docs to docs_readme
* HTML/CSS: Update layout of homepage footer to match new layout in Figma
* version
* final modifs
* modules, version
* modules readme
* link to module list from homepage
* version
* building modules link
* version
* version
* fonts
* version
* version
* fix link
* fix package.json
* links in explore sdk section
* core concepts
* version
* change delimeters for frontmatter
* frontmatter in comments
* version
* temp add tiny-cookie
* fixed link issues
* fixed styling issues, copy
* hide frontmatter
* hide frontmatter
* layout fixes, padded ascii diagram
* fira sans font for code