certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
cosmos-sdk/api/cosmos
History
Amaury 53a6f199fe
chore(group): State machine audit (#11559) 
## Description

ref: #10968 

I would like to have some eyes to:

- Make sure the state machine vulnerabiities are indeed bugs that should be fixed:
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846091449
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846093388
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846096172
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r849306060
- Some open questions:
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846090420
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846094966
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r851193426

Other code changes are small: some small refactors to make code clearer, less panics, better error messages...

depends on:
- [x] #11560 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
 		2022-04-15 10:35:45 +00:00
..
app chore(group): State machine audit (#11559) 2022-04-15 10:35:45 +00:00
auth/v1beta1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
authz/v1beta1 feat!: make grant expiration optional (#11060) 2022-03-24 18:27:23 +00:00
bank/v1beta1 fix: Protobuf docker (#11472) 2022-03-26 23:38:32 +01:00
base feat(scripts): wipe API directory before generating (#11342) 2022-03-10 10:29:42 +00:00
capability/v1beta1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
crisis/v1beta1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
crypto feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
distribution/v1beta1 feat: EIP191 sign mode (#11533) 2022-04-05 08:43:59 +00:00
evidence/v1beta1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
feegrant/v1beta1 chore: fix proto docker (#11423) 2022-03-21 12:23:46 +01:00
genutil/v1beta1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
gov chore: x/gov v1 API audit changes (#11474) 2022-04-05 13:33:26 +00:00
group/v1 chore(group): State machine audit (#11559) 2022-04-15 10:35:45 +00:00
mint/v1beta1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
msg/v1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
nft/v1beta1 feat(scripts): wipe API directory before generating (#11342) 2022-03-10 10:29:42 +00:00
orm refactor(orm)!: move orm.proto to v1 (#11383) 2022-03-26 18:59:15 +00:00
params/v1beta1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
slashing/v1beta1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00
staking/v1beta1 feat: Cancel unbonding delegation entry (#10885) 2022-04-05 10:01:13 +00:00
tx chore: Tx Tips API audit (#11641) 2022-04-14 13:46:23 +00:00
upgrade/v1beta1 feat(scripts): wipe API directory before generating (#11342) 2022-03-10 10:29:42 +00:00
vesting/v1beta1 feat: add msg for permanent locked vesting accounts (#11019) 2022-01-28 16:55:18 -08:00