cosmos-sdk/x/gov/types
Tyler 1dba673573
refactor!: change GetSigners return type to []sdk.AccAddress (#9915)
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description
Changes the `sdk.Msg` interface method `GetSigners() []string` to `GetSigners() []sdk.AccAddress`

Closes: #9885 


+change GetSigner return type
+defer address checking to each msg's `ValidateBasic`  method
+clean up consistency/redundancy issues in validate basic


---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2021-08-13 15:34:00 +00:00
..
codec.go MsgWeightedVote -> MsgVoteWeighted 2021-01-24 20:54:25 -05:00
content.go Remove dependency of types/module package on x/simulation (#5835) 2020-03-23 12:55:44 +01:00
deposit.go Change `address` from bytes to bech32 strings (#7242) 2020-09-25 10:25:37 +00:00
errors.go Merge PR #5665: Bump Module ABCI Error Codes 2020-02-18 14:43:00 +01:00
events.go refactor SubVote to WeightedVoteOption && add utility for NewNonSplitVoteOption 2020-10-30 23:14:39 +10:00
expected_keepers.go Add hooks to governance actions (#9133) 2021-04-21 12:59:30 -04:00
genesis.go Protobuf audit: base package, module packages, tx/Msg's (#7059) 2020-08-19 07:36:41 +00:00
genesis.pb.go Update gogo proto deps with v1.3.2 security fixes (#8350) 2021-01-15 19:45:34 +00:00
genesis_test.go Proto Auditing: Replace ID with Id (#7032) 2020-08-14 08:55:54 +00:00
gov.pb.go fix: Correctly populate legacy Vote.Option field (#9583) 2021-06-25 15:52:44 +02:00
hooks.go Add hooks to governance actions (#9133) 2021-04-21 12:59:30 -04:00
keys.go fix: check store keys length before accessing (#9639) 2021-07-08 13:29:12 +02:00
keys_test.go Merge cosmos-sdk master 2021-02-03 22:36:29 +10:00
msgs.go refactor!: change GetSigners return type to []sdk.AccAddress (#9915) 2021-08-13 15:34:00 +00:00
msgs_test.go x/gov v0.43 Audit updates (#9258) 2021-05-07 12:00:19 +00:00
params.go remove dependency between min deposit tokens and power reduction 2021-02-02 00:11:33 +10:00
proposal.go x/gov v0.43 Audit updates (#9258) 2021-05-07 12:00:19 +00:00
proposals_test.go Enable proto JSON for genesis (#7000) 2020-08-11 14:22:30 +00:00
querier.go Merge PR #5405: Queries to /gov/proposals/{proposalID}/votes support pagination 2019-12-18 13:15:37 -05:00
query.pb.go Update gogo proto deps with v1.3.2 security fixes (#8350) 2021-01-15 19:45:34 +00:00
query.pb.gw.go gRPC gateway issue with colons in the account url path (#8649) 2021-02-22 11:30:45 +00:00
router.go Merge PR #5244: Add debug commands 2019-11-11 09:54:32 -05:00
tally.go refactor SubVote to WeightedVoteOption && add utility for NewNonSplitVoteOption 2020-10-30 23:14:39 +10:00
tx.pb.go x/gov v0.43 Audit updates (#9258) 2021-05-07 12:00:19 +00:00
vote.go refactor: Bring back deprecated proto fields to `v1beta1` (#9534) 2021-06-23 13:03:33 +00:00