cosmos-sdk/baseapp
Tyler 1dba673573
refactor!: change GetSigners return type to []sdk.AccAddress (#9915)
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description
Changes the `sdk.Msg` interface method `GetSigners() []string` to `GetSigners() []sdk.AccAddress`

Closes: #9885 


+change GetSigner return type
+defer address checking to each msg's `ValidateBasic`  method
+clean up consistency/redundancy issues in validate basic


---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2021-08-13 15:34:00 +00:00
..
abci.go feat!: support debug trace QueryResult (#9576) 2021-07-08 09:25:40 +00:00
abci_test.go baseapp, client: reject gRPC connections with out-of-range/nefarious x-cosmos-block-height values (#7663) 2020-11-03 18:35:22 +00:00
baseapp.go refactor!: change GetSigners return type to []sdk.AccAddress (#9915) 2021-08-13 15:34:00 +00:00
baseapp_test.go refactor!: change GetSigners return type to []sdk.AccAddress (#9915) 2021-08-13 15:34:00 +00:00
grpcrouter.go cosmos-reflection: extend to support writing by reflection clients (#8965) 2021-04-07 00:33:54 +01:00
grpcrouter_helpers.go Throw an error on duplicate registration (#7729) 2020-10-29 15:32:47 +00:00
grpcrouter_test.go Rename GRPCRouter (#8079) 2020-12-04 15:06:50 +00:00
grpcserver.go Make gRPC requests go through tendermint Query (#8549) 2021-02-15 10:01:44 +00:00
msg_service_router.go router: fix handler name (#9281) 2021-05-07 12:37:55 +02:00
msg_service_router_test.go Remove ServiceMsgs from ADR-031 (#9139) 2021-04-30 11:00:47 +00:00
options.go x/upgrade: protocol version tracking (#8897) 2021-04-02 07:11:58 -07:00
params.go update error message and add tests (#8166) 2020-12-14 15:56:10 +01:00
params_test.go update error message and add tests (#8166) 2020-12-14 15:56:10 +01:00
queryrouter.go
queryrouter_test.go
recovery.go
recovery_test.go
router.go module: pass route by value (#6404) 2020-06-11 15:37:23 +00:00
router_test.go Concept PR simplify Module (#6231) 2020-06-10 18:48:16 +00:00
state.go
test_helpers.go Handle nil *Any in UnpackAny and add panic handler for tx decoding (#7594) 2020-10-19 18:04:44 +00:00