History

Matt Kocubinski b363e0172e fix: call SetOrderExportGenesis from SimApp (#12048 ) ## Description This was causing sim failures like: ``` exporting genesis... 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=0/12 module=x/crisis name=gov/module-account 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=1/12 module=x/crisis name=bank/nonnegative-outstanding 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=2/12 module=x/crisis name=bank/total-supply 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=3/12 module=x/crisis name=group/Group-TotalWeight 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=4/12 module=x/crisis name=distribution/nonnegative-outstanding 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=5/12 module=x/crisis name=distribution/can-withdraw 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=6/12 module=x/crisis name=distribution/reference-count 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=7/12 module=x/crisis name=distribution/module-account 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=8/12 module=x/crisis name=staking/module-accounts 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=9/12 module=x/crisis name=staking/nonnegative-power 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=10/12 module=x/crisis name=staking/positive-delegation 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=11/12 module=x/crisis name=staking/delegator-shares 2022-05-25T10:36:39-05:00 INFO asserted all invariants duration=1194.381198 height=50 module=x/crisis importing genesis... --- FAIL: TestAppSimulationAfterImport (20.98s) panic: validator set is empty after InitGenesis, please ensure at least one validator is initialized with a delegation greater than or equal to the DefaultPowerReduction ({824635701280}) [recovered] panic: validator set is empty after InitGenesis, please ensure at least one validator is initialized with a delegation greater than or equal to the DefaultPowerReduction ({824635701280}) goroutine 76 [running]: testing.tRunner.func1.2({0x1b88020, 0xc0035d70b0}) /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1389 +0x24e testing.tRunner.func1() /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1392 +0x39f panic({0x1b88020, 0xc0035d70b0}) /home/mkoco/sdk/go1.18.2/src/runtime/panic.go:838 +0x207 github.com/cosmos/cosmos-sdk/types/module.(Manager).InitGenesis(_, {{0x28b5990, 0xc0001b2000}, {0x28c2da0, 0xc002494600}, {{0x0, 0x0}, {0x0, 0x0}, 0x0, ...}, ...}, ...) /home/mkoco/dev/regen/cosmos-sdk/types/module/module.go:329 +0x4fd github.com/cosmos/cosmos-sdk/runtime.(App).InitChainer(_, {{0x28b5990, 0xc0001b2000}, {0x28c2da0, 0xc002494600}, {{0x0, 0x0}, {0x0, 0x0}, 0x0, ...}, ...}, ...) /home/mkoco/dev/regen/cosmos-sdk/runtime/app.go:121 +0x12e github.com/cosmos/cosmos-sdk/simapp.(SimApp).InitChainer(_, {{0x28b5990, 0xc0001b2000}, {0x28c2da0, 0xc002494600}, {{0x0, 0x0}, {0x0, 0x0}, 0x0, ...}, ...}, ...) /home/mkoco/dev/regen/cosmos-sdk/simapp/app.go:504 +0x178 github.com/cosmos/cosmos-sdk/baseapp.(BaseApp).InitChain(0xc000fb1340, {{0x0, 0x0, 0x0}, {0x0, 0x0}, 0x0, {0x0, 0x0, 0x0}, ...}) /home/mkoco/dev/regen/cosmos-sdk/baseapp/abci.go:69 +0x3f5 github.com/cosmos/cosmos-sdk/simapp.TestAppSimulationAfterImport(0xc000abf520) /home/mkoco/dev/regen/cosmos-sdk/simapp/sim_test.go:269 +0xd67 testing.tRunner(0xc000abf520, 0x2590ac0) /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1439 +0x102 created by testing.(T).Run /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1486 +0x35f FAIL github.com/cosmos/cosmos-sdk/simapp 21.018s FAIL ``` ### Root cause Prior to merge of #11924, SimApp calls [module/NewManager](`2b549b807c/simapp/app.go (L344)`), which implicitly sets sane default values of [OrderExportGenesis](`2b549b807c/types/module/module.go (L239)`) from the modules passed as parameters. Since this usage was deprecated in favor of [RegisterModules](`823d2a7f28/simapp/app.go (L354)`) in the app wiring work, `OrderExportGenesis` was now `nil`, resulting in empty `genesisData` in [ExportGenesis](`823d2a7f28/types/module/module.go (L339)`) ### Fix Explicitly set `OrderExportGenesis` with same module order as `OrderInitGenesis` from `SimApp`. --- ### Author Checklist All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items. I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)		2022-05-25 21:34:51 +00:00
..
cosmos	fix: call SetOrderExportGenesis from SimApp (#12048 )	2022-05-25 21:34:51 +00:00
tendermint	feat: Add `MsgSoftwareUpgrade` and `MsgCancelUpgrade` (for new msgs-based gov proposals) (#11116 )	2022-03-03 16:45:02 +01:00
README.md	docs: Code blocks in SDK docs are broken (#11189 )	2022-02-14 23:39:35 +01:00
buf.gen.gogo.yaml	feat: full api module building alongside gogo proto files with buf schema registry support (#10669 )	2022-01-06 14:57:55 -05:00
buf.gen.pulsar.yaml	chore: api sub-module vanity URL (#11941 )	2022-05-12 10:19:04 +00:00
buf.lock	feat: full api module building alongside gogo proto files with buf schema registry support (#10669 )	2022-01-06 14:57:55 -05:00
buf.md	docs: Improve markdownlint configuration (#11104 )	2022-02-10 12:07:01 +00:00
buf.yaml	feat: full api module building alongside gogo proto files with buf schema registry support (#10669 )	2022-01-06 14:57:55 -05:00

README.md

Maintaining Cosmos SDK Proto Files

All of the Cosmos SDK proto files are defined here. This folder should be synced regularly with buf.build/cosmos/cosmos-sdk regularly by a maintainer by running buf push in this folder.

User facing documentation should not be placed here but instead goes in buf.md and in each protobuf package following the guidelines in https://docs.buf.build/bsr/documentation.